Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

refactor(web): Migrate HoverCard to design-system (#18171)

Ben Bachemed9773c755c6
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 10ef051a9e..e88756d53a 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -639,9 +639,6 @@ importers:
'@radix-ui/react-dropdown-menu':
specifier: ^2.1.16
- '@radix-ui/react-hover-card':
- specifier: ^1.1.15
'@radix-ui/react-label':
specifier: ^2.1.8
@@ -4836,19 +4833,6 @@ packages:
'@types/react-dom':
optional: true
- '@radix-ui/[email protected]':
- resolution: {integrity: sha512-qgTkjNT1CfKMoP0rcasmlH2r1DAiYicWsDsufxl940sT2wHNEWWv6FMWIQXWhVdmC1d/HYfbhQx60KYyAtKxjg==}
- peerDependencies:
- '@types/react': '*'
- '@types/react-dom': 19.2.3
- react: ^16.8 || ^17.0 || ^18.0 || ^19.0 || ^19.0.0-rc
- react-dom: ^16.8 || ^17.0 || ^18.0 || ^19.0 || ^19.0.0-rc
- peerDependenciesMeta:
- '@types/react':
- optional: true
- '@types/react-dom':
- optional: true
-
'@radix-ui/[email protected]':
resolution: {integrity: sha512-kGkGegYIdQsOb4XjsfM97rXsiHaBwco+hFI66oO4s9LU+PLAC5oJ7khdOVFxkhsmlbpUqDAvXw11CluXP+jkHg==}
peerDependencies:
@@ -16357,23 +16341,6 @@ snapshots:
'@types/react': 19.2.14
'@types/react-dom': 19.2.3(@types/[email protected])
- dependencies:
- '@radix-ui/primitive': 1.1.3
- '@radix-ui/react-compose-refs': 1.1.2(@types/[email protected])([email protected])
- '@radix-ui/react-context': 1.1.2(@types/[email protected])([email protected])
- '@radix-ui/react-dismissable-layer': 1.1.11(@types/[email protected](@types/[email protected]))(@types/[email protected])([email protected]([email protected]))([email protected])
- '@radix-ui/react-use-controllable-state': 1.2.2(@types/[email protected])([email protected])
- react: 19.2.4
- react-dom: 19.2.4([email protected])
- optionalDependencies:
- '@types/react': 19.2.14
- '@types/react-dom': 19.2.3(@types/[email protected])
-
dependencies:
'@radix-ui/react-use-layout-effect': 1.1.1(@types/[email protected])([email protected])
diff --git a/web/eslint.config.mjs b/web/eslint.config.mjs
index 2019e7b232..c5936d3632 100644
--- a/web/eslint.config.mjs
+++ b/web/eslint.config.mjs
@@ -494,7 +494,8 @@ export default [
"src/components/ui/popover.tsx",
"src/components/ui/dropdown-menu.tsx",
"src/components/ui/select.tsx",
- "src/components/ui/hover-card.tsx",
+ "src/components/design-system/HoverCardController/HoverCardController.tsx",
+ "src/components/design-system/ControlledHoverCard/ControlledHoverCard.tsx",
"src/components/ui/tooltip.tsx",
],
rules: {
diff --git a/web/package.json b/web/package.json
index 6a43f1bc7d..ac8175e69b 100644
--- a/web/package.json
+++ b/web/package.json
@@ -82,7 +82,6 @@
"@radix-ui/react-collapsible": "^1.1.12",
"@radix-ui/react-dialog": "^1.1.15",
"@radix-ui/react-dropdown-menu": "^2.1.16",
- "@radix-ui/react-hover-card": "^1.1.15",
"@radix-ui/react-label": "^2.1.8",
"@radix-ui/react-popover": "^1.1.15",
"@radix-ui/react-progress": "^1.1.8",
@@ -196,8 +195,8 @@
"@types/bcryptjs": "^2.4.6",
"@types/chroma-js": "^3.1.2",
"@types/cors": "^2.8.19",
- "@types/d3-selection": "^3.0.11",
"@types/d3-scale": "^4.0.9",
+ "@types/d3-selection": "^3.0.11",
"@types/d3-shape": "^3.2.0",
"@types/d3-zoom": "^3.0.8",
"@types/lodash": "^4.17.24",
diff --git a/web/src/components/ActionButton.tsx b/web/src/components/ActionButton.tsx
index 1585905501..27379c5b71 100644
--- a/web/src/components/ActionButton.tsx
+++ b/web/src/components/ActionButton.tsx
@@ -2,12 +2,7 @@
import React, { useMemo } from "react";
import { Lock, AlertCircle, Sparkle } from "lucide-react";
import { Button, type ButtonProps } from "@/src/components/ui/button";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
- HoverCardPortal,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import Link from "next/link";
import { usePostHogClientCapture } from "@/src/features/posthog-analytics";
@@ -115,15 +110,13 @@ export const ActionButton = React.forwardRef<
if (isDisabled && disabledReason) {
return (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <span>{btnContent}</span>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent className="w-80 text-sm">
- {disabledReason}
- </HoverCardContent>
- </HoverCardPortal>
+ <HoverCard
+ openDelay={200}
+ content={<div className="w-80 p-3 text-sm">{disabledReason}</div>}
+ >
+ {({ getTriggerProps }) => (
+ <span {...getTriggerProps()}>{btnContent}</span>
+ )}
</HoverCard>
);
}
diff --git a/web/src/components/GroupedScoreBadges.stories.tsx b/web/src/components/GroupedScoreBadges.stories.tsx
index 377bafb8c7..7531794251 100644
--- a/web/src/components/GroupedScoreBadges.stories.tsx
+++ b/web/src/components/GroupedScoreBadges.stories.tsx
@@ -84,7 +84,7 @@ export const WithOverflow = meta.story({
).toHaveLength(3);
});
- const popover = within(body.getByRole("dialog"));
+ const popover = within(body.getByRole("dialog", { name: "" }));
const commentButton = popover.getByLabelText(
"View comment for quality: 0.92",
);
diff --git a/web/src/components/MediaTag/MediaTag.clienttest.tsx b/web/src/components/MediaTag/MediaTag.clienttest.tsx
index 3fa04a305d..e5f8358fd0 100644
--- a/web/src/components/MediaTag/MediaTag.clienttest.tsx
+++ b/web/src/components/MediaTag/MediaTag.clienttest.tsx
@@ -1,9 +1,18 @@
/* eslint-disable @repo/prefer-stories-over-client-tests */
-import { fireEvent, render, screen } from "@testing-library/react";
+import {
+ fireEvent,
+ render as renderWithProviders,
+ screen,
+} from "@testing-library/react";
+import { type ReactElement } from "react";
+import { LayerProvider } from "@/src/context/LayerContext/LayerContext";
import { describe, expect, it, vi } from "vitest";
import { MediaTag } from "./MediaTag";
+const render = (ui: ReactElement) =>
+ renderWithProviders(ui, { wrapper: LayerProvider });
+
const OFFICE_CONTENT_TYPES = [
["application/msword", "DOC"],
[
diff --git a/web/src/components/MediaTag/MediaTag.tsx b/web/src/components/MediaTag/MediaTag.tsx
index 216132fbb0..85200831b5 100644
--- a/web/src/components/MediaTag/MediaTag.tsx
+++ b/web/src/components/MediaTag/MediaTag.tsx
@@ -15,11 +15,7 @@ import { cva } from "class-variance-authority";
import { Button } from "@/src/components/ui/button";
import { Skeleton } from "@/src/components/ui/skeleton";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
import { cn } from "@/src/utils/tailwind";
import { getMappedMediaLabel } from "@/src/fns/getMappedMediaLabel";
@@ -249,25 +245,88 @@ export const MediaTag = React.forwardRef<HTMLButtonElement, MediaTagProps>(
const openPeek = React.useCallback(() => setOpen(true), [setOpen]);
return (
- <HoverCard open={isOpen} onOpenChange={setOpen}>
- <HoverCardTrigger asChild>
+ <ControlledHoverCard
+ open={isOpen}
+ onOpenChange={setOpen}
+ placement="bottom-start"
+ onClick={(event) => event.stopPropagation()}
+ content={
+ <div className="ph-no-capture flex w-auto max-w-sm flex-col gap-2 p-2">
+ <div className="flex items-center justify-between gap-4">
+ <div className="text-muted-foreground flex min-w-0 items-center gap-1.5 text-xs">
+ <KindIcon kind={kind} className="icon-base shrink-0" />
+ <span
+ className="max-w-[20ch] truncate font-mono leading-4"
+ title={contentType}
+ >
+ {contentType}
+ </span>
+ {contentLength !== undefined ? (
+ <>
+ <span aria-hidden="true">·</span>
+ <span className="shrink-0">
+ {formatFileSize(contentLength)}
+ </span>
+ </>
+ ) : null}
+ </div>
+ {canOpen ? (
+ <Button
+ asChild
+ variant="outline"
+ size={openActionLabel ? "sm" : "icon-xs"}
+ className={openActionLabel ? "gap-1.5" : undefined}
+ title="Open in new tab"
+ >
+ <a href={url} target="_blank" rel="noopener noreferrer">
+ {openActionLabel ? <span>{openActionLabel}</span> : null}
+ <ExternalLink className="icon-sm text-icon-foreground" />
+ </a>
+ </Button>
+ ) : (
+ <Button
+ variant="outline"
+ size={openActionLabel ? "sm" : "icon-xs"}
+ className={openActionLabel ? "gap-1.5" : undefined}
+ disabled
+ title="Open in new tab"
+ >
+ {openActionLabel ? <span>{openActionLabel}</span> : null}
+ <ExternalLink className="icon-sm text-icon-foreground" />
+ </Button>
+ )}
+ </div>
+ {description ? (
+ <p className="text-muted-foreground max-w-64 text-xs">
+ {description}
+ </p>
+ ) : null}
+ <PeekBody
+ kind={kind}
+ status={previewStatus}
+ url={url}
+ onPreviewError={() => setFailedPreviewUrl(url ?? null)}
+ />
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<button
- ref={ref}
type="button"
- // Marker for containers to detect chip hover via event delegation
- // (`closest("[data-media-tag]")`): IOTableCell suppresses its
- // expand-on-hover card and native title while over a chip.
+ // Containers detect chip hover via event delegation to suppress their own previews.
data-media-tag=""
aria-label={`${chipLabel} media`}
- aria-expanded={isOpen}
className={mediaTagVariants({ intent })}
- onClick={openPeek}
- onPointerDown={(event) => {
- if (event.pointerType !== "mouse") {
- event.preventDefault();
- openPeek();
- }
- }}
+ {...getTriggerProps({
+ ref,
+ onClick: openPeek,
+ onPointerDown: (event) => {
+ if (event.pointerType !== "mouse") {
+ event.preventDefault();
+ openPeek();
+ }
+ },
+ })}
>
{intent === "attachment" ? (
<Paperclip className="icon-sm shrink-0" />
@@ -279,77 +338,14 @@ export const MediaTag = React.forwardRef<HTMLButtonElement, MediaTagProps>(
"truncate font-mono leading-4",
hasGeneratedLabel && "max-w-[10ch]",
)}
- // Empty while the peek is open: a native tooltip would render on
- // top of the peek. Ancestors with a title still tooltip over the
- // peek — containers must suppress theirs too (see IOTableCell).
+ // Suppress native tooltips while the peek is open.
title={isOpen ? "" : hasGeneratedLabel ? contentType : chipLabel}
>
{chipLabel}
</span>
</button>
- </HoverCardTrigger>
- <HoverCardContent
- align="start"
- className="ph-no-capture flex w-auto max-w-sm flex-col gap-2 p-2"
- onClick={(event) => event.stopPropagation()}
- >
- <div className="flex items-center justify-between gap-4">
- <div className="text-muted-foreground flex min-w-0 items-center gap-1.5 text-xs">
- <KindIcon kind={kind} className="icon-base shrink-0" />
- <span
- className="max-w-[20ch] truncate font-mono leading-4"
- title={contentType}
- >
- {contentType}
- </span>
- {contentLength !== undefined ? (
- <>
- <span aria-hidden="true">·</span>
- <span className="shrink-0">
- {formatFileSize(contentLength)}
- </span>
- </>
- ) : null}
- </div>
- {canOpen ? (
- <Button
- asChild
- variant="outline"
- size={openActionLabel ? "sm" : "icon-xs"}
- className={openActionLabel ? "gap-1.5" : undefined}
- title="Open in new tab"
- >
- <a href={url} target="_blank" rel="noopener noreferrer">
- {openActionLabel ? <span>{openActionLabel}</span> : null}
- <ExternalLink className="icon-sm text-icon-foreground" />
- </a>
- </Button>
- ) : (
- <Button
- variant="outline"
- size={openActionLabel ? "sm" : "icon-xs"}
- className={openActionLabel ? "gap-1.5" : undefined}
- disabled
- title="Open in new tab"
- >
- {openActionLabel ? <span>{openActionLabel}</span> : null}
- <ExternalLink className="icon-sm text-icon-foreground" />
- </Button>
- )}
- </div>
- {description ? (
- <p className="text-muted-foreground max-w-64 text-xs">
- {description}
- </p>
- ) : null}
- <PeekBody
- kind={kind}
- status={previewStatus}
- url={url}
- onPreviewError={() => setFailedPreviewUrl(url ?? null)}
- />
- </HoverCardContent>
- </HoverCard>
+ )}
+ </ControlledHoverCard>
);
},
);
diff --git a/web/src/components/ScoreBadge/ScoreBadge.clienttest.tsx b/web/src/components/ScoreBadge/ScoreBadge.clienttest.tsx
new file mode 100644
index 0000000000..3aff5d0e7a
--- /dev/null
+++ b/web/src/components/ScoreBadge/ScoreBadge.clienttest.tsx
@@ -0,0 +1,64 @@
+// Rerendering the same owner directly exercises score identity across data refreshes.
+/* eslint-disable @repo/prefer-stories-over-client-tests */
+import { type LastUserScore } from "@langfuse/shared";
+import { fireEvent, render, screen, within } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+
+import { LayerProvider } from "@/src/context/LayerContext/LayerContext";
+import { ScoreBadge } from "./ScoreBadge";
+
+vi.mock("@/src/hooks/useProjectIdFromURL", () => ({
+ default: () => "project-id",
+}));
+
+const firstScore = {
+ id: "first-score",
+ name: "quality",
+ dataType: "NUMERIC",
+ source: "API",
+ value: 1,
+ timestamp: new Date("2026-01-01T00:00:00.000Z"),
+ traceId: "trace-id",
+ userId: "user-id",
+ metadata: { detail: "First score metadata" },
+} satisfies LastUserScore;
+
+const secondScore = {
+ ...firstScore,
+ id: "second-score",
+ value: 2,
+ metadata: { detail: "Second score metadata" },
+} satisfies LastUserScore;
+
+describe("ScoreBadge metadata preview", () => {
+ it("keeps the preview attached to its score after reordering and closes when removed", async () => {
+ const { rerender } = render(
+ <ScoreBadge name="quality" scores={[firstScore, secondScore]} />,
+ { wrapper: LayerProvider },
+ );
+ fireEvent.focus(
+ screen.getByRole("button", { name: "View metadata for quality: 1.00" }),
+ );
+
+ const card = await screen.findByRole("dialog");
+ expect(card.firstElementChild).toHaveClass(
+ "bg-popover",
+ "border",
+ "shadow-md",
+ );
+ expect(
+ within(card).getByText('"First score metadata"'),
+ ).toBeInTheDocument();
+
+ rerender(<ScoreBadge name="quality" scores={[secondScore, firstScore]} />);
+ expect(
+ within(screen.getByRole("dialog")).getByText('"First score metadata"'),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole("button", { name: "View metadata for quality: 2.00" }),
+ ).toHaveAttribute("aria-expanded", "false");
+
+ rerender(<ScoreBadge name="quality" scores={[secondScore]} />);
+ expect(screen.queryByRole("dialog")).not.toBeInTheDocument();
+ });
+});
diff --git a/web/src/components/ScoreBadge/ScoreBadge.tsx b/web/src/components/ScoreBadge/ScoreBadge.tsx
index 282953fc2a..704211dabe 100644
--- a/web/src/components/ScoreBadge/ScoreBadge.tsx
+++ b/web/src/components/ScoreBadge/ScoreBadge.tsx
@@ -37,7 +37,7 @@ export const ScoreBadge = <
{scores.map((score, index) => {
return (
<span
- key={index}
+ key={score.id}
className="inline-flex min-w-0 items-center gap-1"
>
<ScoreValue name={name} score={score} />
diff --git a/web/src/components/ScoreValue.tsx b/web/src/components/ScoreValue.tsx
index 823422f6dc..6512b6f95f 100644
--- a/web/src/components/ScoreValue.tsx
+++ b/web/src/components/ScoreValue.tsx
@@ -7,11 +7,7 @@ import {
import Link from "next/link";
import { JSONView } from "@/src/components/ui/CodeJsonViewer";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import useProjectIdFromURL from "@/src/hooks/useProjectIdFromURL";
import { type WithStringifiedMetadata } from "@/src/utils/clientSideDomainTypes";
@@ -46,43 +42,57 @@ export const ScoreValue = ({
{value}
</span>
{score.comment && (
- <HoverCard>
- <HoverCardTrigger
- aria-label={`View comment for ${name}: ${value}`}
- className="inline-block shrink-0"
- >
- <MessageCircleMoreIcon className="text-foreground-tertiary icon-sm! mb-0.25" />
- </HoverCardTrigger>
- <HoverCardContent className="max-h-[50dvh] overflow-y-auto text-xs break-normal whitespace-normal">
- <p className="whitespace-pre-wrap">{score.comment}</p>
- {"executionTraceId" in score &&
- score.executionTraceId &&
- projectId && (
- <div className="mt-2">
- <Link
- href={`/project/${projectId}/traces/${encodeURIComponent(score.executionTraceId)}`}
- className="flex items-center gap-1 text-blue-600 hover:underline"
- target="_blank"
- >
- <ExternalLinkIcon className="icon-sm" />
- View execution trace
- </Link>
- </div>
- )}
- </HoverCardContent>
+ <HoverCard
+ content={
+ <div className="max-h-[50dvh] w-64 overflow-y-auto p-3 text-xs break-normal whitespace-normal">
+ <p className="whitespace-pre-wrap">{score.comment}</p>
+ {"executionTraceId" in score &&
+ score.executionTraceId &&
+ projectId && (
+ <div className="mt-2">
+ <Link
+ href={`/project/${projectId}/traces/${encodeURIComponent(score.executionTraceId)}`}
+ className="flex items-center gap-1 text-blue-600 hover:underline"
+ target="_blank"
+ >
+ <ExternalLinkIcon className="icon-sm" />
+ View execution trace
+ </Link>
+ </div>
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label={`View comment for ${name}: ${value}`}
+ className="inline-block shrink-0"
+ {...getTriggerProps()}
+ >
+ <MessageCircleMoreIcon className="text-foreground-tertiary icon-sm! mb-0.25" />
+ </button>
+ )}
</HoverCard>
)}
{hasMetadata(score) && (
- <HoverCard>
- <HoverCardTrigger
- aria-label={`View metadata for ${name}: ${value}`}
- className="inline-block shrink-0"
- >
- <BracesIcon className="text-foreground-tertiary icon-sm! mb-0.25" />
- </HoverCardTrigger>
- <HoverCardContent className="max-h-[50dvh] overflow-y-auto rounded-md border-none p-0 text-xs break-normal whitespace-normal">
- <JSONView codeClassName="rounded-md!" json={score.metadata} />
- </HoverCardContent>
+ <HoverCard
+ content={
+ <div className="max-h-[50dvh] w-64 overflow-y-auto rounded-md p-0 text-xs break-normal whitespace-normal">
+ <JSONView codeClassName="rounded-md!" json={score.metadata} />
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label={`View metadata for ${name}: ${value}`}
+ className="inline-block shrink-0"
+ {...getTriggerProps()}
+ >
+ <BracesIcon className="text-foreground-tertiary icon-sm! mb-0.25" />
+ </button>
+ )}
</HoverCard>
)}
</span>
diff --git a/web/src/components/TruncatedLabels.tsx b/web/src/components/TruncatedLabels.tsx
index fe27ea0afe..3e0a24818c 100644
--- a/web/src/components/TruncatedLabels.tsx
+++ b/web/src/components/TruncatedLabels.tsx
@@ -1,11 +1,7 @@
/* eslint-disable @repo/no-style-props */
import React from "react";
import { Button } from "@/src/components/ui/button";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { StatusBadge } from "@/src/components/ui/StatusBadge/StatusBadge";
import { PRODUCTION_LABEL, LATEST_PROMPT_LABEL } from "@langfuse/shared";
import { cn } from "@/src/utils/tailwind";
@@ -62,40 +58,45 @@ export function TruncatedLabels({
),
)}
{hasHiddenLabels && (
- <HoverCard>
- <HoverCardTrigger asChild>
+ <HoverCard
+ placement="bottom-start"
+ content={
+ <div className="w-80 p-3">
+ <div className="space-y-2">
+ <h4 className="text-sm font-bold">All Labels</h4>
+ <div className="flex flex-wrap gap-1">
+ {sortedLabels.map((label) =>
+ showSimpleBadges ? (
+ <div
+ key={label}
+ className="bg-secondary text-secondary-foreground max-h-fit min-h-6 w-fit content-center rounded-sm px-1 text-left text-xs font-bold"
+ >
+ {label}
+ </div>
+ ) : (
+ <StatusBadge
+ type={label}
+ key={label}
+ isLive={label === PRODUCTION_LABEL}
+ preserveCase
+ />
+ ),
+ )}
+ </div>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<Button
variant="outline"
size="sm"
className="text-muted-foreground hover:text-foreground h-6 cursor-pointer text-xs"
+ {...getTriggerProps()}
>
+{hiddenLabels.length} more
</Button>
- </HoverCardTrigger>
- <HoverCardContent className="w-80 p-3" side="bottom" align="start">
- <div className="space-y-2">
- <h4 className="text-sm font-bold">All Labels</h4>
- <div className="flex flex-wrap gap-1">
- {sortedLabels.map((label) =>
- showSimpleBadges ? (
- <div
- key={label}
- className="bg-secondary text-secondary-foreground max-h-fit min-h-6 w-fit content-center rounded-sm px-1 text-left text-xs font-bold"
- >
- {label}
- </div>
- ) : (
- <StatusBadge
- type={label}
- key={label}
- isLive={label === PRODUCTION_LABEL}
- preserveCase
- />
- ),
- )}
- </div>
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
)}
</div>
diff --git a/web/src/components/date-range-dropdowns.tsx b/web/src/components/date-range-dropdowns.tsx
index 21073c9520..bef5ba701a 100644
--- a/web/src/components/date-range-dropdowns.tsx
+++ b/web/src/components/date-range-dropdowns.tsx
@@ -20,12 +20,7 @@ import {
} from "@/src/utils/date-range-utils";
import { useEntitlementLimit } from "@/src/features/entitlements";
import { useMemo } from "react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
- HoverCardPortal,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
type BaseDateRangeDropdownProps<T> = {
selectedOption: T;
@@ -76,15 +71,19 @@ const BaseDateRangeDropdown = <T extends string>({
const isLimited = limitedOptions?.includes(item);
return isLimited ? (
- <HoverCard openDelay={200} key={item}>
- <HoverCardTrigger asChild>
- <span>{itemObj}</span>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent className="w-60 text-sm" side="right">
+ <HoverCard
+ openDelay={200}
+ key={item}
+ placement="right"
+ content={
+ <div className="w-60 p-3 text-sm">
This time range is not available in your current plan.
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span {...getTriggerProps()}>{itemObj}</span>
+ )}
</HoverCard>
) : (
itemObj
diff --git a/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.stories.tsx b/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.stories.tsx
new file mode 100644
index 0000000000..d4f543e69a
--- /dev/null
+++ b/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.stories.tsx
@@ -0,0 +1,106 @@
+import * as React from "react";
+import {
+ expect,
+ fireEvent,
+ fn,
+ userEvent,
+ waitFor,
+ within,
+} from "storybook/test";
+
+import preview from "../../../../.storybook/preview";
+import { ControlledHoverCard } from "./ControlledHoverCard";
+
+const meta = preview.meta({
+ component: ControlledHoverCard,
+ args: {
+ children: () => null,
+ content: <div className="w-64 p-3">Controlled preview</div>,
+ open: false,
+ onOpenChange: fn(),
+ openDelay: 0,
+ closeDelay: 100,
+ },
+ render: function ControlledExample(args) {
+ const [open, setOpen] = React.useState(args.open);
+
+ return (
+ <ControlledHoverCard {...args} open={open} onOpenChange={setOpen}>
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ {...getTriggerProps({ onClick: () => setOpen(!open) })}
+ >
+ Toggle preview
+ </button>
+ )}
+ </ControlledHoverCard>
+ );
+ },
+});
+
+export const Default = meta.story({});
+
+export const ControlledClosed = meta.story({
+ name: "(Test) Controlled state stays closed",
+ render: (args) => (
+ <ControlledHoverCard {...args}>
+ {({ getTriggerProps }) => (
+ <button type="button" {...getTriggerProps()}>
+ Show preview
+ </button>
+ )}
+ </ControlledHoverCard>
+ ),
+ play: async ({ args, canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+
+ await userEvent.hover(canvas.getByRole("button", { name: "Show preview" }));
+ await waitFor(() =>
+ expect(args.onOpenChange).toHaveBeenCalledWith(
+ true,
+ expect.any(MouseEvent),
+ "hover",
+ ),
+ );
+ await expect(body.queryByRole("dialog")).not.toBeInTheDocument();
+ },
+});
+
+export const PopoverLayer = meta.story({
+ name: "(Test) Controlled open card uses the popover layer",
+ args: { open: true },
+ play: async ({ canvasElement }) => {
+ const body = within(canvasElement.ownerDocument.body);
+ const card = await body.findByRole("dialog");
+
+ await expect(card.closest('[data-layer="popover"]')).not.toBeNull();
+ await userEvent.keyboard("{Escape}");
+ await waitFor(() =>
+ expect(body.queryByRole("dialog")).not.toBeInTheDocument(),
+ );
+ },
+});
+
+export const Controlled = meta.story({
+ name: "(Test) Controlled",
+ play: async ({ canvasElement }) => {
+ const body = within(canvasElement.ownerDocument.body);
+ // Hover/focus would open the card before the toggle handler runs.
+ await fireEvent.click(
+ within(canvasElement).getByRole("button", { name: "Toggle preview" }),
+ );
+ const card = await body.findByRole("dialog");
+ await expect(card).toHaveTextContent("Controlled preview");
+ await expect(card.firstElementChild).toHaveClass(
+ "bg-popover",
+ "border",
+ "shadow-md",
+ );
+ await userEvent.keyboard("{Escape}");
+ await waitFor(() =>
+ expect(body.queryByRole("dialog")).not.toBeInTheDocument(),
+ );
+ },
+});
diff --git a/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.tsx b/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.tsx
new file mode 100644
index 0000000000..544361545c
--- /dev/null
+++ b/web/src/components/design-system/ControlledHoverCard/ControlledHoverCard.tsx
@@ -0,0 +1,23 @@
+"use client";
+
+import * as React from "react";
+
+import { HoverCardController } from "../HoverCardController/HoverCardController";
+
+function ControlledHoverCard({
+ content,
+ ...props
+}: React.ComponentProps<typeof HoverCardController>) {
+ return (
+ <HoverCardController
+ {...props}
+ content={
+ <div className="bg-popover text-popover-foreground rounded-md border shadow-md">
+ {content}
+ </div>
+ }
+ />
+ );
+}
+
+export { ControlledHoverCard };
diff --git a/web/src/components/design-system/HoverCard/HoverCard.stories.tsx b/web/src/components/design-system/HoverCard/HoverCard.stories.tsx
new file mode 100644
index 0000000000..412abcde1c
--- /dev/null
+++ b/web/src/components/design-system/HoverCard/HoverCard.stories.tsx
@@ -0,0 +1,229 @@
+import * as React from "react";
+import { expect, fn, userEvent, waitFor, within } from "storybook/test";
+
+import preview from "../../../../.storybook/preview";
+import { HoverCard } from "./HoverCard";
+
+const meta = preview.meta({
+ component: HoverCard,
+ args: {
+ children: () => null,
+ content: (
+ <div className="w-64 space-y-2 p-3">
+ <p className="font-bold">Preview details</p>
+ <button type="button" onClick={fn()}>
+ Copy details
+ </button>
+ </div>
+ ),
+ openDelay: 0,
+ closeDelay: 100,
+ },
+ render: (args) => (
+ <HoverCard {...args}>
+ {({ getTriggerProps }) => (
+ <button type="button" {...getTriggerProps()}>
+ Show preview
+ </button>
+ )}
+ </HoverCard>
+ ),
+});
+
+export const Default = meta.story({});
+
+export const DefaultSurface = meta.story({
+ name: "(Test) Default surface",
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+
+ await userEvent.hover(canvas.getByRole("button", { name: "Show preview" }));
+ const card = await body.findByRole("dialog");
+ await expect(card.firstElementChild).toHaveClass(
+ "bg-popover",
+ "border",
+ "shadow-md",
+ );
+ await expect(card.querySelectorAll(".bg-popover")).toHaveLength(1);
+ },
+});
+
+export const HoverableContent = meta.story({
+ name: "(Test) Hoverable content",
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+ const trigger = canvas.getByRole("button", { name: "Show preview" });
+
+ await userEvent.hover(trigger);
+ const action = await body.findByRole("button", { name: "Copy details" });
+ await userEvent.unhover(trigger);
+ await userEvent.hover(action);
+ await userEvent.click(action);
+ await expect(body.getByRole("dialog")).toBeVisible();
+ await userEvent.keyboard("{Escape}");
+ await waitFor(() =>
+ expect(body.queryByRole("dialog")).not.toBeInTheDocument(),
+ );
+ },
+});
+
+export const KeyboardNavigation = meta.story({
+ name: "(Test) Keyboard navigation",
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+
+ await userEvent.tab();
+ await expect(
+ canvas.getByRole("button", { name: "Show preview" }),
+ ).toHaveFocus();
+ await body.findByRole("dialog");
+ await userEvent.tab();
+ await expect(
+ body.getByRole("button", { name: "Copy details" }),
+ ).toHaveFocus();
+ await userEvent.keyboard("{Escape}");
+ await waitFor(() =>
+ expect(body.queryByRole("dialog")).not.toBeInTheDocument(),
+ );
+ },
+});
+
+export const Delayed = meta.story({
+ name: "(Test) Delayed",
+ args: { openDelay: 700, closeDelay: 300 },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+
+ await userEvent.hover(canvas.getByRole("button", { name: "Show preview" }));
+ await expect(body.queryByRole("dialog")).not.toBeInTheDocument();
+ await expect(
+ await body.findByRole("dialog", {}, { timeout: 2000 }),
+ ).toHaveTextContent("Preview details");
+ },
+});
+
+export const TriggerRefAndClickHandler = meta.story({
+ name: "(Test) Trigger ref and click handler are merged",
+ render: function TriggerRefExample(args) {
+ const ref = React.useRef<HTMLButtonElement>(null);
+ const [clickResult, setClickResult] = React.useState({
+ count: 0,
+ refConnected: false,
+ });
+
+ return (
+ <>
+ <HoverCard {...args}>
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ {...getTriggerProps({
+ ref,
+ onClick: (event) => {
+ const refConnected = ref.current === event.currentTarget;
+ setClickResult((current) => ({
+ count: current.count + 1,
+ refConnected,
+ }));
+ },
+ })}
+ >
+ Show preview
+ </button>
+ )}
+ </HoverCard>
+ <p>{clickResult.count} trigger clicks</p>
+ <p>
+ {clickResult.refConnected
+ ? "Trigger ref connected"
+ : "Trigger ref disconnected"}
+ </p>
+ </>
+ );
+ },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+ const trigger = canvas.getByRole("button", { name: "Show preview" });
+
+ await userEvent.click(trigger);
+ await expect(canvas.getByText("1 trigger clicks")).toBeVisible();
+ await expect(canvas.getByText("Trigger ref connected")).toBeVisible();
+ await waitFor(() => expect(body.getByRole("dialog")).toBeVisible());
+ await userEvent.click(trigger);
+ await expect(canvas.getByText("2 trigger clicks")).toBeVisible();
+ await expect(canvas.getByText("Trigger ref connected")).toBeVisible();
+ },
+});
+
+export const TriggerRefCleanup = meta.story({
+ name: "(Test) Trigger callback-ref cleanup",
+ render: function TriggerRefCleanupExample(args) {
+ const [showCard, setShowCard] = React.useState(true);
+ const [cleanupCount, setCleanupCount] = React.useState(0);
+ const ref = React.useCallback((node: HTMLElement | null) => {
+ if (!node) return;
+ return () => setCleanupCount((count) => count + 1);
+ }, []);
+
+ return (
+ <>
+ {showCard && (
+ <HoverCard {...args}>
+ {({ getTriggerProps }) => (
+ <button type="button" {...getTriggerProps({ ref })}>
+ Show preview
+ </button>
+ )}
+ </HoverCard>
+ )}
+ <button type="button" onClick={() => setShowCard(false)}>
+ Unmount preview
+ </button>
+ <p>{cleanupCount} ref cleanups</p>
+ </>
+ );
+ },
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ await expect(canvas.getByText("0 ref cleanups")).toBeVisible();
+ await userEvent.click(
+ canvas.getByRole("button", { name: "Unmount preview" }),
+ );
+ await expect(canvas.getByText("1 ref cleanups")).toBeVisible();
+ },
+});
+
+export const Disabled = meta.story({
+ name: "(Test) Disabled hover and focus interactions",
+ args: { enabled: false, onOpenChange: fn() },
+ play: async ({ args, canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+ const trigger = canvas.getByRole("button", { name: "Show preview" });
+
+ await userEvent.hover(trigger);
+ await userEvent.tab();
+ await expect(trigger).toHaveFocus();
+ await expect(args.onOpenChange).not.toHaveBeenCalled();
+ await expect(body.queryByRole("dialog")).not.toBeInTheDocument();
+ },
+});
+
+export const DisabledButton = meta.story({
+ render: (args) => (
+ <HoverCard {...args} placement="right">
+ {({ getTriggerProps }) => (
+ <span className="inline-flex" tabIndex={0} {...getTriggerProps()}>
+ <button type="button" disabled>
+ Unavailable action
+ </button>
+ </span>
+ )}
+ </HoverCard>
+ ),
+});
diff --git a/web/src/components/design-system/HoverCard/HoverCard.tsx b/web/src/components/design-system/HoverCard/HoverCard.tsx
new file mode 100644
index 0000000000..573fbb3c4a
--- /dev/null
+++ b/web/src/components/design-system/HoverCard/HoverCard.tsx
@@ -0,0 +1,31 @@
+"use client";
+
+import * as React from "react";
+
+import { ControlledHoverCard } from "../ControlledHoverCard/ControlledHoverCard";
+
+function HoverCard({
+ onOpenChange,
+ ...props
+}: Omit<
+ React.ComponentProps<typeof ControlledHoverCard>,
+ "open" | "onOpenChange"
+> & {
+ onOpenChange?: React.ComponentProps<
+ typeof ControlledHoverCard
+ >["onOpenChange"];
+}) {
+ const [open, setOpen] = React.useState(false);
+ return (
+ <ControlledHoverCard
+ {...props}
+ open={open}
+ onOpenChange={(nextOpen) => {
+ setOpen(nextOpen);
+ onOpenChange?.(nextOpen);
+ }}
+ />
+ );
+}
+
+export { HoverCard };
diff --git a/web/src/components/design-system/HoverCardController/HoverCardController.stories.tsx b/web/src/components/design-system/HoverCardController/HoverCardController.stories.tsx
new file mode 100644
index 0000000000..8c0f7dc885
--- /dev/null
+++ b/web/src/components/design-system/HoverCardController/HoverCardController.stories.tsx
@@ -0,0 +1,50 @@
+import * as React from "react";
+import { expect, fn, userEvent, within } from "storybook/test";
+
+import preview from "../../../../.storybook/preview";
+import { HoverCardController } from "./HoverCardController";
+
+const meta = preview.meta({
+ component: HoverCardController,
+ args: {
+ children: () => null,
+ open: false,
+ onOpenChange: fn(),
+ openDelay: 0,
+ closeDelay: 100,
+ content: (
+ <div className="bg-muted w-64 rounded-md p-3 shadow-md">
+ A custom surface, composed without the default card frame.
+ </div>
+ ),
+ },
+ render: function CustomSurfaceExample(args) {
+ const [open, setOpen] = React.useState(args.open);
+ return (
+ <HoverCardController {...args} open={open} onOpenChange={setOpen}>
+ {({ getTriggerProps }) => (
+ <button type="button" {...getTriggerProps()}>
+ Show preview
+ </button>
+ )}
+ </HoverCardController>
+ );
+ },
+});
+
+export const Default = meta.story({});
+
+export const CustomSurface = meta.story({
+ name: "(Test) Custom surface",
+ play: async ({ canvasElement }) => {
+ const canvas = within(canvasElement);
+ const body = within(canvasElement.ownerDocument.body);
+
+ await userEvent.hover(canvas.getByRole("button", { name: "Show preview" }));
+ const card = await body.findByRole("dialog");
+ await expect(card).toHaveTextContent(
+ "A custom surface, composed without the default card frame.",
+ );
+ await expect(card.querySelector(".bg-popover")).toBeNull();
+ },
+});
diff --git a/web/src/components/design-system/HoverCardController/HoverCardController.tsx b/web/src/components/design-system/HoverCardController/HoverCardController.tsx
new file mode 100644
index 0000000000..721ab47951
--- /dev/null
+++ b/web/src/components/design-system/HoverCardController/HoverCardController.tsx
@@ -0,0 +1,181 @@
+"use client";
+
+import {
+ autoUpdate,
+ flip,
+ FloatingFocusManager,
+ FloatingPortal,
+ hide,
+ offset,
+ safePolygon,
+ shift,
+ useDismiss,
+ useFloating,
+ useFocus,
+ useHover,
+ useInteractions,
+ useRole,
+ type Placement,
+} from "@floating-ui/react";
+import * as React from "react";
+
+import { useLayerContainer } from "@/src/context/LayerContext/LayerContext";
+import { stopScrollPropagation } from "@/src/hooks/stopScrollPropagation";
+
+type HoverCardControllerProps = Omit<
+ React.ComponentPropsWithoutRef<"div">,
+ "children" | "content" | "defaultValue" | "className" | "style"
+> & {
+ children: (controls: {
+ getTriggerProps: (
+ props?: React.HTMLProps<HTMLElement>,
+ ) => ReturnType<ReturnType<typeof useInteractions>["getReferenceProps"]>;
+ }) => React.ReactNode;
+ // Content owns its sizing, padding, and scroll layout inside the portaled frame.
+ content: React.ReactElement;
+ open: boolean;
+ onOpenChange: (open: boolean) => void;
+ openDelay?: number;
+ closeDelay?: number;
+ placement?: Placement;
+ sideOffset?: number;
+ collisionPadding?: number;
+ hideWhenDetached?: boolean;
+ enabled?: boolean;
+};
+
+function HoverCardController({
+ children,
+ content,
+ open,
+ onOpenChange,
+ openDelay = 700,
+ closeDelay = 300,
+ placement = "bottom",
+ sideOffset = 4,
+ collisionPadding = 8,
+ hideWhenDetached = false,
+ enabled = true,
+ onWheel,
+ onTouchMove,
+ ...props
+}: HoverCardControllerProps) {
+ const isOpen = enabled && open;
+ const layerContainer = useLayerContainer("popover");
+ const {
+ context,
+ floatingStyles,
+ middlewareData,
+ refs,
+ placement: resolvedPlacement,
+ } = useFloating({
+ open: isOpen,
+ onOpenChange,
+ placement,
+ strategy: "fixed",
+ middleware: [
+ offset(sideOffset),
+ flip({ padding: collisionPadding }),
+ shift({ padding: collisionPadding }),
+ ...(hideWhenDetached ? [hide({ padding: collisionPadding })] : []),
+ ],
+ transform: false,
+ whileElementsMounted: autoUpdate,
+ });
+ const hover = useHover(context, {
+ enabled,
+ delay: { open: openDelay, close: closeDelay },
+ handleClose: safePolygon(),
+ move: false,
+ });
+ const focus = useFocus(context, { enabled });
+ const dismiss = useDismiss(context);
+ const role = useRole(context, { role: "dialog" });
+ const { getFloatingProps, getReferenceProps } = useInteractions([
+ hover,
+ focus,
+ dismiss,
+ role,
+ ]);
+ const { setReference } = refs;
+ const getTriggerRef = React.useMemo(() => {
+ // Stable composed refs avoid detaching the trigger on every prop-getter call.
+ const mergedRefs = new WeakMap<
+ NonNullable<React.Ref<HTMLElement>>,
+ React.RefCallback<HTMLElement>
+ >();
+
+ return (callerRef: React.Ref<HTMLElement> | undefined) => {
+ if (!callerRef) return setReference;
+ const cachedRef = mergedRefs.get(callerRef);
+ if (cachedRef) return cachedRef;
+
+ const mergedRef: React.RefCallback<HTMLElement> = (node) => {
+ setReference(node);
+ if (typeof callerRef === "function") {
+ const cleanup = callerRef(node);
+ return () => {
+ setReference(null);
+ if (cleanup) {
+ cleanup();
+ } else {
+ callerRef(null);
+ }
+ };
+ }
+
+ callerRef.current = node;
+ return () => {
+ setReference(null);
+ callerRef.current = null;
+ };
+ };
+ mergedRefs.set(callerRef, mergedRef);
+ return mergedRef;
+ };
+ }, [setReference]);
+
+ return (
+ <>
+ {children({
+ getTriggerProps: (triggerProps) =>
+ getReferenceProps({
+ ...triggerProps,
+ ref: getTriggerRef(triggerProps?.ref),
+ }),
+ })}
+ {isOpen ? (
+ <FloatingPortal root={layerContainer}>
+ <FloatingFocusManager
+ context={context}
+ modal={false}
+ initialFocus={-1}
+ >
+ <div
+ ref={refs.setFloating}
+ aria-label="Preview"
+ data-state="open"
+ data-side={resolvedPlacement.split("-")[0]}
+ className="animate-in fade-in-0 zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 outline-hidden"
+ style={{
+ ...floatingStyles,
+ ...(middlewareData.hide?.referenceHidden
+ ? { visibility: "hidden" }
+ : {}),
+ }}
+ {...getFloatingProps({
+ ...props,
+ onWheel: stopScrollPropagation(onWheel),
+ onTouchMove: stopScrollPropagation(onTouchMove),
+ })}
+ >
+ {content}
+ </div>
+ </FloatingFocusManager>
+ </FloatingPortal>
+ ) : null}
+ </>
+ );
+}
+
+export { HoverCardController };
diff --git a/web/src/components/design-system/table/components/IOTableCell/IOTableCell.tsx b/web/src/components/design-system/table/components/IOTableCell/IOTableCell.tsx
index 9076b4452f..9c03bfda01 100644
--- a/web/src/components/design-system/table/components/IOTableCell/IOTableCell.tsx
+++ b/web/src/components/design-system/table/components/IOTableCell/IOTableCell.tsx
@@ -18,11 +18,7 @@ import {
useState,
type ReactNode,
} from "react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
import { decodeUnicodeEscapesOnly } from "@/src/utils/unicode";
import { EmptyValue } from "@/src/components/design-system/table/components/EmptyValue/EmptyValue";
@@ -269,7 +265,7 @@ export const IOTableCell = memo(function IOTableCell({
}
return (
- <HoverCard
+ <ControlledHoverCard
openDelay={700}
closeDelay={100}
open={isExpandOpen}
@@ -277,32 +273,33 @@ export const IOTableCell = memo(function IOTableCell({
if (open && isPointerOverMediaTagRef.current) return;
setIsExpandOpen(open);
}}
+ placement="top-start"
+ content={
+ <div className="ph-no-capture max-h-[40vh] w-[400px] overflow-y-auto p-3">
+ <JSONView
+ json={data}
+ className="w-full"
+ codeClassName="p-0 border-none"
+ />
+ </div>
+ }
>
- <HoverCardTrigger asChild>
+ {({ getTriggerProps }) => (
<div
className="group/io-cell relative h-full w-full"
- onPointerOver={(event) => {
- const overMediaTag = Boolean(
- (event.target as Element).closest("[data-media-tag]"),
- );
- isPointerOverMediaTagRef.current = overMediaTag;
- if (overMediaTag) setIsExpandOpen(false);
- }}
+ {...getTriggerProps({
+ onPointerOver: (event) => {
+ const overMediaTag = Boolean(
+ (event.target as Element).closest("[data-media-tag]"),
+ );
+ isPointerOverMediaTagRef.current = overMediaTag;
+ if (overMediaTag) setIsExpandOpen(false);
+ },
+ })}
>
{content}
</div>
- </HoverCardTrigger>
- <HoverCardContent
- className="ph-no-capture max-h-[40vh] w-[400px] overflow-y-auto"
- side="top"
- align="start"
- >
- <JSONView
- json={data}
- className="w-full"
- codeClassName="p-0 border-none"
- />
- </HoverCardContent>
- </HoverCard>
+ )}
+ </ControlledHoverCard>
);
});
diff --git a/web/src/components/layouts/doc-popup.tsx b/web/src/components/layouts/doc-popup.tsx
index c50270fe00..a284521adc 100644
--- a/web/src/components/layouts/doc-popup.tsx
+++ b/web/src/components/layouts/doc-popup.tsx
@@ -1,11 +1,7 @@
/* eslint-disable @repo/no-style-props */
import { useState } from "react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
- HoverCardPortal,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
import { usePostHogClientCapture } from "@/src/features/posthog-analytics";
import { cn } from "@/src/utils/tailwind";
import { ExternalLink, Info } from "lucide-react";
@@ -26,7 +22,7 @@ export default function DocPopup({
// never opens on touch by itself, and the old click-to-navigate behavior
// is gone — docs open only via the explicit link inside the card.
const [open, setOpen] = useState(false);
- // Single open-change path: Radix only calls onOpenChange from its own
+ // Single open-change path: Floating UI only calls onOpenChange from its own
// hover/focus handling, so the click handler must route through here too
// or tap-opens (the only way in on touch) would never be captured.
const handleOpenChange = (nextOpen: boolean) => {
@@ -40,24 +36,12 @@ export default function DocPopup({
};
return (
- <HoverCard openDelay={200} open={open} onOpenChange={handleOpenChange}>
- {/* The ⓘ itself never navigates; a click toggles the card (touch
- support) and must not bubble into whatever the icon sits on —
- e.g. a filter facet's accordion trigger. */}
- <HoverCardTrigger className="mx-1 cursor-help" asChild>
- <div
- className="text-muted-foreground inline-block whitespace-nowrap sm:pl-0"
- onClick={(e) => {
- e.preventDefault();
- e.stopPropagation();
- handleOpenChange(!open);
- }}
- >
- <Info className="icon-sm" />
- </div>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent>
+ <ControlledHoverCard
+ openDelay={200}
+ open={open}
+ onOpenChange={handleOpenChange}
+ content={
+ <div className="w-64 p-3">
<div
className={cn(
"text-primary text-xs font-normal whitespace-break-spaces sm:pl-0",
@@ -84,9 +68,26 @@ export default function DocPopup({
<ExternalLink className="icon-sm" />
</a>
)}
- </HoverCardContent>
- </HoverCardPortal>
- </HoverCard>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label="More information"
+ className="text-muted-foreground mx-1 inline-block cursor-help whitespace-nowrap sm:pl-0"
+ {...getTriggerProps({
+ onClick: (e) => {
+ e.preventDefault();
+ e.stopPropagation();
+ handleOpenChange(!open);
+ },
+ })}
+ >
+ <Info className="icon-sm" />
+ </button>
+ )}
+ </ControlledHoverCard>
);
}
@@ -97,15 +98,25 @@ export type PopupProps = {
export function Popup({ triggerContent, description }: PopupProps) {
return (
- <HoverCard openDelay={200}>
- <HoverCardTrigger className="mx-1 cursor-pointer" asChild>
- <div>{triggerContent}</div>
- </HoverCardTrigger>
- <HoverCardContent>
- <div className="text-primary text-xs font-normal whitespace-break-spaces sm:pl-0">
- {description}
+ <HoverCard
+ openDelay={200}
+ content={
+ <div className="w-64 p-3">
+ <div className="text-primary text-xs font-normal whitespace-break-spaces sm:pl-0">
+ {description}
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <div
+ className="mx-1 cursor-pointer"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
+ {triggerContent}
</div>
- </HoverCardContent>
+ )}
</HoverCard>
);
}
diff --git a/web/src/components/scores-table-cell.tsx b/web/src/components/scores-table-cell.tsx
index 4b7a285573..c9b8bac78c 100644
--- a/web/src/components/scores-table-cell.tsx
+++ b/web/src/components/scores-table-cell.tsx
@@ -1,8 +1,5 @@
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
import {
type CategoricalAggregate,
type AggregatedScoreData,
@@ -91,35 +88,45 @@ export const ScoresTableCell = ({
{aggregate.type === "NUMERIC" ? aggregate.average.toFixed(2) : value}
</span>
{aggregate.comment && (
- <HoverCard>
- <HoverCardTrigger className="inline-flex shrink-0 cursor-pointer items-center">
- <MessageCircleMore className="icon-sm" />
- </HoverCardTrigger>
- <HoverCardContent className="flex flex-col p-0 text-xs break-normal whitespace-normal">
- {/* Name what the icon opened: a bare block of text next to a
+ <HoverCard
+ content={
+ <div className="flex w-64 flex-col p-0 text-xs break-normal whitespace-normal">
+ {/* Name what the icon opened: a bare block of text next to a
score does not say it is the score's comment. */}
- <div className="bg-popover sticky top-0 z-10 flex h-8 items-center justify-between px-1">
- <span className="text-muted-foreground pl-1.5 text-[10px] font-bold uppercase">
- Score comment
- </span>
- <Button
- onClick={handleCopy}
- variant="ghost"
- size="icon-xs"
- className="hover:bg-accent rounded p-1"
- aria-label={copied ? "Copied" : "Copy to clipboard"}
- >
- {copied ? (
- <Check className="icon-sm text-icon-foreground" />
- ) : (
- <Copy className="icon-sm text-icon-foreground" />
- )}
- </Button>
- </div>
- <div className="max-h-[40vh] overflow-y-auto p-3 pt-0">
- <p className="whitespace-pre-wrap">{aggregate.comment}</p>
+ <div className="bg-popover sticky top-0 z-10 flex h-8 items-center justify-between px-1">
+ <span className="text-muted-foreground pl-1.5 text-[10px] font-bold uppercase">
+ Score comment
+ </span>
+ <Button
+ onClick={handleCopy}
+ variant="ghost"
+ size="icon-xs"
+ className="hover:bg-accent rounded p-1"
+ aria-label={copied ? "Copied" : "Copy to clipboard"}
+ >
+ {copied ? (
+ <Check className="icon-sm text-icon-foreground" />
+ ) : (
+ <Copy className="icon-sm text-icon-foreground" />
+ )}
+ </Button>
+ </div>
+ <div className="max-h-[40vh] overflow-y-auto p-3 pt-0">
+ <p className="whitespace-pre-wrap">{aggregate.comment}</p>
+ </div>
</div>
- </HoverCardContent>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label="View score comment"
+ className="inline-flex shrink-0 cursor-pointer items-center"
+ {...getTriggerProps()}
+ >
+ <MessageCircleMore className="icon-sm" />
+ </button>
+ )}
</HoverCard>
)}
{hasMetadata && !!aggregate.id && (
@@ -143,13 +150,21 @@ export const ScoresTableCell = ({
return (
<div className="group">
{aggregate.valueCounts.length > COLLAPSE_CATEGORICAL_SCORES_AFTER ? (
- <HoverCard>
- <HoverCardTrigger asChild>
+ <HoverCard
+ content={
+ <div className="flex max-h-[40vh] w-64 max-w-64 flex-col overflow-y-auto p-3 text-xs break-normal whitespace-normal">
+ <ScoreValueCounts valueCounts={aggregate.valueCounts} wrap />
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<div
+ tabIndex={0}
className={cn(
"group-hover:text-accent-dark-blue/55 cursor-pointer overflow-hidden",
wrap ? "line-clamp-5" : "text-ellipsis whitespace-nowrap",
)}
+ {...getTriggerProps()}
>
<ScoreValueCounts
valueCounts={aggregate.valueCounts.slice(
@@ -159,10 +174,7 @@ export const ScoresTableCell = ({
wrap={wrap}
/>
</div>
- </HoverCardTrigger>
- <HoverCardContent className="z-20 flex max-h-[40vh] max-w-64 flex-col overflow-y-auto text-xs break-normal whitespace-normal">
- <ScoreValueCounts valueCounts={aggregate.valueCounts} wrap />
- </HoverCardContent>
+ )}
</HoverCard>
) : (
<div className={cn("flex", wrap ? "flex-col" : "flex-row")}>
@@ -204,17 +216,29 @@ function AggregateScoreMetadataPeek({
const metadataLoaded = metadata && Object.keys(metadata).length > 0;
return (
- <HoverCard onOpenChange={setIsOpen}>
- <HoverCardTrigger className="inline-flex shrink-0 cursor-pointer items-center">
- <BracesIcon className="icon-sm" />
- </HoverCardTrigger>
- <HoverCardContent className="overflow-hidden rounded-md border-none p-0 text-xs break-normal whitespace-normal">
- {metadataLoaded ? (
- <JSONView codeClassName="rounded-md!" json={metadata} />
- ) : (
- <Skeleton className="h-12 w-full" />
- )}
- </HoverCardContent>
- </HoverCard>
+ <ControlledHoverCard
+ open={isOpen}
+ onOpenChange={setIsOpen}
+ content={
+ <div className="w-64 overflow-hidden rounded-md p-0 text-xs break-normal whitespace-normal">
+ {metadataLoaded ? (
+ <JSONView codeClassName="rounded-md!" json={metadata} />
+ ) : (
+ <Skeleton className="h-12 w-full" />
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label="View score metadata"
+ className="inline-flex shrink-0 cursor-pointer items-center"
+ {...getTriggerProps()}
+ >
+ <BracesIcon className="icon-sm" />
+ </button>
+ )}
+ </ControlledHoverCard>
);
}
diff --git a/web/src/components/table/filtered-run-pills.tsx b/web/src/components/table/filtered-run-pills.tsx
index 39e41f5fa7..37b7e8f613 100644
--- a/web/src/components/table/filtered-run-pills.tsx
+++ b/web/src/components/table/filtered-run-pills.tsx
@@ -1,10 +1,6 @@
/* eslint-disable @repo/no-style-props */
import { Badge } from "@/src/components/ui/badge";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { api } from "@/src/utils/api";
import { ListFilter } from "lucide-react";
import React, { useMemo } from "react";
@@ -88,30 +84,36 @@ export function FilteredRunPills({
<div className={`flex flex-wrap items-center gap-1 ${className ?? ""}`}>
{allFilters.map((item) => {
return (
- <HoverCard key={item.key}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ key={item.key}
+ content={
+ <div className="w-64 p-3">
+ <div className="space-y-2">
+ <div className="flex items-center gap-2 text-sm">
+ {item.runName}
+ </div>
+ <div className="space-y-1">
+ <div className="bg-muted rounded-md px-2 py-1 text-sm">
+ {formatFilterForPill(item.filter)}
+ </div>
+ </div>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<Badge
variant="secondary"
className="hover:bg-secondary/80 cursor-pointer text-xs transition-colors"
+ tabIndex={0}
+ {...getTriggerProps()}
>
<ListFilter className="icon-sm mr-1" />
<div className="font-normal">
{formatFilterForPill(item.filter)}
</div>
</Badge>
- </HoverCardTrigger>
- <HoverCardContent className="w-64">
- <div className="space-y-2">
- <div className="flex items-center gap-2 text-sm">
- {item.runName}
- </div>
- <div className="space-y-1">
- <div className="bg-muted rounded-md px-2 py-1 text-sm">
- {formatFilterForPill(item.filter)}
- </div>
- </div>
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
);
})}
diff --git a/web/src/components/ui/hover-card.tsx b/web/src/components/ui/hover-card.tsx
deleted file mode 100644
index 4d8e160d12..0000000000
--- a/web/src/components/ui/hover-card.tsx
+++ /dev/null
@@ -1,81 +0,0 @@
-/* eslint-disable @repo/no-style-props */
-"use client";
-
-import * as React from "react";
-import * as HoverCardPrimitive from "@radix-ui/react-hover-card";
-
-import { cn } from "@/src/utils/tailwind";
-import { useLayerContainer } from "@/src/context/LayerContext/LayerContext";
-import { stopScrollPropagation } from "@/src/hooks/stopScrollPropagation";
-
-const HoverCard = HoverCardPrimitive.Root;
-
-const HoverCardTrigger = HoverCardPrimitive.Trigger;
-
-// Route into the `popover` overlay layer (same as HoverCardContent). null until
-// mounted → falls back to <body>, SSR-parity. Layer order, not z-index, stacks
-// it. An explicit `container` prop still overrides the default.
-const HoverCardPortal = ({
- ...props
-}: React.ComponentPropsWithoutRef<typeof HoverCardPrimitive.Portal>) => {
- const container = useLayerContainer("popover");
- return <HoverCardPrimitive.Portal container={container} {...props} />;
-};
-HoverCardPortal.displayName = "HoverCardPortal";
-
-const HoverCardContent = React.forwardRef<
- React.ComponentRef<typeof HoverCardPrimitive.Content>,
- React.ComponentPropsWithoutRef<typeof HoverCardPrimitive.Content>
->(
- (
- {
- className,
- align = "center",
- sideOffset = 4,
- onWheel,
- onTouchMove,
- ...props
- },
- ref,
- ) => {
- // Route into the `popover` overlay layer. null until mounted → falls back to
- // <body>, SSR-parity. Layer order, not z-index, stacks it.
- const container = useLayerContainer("popover");
- return (
- <HoverCardPrimitive.Portal container={container}>
- <HoverCardPrimitive.Content
- ref={ref}
- align={align}
- sideOffset={sideOffset}
- // Keeps scrollable content in a hover card scrollable when it is
- // opened from a scroll-locked overlay (see `stopScrollPropagation`).
- onWheel={stopScrollPropagation(onWheel)}
- onTouchMove={stopScrollPropagation(onTouchMove)}
- className={cn(
- "bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 w-64 rounded-md border p-3 shadow-md outline-hidden",
- className,
- )}
- {...props}
- />
- </HoverCardPrimitive.Portal>
- );
- },
-);
-HoverCardContent.displayName = HoverCardPrimitive.Content.displayName;
-
-const HoverCardTitle = React.forwardRef<
- HTMLParagraphElement,
- React.HTMLAttributes<HTMLHeadingElement>
->(({ className, ...props }, ref) => (
- <h3
- ref={ref}
- className={cn(
- "p-2 text-sm leading-none font-bold tracking-tight",
- className,
- )}
- {...props}
- />
-));
-HoverCardTitle.displayName = "HoverCardTitle";
-
-export { HoverCard, HoverCardTrigger, HoverCardContent, HoverCardPortal };
diff --git a/web/src/components/ui/media/MediaReferenceTag.clienttest.tsx b/web/src/components/ui/media/MediaReferenceTag.clienttest.tsx
index 16ecdd6c31..ff8637e3be 100644
--- a/web/src/components/ui/media/MediaReferenceTag.clienttest.tsx
+++ b/web/src/components/ui/media/MediaReferenceTag.clienttest.tsx
@@ -3,6 +3,7 @@ import { describe, expect, it, vi } from "vitest";
import { MediaReferenceTag } from "./MediaReferenceTag";
import { classifyMediaValue } from "./mediaUtils";
+import { LayerProvider } from "@/src/context/LayerContext/LayerContext";
vi.mock("./useResolvedMedia", () => ({
useResolvedMedia: () => ({
@@ -19,7 +20,9 @@ describe("MediaReferenceTag", () => {
);
expect(descriptor).not.toBeNull();
- render(<MediaReferenceTag descriptor={descriptor!} />);
+ render(<MediaReferenceTag descriptor={descriptor!} />, {
+ wrapper: LayerProvider,
+ });
const trigger = screen.getByRole("button", { name: "PNG media" });
trigger.focus();
@@ -34,7 +37,9 @@ describe("MediaReferenceTag", () => {
);
expect(descriptor).not.toBeNull();
- render(<MediaReferenceTag descriptor={descriptor!} />);
+ render(<MediaReferenceTag descriptor={descriptor!} />, {
+ wrapper: LayerProvider,
+ });
const attachment = screen.getByRole("button", {
name: "Full value attached media",
diff --git a/web/src/components/ui/overlay-scroll.clienttest.tsx b/web/src/components/ui/overlay-scroll.clienttest.tsx
index d2af546992..b8e7458910 100644
--- a/web/src/components/ui/overlay-scroll.clienttest.tsx
+++ b/web/src/components/ui/overlay-scroll.clienttest.tsx
@@ -13,11 +13,8 @@ import {
PopoverContent,
PopoverTrigger,
} from "@/src/components/ui/popover";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
+import { LayerProvider } from "@/src/context/LayerContext/LayerContext";
describe("overlay content keeps scroll events local", () => {
beforeAll(() => {
@@ -68,12 +65,14 @@ describe("overlay content keeps scroll events local", () => {
it("hover card: neither event reaches the document", () => {
render(
- <HoverCard open>
- <HoverCardTrigger>hover</HoverCardTrigger>
- <HoverCardContent>
- <pre>preview</pre>
- </HoverCardContent>
- </HoverCard>,
+ <ControlledHoverCard
+ open
+ onOpenChange={vi.fn()}
+ content={<pre>preview</pre>}
+ >
+ {({ getTriggerProps }) => <button {...getTriggerProps()}>hover</button>}
+ </ControlledHoverCard>,
+ { wrapper: LayerProvider },
);
scroll(screen.getByText("preview"));
diff --git a/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorPromptPreview.tsx b/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorPromptPreview.tsx
index 21d3a4b466..722133ef52 100644
--- a/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorPromptPreview.tsx
+++ b/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorPromptPreview.tsx
@@ -1,11 +1,7 @@
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
type EvaluatorPromptPreviewProps = {
- trigger: React.ReactNode;
+ trigger: React.ComponentProps<typeof HoverCard>["children"];
previewContent: string;
};
@@ -13,16 +9,22 @@ export function EvaluatorPromptPreview(props: EvaluatorPromptPreviewProps) {
const { trigger, previewContent } = props;
return (
- <HoverCard openDelay={150} closeDelay={150}>
- <HoverCardTrigger asChild>{trigger}</HoverCardTrigger>
- <HoverCardContent className="w-[520px] max-w-[85vw]" align="end">
- <p className="text-muted-foreground mb-2 text-xs">
- Prompt preview with the first selected observation
- </p>
- <pre className="bg-muted/20 max-h-[320px] overflow-y-auto rounded-md border p-2 text-xs wrap-break-word whitespace-pre-wrap">
- {previewContent}
- </pre>
- </HoverCardContent>
+ <HoverCard
+ openDelay={150}
+ closeDelay={150}
+ placement="bottom-end"
+ content={
+ <div className="w-[520px] max-w-[85vw] p-3">
+ <p className="text-muted-foreground mb-2 text-xs">
+ Prompt preview with the first selected observation
+ </p>
+ <pre className="bg-muted/20 max-h-[320px] overflow-y-auto rounded-md border p-2 text-xs wrap-break-word whitespace-pre-wrap">
+ {previewContent}
+ </pre>
+ </div>
+ }
+ >
+ {trigger}
</HoverCard>
);
}
diff --git a/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorSelectionStep.tsx b/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorSelectionStep.tsx
index 2802249416..b543c7c03d 100644
--- a/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorSelectionStep.tsx
+++ b/web/src/features/batch-actions/components/RunEvaluationDialog/EvaluatorSelectionStep.tsx
@@ -141,8 +141,8 @@ export function EvaluatorSelectionStep(props: EvaluatorSelectionStepProps) {
<EvaluatorPromptPreview
key={evaluator.id}
previewContent={getPromptPreview(evaluator)}
- trigger={
- <div>
+ trigger={({ getTriggerProps }) => (
+ <div tabIndex={0} {...getTriggerProps()}>
<Badge
variant="secondary"
className="flex items-center gap-1 pr-1"
@@ -158,7 +158,7 @@ export function EvaluatorSelectionStep(props: EvaluatorSelectionStepProps) {
</button>
</Badge>
</div>
- }
+ )}
/>
))
) : (
@@ -191,21 +191,23 @@ export function EvaluatorSelectionStep(props: EvaluatorSelectionStepProps) {
</p>
<EvaluatorPromptPreview
previewContent={getPromptPreview(item)}
- trigger={
+ trigger={({ getTriggerProps }) => (
<Button
variant="ghost"
size="icon-sm"
className="h-7 w-7"
- onMouseDown={(event) => {
- event.preventDefault();
- event.stopPropagation();
- }}
- onClick={(event) => event.stopPropagation()}
+ {...getTriggerProps({
+ onMouseDown: (event) => {
+ event.preventDefault();
+ event.stopPropagation();
+ },
+ onClick: (event) => event.stopPropagation(),
+ })}
aria-label={`Preview ${item.scoreName}`}
>
<Eye className="icon-base text-icon-foreground" />
</Button>
- }
+ )}
/>
<span className="mr-1">
<Checkbox
diff --git a/web/src/features/comments/ReactionBar.tsx b/web/src/features/comments/ReactionBar.tsx
index 4bfd1e5e77..b9857fcfe8 100644
--- a/web/src/features/comments/ReactionBar.tsx
+++ b/web/src/features/comments/ReactionBar.tsx
@@ -1,9 +1,5 @@
import { Button } from "@/src/components/ui/button";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { cn } from "@/src/utils/tailwind";
import { api } from "@/src/utils/api";
@@ -54,17 +50,30 @@ export function ReactionBar({
}
return (
- <HoverCard key={reaction.emoji} openDelay={200}>
- <HoverCardTrigger asChild>{button}</HoverCardTrigger>
- <HoverCardContent className="w-fit p-2" side="top">
- <div className="flex flex-col gap-1">
- {reaction.users.map((user) => (
- <div key={user.id} className="text-muted-foreground text-xs">
- {user.name || "Unknown user"}
- </div>
- ))}
+ <HoverCard
+ key={reaction.emoji}
+ openDelay={200}
+ placement="top"
+ content={
+ <div className="w-fit p-2">
+ <div className="flex flex-col gap-1">
+ {reaction.users.map((user) => (
+ <div
+ key={user.id}
+ className="text-muted-foreground text-xs"
+ >
+ {user.name || "Unknown user"}
+ </div>
+ ))}
+ </div>
</div>
- </HoverCardContent>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span className="inline-flex" {...getTriggerProps()}>
+ {button}
+ </span>
+ )}
</HoverCard>
);
})}
diff --git a/web/src/features/datasets/components/DatasetSchemaHoverCard.tsx b/web/src/features/datasets/components/DatasetSchemaHoverCard.tsx
index eaa9296f68..517863338b 100644
--- a/web/src/features/datasets/components/DatasetSchemaHoverCard.tsx
+++ b/web/src/features/datasets/components/DatasetSchemaHoverCard.tsx
@@ -1,9 +1,5 @@
import { ArrowUpRight, LockIcon, Copy, Check } from "lucide-react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { CodeMirrorEditor } from "@/src/components/editor";
import type { Prisma } from "@langfuse/shared";
import { Button } from "@/src/components/ui/button";
@@ -53,74 +49,78 @@ export const DatasetSchemaHoverCard: React.FC<DatasetSchemaHoverCardProps> = ({
};
return (
- <HoverCard openDelay={200} closeDelay={100}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ openDelay={200}
+ closeDelay={100}
+ collisionPadding={20}
+ content={
+ <div className="max-h-[80vh] w-[400px] overflow-auto p-3">
+ <p className="text-sm font-bold">{title}</p>
+ <p className="text-muted-foreground pt-2 text-sm">
+ Learn more about{" "}
+ <a
+ href="https://json-schema.org/learn/miscellaneous-examples"
+ target="_blank"
+ rel="noopener noreferrer"
+ className="hover:text-foreground inline-flex items-center underline"
+ >
+ JSON Schema
+ <ArrowUpRight className="icon-sm ml-0.5" />
+ </a>
+ </p>
+ <div className="mt-2">
+ <CodeMirrorEditor
+ mode="json"
+ value={schemaString}
+ onChange={() => {}} // Read-only
+ className="max-h-[250px] overflow-y-auto"
+ editable={false}
+ />
+ </div>
+
+ {exampleObject && (
+ <>
+ <Separator className="my-4" />
+ <div className="flex items-center justify-between">
+ <p className="text-sm font-bold">Example Object</p>
+ <Button
+ variant="ghost"
+ size="sm"
+ onClick={handleCopyExample}
+ className="h-7 px-2"
+ >
+ {copied ? (
+ <Check className="icon-base text-icon-foreground" />
+ ) : (
+ <Copy className="icon-base text-icon-foreground" />
+ )}
+ </Button>
+ </div>
+ <div className="mt-2">
+ <CodeMirrorEditor
+ mode="json"
+ value={exampleObject}
+ className="max-h-[250px] overflow-y-auto"
+ editable={false}
+ />
+ </div>
+ </>
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<Button
variant="ghost"
className="text-muted-foreground hover:bg-accent hover:text-accent-foreground inline-flex items-center gap-1.5 rounded p-1 text-xs transition-colors"
aria-label={`View ${title}`}
size="sm"
+ {...getTriggerProps()}
>
<LockIcon className="icon-base text-icon-foreground" />
{showLabel && <span>Schema enforced</span>}
</Button>
- </HoverCardTrigger>
- <HoverCardContent
- className="max-h-[80vh] w-[400px] overflow-auto"
- collisionPadding={20}
- >
- <p className="text-sm font-bold">{title}</p>
- <p className="text-muted-foreground pt-2 text-sm">
- Learn more about{" "}
- <a
- href="https://json-schema.org/learn/miscellaneous-examples"
- target="_blank"
- rel="noopener noreferrer"
- className="hover:text-foreground inline-flex items-center underline"
- >
- JSON Schema
- <ArrowUpRight className="icon-sm ml-0.5" />
- </a>
- </p>
- <div className="mt-2">
- <CodeMirrorEditor
- mode="json"
- value={schemaString}
- onChange={() => {}} // Read-only
- className="max-h-[250px] overflow-y-auto"
- editable={false}
- />
- </div>
-
- {exampleObject && (
- <>
- <Separator className="my-4" />
- <div className="flex items-center justify-between">
- <p className="text-sm font-bold">Example Object</p>
- <Button
- variant="ghost"
- size="sm"
- onClick={handleCopyExample}
- className="h-7 px-2"
- >
- {copied ? (
- <Check className="icon-base text-icon-foreground" />
- ) : (
- <Copy className="icon-base text-icon-foreground" />
- )}
- </Button>
- </div>
- <div className="mt-2">
- <CodeMirrorEditor
- mode="json"
- value={exampleObject}
- className="max-h-[250px] overflow-y-auto"
- editable={false}
- />
- </div>
- </>
- )}
- </HoverCardContent>
+ )}
</HoverCard>
);
};
diff --git a/web/src/features/evals/v2/components/Evaluators/EvaluatorStatusBadge/EvaluatorStatusBadge.tsx b/web/src/features/evals/v2/components/Evaluators/EvaluatorStatusBadge/EvaluatorStatusBadge.tsx
index 92a572cb12..f512247a4b 100644
--- a/web/src/features/evals/v2/components/Evaluators/EvaluatorStatusBadge/EvaluatorStatusBadge.tsx
+++ b/web/src/features/evals/v2/components/Evaluators/EvaluatorStatusBadge/EvaluatorStatusBadge.tsx
@@ -5,11 +5,7 @@ import {
type EvaluatorBlockReason,
} from "@langfuse/shared";
import { Badge } from "@/src/components/design-system/Badge/Badge";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
type ExecutionSummary = { total: number; failed: number };
@@ -85,35 +81,44 @@ export function EvaluatorStatusBadge({
);
return (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- {executionsHref ? (
- <Link
- href={executionsHref}
- onClick={(event) => event.stopPropagation()}
- aria-label={`View executions: ${status}`}
- className="focus-visible:ring-ring inline-flex rounded-sm focus-visible:ring-2 focus-visible:outline-none"
- >
- {badge}
- </Link>
- ) : (
- <span className="inline-flex" tabIndex={0}>
- {badge}
- </span>
- )}
- </HoverCardTrigger>
- <HoverCardContent align="start" className="w-80 text-sm">
- <p>{explanation}</p>
- {executionsHref && (
- <Link
- href={executionsHref}
- onClick={(event) => event.stopPropagation()}
- className="text-primary mt-2 inline-block underline"
- >
- View executions
- </Link>
- )}
- </HoverCardContent>
+ <HoverCard
+ openDelay={200}
+ placement="bottom-start"
+ content={
+ <div className="w-80 p-3 text-sm">
+ <p>{explanation}</p>
+ {executionsHref && (
+ <Link
+ href={executionsHref}
+ onClick={(event) => event.stopPropagation()}
+ className="text-primary mt-2 inline-block underline"
+ >
+ View executions
+ </Link>
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <>
+ {executionsHref ? (
+ <Link
+ {...getTriggerProps({
+ onClick: (event) => event.stopPropagation(),
+ })}
+ href={executionsHref}
+ aria-label={`View executions: ${status}`}
+ className="focus-visible:ring-ring inline-flex rounded-sm focus-visible:ring-2 focus-visible:outline-none"
+ >
+ {badge}
+ </Link>
+ ) : (
+ <span className="inline-flex" tabIndex={0} {...getTriggerProps()}>
+ {badge}
+ </span>
+ )}
+ </>
+ )}
</HoverCard>
);
}
diff --git a/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx b/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
index f76cca12c4..90f95489b7 100644
--- a/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
+++ b/web/src/features/experiments/components/table/ExperimentGridCell.clienttest.tsx
@@ -9,6 +9,7 @@ import type { VisibilityState } from "@tanstack/react-table";
import type { ComponentProps } from "react";
import { ExperimentGridCell } from "./ExperimentGridCell";
import { TooltipProvider } from "@/src/components/ui/tooltip";
+import { LayerProvider } from "@/src/context/LayerContext/LayerContext";
const metadataQuery = vi.hoisted(() => vi.fn(() => ({ data: undefined })));
@@ -94,6 +95,7 @@ const renderGridCell = (
{...overrides}
/>
</TooltipProvider>,
+ { wrapper: LayerProvider },
);
describe("ExperimentGridCell", () => {
@@ -134,10 +136,13 @@ describe("ExperimentGridCell", () => {
expect(
screen.queryByText("← Baseline: Incorrect"),
).not.toBeInTheDocument();
- fireEvent.pointerEnter(screen.getByText("accuracy"));
+ const trigger = screen.getByText("accuracy").closest("[tabindex]");
+ if (!trigger) throw new Error("Score hover trigger not found");
+ fireEvent.mouseEnter(trigger);
await act(async () => {
await new Promise((resolve) => setTimeout(resolve, 750));
});
+ await screen.findByRole("dialog", { name: "Preview" });
expect(screen.queryByText("← Baseline: Incorrect") !== null).toBe(
showDiff,
);
@@ -249,7 +254,9 @@ describe("ExperimentGridCell", () => {
{ projectId: "project-id", id: "score-id" },
expect.objectContaining({ enabled: false }),
);
- fireEvent.pointerEnter(screen.getByText("quality"));
+ fireEvent.mouseEnter(
+ screen.getByText("quality").closest('[aria-haspopup="dialog"]')!,
+ );
await act(async () => {
await new Promise((resolve) => setTimeout(resolve, 750));
});
diff --git a/web/src/features/experiments/components/table/ExperimentGridCell.tsx b/web/src/features/experiments/components/table/ExperimentGridCell.tsx
index e06b5dcd16..68cee2c018 100644
--- a/web/src/features/experiments/components/table/ExperimentGridCell.tsx
+++ b/web/src/features/experiments/components/table/ExperimentGridCell.tsx
@@ -25,11 +25,7 @@ import {
} from "@/src/features/experiments/components/table/types";
import { buildLocalIsoDatePresentation } from "@/src/utils/dates";
import { usdFormatter } from "@/src/utils/numbers";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { Copy, Check, ExternalLink, SquarePen } from "lucide-react";
import { Button } from "@/src/components/design-system/Button/Button";
import { copyTextToClipboard } from "@/src/utils/clipboard";
@@ -174,11 +170,82 @@ const ScoreItem = ({
);
return (
- <HoverCard onOpenChange={setIsOpen}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ onOpenChange={setIsOpen}
+ placement="bottom-start"
+ onClick={(event) => event.stopPropagation()}
+ content={
+ <div className="max-h-[50vh] w-96 overflow-auto p-3 text-xs break-words whitespace-normal">
+ <div className="flex flex-col gap-3">
+ <span className="font-bold">{name}</span>
+ <dl className="grid grid-cols-[auto_1fr] gap-x-4 gap-y-1">
+ <dt className="text-muted-foreground">Value</dt>
+ <dd className="min-w-0">
+ {displayValue}
+ {diff?.type === "CATEGORICAL" && (
+ <span className="text-muted-foreground ml-2 whitespace-normal">
+ {diff.from
+ ? `← Baseline: ${diff.from}`
+ : "Varies from baseline"}
+ </span>
+ )}
+ </dd>
+ <dt className="text-muted-foreground">Source</dt>
+ <dd className="capitalize">{source.toLowerCase()}</dd>
+ <dt className="text-muted-foreground">Type</dt>
+ <dd className="capitalize">{dataType.toLowerCase()}</dd>
+ </dl>
+ {aggregate?.comment && (
+ <div>
+ <div className="flex items-center justify-between">
+ <span className="text-muted-foreground">Comment</span>
+ <Button
+ variant="ghost"
+ size="sm"
+ text={copied ? "Copied" : "Copy comment"}
+ icon={copied ? Check : Copy}
+ onClick={async () => {
+ await copyTextToClipboard(aggregate.comment!);
+ setCopied(true);
+ setTimeout(() => setCopied(false), 2000);
+ }}
+ />
+ </div>
+ <p className="whitespace-pre-wrap">{aggregate.comment}</p>
+ </div>
+ )}
+ {aggregate?.hasMetadata && aggregate.id && (
+ <div className="flex flex-col gap-1">
+ <span className="text-muted-foreground">Metadata</span>
+ {isError && <p>Could not load metadata.</p>}
+ {!isError && metadata !== undefined && (
+ <JSONView json={metadata} />
+ )}
+ {!isError && metadata === undefined && (
+ <Skeleton className="h-12 w-full" />
+ )}
+ </div>
+ )}
+ {aggregate?.executionTraceId && (
+ <Link
+ href={`/project/${projectId}/traces/${encodeURIComponent(aggregate.executionTraceId)}`}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="flex items-center gap-1 hover:underline"
+ >
+ <ExternalLink className="icon-sm" />
+ View execution trace
+ </Link>
+ )}
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<div
tabIndex={0}
className="flex cursor-default items-center justify-between gap-2 text-xs"
+ {...getTriggerProps()}
>
<div className="flex min-w-0 items-center gap-1">
<span className="text-muted-foreground line-clamp-1 min-w-0">
@@ -223,75 +290,7 @@ const ScoreItem = ({
)}
</div>
</div>
- </HoverCardTrigger>
- <HoverCardContent
- align="start"
- className="max-h-[50vh] w-96 overflow-auto text-xs break-words whitespace-normal"
- onClick={(event) => event.stopPropagation()}
- >
- <div className="flex flex-col gap-3">
- <span className="font-bold">{name}</span>
- <dl className="grid grid-cols-[auto_1fr] gap-x-4 gap-y-1">
- <dt className="text-muted-foreground">Value</dt>
- <dd className="min-w-0">
- {displayValue}
- {diff?.type === "CATEGORICAL" && (
- <span className="text-muted-foreground ml-2 whitespace-normal">
- {diff.from
- ? `← Baseline: ${diff.from}`
- : "Varies from baseline"}
- </span>
- )}
- </dd>
- <dt className="text-muted-foreground">Source</dt>
- <dd className="capitalize">{source.toLowerCase()}</dd>
- <dt className="text-muted-foreground">Type</dt>
- <dd className="capitalize">{dataType.toLowerCase()}</dd>
- </dl>
- {aggregate?.comment && (
- <div>
- <div className="flex items-center justify-between">
- <span className="text-muted-foreground">Comment</span>
- <Button
- variant="ghost"
- size="sm"
- text={copied ? "Copied" : "Copy comment"}
- icon={copied ? Check : Copy}
- onClick={async () => {
- await copyTextToClipboard(aggregate.comment!);
- setCopied(true);
- setTimeout(() => setCopied(false), 2000);
- }}
- />
- </div>
- <p className="whitespace-pre-wrap">{aggregate.comment}</p>
- </div>
- )}
- {aggregate?.hasMetadata && aggregate.id && (
- <div className="flex flex-col gap-1">
- <span className="text-muted-foreground">Metadata</span>
- {isError && <p>Could not load metadata.</p>}
- {!isError && metadata !== undefined && (
- <JSONView json={metadata} />
- )}
- {!isError && metadata === undefined && (
- <Skeleton className="h-12 w-full" />
- )}
- </div>
- )}
- {aggregate?.executionTraceId && (
- <Link
- href={`/project/${projectId}/traces/${encodeURIComponent(aggregate.executionTraceId)}`}
- target="_blank"
- rel="noopener noreferrer"
- className="flex items-center gap-1 hover:underline"
- >
- <ExternalLink className="icon-sm" />
- View execution trace
- </Link>
- )}
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
);
};
diff --git a/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx b/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
index 8072ce26f0..a5e590b488 100644
--- a/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
+++ b/web/src/features/experiments/components/table/ScoreColumnHeaderSummary.tsx
@@ -1,8 +1,4 @@
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import {
Tooltip,
TooltipContent,
@@ -111,9 +107,64 @@ export const ScoreColumnHeaderSummary = ({
// The filter menu sits outside the hover-card trigger so its own popover is
// not fighting the hover card for the pointer.
<div className="flex min-w-0 flex-1 items-start gap-1">
- <HoverCard>
- <HoverCardTrigger asChild>
- <div className="flex min-w-0 flex-1 cursor-default flex-col gap-0.5 py-0.5">
+ <HoverCard
+ placement="bottom-start"
+ content={
+ <div className="flex w-64 flex-col gap-1 p-3 font-normal">
+ <span className="text-xs font-bold break-all">{label}</span>
+ <span className="text-muted-foreground text-[10px]">
+ {getScoreDataTypeExplanation(dataType)}
+ </span>
+ <SummaryRow
+ label={`${hasBaseline ? "Baseline experiment" : "This experiment"} (${DIFF_LABEL_TITLES[dataType]})`}
+ value={
+ baseline ? formatScoreColumnAggregate(baseline) : "no values"
+ }
+ />
+ <SummaryRow label="Items scored" value={baseline?.count ?? 0} />
+ {movement && (
+ <>
+ <SummaryRow
+ label={comparisonName ? `vs ${comparisonName}` : "Comparison"}
+ value={
+ comparison
+ ? formatScoreColumnAggregate(comparison)
+ : "no values"
+ }
+ />
+ {delta !== null && (
+ <SummaryRow
+ label="Change"
+ value={`${delta > 0 ? "+" : ""}${formatScoreValue(delta)}`}
+ />
+ )}
+ {dataType === "CATEGORICAL" ? (
+ <SummaryRow label="Changed value" value={movement.changed} />
+ ) : (
+ <>
+ <SummaryRow label="Improved" value={movement.improved} />
+ <SummaryRow label="Regressed" value={movement.regressed} />
+ </>
+ )}
+ <SummaryRow label="Unchanged" value={movement.unchanged} />
+ <SummaryRow label="Not scored" value={movement.notComparable} />
+ <span className="text-muted-foreground text-[10px]">
+ Not scored: only one of the two experiments has a score for
+ the item — or, for a categorical score, the item has no single
+ value to compare — so it counts as neither an improvement nor
+ a regression.
+ </span>
+ </>
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <div
+ className="flex min-w-0 flex-1 cursor-default flex-col gap-0.5 py-0.5"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
<span className="flex min-w-0 items-baseline gap-1">
{icon && <ScoreDataTypeMarker icon={icon} dataType={dataType} />}
<span className="truncate" title={label}>
@@ -203,59 +254,7 @@ export const ScoreColumnHeaderSummary = ({
</span>
)}
</div>
- </HoverCardTrigger>
- <HoverCardContent
- align="start"
- className="flex w-64 flex-col gap-1 p-3 font-normal"
- >
- <span className="text-xs font-bold break-all">{label}</span>
- <span className="text-muted-foreground text-[10px]">
- {getScoreDataTypeExplanation(dataType)}
- </span>
- <SummaryRow
- label={`${
- hasBaseline ? "Baseline experiment" : "This experiment"
- } (${DIFF_LABEL_TITLES[dataType]})`}
- value={
- baseline ? formatScoreColumnAggregate(baseline) : "no values"
- }
- />
- <SummaryRow label="Items scored" value={baseline?.count ?? 0} />
- {movement && (
- <>
- <SummaryRow
- label={comparisonName ? `vs ${comparisonName}` : "Comparison"}
- value={
- comparison
- ? formatScoreColumnAggregate(comparison)
- : "no values"
- }
- />
- {delta !== null && (
- <SummaryRow
- label="Change"
- value={`${delta > 0 ? "+" : ""}${formatScoreValue(delta)}`}
- />
- )}
- {dataType === "CATEGORICAL" ? (
- <SummaryRow label="Changed value" value={movement.changed} />
- ) : (
- <>
- <SummaryRow label="Improved" value={movement.improved} />
- <SummaryRow label="Regressed" value={movement.regressed} />
- </>
- )}
- <SummaryRow label="Unchanged" value={movement.unchanged} />
- <SummaryRow label="Not scored" value={movement.notComparable} />
- <span className="text-muted-foreground text-[10px]">
- Not scored: only one of the two experiments has a score for the
- item — or, for a categorical score, the item has no single value
- to compare — so it counts as neither an improvement nor a
- regression.
- </span>
- </>
- )}
- </HoverCardContent>
+ )}
</HoverCard>
{filterMenu}
</div>
diff --git a/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.clienttest.tsx b/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.clienttest.tsx
index ee8e2498a6..b3faefd099 100644
--- a/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.clienttest.tsx
+++ b/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.clienttest.tsx
@@ -1,5 +1,6 @@
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
import type { ComponentProps, ReactNode } from "react";
+import type { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { UserFeaturePreviewsControl } from "./UserFeaturePreviewsPopover";
import { featurePreviewFlags } from "../available-flags";
@@ -47,11 +48,12 @@ vi.mock("@/src/components/ui/popover", () => ({
),
}));
-vi.mock("@/src/components/ui/hover-card", () => ({
- HoverCard: ({ children }: { children: ReactNode }) => <>{children}</>,
- HoverCardTrigger: ({ children }: { children: ReactNode }) => <>{children}</>,
- HoverCardContent: ({ children }: { children: ReactNode }) => (
- <div>{children}</div>
+vi.mock("@/src/components/design-system/HoverCard/HoverCard", () => ({
+ HoverCard: ({ children, content }: ComponentProps<typeof HoverCard>) => (
+ <>
+ {children({ getTriggerProps: () => ({}) })}
+ {content}
+ </>
),
}));
diff --git a/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.tsx b/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.tsx
index f2ac2f83f2..5ce572660b 100644
--- a/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.tsx
+++ b/web/src/features/feature-flags/components/UserFeaturePreviewsPopover.tsx
@@ -4,11 +4,7 @@ import { useSession } from "next-auth/react";
import { Switch } from "@/src/components/design-system/Switch/Switch";
import { Button } from "@/src/components/ui/button";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { PopoverContent } from "@/src/components/ui/popover";
import {
featurePreviewFlags,
@@ -75,20 +71,30 @@ export function UserFeaturePreviewsControl({
if (!management.allowed) {
return (
- <HoverCard openDelay={0} closeDelay={0}>
- <HoverCardTrigger asChild>
- <span className="inline-flex cursor-not-allowed">
+ <HoverCard
+ openDelay={0}
+ closeDelay={0}
+ placement="left"
+ content={
+ <div className="w-64 p-3">
+ <p className="text-xs">
+ You can only change this user&apos;s feature flags if you are an
+ administrator in every organization they belong to.
+ </p>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="inline-flex cursor-not-allowed"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
<Button variant="outline" size="sm" disabled>
{enabledCount}/{totalCount} enabled
</Button>
</span>
- </HoverCardTrigger>
- <HoverCardContent align="center" side="left">
- <p className="text-xs">
- You can only change this user&apos;s feature flags if you are an
- administrator in every organization they belong to.
- </p>
- </HoverCardContent>
+ )}
</HoverCard>
);
}
diff --git a/web/src/features/models/ModelDetailPage.tsx b/web/src/features/models/ModelDetailPage.tsx
index ea33ea8e41..7315d95849 100644
--- a/web/src/features/models/ModelDetailPage.tsx
+++ b/web/src/features/models/ModelDetailPage.tsx
@@ -29,11 +29,7 @@ import {
SelectTrigger,
SelectValue,
} from "@/src/components/ui/select";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { CodeMirrorEditor } from "@/src/components/editor";
const resolvePricingTier = <T extends { id: string }>(
@@ -224,42 +220,46 @@ export default function ModelDetailPage() {
</SelectContent>
</Select>
{activeTier && !activeTier.isDefault && (
- <HoverCard openDelay={200} closeDelay={100}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ openDelay={200}
+ closeDelay={100}
+ collisionPadding={20}
+ content={
+ <div className="max-h-[80vh] w-[400px] overflow-auto p-3">
+ <p className="text-sm font-bold">
+ Pricing Tier Conditions
+ </p>
+ <p className="text-muted-foreground pt-2 text-sm">
+ This tier is applied when the following conditions
+ are met:
+ </p>
+ <div className="mt-2">
+ <CodeMirrorEditor
+ mode="json"
+ value={JSON.stringify(
+ activeTier.conditions,
+ null,
+ 2,
+ )}
+ onChange={() => {}} // Read-only
+ className="max-h-[250px] overflow-y-auto"
+ editable={false}
+ />
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<Button
variant="ghost"
className="text-muted-foreground hover:text-accent-foreground inline-flex h-auto items-center gap-1.5 p-0 text-xs hover:bg-transparent"
size="sm"
+ {...getTriggerProps()}
>
<InfoIcon className="icon-base text-icon-foreground" />
<span>Conditions</span>
</Button>
- </HoverCardTrigger>
- <HoverCardContent
- className="max-h-[80vh] w-[400px] overflow-auto"
- collisionPadding={20}
- >
- <p className="text-sm font-bold">
- Pricing Tier Conditions
- </p>
- <p className="text-muted-foreground pt-2 text-sm">
- This tier is applied when the following conditions are
- met:
- </p>
- <div className="mt-2">
- <CodeMirrorEditor
- mode="json"
- value={JSON.stringify(
- activeTier.conditions,
- null,
- 2,
- )}
- onChange={() => {}} // Read-only
- className="max-h-[250px] overflow-y-auto"
- editable={false}
- />
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
)}
</div>
diff --git a/web/src/features/rbac/components/MembersSettingsTable/MembersSettingsTable.tsx b/web/src/features/rbac/components/MembersSettingsTable/MembersSettingsTable.tsx
index a5f29e0543..2cf1f642d8 100644
--- a/web/src/features/rbac/components/MembersSettingsTable/MembersSettingsTable.tsx
+++ b/web/src/features/rbac/components/MembersSettingsTable/MembersSettingsTable.tsx
@@ -24,12 +24,7 @@ import {
SelectTrigger,
SelectValue,
} from "@/src/components/ui/select";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardPortal,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import Link from "next/link";
import { Popover, PopoverTrigger } from "@/src/components/ui/popover";
import { Button } from "@/src/components/ui/button";
@@ -146,10 +141,12 @@ export function MembersSettingsTable({
if (!project || !hasOrgCudAccess) return select;
return (
- <HoverCard openDelay={0} closeDelay={0}>
- <HoverCardTrigger asChild>{select}</HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent align="center" side="right">
+ <HoverCard
+ openDelay={0}
+ closeDelay={0}
+ placement="right"
+ content={
+ <div className="w-64 p-3">
<p className="text-xs">
The organization-level role can be edited in the{" "}
<Link
@@ -160,8 +157,14 @@ export function MembersSettingsTable({
</Link>
.
</p>
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span className="inline-flex" {...getTriggerProps()}>
+ {select}
+ </span>
+ )}
</HoverCard>
);
},
diff --git a/web/src/features/rbac/components/RoleSelectItem.tsx b/web/src/features/rbac/components/RoleSelectItem.tsx
index ecc455621b..66689f02bd 100644
--- a/web/src/features/rbac/components/RoleSelectItem.tsx
+++ b/web/src/features/rbac/components/RoleSelectItem.tsx
@@ -1,10 +1,5 @@
/* eslint-disable no-nested-ternary */
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
- HoverCardPortal,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { SelectItem } from "@/src/components/ui/select";
import {
projectNoneRoleComment,
@@ -30,17 +25,13 @@ export const RoleSelectItem = ({
const projectScopes = reduceScopesToListItems(projectRoleAccessRights, role);
return (
- <HoverCard openDelay={0} closeDelay={0}>
- <HoverCardTrigger asChild>
- <SelectItem value={role} className="max-w-56">
- <span>
- {formatRole(role)}
- {isProjectNoneRole ? " (keep default role)" : ""}
- </span>
- </SelectItem>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent hideWhenDetached={true} align="center" side="right">
+ <HoverCard
+ openDelay={0}
+ closeDelay={0}
+ hideWhenDetached
+ placement="right"
+ content={
+ <div className="w-64 p-3">
{isProjectNoneRole ? (
<div className="text-xs">{projectNoneRoleComment}</div>
) : isOrgNoneRole ? (
@@ -59,8 +50,17 @@ export const RoleSelectItem = ({
</p>
</>
)}
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <SelectItem value={role} className="max-w-56" {...getTriggerProps()}>
+ <span>
+ {formatRole(role)}
+ {isProjectNoneRole ? " (keep default role)" : ""}
+ </span>
+ </SelectItem>
+ )}
</HoverCard>
);
};
diff --git a/web/src/features/score-analytics/components/SamplingDetailsHoverCard.tsx b/web/src/features/score-analytics/components/SamplingDetailsHoverCard.tsx
index a6fa4b4652..d7d4733841 100644
--- a/web/src/features/score-analytics/components/SamplingDetailsHoverCard.tsx
+++ b/web/src/features/score-analytics/components/SamplingDetailsHoverCard.tsx
@@ -1,8 +1,4 @@
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { Info } from "lucide-react";
interface SamplingMetadata {
@@ -30,96 +26,104 @@ export function SamplingDetailsHoverCard({
showLabel = false,
}: SamplingDetailsHoverCardProps) {
return (
- <HoverCard>
- <HoverCardTrigger asChild>
- <button
- className={
- showLabel
- ? "text-muted-foreground hover:text-foreground inline-flex items-center gap-1 text-sm"
- : "hover:bg-muted-foreground/10 inline-flex h-4 w-4 items-center justify-center rounded-full"
- }
- aria-label="View sampling details"
- >
- {showLabel && <span>Sampled Data</span>}
- <Info
- className={showLabel ? "icon-sm" : "text-muted-foreground icon-sm"}
- />
- </button>
- </HoverCardTrigger>
- <HoverCardContent className="w-80" align="start">
- <div className="space-y-3">
- <div>
- <h4 className="mb-2 text-sm font-bold">
- {mode === "single" ? "Estimated Score Count" : "Estimated Scores"}
- </h4>
- <dl className="space-y-1 text-sm">
- {mode === "single" ? (
- <div className="flex justify-between">
- <dt className="text-muted-foreground">Total Scores:</dt>
- <dd className="font-bold">
- ~
- {samplingMetadata.preflightEstimates?.score1Count.toLocaleString()}
- </dd>
- </div>
- ) : (
- <>
+ <HoverCard
+ placement="bottom-start"
+ content={
+ <div className="w-80 p-3">
+ <div className="space-y-3">
+ <div>
+ <h4 className="mb-2 text-sm font-bold">
+ {mode === "single"
+ ? "Estimated Score Count"
+ : "Estimated Scores"}
+ </h4>
+ <dl className="space-y-1 text-sm">
+ {mode === "single" ? (
<div className="flex justify-between">
- <dt className="text-muted-foreground">Score 1:</dt>
+ <dt className="text-muted-foreground">Total Scores:</dt>
<dd className="font-bold">
~
{samplingMetadata.preflightEstimates?.score1Count.toLocaleString()}
</dd>
</div>
- <div className="flex justify-between">
- <dt className="text-muted-foreground">Score 2:</dt>
- <dd className="font-bold">
- ~
- {samplingMetadata.preflightEstimates?.score2Count.toLocaleString()}
- </dd>
- </div>
- <div className="flex justify-between">
- <dt className="text-muted-foreground">
- Estimated Matches:
- </dt>
- <dd className="font-bold">
- ~
- {samplingMetadata.preflightEstimates?.estimatedMatchedCount.toLocaleString()}
- </dd>
- </div>
- </>
- )}
- </dl>
- </div>
+ ) : (
+ <>
+ <div className="flex justify-between">
+ <dt className="text-muted-foreground">Score 1:</dt>
+ <dd className="font-bold">
+ ~
+ {samplingMetadata.preflightEstimates?.score1Count.toLocaleString()}
+ </dd>
+ </div>
+ <div className="flex justify-between">
+ <dt className="text-muted-foreground">Score 2:</dt>
+ <dd className="font-bold">
+ ~
+ {samplingMetadata.preflightEstimates?.score2Count.toLocaleString()}
+ </dd>
+ </div>
+ <div className="flex justify-between">
+ <dt className="text-muted-foreground">
+ Estimated Matches:
+ </dt>
+ <dd className="font-bold">
+ ~
+ {samplingMetadata.preflightEstimates?.estimatedMatchedCount.toLocaleString()}
+ </dd>
+ </div>
+ </>
+ )}
+ </dl>
+ </div>
- <div>
- <h4 className="mb-2 text-sm font-bold">Query Optimizations</h4>
- <dl className="space-y-1 text-sm">
- <div className="flex justify-between">
- <dt className="text-muted-foreground">Sampling:</dt>
- <dd className="font-bold">
- {(samplingMetadata.samplingRate * 100).toFixed(1)}%
- (hash-based)
- </dd>
- </div>
- {samplingMetadata.adaptiveFinal && (
+ <div>
+ <h4 className="mb-2 text-sm font-bold">Query Optimizations</h4>
+ <dl className="space-y-1 text-sm">
<div className="flex justify-between">
- <dt className="text-muted-foreground">Deduplication:</dt>
+ <dt className="text-muted-foreground">Sampling:</dt>
<dd className="font-bold">
- {samplingMetadata.adaptiveFinal.usedFinal
- ? "Enabled"
- : "Skipped for performance"}
+ {(samplingMetadata.samplingRate * 100).toFixed(1)}%
+ (hash-based)
</dd>
</div>
- )}
- </dl>
- </div>
+ {samplingMetadata.adaptiveFinal && (
+ <div className="flex justify-between">
+ <dt className="text-muted-foreground">Deduplication:</dt>
+ <dd className="font-bold">
+ {samplingMetadata.adaptiveFinal.usedFinal
+ ? "Enabled"
+ : "Skipped for performance"}
+ </dd>
+ </div>
+ )}
+ </dl>
+ </div>
- <p className="text-muted-foreground text-xs">
- Hash-based sampling ensures consistent, repeatable results while
- maintaining statistical accuracy.
- </p>
+ <p className="text-muted-foreground text-xs">
+ Hash-based sampling ensures consistent, repeatable results while
+ maintaining statistical accuracy.
+ </p>
+ </div>
</div>
- </HoverCardContent>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ className={
+ showLabel
+ ? "text-muted-foreground hover:text-foreground inline-flex items-center gap-1 text-sm"
+ : "hover:bg-muted-foreground/10 inline-flex h-4 w-4 items-center justify-center rounded-full"
+ }
+ aria-label="View sampling details"
+ {...getTriggerProps()}
+ >
+ {showLabel && <span>Sampled Data</span>}
+ <Info
+ className={showLabel ? "icon-sm" : "text-muted-foreground icon-sm"}
+ />
+ </button>
+ )}
</HoverCard>
);
}
diff --git a/web/src/features/score-analytics/components/ScoreAnalyticsHeader.tsx b/web/src/features/score-analytics/components/ScoreAnalyticsHeader.tsx
index 492cf2fdad..8d09c70a91 100644
--- a/web/src/features/score-analytics/components/ScoreAnalyticsHeader.tsx
+++ b/web/src/features/score-analytics/components/ScoreAnalyticsHeader.tsx
@@ -9,11 +9,7 @@ import {
} from "@/src/utils/date-range-utils";
import { useAnalyticsUrlState } from "@/src/features/score-analytics/lib/analytics-url-state";
import { Badge } from "@/src/components/ui/badge";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
export interface ScoreAnalyticsHeaderProps {
scoreOptions: ScoreOption[];
@@ -80,30 +76,38 @@ export function ScoreAnalyticsHeader({
disabled={!urlState.score1}
className="h-8 w-[200px]"
/>
- <HoverCard>
- <HoverCardTrigger asChild>
- <Badge variant="warning" className="cursor-help">
+ <HoverCard
+ content={
+ <div className="w-80 p-3">
+ <div className="space-y-2">
+ <h4 className="text-sm font-bold">Beta Feature</h4>
+ <p className="text-muted-foreground text-sm">
+ Score analytics is currently in beta. We&apos;re actively
+ improving this feature and would love to hear your feedback.
+ </p>
+ <a
+ href="https://langfuse.com/discussions"
+ target="_blank"
+ rel="noopener noreferrer"
+ className="text-primary inline-flex items-center gap-1 text-sm font-bold hover:underline"
+ >
+ Share feedback on GitHub Discussions
+ <ExternalLink className="icon-sm" />
+ </a>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <Badge
+ variant="warning"
+ className="cursor-help"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
Beta Feature
</Badge>
- </HoverCardTrigger>
- <HoverCardContent className="w-80">
- <div className="space-y-2">
- <h4 className="text-sm font-bold">Beta Feature</h4>
- <p className="text-muted-foreground text-sm">
- Score analytics is currently in beta. We&apos;re actively
- improving this feature and would love to hear your feedback.
- </p>
- <a
- href="https://langfuse.com/discussions"
- target="_blank"
- rel="noopener noreferrer"
- className="text-primary inline-flex items-center gap-1 text-sm font-bold hover:underline"
- >
- Share feedback on GitHub Discussions
- <ExternalLink className="icon-sm" />
- </a>
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
</div>
diff --git a/web/src/features/score-analytics/components/charts/Heatmap.tsx b/web/src/features/score-analytics/components/charts/Heatmap.tsx
index 5a1ab8dff9..fcf73389bd 100644
--- a/web/src/features/score-analytics/components/charts/Heatmap.tsx
+++ b/web/src/features/score-analytics/components/charts/Heatmap.tsx
@@ -3,11 +3,7 @@ import { useMemo, useLayoutEffect, useState, useRef } from "react";
import { type HeatmapCell } from "@/src/features/score-analytics/lib/heatmap-utils";
import { HeatmapCellComponent } from "./HeatmapCell";
import { TooltipProvider } from "@/src/components/ui/tooltip";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { cn } from "@/src/utils/tailwind";
export interface HeatmapProps {
@@ -200,21 +196,25 @@ export function Heatmap({
)}
>
{shouldTruncate ? (
- <HoverCard>
- <HoverCardTrigger asChild>
- <span className="cursor-help text-right">
+ <HoverCard
+ placement="left"
+ content={
+ <div className="w-auto p-3">
+ <div className="space-y-1">
+ <p className="font-bold">{label}</p>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="cursor-help text-right"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
{truncated}
</span>
- </HoverCardTrigger>
- <HoverCardContent
- side="left"
- align="center"
- className="w-auto"
- >
- <div className="space-y-1">
- <p className="font-bold">{label}</p>
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
) : (
<span>{label}</span>
@@ -302,19 +302,24 @@ export function Heatmap({
)}
>
{shouldTruncate ? (
- <HoverCard>
- <HoverCardTrigger asChild>
- <span className="cursor-help">{truncated}</span>
- </HoverCardTrigger>
- <HoverCardContent
- side="bottom"
- align="center"
- className="w-auto"
- >
- <div className="space-y-1">
- <p className="text-xs">{label}</p>
+ <HoverCard
+ content={
+ <div className="w-auto p-3">
+ <div className="space-y-1">
+ <p className="text-xs">{label}</p>
+ </div>
</div>
- </HoverCardContent>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="cursor-help"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
+ {truncated}
+ </span>
+ )}
</HoverCard>
) : (
<span>{label}</span>
diff --git a/web/src/features/score-analytics/components/charts/MetricCard.tsx b/web/src/features/score-analytics/components/charts/MetricCard.tsx
index 8272ccab31..7e2bcd6a80 100644
--- a/web/src/features/score-analytics/components/charts/MetricCard.tsx
+++ b/web/src/features/score-analytics/components/charts/MetricCard.tsx
@@ -5,11 +5,7 @@ import {
TooltipProvider,
TooltipTrigger,
} from "@/src/components/ui/tooltip";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { HelpCircle, AlertCircle } from "lucide-react";
import type { InterpretationResult } from "@/src/features/score-analytics/lib/statistics-utils";
@@ -114,13 +110,14 @@ export function MetricCard({
</TooltipProvider>
)}
{warning?.show && !isPlaceholder && !isNA && (
- <HoverCard>
- <HoverCardTrigger asChild>
- <AlertCircle className="icon-base cursor-help text-amber-500" />
- </HoverCardTrigger>
- <HoverCardContent className="w-80">
- {warning.content}
- </HoverCardContent>
+ <HoverCard
+ content={<div className="w-80 p-3">{warning.content}</div>}
+ >
+ {({ getTriggerProps }) => (
+ <span tabIndex={0} {...getTriggerProps()}>
+ <AlertCircle className="icon-base cursor-help text-amber-500" />
+ </span>
+ )}
</HoverCard>
)}
</div>
diff --git a/web/src/features/scores/components/AnnotationScoreRow.tsx b/web/src/features/scores/components/AnnotationScoreRow.tsx
index afb85090d4..15df021a17 100644
--- a/web/src/features/scores/components/AnnotationScoreRow.tsx
+++ b/web/src/features/scores/components/AnnotationScoreRow.tsx
@@ -29,8 +29,7 @@ import {
PopoverContent,
PopoverTrigger,
} from "@/src/components/ui/popover";
-import { HoverCardContent } from "@radix-ui/react-hover-card";
-import { HoverCard, HoverCardTrigger } from "@/src/components/ui/hover-card";
+import { ControlledHoverCard } from "@/src/components/design-system/ControlledHoverCard/ControlledHoverCard";
import { Badge } from "@/src/components/ui/badge";
import {
DropdownMenuController,
@@ -245,12 +244,19 @@ export function AnnotationScoreRow({
{config.description ||
isPresent(config.maxValue) ||
isPresent(config.minValue) ? (
- <HoverCard
+ <ControlledHoverCard
open={isActive && detailsOpen}
onOpenChange={setDetailsOpen}
+ content={
+ <div className="max-h-[60vh] w-64 max-w-64 overflow-y-auto p-3">
+ <ScoreConfigDetails config={config} />
+ </div>
+ }
>
- <HoverCardTrigger asChild>
+ {({ getTriggerProps }) => (
<span
+ tabIndex={0}
+ {...getTriggerProps()}
className={cn(
"decoration-muted-gray line-clamp-2 min-w-0 text-xs font-bold wrap-break-word underline decoration-dashed underline-offset-2",
config.isArchived ? "text-foreground/40" : "",
@@ -258,11 +264,8 @@ export function AnnotationScoreRow({
>
{score.name}
</span>
- </HoverCardTrigger>
- <HoverCardContent className="z-20 max-h-[60vh] max-w-64 overflow-y-auto rounded border">
- <ScoreConfigDetails config={config} />
- </HoverCardContent>
- </HoverCard>
+ )}
+ </ControlledHoverCard>
) : (
<span
className={cn(
diff --git a/web/src/features/scores/components/ScoreRow.tsx b/web/src/features/scores/components/ScoreRow.tsx
index ea9de01ac3..eaf4b7f02c 100644
--- a/web/src/features/scores/components/ScoreRow.tsx
+++ b/web/src/features/scores/components/ScoreRow.tsx
@@ -4,11 +4,7 @@ import {
type AggregatedScoreData,
} from "@langfuse/shared";
import { MessageCircleMore } from "lucide-react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import {
Tooltip,
TooltipContent,
@@ -124,85 +120,89 @@ export const ScoreRow = ({
}
return (
- <HoverCard openDelay={700} closeDelay={100} onOpenChange={setIsHovered}>
- <div className="flex h-6 w-full items-center gap-2">
- <span className="w-32 shrink-0 truncate font-bold" title={name}>
- {name}
- </span>
- <HoverCardTrigger asChild>
- <div className="cursor-pointer">
- <ScoreValueSection aggregate={aggregate} diff={diff} />
- </div>
- </HoverCardTrigger>
- </div>
- <HoverCardContent
- className="max-h-[40vh] w-[300px] cursor-pointer overflow-y-auto"
- side="top"
- align="start"
- >
- <div className="cursor-pointer space-y-3">
- <h4 className="text-sm font-bold">{name}</h4>
-
- <div className="space-y-2 text-xs">
- <ScoreDetailRow
- label="Value"
- value={resolveScoreValue(aggregate)}
- />
- <ScoreDetailRow label="Source" value={source} />
+ <HoverCard
+ openDelay={700}
+ closeDelay={100}
+ onOpenChange={setIsHovered}
+ placement="top-start"
+ content={
+ <div className="max-h-[40vh] w-[300px] cursor-pointer overflow-y-auto p-3">
+ <div className="cursor-pointer space-y-3">
+ <h4 className="text-sm font-bold">{name}</h4>
- {aggregate.comment && (
+ <div className="space-y-2 text-xs">
<ScoreDetailRow
- label="Comment"
- value={
- <span
- title={aggregate.comment}
- className="line-clamp-10 max-h-[240px] overflow-hidden wrap-break-word"
- style={{
- textAlign: "justify",
- textAlignLast: "right",
- }}
- >
- {aggregate.comment}
- </span>
- }
+ label="Value"
+ value={resolveScoreValue(aggregate)}
/>
- )}
+ <ScoreDetailRow label="Source" value={source} />
- {aggregate.hasMetadata && (
- <ScoreDetailRow
- label="Metadata"
- value={
- <Tooltip>
- <TooltipTrigger asChild>
- <span className="line-clamp-1 cursor-help">
- {(() => {
- try {
- return metadata && Object.keys(metadata).length > 0
- ? JSON.stringify(metadata)
- : "Loading...";
- } catch {
- return "Invalid JSON";
- }
- })()}
- </span>
- </TooltipTrigger>
- <TooltipContent className="w-[400px] text-xs wrap-break-word">
- {metadata && Object.keys(metadata).length > 0 ? (
- <JSONView
- codeClassName="border-none p-0 overflow-y-auto max-h-[40vh]"
- json={metadata}
- />
- ) : (
- <Skeleton className="h-12 w-full" />
- )}
- </TooltipContent>
- </Tooltip>
- }
- />
- )}
+ {aggregate.comment && (
+ <ScoreDetailRow
+ label="Comment"
+ value={
+ <span
+ title={aggregate.comment}
+ className="line-clamp-10 max-h-[240px] overflow-hidden wrap-break-word"
+ style={{
+ textAlign: "justify",
+ textAlignLast: "right",
+ }}
+ >
+ {aggregate.comment}
+ </span>
+ }
+ />
+ )}
+
+ {aggregate.hasMetadata && (
+ <ScoreDetailRow
+ label="Metadata"
+ value={
+ <Tooltip>
+ <TooltipTrigger asChild>
+ <span className="line-clamp-1 cursor-help">
+ {(() => {
+ try {
+ return metadata &&
+ Object.keys(metadata).length > 0
+ ? JSON.stringify(metadata)
+ : "Loading...";
+ } catch {
+ return "Invalid JSON";
+ }
+ })()}
+ </span>
+ </TooltipTrigger>
+ <TooltipContent className="w-[400px] text-xs wrap-break-word">
+ {metadata && Object.keys(metadata).length > 0 ? (
+ <JSONView
+ codeClassName="border-none p-0 overflow-y-auto max-h-[40vh]"
+ json={metadata}
+ />
+ ) : (
+ <Skeleton className="h-12 w-full" />
+ )}
+ </TooltipContent>
+ </Tooltip>
+ }
+ />
+ )}
+ </div>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <div className="flex h-6 w-full items-center gap-2">
+ <span className="w-32 shrink-0 truncate font-bold" title={name}>
+ {name}
+ </span>
+ <div className="cursor-pointer" tabIndex={0} {...getTriggerProps()}>
+ <ScoreValueSection aggregate={aggregate} diff={diff} />
</div>
</div>
- </HoverCardContent>
+ )}
</HoverCard>
);
};
diff --git a/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx b/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
index 639ab515ff..f0cbbe4f94 100644
--- a/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
+++ b/web/src/features/traces/components/AdvancedJsonViewer/components/TruncatedString.tsx
@@ -2,15 +2,11 @@
* TruncatedString - String value with truncation and popover
*
* Shows truncated string with "..." and full value in a popover on hover.
- * Uses shadcn/ui HoverCard component.
+ * Uses the design-system HoverCard component.
*/
import { useRef, useState, useEffect } from "react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import {
Tooltip,
TooltipContent,
@@ -115,10 +111,38 @@ export function TruncatedString({
// Truncated - show popover on hover, use CSS ellipsis for visual truncation
return (
- <HoverCard openDelay={300} closeDelay={100}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ openDelay={300}
+ closeDelay={100}
+ placement="bottom-start"
+ content={
+ <div
+ className="w-64"
+ style={{
+ width: triggerWidth ? `${triggerWidth}px` : undefined,
+ minWidth: triggerWidth ? `${triggerWidth}px` : undefined,
+ maxWidth: triggerWidth ? `${triggerWidth}px` : "28rem",
+ }}
+ >
+ <div
+ className="max-h-60 overflow-auto p-0.5"
+ style={{
+ fontFamily: "var(--font-mono)",
+ fontSize: theme.fontSize,
+ color: theme.stringColor,
+ whiteSpace: "pre-wrap",
+ wordBreak: "break-word",
+ }}
+ >
+ {value}
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<span
- ref={triggerRef}
+ tabIndex={0}
+ {...getTriggerProps({ ref: triggerRef })}
style={{
color: theme.stringColor,
fontFamily: "var(--font-mono)",
@@ -151,30 +175,7 @@ export function TruncatedString({
})}
<span>&quot;</span>
</span>
- </HoverCardTrigger>
- <HoverCardContent
- side="bottom"
- align="start"
- className="p-0"
- style={{
- width: triggerWidth ? `${triggerWidth}px` : undefined,
- minWidth: triggerWidth ? `${triggerWidth}px` : undefined,
- maxWidth: triggerWidth ? `${triggerWidth}px` : "28rem",
- }}
- >
- <div
- className="max-h-60 overflow-auto p-0.5"
- style={{
- fontFamily: "var(--font-mono)",
- fontSize: theme.fontSize,
- color: theme.stringColor,
- whiteSpace: "pre-wrap",
- wordBreak: "break-word",
- }}
- >
- {value}
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
);
}
diff --git a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
index 7ff077beb5..ee674dd94c 100644
--- a/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
+++ b/web/src/features/traces/components/IOPreview/IOPreviewJSON.tsx
@@ -10,11 +10,7 @@ import { Button } from "@/src/components/ui/button";
import { ChevronUp, ChevronDown, WrapText, Minus, Copy } from "lucide-react";
import { useJsonViewPreferences } from "@/src/features/traces/components/AdvancedJsonViewer/hooks/useJsonViewPreferences";
import { type MediaReturnType } from "@/src/features/media";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import {
InlineCommentSelectionProvider,
useInlineCommentSelectionOptional,
@@ -763,24 +759,32 @@ function IOPreviewJSONInner({
</span>
))}
{needsVirtualization && (
- <HoverCard>
- <HoverCardTrigger asChild>
- <span className="bg-muted text-muted-foreground ml-auto cursor-help rounded px-1.5 py-px text-[10px] font-bold">
+ <HoverCard
+ placement="bottom-end"
+ content={
+ <div className="w-80 p-3">
+ <div className="space-y-2">
+ <p className="text-base font-bold">Virtualized View</p>
+ <p className="text-muted-foreground text-xs">
+ This view is using virtualization due to a large number of
+ keys ({rowCounts.input.toLocaleString()} input,{" "}
+ {rowCounts.output.toLocaleString()} output,{" "}
+ {rowCounts.metadata.toLocaleString()} metadata). Only
+ visible rows are rendered for optimal performance.
+ </p>
+ </div>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="bg-muted text-muted-foreground ml-auto cursor-help rounded px-1.5 py-px text-[10px] font-bold"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
Virtualized
</span>
- </HoverCardTrigger>
- <HoverCardContent className="w-80" side="bottom" align="end">
- <div className="space-y-2">
- <p className="text-base font-bold">Virtualized View</p>
- <p className="text-muted-foreground text-xs">
- This view is using virtualization due to a large number of
- keys ({rowCounts.input.toLocaleString()} input,{" "}
- {rowCounts.output.toLocaleString()} output,{" "}
- {rowCounts.metadata.toLocaleString()} metadata). Only visible
- rows are rendered for optimal performance.
- </p>
- </div>
- </HoverCardContent>
+ )}
</HoverCard>
)}
</div>
diff --git a/web/src/features/traces/components/IOPreview/components/CorrectedOutputField.tsx b/web/src/features/traces/components/IOPreview/components/CorrectedOutputField.tsx
index 40d97d9549..fbabb6109b 100644
--- a/web/src/features/traces/components/IOPreview/components/CorrectedOutputField.tsx
+++ b/web/src/features/traces/components/IOPreview/components/CorrectedOutputField.tsx
@@ -13,11 +13,7 @@ import { usePostHogClientCapture } from "@/src/features/posthog-analytics";
import { Switch } from "@/src/components/design-system/Switch/Switch";
import useLocalStorage from "@/src/components/useLocalStorage";
import { CorrectedOutputDiffDialog } from "./CorrectedOutputDiffDialog";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import Link from "next/link";
import { Spinner } from "@/src/components/design-system/Spinner/Spinner";
@@ -202,27 +198,36 @@ export function CorrectedOutputField({
>
{compact ? "" : "Corrected Output"}
</span>
- <HoverCard>
- <HoverCardTrigger asChild>
- <button className="text-muted-foreground hover:text-foreground">
+ <HoverCard
+ placement="right"
+ content={
+ <div className="w-80 p-3 text-xs">
+ <p>
+ Corrected outputs allow you to save the expected output
+ for a trace or observation. Learn more in the{" "}
+ <Link
+ href="https://langfuse.com/docs/observability/features/corrections"
+ target="_blank"
+ rel="noreferrer"
+ className="hover:text-foreground underline"
+ >
+ documentation
+ </Link>
+ .
+ </p>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label="About corrected outputs"
+ className="text-muted-foreground hover:text-foreground"
+ {...getTriggerProps()}
+ >
<Info className="icon-base" />
</button>
- </HoverCardTrigger>
- <HoverCardContent className="w-80 text-xs" side="right">
- <p>
- Corrected outputs allow you to save the expected output for
- a trace or observation. Learn more in the{" "}
- <Link
- href="https://langfuse.com/docs/observability/features/corrections"
- target="_blank"
- rel="noreferrer"
- className="hover:text-foreground underline"
- >
- documentation
- </Link>
- .
- </p>
- </HoverCardContent>
+ )}
</HoverCard>
</div>
<div className="flex items-center">
diff --git a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
index 04e52c8fcc..3934210005 100644
--- a/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
+++ b/web/src/features/traces/components/IOPreview/components/ToolCallDefinitionCard.tsx
@@ -8,11 +8,7 @@ import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import useLocalStorage from "@/src/components/useLocalStorage";
import useSessionStorage from "@/src/components/useSessionStorage";
import { useMemo, useState } from "react";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import type { ToolCallInvocation } from "../../../hooks/useChatMLParser";
// Tool definition extracted from messages
@@ -126,12 +122,7 @@ function ToolGroupHoverContent({
toolNameToDefinitionNumber?: Map<string, number>;
}) {
return (
- <HoverCardContent
- side="bottom"
- align="start"
- sideOffset={6}
- className="max-h-96 w-80 max-w-[calc(100vw-2rem)] overflow-auto p-0"
- >
+ <>
<div className="flex flex-col gap-1 p-2">
{tools.map((tool, index) => {
const callCount = toolCallCounts.get(tool.name) ?? 0;
@@ -170,7 +161,7 @@ function ToolGroupHoverContent({
);
})}
</div>
- </HoverCardContent>
+ </>
);
}
@@ -247,13 +238,24 @@ function ToolGroupSummary({
}
return (
- <HoverCard openDelay={200} closeDelay={100}>
- <HoverCardTrigger asChild>{summaryButton}</HoverCardTrigger>
- <ToolGroupHoverContent
- tools={tools}
- toolCallCounts={toolCallCounts}
- toolNameToDefinitionNumber={toolNameToDefinitionNumber}
- />
+ <HoverCard
+ openDelay={200}
+ closeDelay={100}
+ placement="bottom-start"
+ sideOffset={6}
+ content={
+ <div className="max-h-96 w-80 max-w-[calc(100vw-2rem)] overflow-auto">
+ <ToolGroupHoverContent
+ tools={tools}
+ toolCallCounts={toolCallCounts}
+ toolNameToDefinitionNumber={toolNameToDefinitionNumber}
+ />
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <div {...getTriggerProps()}>{summaryButton}</div>
+ )}
</HoverCard>
);
}
@@ -285,26 +287,30 @@ function ToolCallStatusBadge({
}
return (
- <HoverCard openDelay={200} closeDelay={100}>
- <HoverCardTrigger asChild>
- <div className="inline-flex">{badge}</div>
- </HoverCardTrigger>
- <HoverCardContent
- side="bottom"
- align="end"
- sideOffset={6}
- className="max-h-96 w-96 max-w-[calc(100vw-2rem)] overflow-auto p-0"
- >
- <div className="border-border border-b px-3 py-2">
- <div className="text-foreground text-xs font-bold">
- Tool call arguments
- </div>
- <div className="text-muted-foreground text-xs">
- {toolCalls.length === 1 ? "1 call" : `${toolCalls.length} calls`}
+ <HoverCard
+ openDelay={200}
+ closeDelay={100}
+ placement="bottom-end"
+ sideOffset={6}
+ content={
+ <div className="max-h-96 w-96 max-w-[calc(100vw-2rem)] overflow-auto">
+ <div className="border-border border-b px-3 py-2">
+ <div className="text-foreground text-xs font-bold">
+ Tool call arguments
+ </div>
+ <div className="text-muted-foreground text-xs">
+ {toolCalls.length === 1 ? "1 call" : `${toolCalls.length} calls`}
+ </div>
</div>
+ <ToolCallArgumentsList toolCalls={toolCalls} className="p-3" />
</div>
- <ToolCallArgumentsList toolCalls={toolCalls} className="p-3" />
- </HoverCardContent>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <div className="inline-flex" tabIndex={0} {...getTriggerProps()}>
+ {badge}
+ </div>
+ )}
</HoverCard>
);
}
diff --git a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
index 323244e06a..d50b52224e 100644
--- a/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
+++ b/web/src/features/traces/components/ObservationDetailView/ConnectedObservationDetailView.tsx
@@ -21,11 +21,7 @@
import { type ObservationReturnTypeWithMetadata } from "@/src/server/api/routers/traces";
import { useCallback, useMemo, useState } from "react";
import { Switch } from "@/src/components/design-system/Switch/Switch";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { Tabs } from "@/src/components/design-system/Tabs/Tabs";
import {
TabsBar,
@@ -457,9 +453,28 @@ export function ConnectedObservationDetailView({
label="Formatted"
/>
{selectedTab === "log" && isLogViewVirtualized ? (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <span>
+ <HoverCard
+ openDelay={200}
+ sideOffset={8}
+ placement="bottom-end"
+ content={
+ <div className="w-64 p-3 text-sm">
+ <p className="font-bold">
+ Raw view unavailable
+ </p>
+ <p className="text-muted-foreground mt-1">
+ Disabled for traces with{" "}
+ {
+ TRACE_VIEW_CONFIG.logView
+ .virtualizationThreshold
+ }
+ + observations to maintain performance.
+ </p>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span tabIndex={0} {...getTriggerProps()}>
<Tabs.Trigger
value="json"
size="sm"
@@ -467,24 +482,7 @@ export function ConnectedObservationDetailView({
label="Raw"
/>
</span>
- </HoverCardTrigger>
- <HoverCardContent
- align="end"
- className="w-64 text-sm"
- sideOffset={8}
- >
- <p className="font-bold">
- Raw view unavailable
- </p>
- <p className="text-muted-foreground mt-1">
- Disabled for traces with{" "}
- {
- TRACE_VIEW_CONFIG.logView
- .virtualizationThreshold
- }
- + observations to maintain performance.
- </p>
- </HoverCardContent>
+ )}
</HoverCard>
) : (
<Tabs.Trigger
diff --git a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
index a5ec7217c0..43afd44cb0 100644
--- a/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
+++ b/web/src/features/traces/components/TraceDetailView/TraceDetailView.tsx
@@ -27,11 +27,7 @@ import {
TooltipProvider,
TooltipTrigger,
} from "@/src/components/ui/tooltip";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
// Preview tab components
import { IOPreview } from "@/src/features/traces/components/IOPreview/IOPreview";
@@ -361,32 +357,36 @@ export function TraceDetailView({
label="Formatted"
/>
{selectedTab === "log" && isLogViewVirtualized ? (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <Tabs.Trigger
- value="json"
- size="sm"
- disabled
- label="Raw"
- />
- </HoverCardTrigger>
- <HoverCardContent
- align="end"
- className="w-64 text-sm"
- sideOffset={8}
- >
- <p className="font-bold">
- Raw view unavailable
- </p>
- <p className="text-muted-foreground mt-1">
- Disabled for traces with{" "}
- {
- TRACE_VIEW_CONFIG.logView
- .virtualizationThreshold
- }
- + observations to maintain performance.
- </p>
- </HoverCardContent>
+ <HoverCard
+ openDelay={200}
+ sideOffset={8}
+ placement="bottom-end"
+ content={
+ <div className="w-64 p-3 text-sm">
+ <p className="font-bold">
+ Raw view unavailable
+ </p>
+ <p className="text-muted-foreground mt-1">
+ Disabled for traces with{" "}
+ {
+ TRACE_VIEW_CONFIG.logView
+ .virtualizationThreshold
+ }
+ + observations to maintain performance.
+ </p>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span tabIndex={0} {...getTriggerProps()}>
+ <Tabs.Trigger
+ value="json"
+ size="sm"
+ disabled
+ label="Raw"
+ />
+ </span>
+ )}
</HoverCard>
) : (
<Tabs.Trigger
diff --git a/web/src/features/traces/components/TraceLogView/LogViewToolbar.tsx b/web/src/features/traces/components/TraceLogView/LogViewToolbar.tsx
index 77ac688d34..0143036975 100644
--- a/web/src/features/traces/components/TraceLogView/LogViewToolbar.tsx
+++ b/web/src/features/traces/components/TraceLogView/LogViewToolbar.tsx
@@ -24,11 +24,7 @@ import {
TooltipContent,
TooltipTrigger,
} from "@/src/components/ui/tooltip";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { cn } from "@/src/utils/tailwind";
import { Spinner } from "@/src/components/design-system/Spinner/Spinner";
import { type JsonViewPreference } from "@/src/components/ui/jsonViewPreference";
@@ -105,28 +101,34 @@ export const LogViewToolbar = memo(function LogViewToolbar({
<div className="bg-background flex h-9 shrink-0 items-center gap-1.5 border-b px-2">
{/* Large Trace indicator - only shown for virtualized mode */}
{isVirtualized && (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <span className="cursor-help rounded bg-yellow-100 px-1.5 py-0.5 text-xs font-bold text-yellow-700 dark:bg-yellow-900 dark:text-yellow-300">
+ <HoverCard
+ openDelay={200}
+ placement="bottom-start"
+ sideOffset={8}
+ content={
+ <div className="w-72 p-3 text-sm">
+ <p className="font-bold">Optimized for performance</p>
+ <p className="text-muted-foreground mt-1.5">
+ This trace has {observationCount?.toLocaleString() ?? "many"}{" "}
+ observations. To keep things smooth:
+ </p>
+ <ul className="text-muted-foreground mt-1.5 list-inside list-disc space-y-0.5">
+ <li>Content loads as you scroll</li>
+ <li>JSON view is disabled</li>
+ <li>Download/copy includes I/O for cached observations only</li>
+ </ul>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="cursor-help rounded bg-yellow-100 px-1.5 py-0.5 text-xs font-bold text-yellow-700 dark:bg-yellow-900 dark:text-yellow-300"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
Large Trace
</span>
- </HoverCardTrigger>
- <HoverCardContent
- align="start"
- className="w-72 text-sm"
- sideOffset={8}
- >
- <p className="font-bold">Optimized for performance</p>
- <p className="text-muted-foreground mt-1.5">
- This trace has {observationCount?.toLocaleString() ?? "many"}{" "}
- observations. To keep things smooth:
- </p>
- <ul className="text-muted-foreground mt-1.5 list-inside list-disc space-y-0.5">
- <li>Content loads as you scroll</li>
- <li>JSON view is disabled</li>
- <li>Download/copy includes I/O for cached observations only</li>
- </ul>
- </HoverCardContent>
+ )}
</HoverCard>
)}
@@ -150,36 +152,45 @@ export const LogViewToolbar = memo(function LogViewToolbar({
<div className="flex items-center gap-0.5">
{/* Indent Toggle - only in table view (pretty or json-beta) */}
{currentView !== "json" && onToggleIndent && (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <Button
- variant={indentEnabled ? "default" : "ghost"}
- size="icon"
- className={cn(
- "h-7 w-7",
- indentEnabled && "bg-primary text-primary-foreground",
- indentDisabled && "cursor-not-allowed opacity-50",
- )}
- onClick={indentDisabled ? undefined : onToggleIndent}
- disabled={indentDisabled}
- title={
- indentDisabled
- ? undefined
- : indentEnabled
- ? "Hide indentation"
- : "Show indentation"
- }
- >
- <IndentIncrease className="icon-base" />
- </Button>
- </HoverCardTrigger>
- {indentDisabled && (
- <HoverCardContent className="w-56 text-sm" sideOffset={8}>
+ <HoverCard
+ openDelay={200}
+ enabled={indentDisabled}
+ sideOffset={8}
+ content={
+ <div className="w-56 p-3 text-sm">
<p className="font-bold">Indentation unavailable</p>
<p className="text-muted-foreground mt-1">
Disabled for deeply nested trees to maintain readability.
</p>
- </HoverCardContent>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ tabIndex={indentDisabled ? 0 : undefined}
+ {...getTriggerProps()}
+ >
+ <Button
+ variant={indentEnabled ? "default" : "ghost"}
+ size="icon"
+ className={cn(
+ "h-7 w-7",
+ indentEnabled && "bg-primary text-primary-foreground",
+ indentDisabled && "cursor-not-allowed opacity-50",
+ )}
+ onClick={indentDisabled ? undefined : onToggleIndent}
+ disabled={indentDisabled}
+ title={
+ indentDisabled
+ ? undefined
+ : indentEnabled
+ ? "Hide indentation"
+ : "Show indentation"
+ }
+ >
+ <IndentIncrease className="icon-base" />
+ </Button>
+ </span>
)}
</HoverCard>
)}
@@ -235,17 +246,41 @@ export const LogViewToolbar = memo(function LogViewToolbar({
{/* Copy JSON */}
{onCopyJson && (
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
+ <HoverCard
+ openDelay={200}
+ enabled={isCopyOrDownloadCacheOnly && !isCopyOrDownloadLoading}
+ sideOffset={8}
+ content={
+ <div className="w-64 p-3 text-sm">
+ <p className="font-bold">Cache-only mode</p>
+ <p className="text-muted-foreground mt-1">
+ For large traces, only expanded observations include full I/O
+ data.
+ </p>
+ {loadedObservationCount !== undefined &&
+ observationCount !== undefined && (
+ <p className="text-muted-foreground mt-1.5">
+ <span className="font-bold">
+ {loadedObservationCount} of {observationCount}
+ </span>{" "}
+ observations loaded
+ </p>
+ )}
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="h-7 w-7"
- onClick={
- isCopyOrDownloadLoading ? undefined : handleCopyClick
- }
+ {...getTriggerProps({
+ onClick: isCopyOrDownloadLoading
+ ? undefined
+ : handleCopyClick,
+ })}
disabled={isCopyOrDownloadLoading}
>
{isCopyOrDownloadLoading ? (
@@ -265,24 +300,6 @@ export const LogViewToolbar = memo(function LogViewToolbar({
: "Copy as JSON"}
</TooltipContent>
</Tooltip>
- </HoverCardTrigger>
- {isCopyOrDownloadCacheOnly && !isCopyOrDownloadLoading && (
- <HoverCardContent className="w-64 text-sm" sideOffset={8}>
- <p className="font-bold">Cache-only mode</p>
- <p className="text-muted-foreground mt-1">
- For large traces, only expanded observations include full I/O
- data.
- </p>
- {loadedObservationCount !== undefined &&
- observationCount !== undefined && (
- <p className="text-muted-foreground mt-1.5">
- <span className="font-bold">
- {loadedObservationCount} of {observationCount}
- </span>{" "}
- observations loaded
- </p>
- )}
- </HoverCardContent>
)}
</HoverCard>
)}
diff --git a/web/src/features/v4-migration/V4MigrationContent.tsx b/web/src/features/v4-migration/V4MigrationContent.tsx
index e7dd9dcc2c..6409ee09c9 100644
--- a/web/src/features/v4-migration/V4MigrationContent.tsx
+++ b/web/src/features/v4-migration/V4MigrationContent.tsx
@@ -16,12 +16,7 @@ import { useIsInAppAgentLauncherVisible } from "@/src/features/in-app-agent";
import { useLangfuseCloudRegion } from "@/src/features/organizations";
import { useSupportDrawer } from "@/src/features/support-chat";
import { Button } from "@/src/components/ui/button";
-import {
- HoverCard,
- HoverCardContent,
- HoverCardPortal,
- HoverCardTrigger,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { RainbowButton } from "@/src/components/magicui/rainbow-button";
import { Separator } from "@/src/components/ui/separator";
import {
@@ -1456,16 +1451,24 @@ export function V4MigrationAgentUpgradeSection({
(missingApiKeyAccess ? (
// Disabled buttons swallow pointer events, so the hover
// reason needs a span trigger, same pattern as ActionButton.
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <span className="shrink-0">{createKeysButton}</span>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent className="w-80 text-sm">
+ <HoverCard
+ openDelay={200}
+ content={
+ <div className="w-80 p-3 text-sm">
Only users with admin access can create project API
keys. Please contact your admins.
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <span
+ className="shrink-0"
+ tabIndex={0}
+ {...getTriggerProps()}
+ >
+ {createKeysButton}
+ </span>
+ )}
</HoverCard>
) : (
createKeysButton
@@ -1711,18 +1714,10 @@ export function V4MigrationDetailsContent({
<V4MigrationStatusDot variant="neutral" />
<span className="text-muted-foreground flex min-w-0 items-center gap-1.5 text-sm">
Compare traces while you upgrade
- <HoverCard openDelay={200}>
- <HoverCardTrigger asChild>
- <button
- type="button"
- aria-label="Why compare traces?"
- className="shrink-0"
- >
- <Info className="icon-base" />
- </button>
- </HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent className="w-80 text-sm">
+ <HoverCard
+ openDelay={200}
+ content={
+ <div className="w-80 p-3 text-sm">
The latest SDK no longer sets trace input and output;{" "}
<ExternalLink
href={OBSERVATIONS_DATA_MODEL_URL}
@@ -1734,8 +1729,19 @@ export function V4MigrationDetailsContent({
v4 infers them from observations
</ExternalLink>
.
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => (
+ <button
+ type="button"
+ aria-label="Why compare traces?"
+ className="shrink-0"
+ {...getTriggerProps()}
+ >
+ <Info className="icon-base" />
+ </button>
+ )}
</HoverCard>
</span>
<span className="flex-1" />
diff --git a/web/src/features/widgets/components/WidgetPropertySelectItem.tsx b/web/src/features/widgets/components/WidgetPropertySelectItem.tsx
index 8e711ab7a8..2c1c63ca24 100644
--- a/web/src/features/widgets/components/WidgetPropertySelectItem.tsx
+++ b/web/src/features/widgets/components/WidgetPropertySelectItem.tsx
@@ -1,10 +1,5 @@
/* eslint-disable @repo/no-style-props */
-import {
- HoverCard,
- HoverCardContent,
- HoverCardTrigger,
- HoverCardPortal,
-} from "@/src/components/ui/hover-card";
+import { HoverCard } from "@/src/components/design-system/HoverCard/HoverCard";
import { SelectItem } from "@/src/components/ui/select";
import * as React from "react";
@@ -24,10 +19,13 @@ export const PropertyHoverCard = ({
children,
}: PropertyHoverCardProps) => {
return (
- <HoverCard openDelay={0} closeDelay={0}>
- <HoverCardTrigger asChild>{children}</HoverCardTrigger>
- <HoverCardPortal>
- <HoverCardContent hideWhenDetached align="start" side="right">
+ <HoverCard
+ openDelay={0}
+ closeDelay={0}
+ hideWhenDetached
+ placement="right-start"
+ content={
+ <div className="w-64 p-3">
<div className="mb-1 text-sm font-bold">{label}</div>
{(unit || type) && (
<div className="mb-2 flex flex-wrap gap-2 text-xs">
@@ -44,8 +42,10 @@ export const PropertyHoverCard = ({
</div>
)}
{description && <p className="text-xs leading-snug">{description}</p>}
- </HoverCardContent>
- </HoverCardPortal>
+ </div>
+ }
+ >
+ {({ getTriggerProps }) => <div {...getTriggerProps()}>{children}</div>}
</HoverCard>
);
};