🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
feat(web): Add formatted json to the dataset item (#17932)
Trang Nguyenf48b031d55e6
diff --git a/web/src/features/datasets/DatasetItemPage.tsx b/web/src/features/datasets/DatasetItemPage.tsxindex fb55c77473..f432809438 100644--- a/web/src/features/datasets/DatasetItemPage.tsx+++ b/web/src/features/datasets/DatasetItemPage.tsx@@ -8,9 +8,12 @@ import { api } from "@/src/utils/api";import { useDatasetVersion } from "@/src/features/datasets/hooks/useDatasetVersion";import { toDatasetSchema } from "@/src/features/datasets/utils/datasetItemUtils";import { Switch } from "@/src/components/design-system/Switch/Switch";+import { Tabs } from "@/src/components/design-system/Tabs/Tabs";+import { type DatasetItemRenderMode } from "@/src/features/datasets/components/DatasetItemField";import { Label } from "@/src/components/ui/label";import { Button } from "@/src/components/ui/button";import useSessionStorage from "@/src/components/useSessionStorage";+import useLocalStorage from "@/src/components/useLocalStorage";import { History, PanelRightOpen } from "lucide-react";import { useState } from "react";import {@@ -48,6 +51,13 @@ function DatasetItemContent({);const [isVersionPanelOpen, setIsVersionPanelOpen] =useState(!!selectedVersion);+ const [storedRenderMode, setRenderMode] =+ useLocalStorage<DatasetItemRenderMode>(+ "datasetItemJsonViewPreference",+ "pretty",+ );+ const renderMode: DatasetItemRenderMode =+ storedRenderMode === "json" ? "json" : "pretty";const routeReady =Boolean(projectId) && Boolean(datasetId) && Boolean(itemId);@@ -124,7 +134,20 @@ function DatasetItemContent({)}{/* Version panel toggle button */}- <div className="bg-background sticky top-0 z-10 flex justify-end border-b p-2">+ <div className="bg-background sticky top-0 z-10 flex items-center justify-end gap-2 border-b p-2">+ {!isViewingOldVersion && (+ <Tabs+ value={renderMode}+ onValueChange={(value) =>+ setRenderMode(value === "json" ? "json" : "pretty")+ }+ >+ <Tabs.List size="sm">+ <Tabs.Trigger value="pretty" size="sm" label="Formatted" />+ <Tabs.Trigger value="json" size="sm" label="Raw" />+ </Tabs.List>+ </Tabs>+ )}<Buttonvariant="ghost"size="sm"@@ -192,6 +215,7 @@ function DatasetItemContent({item={item.data ?? null}isLoading={item.isLoading}dataset={toDatasetSchema(dataset.data ?? null)}+ renderMode={renderMode}/>)}</div>diff --git a/web/src/features/datasets/components/DatasetItemField.tsx b/web/src/features/datasets/components/DatasetItemField.tsxindex 51944403e8..93f12a855b 100644--- a/web/src/features/datasets/components/DatasetItemField.tsx+++ b/web/src/features/datasets/components/DatasetItemField.tsx@@ -2,6 +2,9 @@ import { useCallback, useMemo, useRef } from "react";import { type ReactCodeMirrorRef } from "@uiw/react-codemirror";import { CodeMirrorEditor } from "@/src/components/editor";+import { PrettyJsonView } from "@/src/components/ui/PrettyJsonView";+import { MarkdownJsonViewHeader } from "@/src/components/ui/MarkdownJsonView";+import { copyTextToClipboard } from "@/src/utils/clipboard";import { useMediaTagChips } from "@/src/components/editor/mediaTagWidget";import { DatasetSchemaHoverCard } from "./DatasetSchemaHoverCard";import { DatasetItemFieldSchemaErrors } from "./DatasetItemFieldSchemaErrors";@@ -28,12 +31,15 @@ type DatasetError = {}>;};+export type DatasetItemRenderMode = "pretty" | "json";+type DatasetItemFieldProps = {label: string;value: string;schema?: Prisma.JsonValue | null;schemaType?: "input" | "expectedOutput";editable: boolean;+ renderMode?: DatasetItemRenderMode;onChange?: (value: string) => void;errors?: DatasetError[];hasSchemas?: boolean;@@ -55,6 +61,7 @@ export const DatasetItemField = ({schema,schemaType,editable,+ renderMode = "json",onChange,errors = [],hasSchemas = false,@@ -64,6 +71,25 @@ export const DatasetItemField = ({}: DatasetItemFieldProps) => {const editorRef = useRef<ReactCodeMirrorRef>(null);const showMediaUpload = isFormField && editable && !!onUploadMedia;+ const showPrettyView = !isFormField && !editable && renderMode === "pretty";+ // Objects and arrays go to the JSON table; scalars and empty values render+ // as one framed mono line so all three fields share the same frame.+ const pretty = useMemo<{ json: unknown; scalar: string | null }>(() => {+ if (!showPrettyView) return { json: value, scalar: null };+ if (value.trim() === "") return { json: null, scalar: "" };+ try {+ const parsed: unknown = JSON.parse(value);+ if (typeof parsed === "object" && parsed !== null) {+ return { json: parsed, scalar: null };+ }+ return { json: parsed, scalar: String(parsed) };+ } catch {+ return { json: value, scalar: value };+ }+ }, [showPrettyView, value]);+ const schemaHoverCard = schema && schemaType && (+ <DatasetSchemaHoverCard schema={schema} schemaType={schemaType} showLabel />+ );const handleSelectFile = async (file: File) => {const referenceString = await onUploadMedia?.(file);@@ -107,25 +133,17 @@ export const DatasetItemField = ({const content = (<>- <div className="flex items-center gap-2">- {isFormField ? (+ {isFormField && (+ <div className="flex items-center gap-2"><FormLabel>{label}</FormLabel>- ) : (- <label className="text-sm font-bold">{label}</label>- )}- {schema && schemaType && (- <DatasetSchemaHoverCard- schema={schema}- schemaType={schemaType}- showLabel+ {schemaHoverCard}+ <DatasetItemFieldToolbar+ copyValue={value}+ onSelectFile={showMediaUpload ? handleSelectFile : undefined}/>- )}- <DatasetItemFieldToolbar- copyValue={value}- onSelectFile={showMediaUpload ? handleSelectFile : undefined}- />- </div>- {isFormField ? (+ </div>+ )}+ {isFormField && (<FormControl><CodeMirrorEditormode="json"@@ -137,7 +155,32 @@ export const DatasetItemField = ({extensions={editorExtensions}/></FormControl>- ) : (+ )}+ {!isFormField && (+ <MarkdownJsonViewHeader+ title={label}+ handleOnCopy={() => copyTextToClipboard(value)}+ controlButtons={schemaHoverCard}+ hoverRevealControls+ />+ )}+ {!isFormField && showPrettyView && pretty.scalar === null && (+ <PrettyJsonView+ json={pretty.json}+ currentView="pretty"+ className="w-full"+ />+ )}+ {!isFormField && showPrettyView && pretty.scalar !== null && (+ <div className="rounded-sm border py-1 pr-2 pl-4 font-mono text-xs/5 wrap-break-word whitespace-pre-wrap">+ {pretty.scalar === "" ? (+ <span className="text-muted-foreground">empty</span>+ ) : (+ pretty.scalar+ )}+ </div>+ )}+ {!isFormField && !showPrettyView && (<CodeMirrorEditormode="json"value={value}@@ -157,6 +200,6 @@ export const DatasetItemField = ({return isFormField ? (<FormItem>{content}</FormItem>) : (- <div className="space-y-2">{content}</div>+ <div className="group/iosection">{content}</div>);};diff --git a/web/src/features/datasets/components/DatasetItemFields.tsx b/web/src/features/datasets/components/DatasetItemFields.tsxindex db23f01b68..dfb36290d6 100644--- a/web/src/features/datasets/components/DatasetItemFields.tsx+++ b/web/src/features/datasets/components/DatasetItemFields.tsx@@ -1,6 +1,9 @@/* eslint-disable no-nested-ternary */import { useMemo } from "react";-import { DatasetItemField } from "./DatasetItemField";+import {+ DatasetItemField,+ type DatasetItemRenderMode,+} from "./DatasetItemField";import {DatasetItemFormMediaAttachments,DatasetItemSavedMediaAttachments,@@ -27,6 +30,7 @@ type DatasetItemFieldsProps = {values?: DatasetItemFormValues;dataset: DatasetSchema | null;editable: boolean;+ renderMode?: DatasetItemRenderMode;projectId: string;// Present in view mode; selects the saved (table-backed) attachment section.datasetItemId?: string;@@ -60,6 +64,7 @@ export const DatasetItemFields = ({values,dataset,editable,+ renderMode,projectId,datasetItemId,datasetItemValidFrom,@@ -135,6 +140,7 @@ export const DatasetItemFields = ({schema={dataset?.inputSchema}schemaType="input"editable={false}+ renderMode={renderMode}errors={inputErrors}hasSchemas={validation.hasSchemas}/>@@ -175,6 +181,7 @@ export const DatasetItemFields = ({schema={dataset?.expectedOutputSchema}schemaType="expectedOutput"editable={false}+ renderMode={renderMode}errors={expectedOutputErrors}hasSchemas={validation.hasSchemas}/>@@ -209,6 +216,7 @@ export const DatasetItemFields = ({label="Metadata"value={metadataValue}editable={false}+ renderMode={renderMode}/>)}diff --git a/web/src/features/datasets/components/DatasetItemViewModeContent.tsx b/web/src/features/datasets/components/DatasetItemViewModeContent.tsxindex 2823e657de..d4fb9be0d4 100644--- a/web/src/features/datasets/components/DatasetItemViewModeContent.tsx+++ b/web/src/features/datasets/components/DatasetItemViewModeContent.tsx@@ -4,11 +4,13 @@ import {type DatasetSchema,} from "../utils/datasetItemUtils";import { DatasetItemFields } from "@/src/features/datasets/components/DatasetItemFields";+import { type DatasetItemRenderMode } from "@/src/features/datasets/components/DatasetItemField";type DatasetItemViewModeContentProps = {item: DatasetItemDomain | null;isLoading: boolean;dataset: DatasetSchema | null;+ renderMode: DatasetItemRenderMode;};/**@@ -19,6 +21,7 @@ export const DatasetItemViewModeContent = ({item,isLoading,dataset,+ renderMode,}: DatasetItemViewModeContentProps) => {if (isLoading) {return <div className="text-muted-foreground text-sm">Loading...</div>;@@ -46,6 +49,7 @@ export const DatasetItemViewModeContent = ({}}dataset={dataset}editable={false}+ renderMode={renderMode}projectId={item.projectId}datasetItemId={item.id}/>