🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.
TypeScript analyticsautogenevaluationlangchainlarge-language-modelsllama-indexllmllm-evaluationllm-observabilityllmopsmonitoringobservabilityopen-sourceopenaiplaygroundprompt-engineeringprompt-managementself-hostedycombinator
fix(web): match versioned PostHog recorder paths in Sentry filter (#17702)
cursor[bot]f4ff9fcaa73b
diff --git a/web/src/utils/sentryFilters.clienttest.ts b/web/src/utils/sentryFilters.clienttest.tsindex a5ad4f658a..7e21fab594 100644--- a/web/src/utils/sentryFilters.clienttest.ts+++ b/web/src/utils/sentryFilters.clienttest.ts@@ -1859,6 +1859,67 @@ describe("isPosthogRecorderInternalEvent", () => {expect(isPosthogRecorderInternalEvent(event)).toBe(true);});+ it("drops the path-versioned recorder script (LANGFUSE-621 setTimeout wrap)", () => {+ const recorder = "app:///static/1.417.1/posthog-recorder.js";+ const event = {+ exception: {+ values: [+ {+ type: "TypeError",+ value: 'string "" is not a function',+ mechanism: {+ type: "auto.browser.browserapierrors.setTimeout",+ handled: false,+ },+ stacktrace: {+ frames: [+ frame(+ "node_modules/.pnpm/@[email protected]/node_modules/@sentry/browser/src/helpers.ts",+ "r",+ ),+ frame(recorder),+ frame(recorder, "Object.Ec"),+ ],+ },+ },+ ],+ },+ } as ErrorEvent;+ expect(isPosthogRecorderInternalEvent(event)).toBe(true);+ });++ it("drops the path-versioned addEventListener wrap (LANGFUSE-620)", () => {+ const recorder = "app:///static/1.417.1/posthog-recorder.js";+ const event = {+ exception: {+ values: [+ {+ type: "TypeError",+ value: 'string "" is not a function',+ mechanism: {+ type: "auto.browser.browserapierrors.addEventListener",+ handled: false,+ },+ stacktrace: {+ frames: [+ frame(+ "node_modules/.pnpm/@[email protected]/node_modules/@sentry/browser/src/helpers.ts",+ "r",+ ),+ frame(recorder, "l"),+ frame(recorder, "callback"),+ frame(recorder, "fr"),+ frame(recorder, "emit"),+ frame(recorder, "Object.onRRwebEmit"),+ ],+ },+ },+ ],+ },+ } as ErrorEvent;+ expect(isPosthogRecorderInternalEvent(event)).toBe(true);+ });+it("drops the addEventListener-wrapped variant with a source-mapped Sentry SDK frame (LANGFUSE-5VY stored shape)", () => {const event = {exception: {@@ -1956,6 +2017,25 @@ describe("isPosthogRecorderInternalEvent", () => {expect(isPosthogRecorderInternalEvent(event)).toBe(false);});+ it("keeps the empty-string TypeError when it is thrown from an app chunk", () => {+ const event = {+ exception: {+ values: [+ {+ type: "TypeError",+ value: 'string "" is not a function',+ stacktrace: {+ frames: [+ frame("app:///_next/static/chunks/0r47ep231kqhy.js", "fn"),+ ],+ },+ },+ ],+ },+ } as ErrorEvent;+ expect(isPosthogRecorderInternalEvent(event)).toBe(false);+ });+it("keeps an all-opaque stack (<anonymous>/[native code] only — no recorder attribution)", () => {const event = {exception: {diff --git a/web/src/utils/sentryFilters.ts b/web/src/utils/sentryFilters.tsindex 0bf3b29571..bbea3dee0d 100644--- a/web/src/utils/sentryFilters.ts+++ b/web/src/utils/sentryFilters.ts@@ -741,10 +741,16 @@ export function isStaleChunkParseErrorEvent(event: ErrorEvent): boolean {}/**- * PostHog's lazily-loaded session-replay recorder script (served as- * `/static/posthog-recorder.js?v=<posthog-js version>`).+ * PostHog's lazily-loaded session-replay recorder script. Older posthog-js+ * served `/static/posthog-recorder.js?v=<version>`; 1.417+ serves+ * `/static/<version>/posthog-recorder.js`. Match the filename as a path+ * segment so both layouts (and a query string) count.*/-const POSTHOG_RECORDER_SCRIPT_SUFFIX = "/static/posthog-recorder.js";+function isPosthogRecorderFilename(path: string): boolean {+ return (+ path === "posthog-recorder.js" || path.endsWith("/posthog-recorder.js")+ );+}/*** Frames that carry no attribution: browser-native/eval frames, and the Sentry@@ -767,8 +773,11 @@ function isOpaqueOrSdkFrame(filename: string): boolean {* every attributable stack frame lives in the recorder script (plus at most* browser-native and Sentry-SDK wrapper frames). rrweb's DOM serialization* throws on exotic page content (observed: `SyntaxError: Invalid or unexpected- * token` from `processMutations` / `onRRwebEmit`, LANGFUSE-5VY/5VX), and each- * throw site mints a new fingerprint per recorder version.+ * token` from `processMutations` / `onRRwebEmit`, LANGFUSE-5VY/5VX; later+ * `TypeError: string "" is not a function` from `onRRwebEmit` under the+ * path-versioned script, LANGFUSE-621/620), and each throw site mints a new+ * fingerprint per recorder version. The recorder filename may sit at+ * `/static/posthog-recorder.js` or `/static/<version>/posthog-recorder.js`.** Safe to drop: an error thrown by OUR code always carries at least one app* chunk frame (the throwing frame), which fails this check. Errors with no@@ -794,11 +803,9 @@ export function isPosthogRecorderInternalEvent(event: ErrorEvent): boolean {const filename = frame?.filename;// A frame with no filename has no attribution — treat like <anonymous>.if (typeof filename !== "string" || filename.length === 0) continue;- // The recorder loads with a version query (`?v=<posthog-js version>`) that- // survives into wire-format frame filenames — strip query/fragment before- // matching the path suffix.+ // Strip query/fragment (older `?v=` layout) before matching the filename.const path = filename.split(/[?#]/)[0];- if (path.endsWith(POSTHOG_RECORDER_SCRIPT_SUFFIX)) {+ if (isPosthogRecorderFilename(path)) {sawRecorderFrame = true;continue;}