Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(filters): let viewer-role users use Ask AI (LFE-14412) (#16042)

Nikita Kabardinf8156e2a8a00
diff --git a/web/src/__tests__/server/ai-filter-access.servertest.ts b/web/src/__tests__/server/ai-filter-access.servertest.ts
new file mode 100644
index 0000000000..38efce264e
--- /dev/null
+++ b/web/src/__tests__/server/ai-filter-access.servertest.ts
@@ -0,0 +1,122 @@
+import { appRouter } from "@/src/server/api/root";
+import { createInnerTRPCContext } from "@/src/server/api/trpc";
+import { prisma, type Role } from "@langfuse/shared/src/db";
+import { createOrgProjectAndApiKey } from "@langfuse/shared/src/server";
+import type { Session } from "next-auth";
+
+// Both Ask AI endpoints only generate a filter over data the caller can
+// already read, so they are gated on `project:read` — a VIEWER must get in.
+const NO_ACCESS = "User does not have access to this resource or action";
+
+const __orgIds: string[] = [];
+
+async function prepare(projectRole: Role) {
+ const { project, org } = await createOrgProjectAndApiKey();
+ __orgIds.push(org.id);
+
+ const session: Session = {
+ expires: "1",
+ user: {
+ id: "user-1",
+ canCreateOrganizations: false,
+ name: "Demo User",
+ admin: false,
+ organizations: [
+ {
+ id: org.id,
+ name: org.name,
+ role: "MEMBER",
+ plan: "cloud:hobby",
+ cloudConfig: undefined,
+ metadata: {},
+ aiFeaturesEnabled: false,
+ aiTelemetryEnabled: false,
+ projects: [
+ {
+ id: project.id,
+ role: projectRole,
+ retentionDays: 30,
+ deletedAt: null,
+ hasTraces: false,
+ name: project.name,
+ metadata: {},
+ createdAt: new Date().toISOString(),
+ },
+ ],
+ },
+ ],
+ featureFlags: {
+ excludeClickhouseRead: false,
+ templateFlag: false,
+ searchBar: true,
+ v4BetaToggleVisible: false,
+ observationEvals: false,
+ experimentsV4Enabled: false,
+ },
+ },
+ environment: {
+ enableExperimentalFeatures: false,
+ selfHostedInstancePlan: "cloud:hobby",
+ },
+ };
+
+ const ctx = createInnerTRPCContext({ session, headers: {} });
+ return { project, caller: appRouter.createCaller({ ...ctx, prisma }) };
+}
+
+/** Message of a rejection, or "" when the call resolved. */
+const failureMessage = (promise: Promise<unknown>) =>
+ promise.then(
+ () => "",
+ (error: unknown) =>
+ error instanceof Error ? error.message : String(error),
+ );
+
+describe("Ask AI filter generation access", () => {
+ afterAll(async () => {
+ await prisma.organization.deleteMany({ where: { id: { in: __orgIds } } });
+ });
+
+ // The org's `aiFeaturesEnabled` is off, so both calls still fail on the
+ // org-level AI gate (or the self-hosted precondition) right after the RBAC
+ // check — no LLM is reached. Only the RBAC verdict is asserted here.
+ it("lets a VIEWER through the RBAC gate on both endpoints", async () => {
+ const { project, caller } = await prepare("VIEWER");
+
+ expect(
+ await failureMessage(
+ caller.naturalLanguageFilters.createCompletion({
+ projectId: project.id,
+ prompt: "traces from today",
+ }),
+ ),
+ ).not.toContain(NO_ACCESS);
+
+ expect(
+ await failureMessage(
+ caller.searchBar.generateFilter({
+ projectId: project.id,
+ prompt: "traces from today",
+ }),
+ ),
+ ).not.toContain(NO_ACCESS);
+ });
+
+ it("rejects a project role without project:read on both endpoints", async () => {
+ const { project, caller } = await prepare("NONE");
+
+ await expect(
+ caller.naturalLanguageFilters.createCompletion({
+ projectId: project.id,
+ prompt: "traces from today",
+ }),
+ ).rejects.toThrow(NO_ACCESS);
+
+ await expect(
+ caller.searchBar.generateFilter({
+ projectId: project.id,
+ prompt: "traces from today",
+ }),
+ ).rejects.toThrow(NO_ACCESS);
+ });
+});
diff --git a/web/src/features/natural-language-filters/server/router.ts b/web/src/features/natural-language-filters/server/router.ts
index ed5ea0925f..29dfc1e3fd 100644
--- a/web/src/features/natural-language-filters/server/router.ts
+++ b/web/src/features/natural-language-filters/server/router.ts
@@ -23,10 +23,13 @@ export const naturalLanguageFilterRouter = createTRPCRouter({
.input(CreateNaturalLanguageFilterCompletion)
.mutation(async ({ input, ctx }) => {
try {
+ // Generating a filter reads nothing a project member cannot already
+ // read by hand, so membership is the right bar; whether the org uses
+ // AI at all is governed by `aiFeaturesEnabled` below.
throwIfNoProjectAccess({
session: ctx.session,
projectId: input.projectId,
- scope: "prompts:CUD",
+ scope: "project:read",
});
if (!env.NEXT_PUBLIC_LANGFUSE_CLOUD_REGION) {
diff --git a/web/src/features/search-bar/server/router.ts b/web/src/features/search-bar/server/router.ts
index 2ae7c02e31..2401bb4578 100644
--- a/web/src/features/search-bar/server/router.ts
+++ b/web/src/features/search-bar/server/router.ts
@@ -80,10 +80,13 @@ export const searchBarRouter = createTRPCRouter({
.input(GenerateFilterInput)
.mutation(async ({ input, ctx }) => {
try {
+ // Generating a filter reads nothing a project member cannot already
+ // read by hand, so membership is the right bar; whether the org uses
+ // AI at all is governed by `aiFeaturesEnabled` below.
throwIfNoProjectAccess({
session: ctx.session,
projectId: input.projectId,
- scope: "prompts:CUD",
+ scope: "project:read",
});
if (!env.NEXT_PUBLIC_LANGFUSE_CLOUD_REGION) {