Skip to content

🪢 Open source agent evals & observability: Trace, evaluate, and improve LLM applications with one open platform.

fix(clickhouse): materialize legacy scores columns in migration 0050 (#19443)

Steffen Reutherff8a520a1a5b
diff --git a/packages/shared/clickhouse/migrations/canonical/0050_scores_trace_index_granularity.up.sql b/packages/shared/clickhouse/migrations/canonical/0050_scores_trace_index_granularity.up.sql
index afc5597cc7..5c49ecef4f 100644
--- a/packages/shared/clickhouse/migrations/canonical/0050_scores_trace_index_granularity.up.sql
+++ b/packages/shared/clickhouse/migrations/canonical/0050_scores_trace_index_granularity.up.sql
@@ -1,3 +1,6 @@
ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} ADD INDEX IF NOT EXISTS idx_project_trace_observation_v2 (project_id, trace_id, observation_id) TYPE bloom_filter(0.001) GRANULARITY 2{CLICKHOUSE_CLUSTERED_ONLY: SETTINGS alter_sync = 2;}{CLICKHOUSE_UNCLUSTERED_ONLY: SETTINGS mutations_sync = 2; }
-ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} MATERIALIZE INDEX IF EXISTS idx_project_trace_observation_v2 SETTINGS mutations_sync = 2;
+-- Scores parts written by older ClickHouse versions can carry the session and dataset run skip indexes without the session_id and dataset_run_id columns on disk. ClickHouse 25.12 and 26.4 fail every mutation that rewrites such a Compact part, so the new index is materialized together with both columns, which writes them out. The temporary DEFAULT NULL is required by MATERIALIZE COLUMN and keeps values already on disk.
+ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} MODIFY COLUMN session_id Nullable(String) DEFAULT NULL, MODIFY COLUMN dataset_run_id Nullable(String) DEFAULT NULL SETTINGS mutations_sync = 2{CLICKHOUSE_CLUSTERED_ONLY:, alter_sync = 2};
+ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} MATERIALIZE COLUMN session_id, MATERIALIZE COLUMN dataset_run_id, MATERIALIZE INDEX idx_project_trace_observation_v2 SETTINGS mutations_sync = 2;
+ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} MODIFY COLUMN session_id REMOVE DEFAULT, MODIFY COLUMN dataset_run_id REMOVE DEFAULT SETTINGS mutations_sync = 2{CLICKHOUSE_CLUSTERED_ONLY:, alter_sync = 2};
ALTER TABLE scores {CLICKHOUSE_CLUSTER_CLAUSE} DROP INDEX IF EXISTS idx_project_trace_observation SETTINGS mutations_sync = 2;