Skip to content

AI agent skill that researches any topic across Reddit, X, YouTube, HN, Polymarket, and the web - then synthesizes a grounded summary

ci: enforce security workflow checks

Shaan Majidf03d8a184c45
diff --git a/.github/workflows/security.yml b/.github/workflows/security.yml
index d25bbb2a..024d9796 100644
--- a/.github/workflows/security.yml
+++ b/.github/workflows/security.yml
@@ -24,12 +24,8 @@ jobs:
- name: Install uv
uses: astral-sh/setup-uv@fac544c07dec837d0ccb6301d7b5580bf5edae39 # v8.2.0
- # Advisory-first: visibility before enforcement. This repo handles API keys,
- # cookies, browser tokens, and local env files, so dependency CVEs should be
- # visible in CI logs even before the project has a clean blocking baseline.
- # Set continue-on-error: false once a clean baseline run is confirmed.
+ # Block known vulnerabilities in the locked Python dependency graph.
- name: Run uv audit against locked dependencies
- continue-on-error: true
run: uv audit --locked
secret-scan:
@@ -44,18 +40,11 @@ jobs:
fetch-depth: 0
persist-credentials: false
- # Advisory-first: this reports verified secrets in pull requests and pushes to
- # main, but does not block merges until maintainers confirm a clean baseline.
- # The TruffleHog action automatically scans the PR range for pull_request
- # events and the pushed commit range for push events.
- # Set continue-on-error: false once a clean baseline run is confirmed.
- # Contributor policy: never commit real secrets in fixtures, tests, docs, or
- # examples; use obvious dummy values and env-based auth patterns instead.
+ # The action derives the commit range from the GitHub event and fails on
+ # verified secrets. Keep output limited to verified findings to avoid noisy
+ # unverified annotations.
- name: Run TruffleHog OSS secret scan
- if: github.event_name == 'pull_request' || github.event_name == 'push' || github.event_name == 'workflow_dispatch'
uses: trufflesecurity/trufflehog@17456f8c7d042d8c82c9a8ca9e937231f9f42e26 # v3.95.2
- continue-on-error: true
with:
- path: ./
- version: v3.95.2
- extra_args: --only-verified
+ version: 3.95.2
+ extra_args: --results=verified
diff --git a/tests/test_security_workflow.py b/tests/test_security_workflow.py
index 088548fb..08399ea8 100644
--- a/tests/test_security_workflow.py
+++ b/tests/test_security_workflow.py
@@ -16,32 +16,30 @@ def test_security_workflow_exists() -> None:
assert WORKFLOW.is_file()
-def test_security_workflow_runs_dependency_audit_advisory_first() -> None:
+def test_security_workflow_runs_dependency_audit_as_blocking_check() -> None:
text = _workflow_text()
+ dependency_audit_job = text.split("dependency-audit:", 1)[1].split("secret-scan:", 1)[0]
assert "dependency-audit:" in text
- assert "uv audit --locked" in text
- assert "continue-on-error: true" in text
- assert "Set continue-on-error: false once a clean baseline run is confirmed" in text
+ assert "uv audit --locked" in dependency_audit_job
+ assert "continue-on-error: true" not in dependency_audit_job
def test_security_workflow_runs_secret_scan_for_pull_requests_and_main_pushes() -> None:
text = _workflow_text()
+ secret_scan_job = text.split("secret-scan:", 1)[1]
assert "secret-scan:" in text
- assert "trufflesecurity/trufflehog" in text
- assert "github.event_name == 'pull_request'" in text
- assert "github.event_name == 'push'" in text
- assert "--only-verified" in text
-
-
-def test_security_workflow_documents_advisory_policy() -> None:
- text = _workflow_text()
-
- assert "advisory-first" in text.lower()
- assert "does not block merges" in text.lower()
- assert "fixtures" in text.lower()
- assert "env-based auth" in text.lower()
+ assert "pull_request:" in text
+ assert "push:" in text
+ assert "workflow_dispatch:" in text
+ assert "branches:\n - main" in text
+ assert "trufflesecurity/trufflehog" in secret_scan_job
+ assert "version: 3.95.2" in secret_scan_job
+ assert "extra_args: --results=verified" in secret_scan_job
+ assert "continue-on-error: true" not in secret_scan_job
+ assert "if: github.event_name" not in secret_scan_job
+ assert "path: ./" not in secret_scan_job
def test_agent_guidance_mentions_secret_hygiene() -> None: