Skip to content

armgit / laya

Public Imported from GitHub
0

Non-autoregressive System 1 decision engine. Typed choice, score and yes/no decisions over any text in a single forward pass, in 100+ languages, with a router that picks the right checkpoint per request.

fix(ts): the French branch of DISCLAIMER had lost 'exclusivement'

Nandakishor56e4e2cd1fd5
diff --git a/laya-ts/src/email.ts b/laya-ts/src/email.ts
index 701b1119..227c1b6c 100644
--- a/laya-ts/src/email.ts
+++ b/laya-ts/src/email.ts
@@ -161,7 +161,7 @@ const DISCLAIMER = new RegExp(
// sender's own request ("le contrat confidentiel") uses just as often
`${B_L}(ce|cet|cette) (message|e-?mail|mail|courriel)${B_R}[^.]{0,80}(confidentiel|privil[eé]gi)|` +
`${B_L}avez re[çc]u (ce|cet|cette) (message|e-?mail|mail)${B_R}[^.]{0,20} par erreur|` +
- `${B_L}(usage exclusif|exclusivamente|uniquement)${B_R}[^.]{0,30}destinataire)`,
+ `${B_L}(usage exclusif|exclusivement|uniquement)${B_R}[^.]{0,30}destinataire)`,
"iu",
);
const SENTENCE = new RegExp(`(?<=[.!?])${SP}+`, "u");
diff --git a/laya-ts/tests/email-parity.test.ts b/laya-ts/tests/email-parity.test.ts
index eae01d4b..10d3927a 100644
--- a/laya-ts/tests/email-parity.test.ts
+++ b/laya-ts/tests/email-parity.test.ts
@@ -99,3 +99,43 @@ describe("Python's whitespace set, where JS's differs", () => {
);
});
});
+
+// Every alternative of the DISCLAIMER pattern, asked one at a time. The corpus above exercises the
+// pattern, not each branch of it, so the port's rewrite of `\b` into a lookaround pair could lose a
+// single word and still pass: `exclusivement` was typed as `exclusivamente`, which left a French
+// footer ("exclusivement destine au destinataire") in the state and already had a Spanish branch of
+// its own. Each answer below is what `laya/email.py::clean_email_body` printed for the same body.
+describe("every DISCLAIMER branch, one word at a time", () => {
+ const KEEP = "Merci de confirmer le remboursement.";
+ const FOOTERS: [string, string][] = [
+ ["en confidential/intended", "This e-mail is confidential and intended solely for the addressee."],
+ ["en confidential/privileged", "This message is confidential and may be privileged."],
+ ["en received in error", "If you received this e-mail in error, please delete it."],
+ ["pt mensagem confidencial", "Esta mensagem e confidencial e de uso restrito."],
+ ["pt uso exclusivo", "Destina-se ao uso exclusivo do destinatario indicado."],
+ ["pt exclusivamente", "Destina-se exclusivamente ao destinatario indicado."],
+ ["pt recebeu por engano", "Se recebeu esta mensagem por engano, apague-a."],
+ ["pt antes de imprimir", "Pense antes de imprimir: o meio ambiente agradece."],
+ ["pt meio ambiente", "O meio ambiente agradece: pense antes de imprimir."],
+ ["es mensaje confidencial", "Este mensaje es confidencial y de uso restringido."],
+ ["es unicamente", "Se dirige unicamente al destinatario indicado."],
+ ["es ha recibido por error", "Si ha recibido este mensaje por error, borrelo."],
+ ["fr ce message confidentiel", "Ce message est confidentiel et destine au seul destinataire."],
+ ["fr recu par erreur", "Si vous avez recu ce message par erreur, supprimez-le."],
+ ["fr usage exclusif", "Ce texte est a usage exclusif du destinataire indique."],
+ ["fr exclusivement", "Ce texte est exclusivement destine au destinataire indique."],
+ ["fr uniquement", "Ce texte est uniquement destine au destinataire indique."],
+ ];
+ it.each(FOOTERS)("%s is stripped, the request above it is kept", (_name, footer) => {
+ expect(cleanEmailBody(KEEP + "\n\n" + footer)).toBe(KEEP);
+ });
+
+ // The control the branch list needs: a sender's own sentence that carries one of the same words
+ // is not a disclaimer, so the paragraph stays whole.
+ it.each([
+ ["the contract is confidential", "Le contrat confidentiel est joint, merci de le relire."],
+ ["a question about confidentiality", "Is this channel confidential?"],
+ ])("%s is not a disclaimer", (_name, body) => {
+ expect(cleanEmailBody(body)).toBe(body);
+ });
+});