Skip to content

armgit / laya

Public Imported from GitHub
0

Non-autoregressive System 1 decision engine. Typed choice, score and yes/no decisions over any text in a single forward pass, in 100+ languages, with a router that picks the right checkpoint per request.

perf(shortlist): clip cosine similarities and guard empty document matrices in candidate ranking (#158)

Kartik Chilkotife6ce76cec89
diff --git a/laya/shortlist.py b/laya/shortlist.py
index 71a51bd5..d4606be5 100644
--- a/laya/shortlist.py
+++ b/laya/shortlist.py
@@ -246,14 +246,14 @@ def _embeddings(embed_fn, texts: Sequence[str]) -> np.ndarray:
def _cosine(query: np.ndarray, docs: np.ndarray) -> np.ndarray:
qn = float(np.linalg.norm(query))
+ if qn == 0.0 or docs.shape[0] == 0:
+ return np.zeros(docs.shape[0], dtype=np.float64)
dn = np.linalg.norm(docs, axis=1)
- sims = np.zeros(docs.shape[0], dtype=np.float64)
- if qn == 0.0:
- return sims
denom = dn * qn
ok = denom > 0.0
+ sims = np.zeros(docs.shape[0], dtype=np.float64)
if np.any(ok):
- sims[ok] = docs[ok] @ query / denom[ok]
+ sims[ok] = np.clip(np.dot(docs[ok], query) / denom[ok], -1.0, 1.0)
return sims
diff --git a/tests/test_shortlist_cosine.py b/tests/test_shortlist_cosine.py
new file mode 100644
index 00000000..34c3fb93
--- /dev/null
+++ b/tests/test_shortlist_cosine.py
@@ -0,0 +1,26 @@
+import unittest
+import numpy as np
+from laya.shortlist import _cosine
+
+class ShortlistCosineTests(unittest.TestCase):
+ def test_cosine_identical_vectors(self):
+ v = np.array([1.0, 2.0, 3.0], dtype=np.float64)
+ docs = np.array([[1.0, 2.0, 3.0], [-1.0, -2.0, -3.0]], dtype=np.float64)
+ sims = _cosine(v, docs)
+ self.assertAlmostEqual(sims[0], 1.0, places=5)
+ self.assertAlmostEqual(sims[1], -1.0, places=5)
+
+ def test_cosine_zero_vectors(self):
+ v = np.zeros(4, dtype=np.float64)
+ docs = np.ones((3, 4), dtype=np.float64)
+ sims = _cosine(v, docs)
+ self.assertTrue(np.all(sims == 0.0))
+
+ def test_cosine_empty_docs(self):
+ v = np.ones(4, dtype=np.float64)
+ docs = np.zeros((0, 4), dtype=np.float64)
+ sims = _cosine(v, docs)
+ self.assertEqual(len(sims), 0)
+
+if __name__ == "__main__":
+ unittest.main()