Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

feat: Move 404 catches earlier (#3257)

Matthew Zhou0a51ae80bc14
diff --git a/letta/server/rest_api/routers/v1/sources.py b/letta/server/rest_api/routers/v1/sources.py
index 48049d730..9daecbdc8 100644
--- a/letta/server/rest_api/routers/v1/sources.py
+++ b/letta/server/rest_api/routers/v1/sources.py
@@ -360,6 +360,13 @@ async def get_file_metadata(
file_id=file_id, actor=actor, include_content=include_content, strip_directory_prefix=True
)
+ if not file_metadata:
+ raise HTTPException(status_code=404, detail=f"File with id={file_id} not found.")
+
+ # Verify the file belongs to the specified source
+ if file_metadata.source_id != source_id:
+ raise HTTPException(status_code=404, detail=f"File with id={file_id} not found in source {source_id}.")
+
if should_use_pinecone() and not file_metadata.is_processing_terminal():
ids = await list_pinecone_index_for_files(file_id=file_id, actor=actor, limit=file_metadata.total_chunks)
logger.info(
@@ -375,13 +382,6 @@ async def get_file_metadata(
file_id=file_metadata.id, actor=actor, chunks_embedded=len(ids), processing_status=file_status
)
- if not file_metadata:
- raise HTTPException(status_code=404, detail=f"File with id={file_id} not found.")
-
- # Verify the file belongs to the specified source
- if file_metadata.source_id != source_id:
- raise HTTPException(status_code=404, detail=f"File with id={file_id} not found in source {source_id}.")
-
return file_metadata