Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.
fix: use new agent loop in hitl test (#5145)
Charles Packer10a301cc4bec
diff --git a/letta/agents/letta_agent_v3.py b/letta/agents/letta_agent_v3.pyindex a6beb6d1d..c511c7cd3 100644--- a/letta/agents/letta_agent_v3.py+++ b/letta/agents/letta_agent_v3.py@@ -669,6 +669,7 @@ class LettaAgentV3(LettaAgentV2):pre_computed_assistant_message_id=pre_computed_assistant_message_id,step_id=step_id,run_id=run_id,+ append_request_heartbeat=False,)messages_to_persist = (initial_messages or []) + [approval_message]continue_stepping = Falsediff --git a/letta/server/rest_api/utils.py b/letta/server/rest_api/utils.pyindex 726f7c0a4..c39af577b 100644--- a/letta/server/rest_api/utils.py+++ b/letta/server/rest_api/utils.py@@ -193,10 +193,12 @@ def create_approval_request_message_from_llm_response(pre_computed_assistant_message_id: Optional[str] = None,step_id: str | None = None,run_id: str = None,+ append_request_heartbeat: bool = True,) -> Message:# Construct the tool call with the assistant's message- # Force set request_heartbeat in tool_args to calculated continue_stepping- function_arguments[REQUEST_HEARTBEAT_PARAM] = continue_stepping+ # Optionally set request_heartbeat in tool args (v2 behavior only)+ if append_request_heartbeat:+ function_arguments[REQUEST_HEARTBEAT_PARAM] = continue_steppingtool_call = OpenAIToolCall(id=tool_call_id,function=OpenAIFunction(diff --git a/tests/integration_test_human_in_the_loop.py b/tests/integration_test_human_in_the_loop.pyindex e52aaff2f..7648badd3 100644--- a/tests/integration_test_human_in_the_loop.py+++ b/tests/integration_test_human_in_the_loop.py@@ -13,6 +13,7 @@ from letta_client.core.api_error import ApiErrorfrom letta.interfaces.anthropic_streaming_interface import AnthropicStreamingInterfacefrom letta.log import get_logger+from letta.schemas.enums import AgentTypelogger = get_logger(__name__)@@ -139,9 +140,10 @@ def agent(client: Letta, approval_tool_fixture) -> AgentState:send_message_tool = client.tools.list(name="send_message")[0]agent_state = client.agents.create(name="approval_test_agent",+ agent_type=AgentType.letta_v1_agent,include_base_tools=False,tool_ids=[send_message_tool.id, approval_tool_fixture.id],- model="anthropic/claude-3-5-sonnet",+ model="anthropic/claude-sonnet-4-20250514",embedding="openai/text-embedding-3-small",tags=["approval_test"],)@@ -207,12 +209,17 @@ def test_send_message_with_requires_approval_tool(messages = accumulate_chunks(response)assert messages is not None- assert len(messages) == 4+ assert len(messages) == 5assert messages[0].message_type == "reasoning_message"- assert messages[1].message_type == "approval_request_message"- assert messages[2].message_type == "stop_reason"- assert messages[2].stop_reason == "requires_approval"- assert messages[3].message_type == "usage_statistics"+ assert messages[1].message_type == "assistant_message"+ assert messages[2].message_type == "approval_request_message"+ # v3/v1 path: approval request tool args must not include request_heartbeat+ import json as _json++ _args = _json.loads(messages[2].tool_call.arguments)+ assert "request_heartbeat" not in _args+ assert messages[3].message_type == "stop_reason"+ assert messages[4].message_type == "usage_statistics"def test_send_message_after_turning_off_requires_approval(@@ -247,13 +254,14 @@ def test_send_message_after_turning_off_requires_approval(messages = accumulate_chunks(response)assert messages is not None- assert len(messages) == 5 or len(messages) == 7+ assert len(messages) == 6 or len(messages) == 8assert messages[0].message_type == "reasoning_message"- assert messages[1].message_type == "tool_call_message"- assert messages[2].message_type == "tool_return_message"- if len(messages) > 5:- assert messages[3].message_type == "reasoning_message"- assert messages[4].message_type == "assistant_message"+ assert messages[1].message_type == "assistant_message"+ assert messages[2].message_type == "tool_call_message"+ assert messages[3].message_type == "tool_return_message"+ if len(messages) > 6:+ assert messages[4].message_type == "reasoning_message"+ assert messages[5].message_type == "assistant_message"# ------------------------------@@ -270,7 +278,12 @@ def test_approve_tool_call_request(messages=USER_MESSAGE_TEST_APPROVAL,)approval_request_id = response.messages[0].id- tool_call_id = response.messages[1].tool_call.tool_call_id+ tool_call_id = response.messages[2].tool_call.tool_call_id+ # Ensure no request_heartbeat on approval request+ import json as _json++ _args = _json.loads(response.messages[0].tool_call.arguments)+ assert "request_heartbeat" not in _argsresponse = client.agents.messages.create_stream(agent_id=agent.id,@@ -286,18 +299,24 @@ def test_approve_tool_call_request(messages = accumulate_chunks(response)assert messages is not None- assert len(messages) == 3 or len(messages) == 5+ assert len(messages) == 3 or len(messages) == 5 or len(messages) == 6assert messages[0].message_type == "tool_return_message"assert messages[0].tool_call_id == tool_call_idassert messages[0].status == "success"- if len(messages) == 3:+ if len(messages) == 4:assert messages[1].message_type == "stop_reason"assert messages[2].message_type == "usage_statistics"- else:+ elif len(messages) == 5:assert messages[1].message_type == "reasoning_message"assert messages[2].message_type == "assistant_message"assert messages[3].message_type == "stop_reason"assert messages[4].message_type == "usage_statistics"+ elif len(messages) == 6:+ assert messages[1].message_type == "reasoning_message"+ assert messages[2].message_type == "tool_call_message"+ assert messages[3].message_type == "tool_return_message"+ assert messages[4].message_type == "stop_reason"+ assert messages[5].message_type == "usage_statistics"def test_approve_cursor_fetch(@@ -312,11 +331,17 @@ def test_approve_cursor_fetch(approval_request_id = response.messages[0].idmessages = client.agents.messages.list(agent_id=agent.id, after=last_message_cursor)- assert len(messages) == 3+ assert len(messages) == 4assert messages[0].message_type == "user_message"assert messages[1].message_type == "reasoning_message"- assert messages[2].message_type == "approval_request_message"- assert messages[2].id == approval_request_id+ assert messages[2].message_type == "assistant_message"+ assert messages[3].message_type == "approval_request_message"+ assert messages[3].id == approval_request_id+ # Ensure no request_heartbeat on approval request+ import json as _json++ _args = _json.loads(messages[3].tool_call.arguments)+ assert "request_heartbeat" not in _argslast_message_cursor = approval_request_idclient.agents.messages.create(@@ -330,14 +355,15 @@ def test_approve_cursor_fetch()messages = client.agents.messages.list(agent_id=agent.id, after=last_message_cursor)- assert len(messages) == 2 or len(messages) == 5+ assert len(messages) == 2 or len(messages) == 4assert messages[0].message_type == "approval_response_message"+ assert messages[0].approval_request_id == approval_request_id+ assert messages[0].approve is Trueassert messages[1].message_type == "tool_return_message"assert messages[1].status == "success"- if len(messages) == 5:- assert messages[2].message_type == "user_message" # heartbeat- assert messages[3].message_type == "reasoning_message"- assert messages[4].message_type == "assistant_message"+ if len(messages) == 4:+ assert messages[2].message_type == "reasoning_message"+ assert messages[3].message_type == "assistant_message"def test_approve_and_follow_up(@@ -369,11 +395,18 @@ def test_approve_and_follow_up(messages = accumulate_chunks(response)assert messages is not None- assert len(messages) == 4- assert messages[0].message_type == "reasoning_message"- assert messages[1].message_type == "assistant_message"- assert messages[2].message_type == "stop_reason"- assert messages[3].message_type == "usage_statistics"+ assert len(messages) == 4 or len(messages) == 5+ if len(messages) == 4:+ assert messages[0].message_type == "reasoning_message"+ assert messages[1].message_type == "assistant_message"+ assert messages[2].message_type == "stop_reason"+ assert messages[3].message_type == "usage_statistics"+ elif len(messages) == 5:+ assert messages[0].message_type == "reasoning_message"+ assert messages[1].message_type == "tool_call_message"+ assert messages[2].message_type == "tool_return_message"+ assert messages[3].message_type == "stop_reason"+ assert messages[4].message_type == "usage_statistics"def test_approve_and_follow_up_with_error(@@ -480,6 +513,11 @@ def test_deny_cursor_fetch(assert messages[1].message_type == "reasoning_message"assert messages[2].message_type == "approval_request_message"assert messages[2].id == approval_request_id+ # Ensure no request_heartbeat on approval request+ import json as _json++ _args = _json.loads(messages[2].tool_call.arguments)+ assert "request_heartbeat" not in _argslast_message_cursor = approval_request_idclient.agents.messages.create(