Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

fix: stainless pagination (#5943)

Ari Webb395c04c52e77
diff --git a/tests/sdk_v1/integration/integration_test_builtin_tools.py b/tests/sdk_v1/integration/integration_test_builtin_tools.py
index e674b35cf..c30d53cdb 100644
--- a/tests/sdk_v1/integration/integration_test_builtin_tools.py
+++ b/tests/sdk_v1/integration/integration_test_builtin_tools.py
@@ -72,9 +72,9 @@ def agent_state(client: Letta) -> AgentState:
"""
client.tools.upsert_base_tools()
- send_message_tool = client.tools.list(name="send_message")[0]
- run_code_tool = client.tools.list(name="run_code")[0]
- web_search_tool = client.tools.list(name="web_search")[0]
+ send_message_tool = list(client.tools.list(name="send_message"))[0]
+ run_code_tool = list(client.tools.list(name="run_code"))[0]
+ web_search_tool = list(client.tools.list(name="web_search"))[0]
agent_state_instance = client.agents.create(
name="test_builtin_tools_agent",
include_base_tools=False,
diff --git a/tests/sdk_v1/test_sdk_client.py b/tests/sdk_v1/test_sdk_client.py
index f2aea9cfe..e9ac9e797 100644
--- a/tests/sdk_v1/test_sdk_client.py
+++ b/tests/sdk_v1/test_sdk_client.py
@@ -515,17 +515,19 @@ def test_list_folders_for_agent(client: LettaSDKClient):
try:
# Initially no folders
folders = client.agents.folders.list(agent_id=agent.id)
- assert len(folders) == 0, "Should start with no folders"
+ folders_list = list(folders)
+ assert len(folders_list) == 0, "Should start with no folders"
# Attach folder
client.agents.folders.attach(agent_id=agent.id, folder_id=folder.id)
# List folders
folders = client.agents.folders.list(agent_id=agent.id)
- assert len(folders) == 1, "Should have one folder"
- assert folders[0].id == folder.id, "Should return the attached folder"
- assert hasattr(folders[0], "name"), "Folder should have name attribute"
- assert hasattr(folders[0], "id"), "Folder should have id attribute"
+ folders_list = list(folders)
+ assert len(folders_list) == 1, "Should have one folder"
+ assert folders_list[0].id == folder.id, "Should return the attached folder"
+ assert hasattr(folders_list[0], "name"), "Folder should have name attribute"
+ assert hasattr(folders_list[0], "id"), "Folder should have id attribute"
finally:
# Clean up
@@ -1062,9 +1064,11 @@ def test_agent_creation(client: LettaSDKClient):
# Verify the tools are properly attached
agent_tools = client.agents.tools.list(agent_id=agent.id)
- assert len(agent_tools) == 2
+ agent_tools_list = list(agent_tools)
+ # Check that both expected tools are present (there might be extras from previous tests)
tool_ids = {tool1.id, tool2.id}
- assert all(tool.id in tool_ids for tool in agent_tools)
+ found_tools = {tool.id for tool in agent_tools_list if tool.id in tool_ids}
+ assert found_tools == tool_ids, f"Expected tools {tool_ids}, but found {found_tools}"
def test_many_blocks(client: LettaSDKClient):
@@ -1154,7 +1158,7 @@ def test_include_return_message_types(client: LettaSDKClient, agent: AgentState,
],
include_return_message_types=message_types,
)
- messages = [message for message in list(response) if message.message_type not in ["stop_reason", "usage_statistics"]]
+ messages = [message for message in list(response) if message.message_type not in ["stop_reason", "usage_statistics", "ping"]]
verify_message_types(messages, message_types)
elif message_create == "async":
@@ -1176,7 +1180,7 @@ def test_include_return_message_types(client: LettaSDKClient, agent: AgentState,
if response.status != "completed":
pytest.fail(f"Response status was NOT completed: {response}")
- messages = client.runs.messages.list(run_id=response.id).items
+ messages = list(client.runs.messages.list(run_id=response.id))
verify_message_types(messages, message_types)
elif message_create == "token_stream":
@@ -1190,7 +1194,7 @@ def test_include_return_message_types(client: LettaSDKClient, agent: AgentState,
],
include_return_message_types=message_types,
)
- messages = [message for message in list(response) if message.message_type not in ["stop_reason", "usage_statistics"]]
+ messages = [message for message in list(response) if message.message_type not in ["stop_reason", "usage_statistics", "ping"]]
verify_message_types(messages, message_types)
elif message_create == "sync":
@@ -1282,9 +1286,9 @@ def test_pydantic_inventory_management_tool(e2b_sandbox_mode, client: LettaSDKCl
print(f"Updated inventory for {data.item.name} with a quantity change of {quantity_change}")
return True
- # test creation
+ # test creation - provide a placeholder id (server will generate a new one)
tool = client.tools.add(
- tool=ManageInventoryTool(),
+ tool=ManageInventoryTool(id="tool-placeholder"),
)
# test that upserting also works
@@ -1294,7 +1298,7 @@ def test_pydantic_inventory_management_tool(e2b_sandbox_mode, client: LettaSDKCl
description: str = new_description
tool = client.tools.add(
- tool=ManageInventoryToolModified(),
+ tool=ManageInventoryToolModified(id="tool-placeholder"),
)
assert tool.description == new_description
@@ -1595,10 +1599,11 @@ def test_agent_tools_list(client: LettaSDKClient):
try:
# Test basic functionality
tools = client.agents.tools.list(agent_id=agent_state.id)
- assert len(tools) > 0, "Agent should have base tools attached"
+ tools_list = list(tools)
+ assert len(tools_list) > 0, "Agent should have base tools attached"
# Verify tool objects have expected attributes
- for tool in tools:
+ for tool in tools_list:
assert hasattr(tool, "id"), "Tool should have id attribute"
assert hasattr(tool, "name"), "Tool should have name attribute"
assert tool.id is not None, "Tool id should not be None"
@@ -1992,7 +1997,8 @@ def test_export_import_agent_with_files(client: LettaSDKClient):
# Verify files were uploaded successfully
files_in_folder = client.folders.files.list(folder_id=folder.id, limit=10)
- assert len(files_in_folder) == len(test_files), f"Expected {len(test_files)} files, got {len(files_in_folder)}"
+ files_list = list(files_in_folder)
+ assert len(files_list) == len(test_files), f"Expected {len(test_files)} files, got {len(files_list)}"
# Create a simple agent with the folder attached (use source_ids with folder ID for compatibility)
temp_agent = client.agents.create(
@@ -2152,11 +2158,13 @@ def test_run_list(client: LettaSDKClient):
# list runs (returns list directly since paginated: false)
runs = client.runs.list(agent_ids=[agent.id])
- assert len(runs) == 2
- assert async_run.id in [run.id for run in runs]
+ runs_list = list(runs)
+ # Check that at least the async run is present (there might be extras from previous tests)
+ assert len(runs_list) >= 2, f"Expected at least 2 runs, got {len(runs_list)}"
+ assert async_run.id in [run.id for run in runs_list]
- # test get run
- run = client.runs.retrieve(runs[0].id)
+ # test get run - use the async_run we created
+ run = client.runs.retrieve(async_run.id)
assert run.agent_id == agent.id
@@ -2203,8 +2211,9 @@ async def test_create_batch(client: LettaSDKClient, server: SyncServer):
# list batches
batches = client.batches.list()
- assert len(batches) >= 1, f"Expected 1 or more batches, got {len(batches)}"
- assert batches[0].status == "running"
+ batches_list = list(batches)
+ assert len(batches_list) >= 1, f"Expected 1 or more batches, got {len(batches_list)}"
+ assert batches_list[0].status == "running"
# Poll it once
await poll_running_llm_batches(server)
@@ -2322,8 +2331,9 @@ def test_create_agent_with_tools(client: LettaSDKClient) -> None:
)
assert tool_from_func is not None
+ # Provide a placeholder id (server will generate a new one)
tool_from_class = client.tools.add(
- tool=ManageInventoryTool(),
+ tool=ManageInventoryTool(id="tool-placeholder"),
)
assert tool_from_class is not None