Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.
fix: patch mcp alerting on sentry
Charles Packer4dcbf0b8f24a
diff --git a/letta/services/mcp/base_client.py b/letta/services/mcp/base_client.pyindex 0df3cba12..4ce0ad0f5 100644--- a/letta/services/mcp/base_client.py+++ b/letta/services/mcp/base_client.py@@ -27,10 +27,14 @@ class AsyncBaseMCPClient:await self.session.initialize()self.initialized = Trueexcept ConnectionError as e:- logger.error(f"MCP connection failed: {str(e)}")+ # MCP connection failures are often due to user misconfiguration, not system errors+ # Log at debug level to avoid triggering Sentry alerts for expected configuration issues+ logger.debug(f"MCP connection failed: {str(e)}")raise eexcept Exception as e:- logger.error(+ # MCP connection failures are often due to user misconfiguration, not system errors+ # Log at info level to help with debugging without triggering Sentry alerts+ logger.info(f"Connecting to MCP server failed. Please review your server config: {self.server_config.model_dump_json(indent=4)}. Error: {str(e)}")if hasattr(self.server_config, "server_url") and self.server_config.server_url:diff --git a/letta/services/mcp_manager.py b/letta/services/mcp_manager.pyindex c79f852ac..fffc90d91 100644--- a/letta/services/mcp_manager.py+++ b/letta/services/mcp_manager.py@@ -60,7 +60,9 @@ class MCPManager:tools = await mcp_client.list_tools()return toolsexcept Exception as e:- logger.error(f"Error listing tools for MCP server {mcp_server_name}: {e}")+ # MCP tool listing errors are often due to connection/configuration issues, not system errors+ # Log at info level to avoid triggering Sentry alerts for expected failures+ logger.info(f"Error listing tools for MCP server {mcp_server_name}: {e}")return []finally:await mcp_client.cleanup()@@ -302,7 +304,8 @@ class MCPManager:try:mcp_config = json.load(f)except Exception as e:- logger.error(f"Failed to parse MCP config file ({mcp_config_path}) as json: {e}")+ # Config parsing errors are user configuration issues, not system errors+ logger.warning(f"Failed to parse MCP config file ({mcp_config_path}) as json: {e}")return mcp_server_list# Proper formatting is "mcpServers" key at the top level,@@ -313,7 +316,8 @@ class MCPManager:# No support for duplicate server namesif server_name in mcp_server_list:- logger.error(f"Duplicate MCP server name found (skipping): {server_name}")+ # Duplicate server names are configuration issues, not system errors+ logger.warning(f"Duplicate MCP server name found (skipping): {server_name}")continueif "url" in server_params_raw:@@ -328,7 +332,8 @@ class MCPManager:)mcp_server_list[server_name] = server_paramsexcept Exception as e:- logger.error(f"Failed to parse server params for MCP server {server_name} (skipping): {e}")+ # Config parsing errors are user configuration issues, not system errors+ logger.warning(f"Failed to parse server params for MCP server {server_name} (skipping): {e}")continueelse:# Attempt to parse the server params as a StdioServerParameters@@ -341,7 +346,8 @@ class MCPManager:)mcp_server_list[server_name] = server_paramsexcept Exception as e:- logger.error(f"Failed to parse server params for MCP server {server_name} (skipping): {e}")+ # Config parsing errors are user configuration issues, not system errors+ logger.warning(f"Failed to parse server params for MCP server {server_name} (skipping): {e}")continuereturn mcp_server_list