Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.
fix(core): reject empty API keys in Bearer auth headers (#9350)
Kian Jones745dd1e124fe
diff --git a/letta/functions/mcp_client/types.py b/letta/functions/mcp_client/types.pyindex 74293d81a..18174e8e2 100644--- a/letta/functions/mcp_client/types.py+++ b/letta/functions/mcp_client/types.py@@ -176,11 +176,11 @@ class HTTPBasedServerConfig(BaseServerConfig):Returns:Dictionary of headers or None if no headers are configured"""- if self.custom_headers is not None or (self.auth_header is not None and self.auth_token is not None):+ if self.custom_headers is not None or (self.auth_header and self.auth_token):headers = self.custom_headers.copy() if self.custom_headers else {}- # Add auth header if specified- if self.auth_header is not None and self.auth_token is not None:+ # Add auth header if specified (skip if either is empty to avoid illegal header values)+ if self.auth_header and self.auth_token:headers[self.auth_header] = self.auth_tokenreturn headersdiff --git a/letta/llm_api/chatgpt_oauth_client.py b/letta/llm_api/chatgpt_oauth_client.pyindex 47e61eecb..9f5a3db53 100644--- a/letta/llm_api/chatgpt_oauth_client.py+++ b/letta/llm_api/chatgpt_oauth_client.py@@ -154,6 +154,11 @@ class ChatGPTOAuthClient(LLMClientBase):Returns:Dictionary of HTTP headers."""+ if not creds.access_token:+ raise LLMAuthenticationError(+ message="ChatGPT OAuth access_token is empty or missing",+ code=ErrorCode.UNAUTHENTICATED,+ )return {"Authorization": f"Bearer {creds.access_token}","ChatGPT-Account-Id": creds.account_id,diff --git a/letta/llm_api/mistral.py b/letta/llm_api/mistral.pyindex 8d5b8b10b..ec75e0a36 100644--- a/letta/llm_api/mistral.py+++ b/letta/llm_api/mistral.py@@ -10,7 +10,7 @@ async def mistral_get_model_list_async(url: str, api_key: str) -> dict:url = smart_urljoin(url, "models")headers = {"Content-Type": "application/json"}- if api_key is not None:+ if api_key:headers["Authorization"] = f"Bearer {api_key}"logger.debug("Sending request to %s", url)diff --git a/letta/llm_api/openai.py b/letta/llm_api/openai.pyindex 69bcaa54d..ae4e34513 100644--- a/letta/llm_api/openai.py+++ b/letta/llm_api/openai.py@@ -59,7 +59,7 @@ async def openai_get_model_list_async(url = smart_urljoin(url, "models")headers = {"Content-Type": "application/json"}- if api_key is not None:+ if api_key:headers["Authorization"] = f"Bearer {api_key}"if "openrouter.ai" in url:if model_settings.openrouter_referer:@@ -478,7 +478,7 @@ def openai_chat_completions_request_stream(data = prepare_openai_payload(chat_completion_request)data["stream"] = True- kwargs = {"api_key": api_key, "base_url": url, "max_retries": 0}+ kwargs = {"api_key": api_key or "DUMMY_API_KEY", "base_url": url, "max_retries": 0}if "openrouter.ai" in url:headers = {}if model_settings.openrouter_referer:@@ -511,7 +511,7 @@ def openai_chat_completions_request(https://platform.openai.com/docs/guides/text-generation?lang=curl"""data = prepare_openai_payload(chat_completion_request)- kwargs = {"api_key": api_key, "base_url": url, "max_retries": 0}+ kwargs = {"api_key": api_key or "DUMMY_API_KEY", "base_url": url, "max_retries": 0}if "openrouter.ai" in url:headers = {}if model_settings.openrouter_referer:diff --git a/letta/local_llm/utils.py b/letta/local_llm/utils.pyindex 0bbfcb105..905736c27 100644--- a/letta/local_llm/utils.py+++ b/letta/local_llm/utils.py@@ -25,15 +25,15 @@ def post_json_auth_request(uri, json_payload, auth_type, auth_key):# Used by OpenAI, together.ai, Mistral AIelif auth_type == "bearer_token":- if auth_key is None:- raise ValueError(f"auth_type is {auth_type}, but auth_key is null")+ if not auth_key:+ raise ValueError(f"auth_type is {auth_type}, but auth_key is null or empty")headers = {"Content-Type": "application/json", "Authorization": f"Bearer {auth_key}"}response = requests.post(uri, json=json_payload, headers=headers)# Used by OpenAI Azureelif auth_type == "api_key":- if auth_key is None:- raise ValueError(f"auth_type is {auth_type}, but auth_key is null")+ if not auth_key:+ raise ValueError(f"auth_type is {auth_type}, but auth_key is null or empty")headers = {"Content-Type": "application/json", "api-key": f"{auth_key}"}response = requests.post(uri, json=json_payload, headers=headers)