Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

feat(asyncify): add size_async db function (#2207)

cthomas80bde05b73c2
diff --git a/letta/agents/letta_agent.py b/letta/agents/letta_agent.py
index 18d03e795..78bc5c629 100644
--- a/letta/agents/letta_agent.py
+++ b/letta/agents/letta_agent.py
@@ -62,8 +62,8 @@ class LettaAgent(BaseAgent):
self.last_function_response = None
# Cached archival memory/message size
- self.num_messages = self.message_manager.size(actor=self.actor, agent_id=agent_id)
- self.num_archival_memories = self.passage_manager.size(actor=self.actor, agent_id=agent_id)
+ self.num_messages = 0
+ self.num_archival_memories = 0
@trace_method
async def step(self, input_messages: List[MessageCreate], max_steps: int = 10, use_assistant_message: bool = True) -> LettaResponse:
@@ -201,8 +201,8 @@ class LettaAgent(BaseAgent):
# TODO: This may be out of sync, if in between steps users add files
# NOTE (cliandy): temporary for now for particlar use cases.
- self.num_messages = self.message_manager.size(actor=self.actor, agent_id=agent_state.id)
- self.num_archival_memories = self.passage_manager.size(actor=self.actor, agent_id=agent_state.id)
+ self.num_messages = await self.message_manager.size_async(actor=self.actor, agent_id=agent_state.id)
+ self.num_archival_memories = await self.passage_manager.size_async(actor=self.actor, agent_id=agent_state.id)
# TODO: Also yield out a letta usage stats SSE
yield f"data: {usage.model_dump_json()}\n\n"
@@ -219,6 +219,10 @@ class LettaAgent(BaseAgent):
stream: bool,
) -> ChatCompletion | AsyncStream[ChatCompletionChunk]:
if settings.experimental_enable_async_db_engine:
+ self.num_messages = self.num_messages or (await self.message_manager.size_async(actor=self.actor, agent_id=agent_state.id))
+ self.num_archival_memories = self.num_archival_memories or (
+ await self.passage_manager.size_async(actor=self.actor, agent_id=agent_state.id)
+ )
in_context_messages = await self._rebuild_memory_async(
in_context_messages, agent_state, num_messages=self.num_messages, num_archival_memories=self.num_archival_memories
)
diff --git a/letta/orm/sqlalchemy_base.py b/letta/orm/sqlalchemy_base.py
index 889afb123..d167e5e90 100644
--- a/letta/orm/sqlalchemy_base.py
+++ b/letta/orm/sqlalchemy_base.py
@@ -818,6 +818,39 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
await db_session.refresh(self)
return self
+ @classmethod
+ def _size_preprocess(
+ cls,
+ *,
+ db_session: "Session",
+ actor: Optional["User"] = None,
+ access: Optional[List[Literal["read", "write", "admin"]]] = ["read"],
+ access_type: AccessType = AccessType.ORGANIZATION,
+ **kwargs,
+ ):
+ logger.debug(f"Calculating size for {cls.__name__} with filters {kwargs}")
+ query = select(func.count()).select_from(cls)
+
+ if actor:
+ query = cls.apply_access_predicate(query, actor, access, access_type)
+
+ # Apply filtering logic based on kwargs
+ for key, value in kwargs.items():
+ if value:
+ column = getattr(cls, key, None)
+ if not column:
+ raise AttributeError(f"{cls.__name__} has no attribute '{key}'")
+ if isinstance(value, (list, tuple, set)): # Check for iterables
+ query = query.where(column.in_(value))
+ else: # Single value for equality filtering
+ query = query.where(column == value)
+
+ # Handle soft deletes if the class has the 'is_deleted' attribute
+ if hasattr(cls, "is_deleted"):
+ query = query.where(cls.is_deleted == False)
+
+ return query
+
@classmethod
@handle_db_timeout
def size(
@@ -842,28 +875,8 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
Raises:
DBAPIError: If a database error occurs
"""
- logger.debug(f"Calculating size for {cls.__name__} with filters {kwargs}")
-
with db_session as session:
- query = select(func.count()).select_from(cls)
-
- if actor:
- query = cls.apply_access_predicate(query, actor, access, access_type)
-
- # Apply filtering logic based on kwargs
- for key, value in kwargs.items():
- if value:
- column = getattr(cls, key, None)
- if not column:
- raise AttributeError(f"{cls.__name__} has no attribute '{key}'")
- if isinstance(value, (list, tuple, set)): # Check for iterables
- query = query.where(column.in_(value))
- else: # Single value for equality filtering
- query = query.where(column == value)
-
- # Handle soft deletes if the class has the 'is_deleted' attribute
- if hasattr(cls, "is_deleted"):
- query = query.where(cls.is_deleted == False)
+ query = cls._size_preprocess(db_session=session, actor=actor, access=access, access_type=access_type, **kwargs)
try:
count = session.execute(query).scalar()
@@ -872,6 +885,37 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
logger.exception(f"Failed to calculate size for {cls.__name__}")
raise e
+ @classmethod
+ @handle_db_timeout
+ async def size_async(
+ cls,
+ *,
+ db_session: "AsyncSession",
+ actor: Optional["User"] = None,
+ access: Optional[List[Literal["read", "write", "admin"]]] = ["read"],
+ access_type: AccessType = AccessType.ORGANIZATION,
+ **kwargs,
+ ) -> int:
+ """
+ Get the count of rows that match the provided filters.
+ Args:
+ db_session: SQLAlchemy session
+ **kwargs: Filters to apply to the query (e.g., column_name=value)
+ Returns:
+ int: The count of rows that match the filters
+ Raises:
+ DBAPIError: If a database error occurs
+ """
+ async with db_session as session:
+ query = cls._size_preprocess(db_session=session, actor=actor, access=access, access_type=access_type, **kwargs)
+
+ try:
+ count = await session.execute(query).scalar()
+ return count if count else 0
+ except DBAPIError as e:
+ logger.exception(f"Failed to calculate size for {cls.__name__}")
+ raise e
+
@classmethod
def apply_access_predicate(
cls,
diff --git a/letta/services/message_manager.py b/letta/services/message_manager.py
index 0e19bc98b..36b2f742e 100644
--- a/letta/services/message_manager.py
+++ b/letta/services/message_manager.py
@@ -286,6 +286,21 @@ class MessageManager:
with db_registry.session() as session:
return MessageModel.size(db_session=session, actor=actor, role=role, agent_id=agent_id)
+ @enforce_types
+ async def size_async(
+ self,
+ actor: PydanticUser,
+ role: Optional[MessageRole] = None,
+ agent_id: Optional[str] = None,
+ ) -> int:
+ """Get the total count of messages with optional filters.
+ Args:
+ actor: The user requesting the count
+ role: The role of the message
+ """
+ async with db_registry.async_session() as session:
+ return await MessageModel.size_async(db_session=session, actor=actor, role=role, agent_id=agent_id)
+
@enforce_types
def list_user_messages_for_agent(
self,
diff --git a/letta/services/passage_manager.py b/letta/services/passage_manager.py
index 8d735d9bb..3cd581b3f 100644
--- a/letta/services/passage_manager.py
+++ b/letta/services/passage_manager.py
@@ -216,6 +216,20 @@ class PassageManager:
with db_registry.session() as session:
return AgentPassage.size(db_session=session, actor=actor, agent_id=agent_id)
+ @enforce_types
+ async def size_async(
+ self,
+ actor: PydanticUser,
+ agent_id: Optional[str] = None,
+ ) -> int:
+ """Get the total count of messages with optional filters.
+ Args:
+ actor: The user requesting the count
+ agent_id: The agent ID of the messages
+ """
+ async with db_registry.async_session() as session:
+ return await AgentPassage.size_async(db_session=session, actor=actor, agent_id=agent_id)
+
def estimate_embeddings_size(
self,
actor: PydanticUser,