Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

feat: add low level db traces (#2343)

cthomas8d00e7fd149c
diff --git a/letta/orm/sqlalchemy_base.py b/letta/orm/sqlalchemy_base.py
index 3df9bb5f4..beb04c32f 100644
--- a/letta/orm/sqlalchemy_base.py
+++ b/letta/orm/sqlalchemy_base.py
@@ -13,6 +13,7 @@ from letta.log import get_logger
from letta.orm.base import Base, CommonSqlalchemyMetaMixins
from letta.orm.errors import DatabaseTimeoutError, ForeignKeyConstraintViolationError, NoResultFound, UniqueConstraintViolationError
from letta.orm.sqlite_functions import adapt_array
+from letta.tracing import trace_method
if TYPE_CHECKING:
from pydantic import BaseModel
@@ -48,6 +49,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
id: Mapped[str] = mapped_column(String, primary_key=True)
@classmethod
+ @trace_method
@handle_db_timeout
def list(
cls,
@@ -149,6 +151,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return results
@classmethod
+ @trace_method
@handle_db_timeout
async def list_async(
cls,
@@ -433,6 +436,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return results
@classmethod
+ @trace_method
@handle_db_timeout
def read(
cls,
@@ -471,6 +475,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return found[0]
@classmethod
+ @trace_method
@handle_db_timeout
async def read_async(
cls,
@@ -509,6 +514,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return found[0]
@classmethod
+ @trace_method
@handle_db_timeout
def read_multiple(
cls,
@@ -536,6 +542,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return cls._read_multiple_postprocess(results, identifiers, query_conditions)
@classmethod
+ @trace_method
@handle_db_timeout
async def read_multiple_async(
cls,
@@ -614,6 +621,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
logger.debug(f"{cls.__name__} not found with {conditions_str}")
return []
+ @trace_method
@handle_db_timeout
def create(self, db_session: "Session", actor: Optional["User"] = None, no_commit: bool = False) -> "SqlalchemyBase":
logger.debug(f"Creating {self.__class__.__name__} with ID: {self.id} with actor={actor}")
@@ -631,6 +639,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
except (DBAPIError, IntegrityError) as e:
self._handle_dbapi_error(e)
+ @trace_method
@handle_db_timeout
async def create_async(self, db_session: "AsyncSession", actor: Optional["User"] = None, no_commit: bool = False) -> "SqlalchemyBase":
"""Async version of create function"""
@@ -650,6 +659,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
self._handle_dbapi_error(e)
@classmethod
+ @trace_method
@handle_db_timeout
def batch_create(cls, items: List["SqlalchemyBase"], db_session: "Session", actor: Optional["User"] = None) -> List["SqlalchemyBase"]:
"""
@@ -691,6 +701,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
cls._handle_dbapi_error(e)
@classmethod
+ @trace_method
@handle_db_timeout
async def batch_create_async(
cls, items: List["SqlalchemyBase"], db_session: "AsyncSession", actor: Optional["User"] = None
@@ -735,6 +746,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
except (DBAPIError, IntegrityError) as e:
cls._handle_dbapi_error(e)
+ @trace_method
@handle_db_timeout
def delete(self, db_session: "Session", actor: Optional["User"] = None) -> "SqlalchemyBase":
logger.debug(f"Soft deleting {self.__class__.__name__} with ID: {self.id} with actor={actor}")
@@ -745,6 +757,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
self.is_deleted = True
return self.update(db_session)
+ @trace_method
@handle_db_timeout
async def delete_async(self, db_session: "AsyncSession", actor: Optional["User"] = None) -> "SqlalchemyBase":
"""Soft delete a record asynchronously (mark as deleted)."""
@@ -756,6 +769,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
self.is_deleted = True
return await self.update_async(db_session)
+ @trace_method
@handle_db_timeout
def hard_delete(self, db_session: "Session", actor: Optional["User"] = None) -> None:
"""Permanently removes the record from the database."""
@@ -772,6 +786,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
else:
logger.debug(f"{self.__class__.__name__} with ID {self.id} successfully hard deleted")
+ @trace_method
@handle_db_timeout
async def hard_delete_async(self, db_session: "AsyncSession", actor: Optional["User"] = None) -> None:
"""Permanently removes the record from the database asynchronously."""
@@ -786,6 +801,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
logger.exception(f"Failed to hard delete {self.__class__.__name__} with ID {self.id}")
raise ValueError(f"Failed to hard delete {self.__class__.__name__} with ID {self.id}: {e}")
+ @trace_method
@handle_db_timeout
def update(self, db_session: Session, actor: Optional["User"] = None, no_commit: bool = False) -> "SqlalchemyBase":
logger.debug(...)
@@ -802,6 +818,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
db_session.refresh(self)
return self
+ @trace_method
@handle_db_timeout
async def update_async(self, db_session: AsyncSession, actor: "User | None" = None, no_commit: bool = False) -> "SqlalchemyBase":
"""Async version of update function"""
@@ -852,6 +869,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
return query
@classmethod
+ @trace_method
@handle_db_timeout
def size(
cls,
@@ -886,6 +904,7 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
raise e
@classmethod
+ @trace_method
@handle_db_timeout
async def size_async(
cls,
diff --git a/letta/server/db.py b/letta/server/db.py
index fe9abcff3..32f93a03f 100644
--- a/letta/server/db.py
+++ b/letta/server/db.py
@@ -13,6 +13,7 @@ from sqlalchemy.orm import sessionmaker
from letta.config import LettaConfig
from letta.log import get_logger
from letta.settings import settings
+from letta.tracing import trace_method
logger = get_logger(__name__)
@@ -202,6 +203,7 @@ class DatabaseRegistry:
self.initialize_async()
return self._async_session_factories.get(name)
+ @trace_method
@contextmanager
def session(self, name: str = "default") -> Generator[Any, None, None]:
"""Context manager for database sessions."""
@@ -215,6 +217,7 @@ class DatabaseRegistry:
finally:
session.close()
+ @trace_method
@asynccontextmanager
async def async_session(self, name: str = "default") -> AsyncGenerator[AsyncSession, None]:
"""Async context manager for database sessions."""
diff --git a/letta/server/server.py b/letta/server/server.py
index be3e33da9..02419ee94 100644
--- a/letta/server/server.py
+++ b/letta/server/server.py
@@ -50,7 +50,7 @@ from letta.schemas.letta_message import LegacyLettaMessage, LettaMessage, ToolRe
from letta.schemas.letta_message_content import TextContent
from letta.schemas.letta_response import LettaResponse
from letta.schemas.llm_config import LLMConfig
-from letta.schemas.memory import ArchivalMemorySummary, ContextWindowOverview, Memory, RecallMemorySummary
+from letta.schemas.memory import ArchivalMemorySummary, Memory, RecallMemorySummary
from letta.schemas.message import Message, MessageCreate, MessageUpdate
from letta.schemas.organization import Organization
from letta.schemas.passage import Passage, PassageUpdate