Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

fix: improve identity error handling (#1176)

cthomasb43dc0ec9279
diff --git a/letta/server/rest_api/routers/v1/identities.py b/letta/server/rest_api/routers/v1/identities.py
index a8a9ad275..b22d355a1 100644
--- a/letta/server/rest_api/routers/v1/identities.py
+++ b/letta/server/rest_api/routers/v1/identities.py
@@ -42,6 +42,8 @@ def list_identities(
)
except HTTPException:
raise
+ except NoResultFound as e:
+ raise HTTPException(status_code=404, detail=str(e))
except Exception as e:
raise HTTPException(status_code=500, detail=f"{e}")
return identities
@@ -75,11 +77,11 @@ def create_identity(
except UniqueConstraintViolationError:
if identity.project_id:
raise HTTPException(
- status_code=400,
+ status_code=409,
detail=f"An identity with identifier key {identity.identifier_key} already exists for project {identity.project_id}",
)
else:
- raise HTTPException(status_code=400, detail=f"An identity with identifier key {identity.identifier_key} already exists")
+ raise HTTPException(status_code=409, detail=f"An identity with identifier key {identity.identifier_key} already exists")
except Exception as e:
raise HTTPException(status_code=500, detail=f"{e}")
@@ -96,6 +98,8 @@ def upsert_identity(
return server.identity_manager.upsert_identity(identity=identity, actor=actor)
except HTTPException:
raise
+ except NoResultFound as e:
+ raise HTTPException(status_code=404, detail=str(e))
except Exception as e:
raise HTTPException(status_code=500, detail=f"{e}")
@@ -112,6 +116,8 @@ def modify_identity(
return server.identity_manager.update_identity(identity_id=identity_id, identity=identity, actor=actor)
except HTTPException:
raise
+ except NoResultFound as e:
+ raise HTTPException(status_code=404, detail=str(e))
except Exception as e:
raise HTTPException(status_code=500, detail=f"{e}")
@@ -125,5 +131,12 @@ def delete_identity(
"""
Delete an identity by its identifier key
"""
- actor = server.user_manager.get_user_or_default(user_id=actor_id)
- server.identity_manager.delete_identity(identity_id=identity_id, actor=actor)
+ try:
+ actor = server.user_manager.get_user_or_default(user_id=actor_id)
+ server.identity_manager.delete_identity(identity_id=identity_id, actor=actor)
+ except HTTPException:
+ raise
+ except NoResultFound as e:
+ raise HTTPException(status_code=404, detail=str(e))
+ except Exception as e:
+ raise HTTPException(status_code=500, detail=f"{e}")