Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

feat: Add flag to disable/enable pooling on app level (#2310)

Matthew Zhoub555ded77a94
diff --git a/letta/server/db.py b/letta/server/db.py
index 5204390e7..fe9abcff3 100644
--- a/letta/server/db.py
+++ b/letta/server/db.py
@@ -6,7 +6,7 @@ from typing import Any, AsyncGenerator, Generator
from rich.console import Console
from rich.panel import Panel
from rich.text import Text
-from sqlalchemy import Engine, create_engine
+from sqlalchemy import Engine, NullPool, QueuePool, create_engine
from sqlalchemy.ext.asyncio import AsyncEngine, AsyncSession, async_sessionmaker, create_async_engine
from sqlalchemy.orm import sessionmaker
@@ -14,6 +14,8 @@ from letta.config import LettaConfig
from letta.log import get_logger
from letta.settings import settings
+logger = get_logger(__name__)
+
def print_sqlite_schema_error():
"""Print a formatted error message for SQLite schema issues"""
@@ -76,18 +78,7 @@ class DatabaseRegistry:
self.config.archival_storage_type = "postgres"
self.config.archival_storage_uri = settings.letta_pg_uri_no_default
- engine = create_engine(
- settings.letta_pg_uri,
- # f"{settings.letta_pg_uri}?options=-c%20client_encoding=UTF8",
- pool_size=settings.pg_pool_size,
- max_overflow=settings.pg_max_overflow,
- pool_timeout=settings.pg_pool_timeout,
- pool_recycle=settings.pg_pool_recycle,
- echo=settings.pg_echo,
- pool_pre_ping=settings.pool_pre_ping,
- pool_use_lifo=settings.pool_use_lifo,
- # connect_args={"client_encoding": "utf8"},
- )
+ engine = create_engine(settings.letta_pg_uri, **self._build_sqlalchemy_engine_args(is_async=False))
self._engines["default"] = engine
# SQLite engine
@@ -127,16 +118,7 @@ class DatabaseRegistry:
async_pg_uri = f"postgresql+asyncpg://{pg_uri.split('://', 1)[1]}" if "://" in pg_uri else pg_uri
async_pg_uri = async_pg_uri.replace("sslmode=", "ssl=")
- async_engine = create_async_engine(
- async_pg_uri,
- pool_size=settings.pg_pool_size,
- max_overflow=settings.pg_max_overflow,
- pool_timeout=settings.pg_pool_timeout,
- pool_recycle=settings.pg_pool_recycle,
- echo=settings.pg_echo,
- pool_pre_ping=settings.pool_pre_ping,
- pool_use_lifo=settings.pool_use_lifo,
- )
+ async_engine = create_async_engine(async_pg_uri, **self._build_sqlalchemy_engine_args(is_async=True))
self._async_engines["default"] = async_engine
@@ -150,6 +132,38 @@ class DatabaseRegistry:
# TODO (cliandy): unclear around async sqlite support in sqlalchemy, we will not currently support this
self._initialized["async"] = False
+ def _build_sqlalchemy_engine_args(self, *, is_async: bool) -> dict:
+ """Prepare keyword arguments for create_engine / create_async_engine."""
+ use_null_pool = settings.disable_sqlalchemy_pooling
+
+ if use_null_pool:
+ logger.info("Disabling pooling on SqlAlchemy")
+ pool_cls = NullPool
+ else:
+ logger.info("Enabling pooling on SqlAlchemy")
+ pool_cls = QueuePool if not is_async else None
+
+ base_args = {
+ "echo": settings.pg_echo,
+ "pool_pre_ping": settings.pool_pre_ping,
+ }
+
+ if pool_cls:
+ base_args["poolclass"] = pool_cls
+
+ if not use_null_pool and not is_async:
+ base_args.update(
+ {
+ "pool_size": settings.pg_pool_size,
+ "max_overflow": settings.pg_max_overflow,
+ "pool_timeout": settings.pg_pool_timeout,
+ "pool_recycle": settings.pg_pool_recycle,
+ "pool_use_lifo": settings.pool_use_lifo,
+ }
+ )
+
+ return base_args
+
def _wrap_sqlite_engine(self, engine: Engine) -> None:
"""Wrap SQLite engine with error handling."""
original_connect = engine.connect
diff --git a/letta/settings.py b/letta/settings.py
index 20326eeea..063114328 100644
--- a/letta/settings.py
+++ b/letta/settings.py
@@ -186,6 +186,7 @@ class Settings(BaseSettings):
pg_echo: bool = False # Logging
pool_pre_ping: bool = True # Pre ping to check for dead connections
pool_use_lifo: bool = True
+ disable_sqlalchemy_pooling: bool = False
# multi agent settings
multi_agent_send_message_max_retries: int = 3