Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.
fix: ensure stop_reason is always set when marking runs as failed (#9045)
cthomasca40eff7bcba
diff --git a/letta/server/rest_api/routers/v1/agents.py b/letta/server/rest_api/routers/v1/agents.pyindex 1694f6dfe..c5ee4ed50 100644--- a/letta/server/rest_api/routers/v1/agents.py+++ b/letta/server/rest_api/routers/v1/agents.py@@ -1859,15 +1859,24 @@ async def _process_message_background(runs_manager = RunManager()from letta.schemas.enums import RunStatus+ from letta.schemas.letta_stop_reason import StopReasonType- if result.stop_reason.stop_reason == "cancelled":+ # Handle cases where stop_reason might be None (defensive)+ if result.stop_reason and result.stop_reason.stop_reason == "cancelled":run_status = RunStatus.cancelled+ stop_reason = result.stop_reason.stop_reason+ elif result.stop_reason:+ run_status = RunStatus.completed+ stop_reason = result.stop_reason.stop_reasonelse:+ # Fallback: no stop_reason set (shouldn't happen but defensive)+ logger.error(f"Run {run_id} completed without stop_reason in result, defaulting to end_turn")run_status = RunStatus.completed+ stop_reason = StopReasonType.end_turnawait runs_manager.update_run_by_id_async(run_id=run_id,- update=RunUpdate(status=run_status, stop_reason=result.stop_reason.stop_reason),+ update=RunUpdate(status=run_status, stop_reason=stop_reason),actor=actor,)@@ -1875,20 +1884,22 @@ async def _process_message_background(# Update run status to failed with specific error inforuns_manager = RunManager()from letta.schemas.enums import RunStatus+ from letta.schemas.letta_stop_reason import StopReasonTypeawait runs_manager.update_run_by_id_async(run_id=run_id,- update=RunUpdate(status=RunStatus.failed, metadata={"error": str(e)}),+ update=RunUpdate(status=RunStatus.failed, stop_reason=StopReasonType.error, metadata={"error": str(e)}),actor=actor,)except Exception as e:# Update run status to failedruns_manager = RunManager()from letta.schemas.enums import RunStatus+ from letta.schemas.letta_stop_reason import StopReasonTypeawait runs_manager.update_run_by_id_async(run_id=run_id,- update=RunUpdate(status=RunStatus.failed, metadata={"error": str(e)}),+ update=RunUpdate(status=RunStatus.failed, stop_reason=StopReasonType.error, metadata={"error": str(e)}),actor=actor,)finally:@@ -2028,10 +2039,11 @@ async def send_message_async(async def update_failed_run():runs_manager = RunManager()from letta.schemas.enums import RunStatus+ from letta.schemas.letta_stop_reason import StopReasonTypeawait runs_manager.update_run_by_id_async(run_id=run.id,- update=RunUpdate(status=RunStatus.failed, metadata={"error": error_str}),+ update=RunUpdate(status=RunStatus.failed, stop_reason=StopReasonType.error, metadata={"error": error_str}),actor=actor,)diff --git a/letta/services/run_manager.py b/letta/services/run_manager.pyindex 4aedc99e0..c841a62d9 100644--- a/letta/services/run_manager.py+++ b/letta/services/run_manager.py@@ -455,9 +455,11 @@ class RunManager:# Dispatch callback outside of database session if neededif needs_callback:if refresh_result_messages:+ # Defensive: ensure stop_reason is never None+ stop_reason_value = pydantic_run.stop_reason if pydantic_run.stop_reason else StopReasonType.completedresult = LettaResponse(messages=await self.get_run_messages(run_id=run_id, actor=actor),- stop_reason=LettaStopReason(stop_reason=pydantic_run.stop_reason),+ stop_reason=LettaStopReason(stop_reason=stop_reason_value),usage=await self.get_run_usage(run_id=run_id, actor=actor),)final_metadata["result"] = result.model_dump()