Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

fix: Fix pinecone embedder (#3502)

Matthew Zhoucc431b2e97f9
diff --git a/letta/schemas/embedding_config.py b/letta/schemas/embedding_config.py
index 1020382ba..8738d42c1 100644
--- a/letta/schemas/embedding_config.py
+++ b/letta/schemas/embedding_config.py
@@ -42,6 +42,7 @@ class EmbeddingConfig(BaseModel):
"hugging-face",
"mistral",
"together", # completions endpoint
+ "pinecone",
] = Field(..., description="The endpoint type for the model.")
embedding_endpoint: Optional[str] = Field(None, description="The endpoint for the model (`None` if local).")
embedding_model: str = Field(..., description="The model for the embedding.")
@@ -82,6 +83,15 @@ class EmbeddingConfig(BaseModel):
embedding_chunk_size=DEFAULT_EMBEDDING_CHUNK_SIZE,
embedding_endpoint_type="hugging-face",
)
+ elif provider == "pinecone":
+ # default config for pinecone with empty endpoint
+ return cls(
+ embedding_endpoint=None,
+ embedding_model="llama-text-embed-v2",
+ embedding_dim=1536, # assuming default openai dimension
+ embedding_chunk_size=DEFAULT_EMBEDDING_CHUNK_SIZE,
+ embedding_endpoint_type="pinecone",
+ )
else:
raise ValueError(f"Model {model_name} not supported.")
diff --git a/letta/server/rest_api/routers/v1/sources.py b/letta/server/rest_api/routers/v1/sources.py
index bcd1c6641..bd77ac3e2 100644
--- a/letta/server/rest_api/routers/v1/sources.py
+++ b/letta/server/rest_api/routers/v1/sources.py
@@ -477,7 +477,7 @@ async def load_file_to_source_cloud(
using_pinecone = should_use_pinecone()
if using_pinecone:
- embedder = PineconeEmbedder()
+ embedder = PineconeEmbedder(embedding_config=embedding_config)
else:
embedder = OpenAIEmbedder(embedding_config=embedding_config)
file_processor = FileProcessor(file_parser=file_parser, embedder=embedder, actor=actor, using_pinecone=using_pinecone)
diff --git a/letta/services/agent_serialization_manager.py b/letta/services/agent_serialization_manager.py
index 2612baa7c..a56be24e7 100644
--- a/letta/services/agent_serialization_manager.py
+++ b/letta/services/agent_serialization_manager.py
@@ -429,7 +429,7 @@ class AgentSerializationManager:
# 5. Process files for chunking/embedding (depends on files and sources)
if should_use_pinecone():
- embedder = PineconeEmbedder()
+ embedder = PineconeEmbedder(embedding_config=schema.agents[0].embedding_config)
else:
embedder = OpenAIEmbedder(embedding_config=schema.agents[0].embedding_config)
file_processor = FileProcessor(
diff --git a/letta/services/file_processor/embedder/pinecone_embedder.py b/letta/services/file_processor/embedder/pinecone_embedder.py
index 212ba95d9..c218807e0 100644
--- a/letta/services/file_processor/embedder/pinecone_embedder.py
+++ b/letta/services/file_processor/embedder/pinecone_embedder.py
@@ -1,8 +1,9 @@
-from typing import List
+from typing import List, Optional
from letta.helpers.pinecone_utils import upsert_file_records_to_pinecone_index
from letta.log import get_logger
from letta.otel.tracing import log_event, trace_method
+from letta.schemas.embedding_config import EmbeddingConfig
from letta.schemas.passage import Passage
from letta.schemas.user import User
from letta.services.file_processor.embedder.base_embedder import BaseEmbedder
@@ -18,10 +19,15 @@ logger = get_logger(__name__)
class PineconeEmbedder(BaseEmbedder):
"""Pinecone-based embedding generation"""
- def __init__(self):
+ def __init__(self, embedding_config: Optional[EmbeddingConfig] = None):
if not PINECONE_AVAILABLE:
raise ImportError("Pinecone package is not installed. Install it with: pip install pinecone")
+ # set default embedding config if not provided
+ if embedding_config is None:
+ embedding_config = EmbeddingConfig.default_config(provider="pinecone")
+
+ self.embedding_config = embedding_config
super().__init__()
@trace_method
diff --git a/letta/services/file_processor/file_processor.py b/letta/services/file_processor/file_processor.py
index c69dd7eb8..14e492be7 100644
--- a/letta/services/file_processor/file_processor.py
+++ b/letta/services/file_processor/file_processor.py
@@ -253,7 +253,7 @@ class FileProcessor:
return all_passages
except Exception as e:
- logger.error("File processing failed for %s: %s", filename, e)
+ logger.exception("File processing failed for %s: %s", filename, e)
log_event(
"file_processor.processing_failed",
{