Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

fix: broken pagination for objects with missing created_at [LET-6699] (#8139)

cthomasd489d8837fe3
diff --git a/letta/orm/sqlalchemy_base.py b/letta/orm/sqlalchemy_base.py
index bb2e9ffa0..1ad6c6268 100644
--- a/letta/orm/sqlalchemy_base.py
+++ b/letta/orm/sqlalchemy_base.py
@@ -260,28 +260,40 @@ class SqlalchemyBase(CommonSqlalchemyMetaMixins, Base):
if before_obj and after_obj:
# Window-based query - get records between before and after
- conditions.append(
- or_(cls.created_at < before_obj.created_at, and_(cls.created_at == before_obj.created_at, cls.id < before_obj.id))
- )
- conditions.append(
- or_(cls.created_at > after_obj.created_at, and_(cls.created_at == after_obj.created_at, cls.id > after_obj.id))
- )
+ # Skip pagination if either object has null created_at
+ if before_obj.created_at is not None and after_obj.created_at is not None:
+ conditions.append(
+ or_(cls.created_at < before_obj.created_at, and_(cls.created_at == before_obj.created_at, cls.id < before_obj.id))
+ )
+ conditions.append(
+ or_(cls.created_at > after_obj.created_at, and_(cls.created_at == after_obj.created_at, cls.id > after_obj.id))
+ )
+ else:
+ logger.warning(
+ f"Skipping pagination: before_obj.created_at={before_obj.created_at}, after_obj.created_at={after_obj.created_at}"
+ )
else:
# Pure pagination query
if before_obj:
- conditions.append(
- or_(
- cls.created_at < before_obj.created_at if ascending else cls.created_at > before_obj.created_at,
- and_(cls.created_at == before_obj.created_at, cls.id < before_obj.id),
+ if before_obj.created_at is not None:
+ conditions.append(
+ or_(
+ cls.created_at < before_obj.created_at if ascending else cls.created_at > before_obj.created_at,
+ and_(cls.created_at == before_obj.created_at, cls.id < before_obj.id),
+ )
)
- )
+ else:
+ logger.warning(f"Skipping 'before' pagination: before_obj.created_at is None (id={before_obj.id})")
if after_obj:
- conditions.append(
- or_(
- cls.created_at > after_obj.created_at if ascending else cls.created_at < after_obj.created_at,
- and_(cls.created_at == after_obj.created_at, cls.id > after_obj.id),
+ if after_obj.created_at is not None:
+ conditions.append(
+ or_(
+ cls.created_at > after_obj.created_at if ascending else cls.created_at < after_obj.created_at,
+ and_(cls.created_at == after_obj.created_at, cls.id > after_obj.id),
+ )
)
- )
+ else:
+ logger.warning(f"Skipping 'after' pagination: after_obj.created_at is None (id={after_obj.id})")
if conditions:
query = query.where(and_(*conditions))
diff --git a/letta/services/source_manager.py b/letta/services/source_manager.py
index af050cf60..a2673cc93 100644
--- a/letta/services/source_manager.py
+++ b/letta/services/source_manager.py
@@ -151,6 +151,10 @@ class SourceManager:
source_dict["_last_updated_by_id"] = actor.id
source_dict["organization_id"] = actor.organization_id
+ # Remove created_at if it's None to let database default handle it
+ if source_dict.get("created_at") is None:
+ source_dict.pop("created_at", None)
+
# filter to only include columns that exist in the table
filtered_dict = {k: v for k, v in source_dict.items() if k in valid_columns}
insert_data.append(filtered_dict)