Skip to content

armgit / letta

Public Imported from GitHub
0

Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.

feat: add more indexes (#4849)

Charles Packerd748d860596c
diff --git a/alembic/versions/3d2e9fb40a3c_add_indexes_for_feedback.py b/alembic/versions/3d2e9fb40a3c_add_indexes_for_feedback.py
new file mode 100644
index 000000000..eb669aaa9
--- /dev/null
+++ b/alembic/versions/3d2e9fb40a3c_add_indexes_for_feedback.py
@@ -0,0 +1,68 @@
+"""Add additional indexes
+
+Revision ID: 3d2e9fb40a3c
+Revises: 57bcea83af3f
+Create Date: 2025-09-20 00:00:00.000000
+
+"""
+
+from typing import Sequence, Union
+
+import sqlalchemy as sa
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision: str = "3d2e9fb40a3c"
+down_revision: Union[str, None] = "57bcea83af3f"
+branch_labels: Union[str, Sequence[str], None] = None
+depends_on: Union[str, Sequence[str], None] = None
+
+
+def _create_index_if_missing(index_name: str, table_name: str, columns: list[str], unique: bool = False) -> None:
+ """Create an index if it does not already exist.
+
+ Uses SQLAlchemy inspector to avoid duplicate index errors across environments.
+ """
+ bind = op.get_bind()
+ inspector = sa.inspect(bind)
+ existing = {ix["name"] for ix in inspector.get_indexes(table_name)}
+ if index_name not in existing:
+ op.create_index(index_name, table_name, columns, unique=unique)
+
+
+def upgrade() -> None:
+ # files_agents: speed up WHERE agent_id IN (...)
+ _create_index_if_missing("ix_files_agents_agent_id", "files_agents", ["agent_id"])
+
+ # block: speed up common org+deployment filters
+ _create_index_if_missing(
+ "ix_block_organization_id_deployment_id",
+ "block",
+ ["organization_id", "deployment_id"],
+ )
+
+ # agents: speed up common org+deployment filters
+ _create_index_if_missing(
+ "ix_agents_organization_id_deployment_id",
+ "agents",
+ ["organization_id", "deployment_id"],
+ )
+
+ # Note: The index on block.current_history_entry_id (ix_block_current_history_entry_id)
+ # already exists from prior migrations. If drift is suspected, consider verifying
+ # and recreating it manually to avoid duplicate indexes under different names.
+
+
+def downgrade() -> None:
+ # Drop indexes added in this migration (ignore if missing for portability)
+ for name, table in [
+ ("ix_agents_organization_id_deployment_id", "agents"),
+ ("ix_block_organization_id_deployment_id", "block"),
+ ("ix_files_agents_agent_id", "files_agents"),
+ ]:
+ try:
+ op.drop_index(name, table_name=table)
+ except Exception:
+ # Be permissive in environments where indexes may have different names
+ pass
diff --git a/letta/orm/agent.py b/letta/orm/agent.py
index 16e030a3c..bb12d53ae 100644
--- a/letta/orm/agent.py
+++ b/letta/orm/agent.py
@@ -38,6 +38,7 @@ class Agent(SqlalchemyBase, OrganizationMixin, ProjectMixin, TemplateEntityMixin
__table_args__ = (
Index("ix_agents_created_at", "created_at", "id"),
Index("ix_agents_organization_id", "organization_id"),
+ Index("ix_agents_organization_id_deployment_id", "organization_id", "deployment_id"),
)
# agent generates its own id
diff --git a/letta/orm/block.py b/letta/orm/block.py
index 260239880..de5eafc35 100644
--- a/letta/orm/block.py
+++ b/letta/orm/block.py
@@ -30,6 +30,7 @@ class Block(OrganizationMixin, SqlalchemyBase, ProjectMixin, TemplateEntityMixin
Index("ix_block_is_template", "is_template"),
Index("ix_block_hidden", "hidden"),
Index("ix_block_org_project_template", "organization_id", "project_id", "is_template"),
+ Index("ix_block_organization_id_deployment_id", "organization_id", "deployment_id"),
)
template_name: Mapped[Optional[str]] = mapped_column(
diff --git a/letta/orm/files_agents.py b/letta/orm/files_agents.py
index 1c768711d..0202b34f5 100644
--- a/letta/orm/files_agents.py
+++ b/letta/orm/files_agents.py
@@ -32,6 +32,8 @@ class FileAgent(SqlalchemyBase, OrganizationMixin):
# helpful indexes for look-ups
Index("ix_file_agent", "file_id", "agent_id"),
Index("ix_agent_filename", "agent_id", "file_name"),
+ # improve lookups by agent alone (e.g., WHERE agent_id IN (...))
+ Index("ix_files_agents_agent_id", "agent_id"),
)
__pydantic_model__ = PydanticFileAgent