Platform for stateful agents: AI with advanced memory that can learn and self-improve over time.
fix: non-streaming conversation messages endpoint (#9159)
cthomasd992aa0df4d9
diff --git a/fern/openapi.json b/fern/openapi.jsonindex c10e53afc..92eac32f4 100644--- a/fern/openapi.json+++ b/fern/openapi.json@@ -8859,7 +8859,7 @@"content": {"application/json": {"schema": {- "$ref": "#/components/schemas/LettaStreamingResponse"+ "$ref": "#/components/schemas/LettaResponse"},"description": "JSON response (when streaming=false)"},diff --git a/letta/server/rest_api/routers/v1/conversations.py b/letta/server/rest_api/routers/v1/conversations.pyindex 1269c9e96..88dff4746 100644--- a/letta/server/rest_api/routers/v1/conversations.py+++ b/letta/server/rest_api/routers/v1/conversations.py@@ -7,15 +7,18 @@ from starlette.responses import StreamingResponsefrom letta.agents.agent_loop import AgentLoopfrom letta.agents.letta_agent_v3 import LettaAgentV3+from letta.constants import REDIS_RUN_ID_PREFIXfrom letta.data_sources.redis_client import NoopAsyncRedisClient, get_redis_clientfrom letta.errors import LettaExpiredError, LettaInvalidArgumentError, NoActiveRunsToCancelErrorfrom letta.helpers.datetime_helpers import get_utc_timefrom letta.log import get_loggerfrom letta.schemas.conversation import Conversation, CreateConversation, UpdateConversationfrom letta.schemas.enums import RunStatus+from letta.schemas.job import LettaRequestConfigfrom letta.schemas.letta_message import LettaMessageUnionfrom letta.schemas.letta_request import ConversationMessageRequest, LettaStreamingRequest, RetrieveStreamRequestfrom letta.schemas.letta_response import LettaResponse, LettaStreamingResponse+from letta.schemas.run import Run as PydanticRunfrom letta.server.rest_api.dependencies import HeaderParams, get_headers, get_letta_serverfrom letta.server.rest_api.redis_stream_manager import redis_sse_stream_generatorfrom letta.server.rest_api.streaming_response import (@@ -157,7 +160,7 @@ async def list_conversation_messages(@router.post("/{conversation_id}/messages",- response_model=LettaStreamingResponse,+ response_model=LettaResponse,operation_id="send_conversation_message",responses={200: {@@ -233,10 +236,31 @@ async def send_conversation_message()agent = agent.model_copy(update={"llm_config": override_llm_config})+ # Create a run for execution tracking+ run = None+ if settings.track_agent_run:+ runs_manager = RunManager()+ run = await runs_manager.create_run(+ pydantic_run=PydanticRun(+ agent_id=conversation.agent_id,+ background=False,+ metadata={+ "run_type": "send_conversation_message",+ },+ request_config=LettaRequestConfig.from_letta_request(request),+ ),+ actor=actor,+ )++ # Set run_id in Redis for cancellation support+ redis_client = await get_redis_client()+ await redis_client.set(f"{REDIS_RUN_ID_PREFIX}:{conversation.agent_id}", run.id if run else None)+agent_loop = AgentLoop.load(agent_state=agent, actor=actor)return await agent_loop.step(request.messages,max_steps=request.max_steps,+ run_id=run.id if run else None,use_assistant_message=request.use_assistant_message,include_return_message_types=request.include_return_message_types,client_tools=request.client_tools,diff --git a/tests/integration_test_send_message_v2.py b/tests/integration_test_send_message_v2.pyindex 124b1a5bd..ae50815b3 100644--- a/tests/integration_test_send_message_v2.py+++ b/tests/integration_test_send_message_v2.py@@ -32,12 +32,12 @@ logger = logging.getLogger(__name__)all_configs = [- "openai-gpt-4o-mini.json",- "openai-gpt-4.1.json",+ # "openai-gpt-4o-mini.json",+ # "openai-gpt-4.1.json","openai-gpt-5.json","claude-4-5-sonnet.json",- "gemini-2.5-pro.json",- "zai-glm-4.6.json",+ # "gemini-2.5-pro.json",+ # "zai-glm-4.6.json",]@@ -1017,6 +1017,65 @@ async def test_conversation_streaming_raw_http(assert "assistant_message" in message_types, f"Expected assistant_message in {message_types}"+ "model_config",+ TESTED_MODEL_CONFIGS,+ ids=[handle for handle, _ in TESTED_MODEL_CONFIGS],+)[email protected](loop_scope="function")+async def test_conversation_non_streaming_raw_http(+ disable_e2b_api_key: Any,+ client: AsyncLetta,+ server_url: str,+ agent_state: AgentState,+ model_config: Tuple[str, dict],+) -> None:+ """+ Test conversation-based non-streaming functionality using raw HTTP requests.++ This test verifies that:+ 1. A conversation can be created for an agent+ 2. Messages can be sent to the conversation without streaming (streaming=False)+ 3. The JSON response contains the expected message types+ """+ import httpx++ model_handle, model_settings = model_config+ agent_state = await client.agents.update(agent_id=agent_state.id, model=model_handle, model_settings=model_settings)++ async with httpx.AsyncClient(base_url=server_url, timeout=60.0) as http_client:+ # Create a conversation for the agent+ create_response = await http_client.post(+ "/v1/conversations/",+ params={"agent_id": agent_state.id},+ json={},+ )+ assert create_response.status_code == 200, f"Failed to create conversation: {create_response.text}"+ conversation = create_response.json()+ assert conversation["id"] is not None+ assert conversation["agent_id"] == agent_state.id++ # Send a message to the conversation using NON-streaming mode+ response = await http_client.post(+ f"/v1/conversations/{conversation['id']}/messages",+ json={+ "messages": [{"role": "user", "content": f"Reply with the message '{USER_MESSAGE_RESPONSE}'."}],+ "streaming": False, # Non-streaming mode+ },+ )+ assert response.status_code == 200, f"Failed to send message: {response.text}"++ # Parse JSON response (LettaResponse)+ result = response.json()+ assert "messages" in result, f"Expected 'messages' in response: {result}"+ messages = result["messages"]++ # Verify the response contains expected message types+ assert len(messages) > 0, "Expected at least one message in response"+ message_types = [msg.get("message_type") for msg in messages]+ assert "assistant_message" in message_types, f"Expected assistant_message in {message_types}"++@pytest.mark.parametrize("model_handle,provider_type",[