Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Merge PR #1484: Add Vietnamese interface translation

aiongg05f31758fda7
diff --cc crates/ui-egui/src/i18n.rs
index 1030ed4f1,97be29b6a..b0f3b1ec5
--- a/crates/ui-egui/src/i18n.rs
+++ b/crates/ui-egui/src/i18n.rs
@@@ -126,13 -126,7 +126,14 @@@ language_table!
Ru, "ru", "Русский", "Cyrl", include_str!("../locales/ru.json");
Fr, "fr", "Français", "Latn", include_str!("../locales/fr.json");
Uk, "uk", "Українська", "Cyrl", include_str!("../locales/uk.json");
+ Pl, "pl", "Polski", "Latn", include_str!("../locales/pl.json");
+ Cs, "cs", "Čeština", "Latn", include_str!("../locales/cs.json");
+ It, "it", "Italiano", "Latn", include_str!("../locales/it.json");
+ Ka, "ka", "ქართული", "Geor", include_str!("../locales/ka.json");
+ Sv, "sv", "Svenska", "Latn", include_str!("../locales/sv.json");
+ Fi, "fi", "Suomi", "Latn", include_str!("../locales/fi.json");
+ Id, "id", "Bahasa Indonesia", "Latn", include_str!("../locales/id.json");
+ Vi, "vi", "Tiếng Việt", "Latn", include_str!("../locales/vi.json");
}
// The settings file stores the BCP-47 code (`"zh-hans"`), never the Rust variant name, so a
@@@ -904,13 -671,7 +908,14 @@@ mod tests
("app.language.german", Locale::De),
("app.language.russian", Locale::Ru),
("app.language.ukrainian", Locale::Uk),
+ ("app.language.polish", Locale::Pl),
+ ("app.language.czech", Locale::Cs),
+ ("app.language.italian", Locale::It),
+ ("app.language.georgian", Locale::Ka),
+ ("app.language.swedish", Locale::Sv),
+ ("app.language.finnish", Locale::Fi),
+ ("app.language.indonesian", Locale::Id),
+ ("app.language.vietnamese", Locale::Vi),
];
// One command per language, and every command reachable from the menu table.
assert_eq!(commands.len(), Locale::ALL.len());
diff --cc crates/ui-egui/src/menus.rs
index 51c1887a5,4636162ca..74b029eef
--- a/crates/ui-egui/src/menus.rs
+++ b/crates/ui-egui/src/menus.rs
@@@ -24,13 -24,7 +24,14 @@@ pub const LANGUAGE_COMMANDS: &[UiComman
("app.language.german", crate::i18n::Locale::De.name(), None, "Edit>Language"),
("app.language.russian", crate::i18n::Locale::Ru.name(), None, "Edit>Language"),
("app.language.ukrainian", crate::i18n::Locale::Uk.name(), None, "Edit>Language"),
+ ("app.language.polish", crate::i18n::Locale::Pl.name(), None, "Edit>Language"),
+ ("app.language.czech", crate::i18n::Locale::Cs.name(), None, "Edit>Language"),
+ ("app.language.italian", crate::i18n::Locale::It.name(), None, "Edit>Language"),
+ ("app.language.georgian", crate::i18n::Locale::Ka.name(), None, "Edit>Language"),
+ ("app.language.swedish", crate::i18n::Locale::Sv.name(), None, "Edit>Language"),
+ ("app.language.finnish", crate::i18n::Locale::Fi.name(), None, "Edit>Language"),
+ ("app.language.indonesian", crate::i18n::Locale::Id.name(), None, "Edit>Language"),
+ ("app.language.vietnamese", crate::i18n::Locale::Vi.name(), None, "Edit>Language"),
];
/// Every UI command: the languages, then everything else. `xtask parity` reads both tables from
@@@ -53,13 -47,7 +54,14 @@@ pub fn language_from_command(id: &str)
"app.language.german" => Some(crate::i18n::Locale::De),
"app.language.russian" => Some(crate::i18n::Locale::Ru),
"app.language.ukrainian" => Some(crate::i18n::Locale::Uk),
+ "app.language.polish" => Some(crate::i18n::Locale::Pl),
+ "app.language.czech" => Some(crate::i18n::Locale::Cs),
+ "app.language.italian" => Some(crate::i18n::Locale::It),
+ "app.language.georgian" => Some(crate::i18n::Locale::Ka),
+ "app.language.swedish" => Some(crate::i18n::Locale::Sv),
+ "app.language.finnish" => Some(crate::i18n::Locale::Fi),
+ "app.language.indonesian" => Some(crate::i18n::Locale::Id),
+ "app.language.vietnamese" => Some(crate::i18n::Locale::Vi),
_ => None,
}
}
diff --cc docs/localization-parity.md
index 137c77a4a,36072a006..dcb5a0558
--- a/docs/localization-parity.md
+++ b/docs/localization-parity.md
@@@ -1,12 -1,12 +1,12 @@@
# Localization parity
- > **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-19 · **Change:** minor (Indonesian and Finnish interface catalogs added; Italian: every interface string translated, native-speaker corrections; previously minor: de, es, fr, ja, uk catalogs filled; re-measured; Italian and Georgian interface catalogs added) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6
-> **Last reviewed:** 2026-10-13 · **Last updated:** 2026-10-13 · **Change:** minor (Vietnamese shipped; denominator remeasured) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6
++> **Last reviewed:** 2026-10-13 · **Last updated:** 2026-10-19 · **Change:** minor (Indonesian and Finnish interface catalogs added; Italian: every interface string translated, native-speaker corrections; Vietnamese shipped; previously minor: de, es, fr, ja, uk catalogs filled; re-measured; Italian and Georgian interface catalogs added) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6
How far each interface language is from `full`. How to add or maintain a language is in
[localization.md](localization.md); per-language notes are in `localization-<code>.md`
([zh-hans](localization-zh-hans.md), [zh-hant](localization-zh-hant.md), [ja](localization-ja.md),
[pt-br](localization-pt-br.md), [es](localization-es.md), [de](localization-de.md),
- [ru](localization-ru.md), [fi](localization-fi.md), [ka](localization-ka.md), [id](localization-id.md)).
-[ru](localization-ru.md), [vi](localization-vi.md)).
++[ru](localization-ru.md), [fi](localization-fi.md), [ka](localization-ka.md), [id](localization-id.md), [vi](localization-vi.md)).
## The target
@@@ -45,20 -45,20 +45,20 @@@ that is promising but is not recorded a
| # | Language | Code | UI strings translated | Dialogs / tooltips / help | Script support | Native review | Status | To `full` |
|---|---|---|---:|---|---|---|---|---:|
-| 1 | English | `en` | 2,471 / 2,471 (100%, source) | all; Help ▸ What's New and the shortcut sheet; no full user manual | Latin (Inter) | n/a | **full** | 0 h |
-| 2 | Simplified Chinese | `zh-hans` | 2,223 / 2,471 (90%) | menus, panels, dialogs, presets, profiles, dates; lower-layer errors English | Hans via craft-fonts (Noto Sans CJK SC); IME through winit; no vertical text in UI (not in target either) | no (community edits) | partial | 5–9 h |
-| 3 | Spanish | `es` | 2,209 / 2,471 (89%) | as zh-hans | Latin | no (community edits) | partial | 5–9 h |
+| 1 | English | `en` | 2,304 / 2,304 (100%, source) | all; Help ▸ What's New and the shortcut sheet; no full user manual | Latin (Inter) | n/a | **full** | 0 h |
+| 2 | Simplified Chinese | `zh-hans` | 1,994 / 2,304 (87%) | menus, panels, dialogs, presets, profiles, dates; lower-layer errors English | Hans via craft-fonts (Noto Sans CJK SC); IME through winit; no vertical text in UI (not in target either) | no (community edits) | partial | 6–10 h |
+| 3 | Spanish | `es` | 2,362 / 2,398 (98%; 2026-10-12) | as zh-hans | Latin | no (community edits) | partial | 2–4 h (native review, lower-layer errors) |
| 4 | Hindi | `hi` | 0 (0%) | none | **Devanagari shaping missing** (egui has no complex shaping) | no | none (target: not shipped) | 50–90 h (shaping 25–50 h, shared with Arabic) |
| 5 | Arabic | `ar` | 0 (0%) | none | **RTL layout and Arabic shaping missing** | no | none (target: not shipped) | 60–110 h (RTL mirroring 30–50 h + shaping, shared with Hindi) |
-| 6 | French | `fr` | 2,113 / 2,471 (85%) | as zh-hans | Latin | no (community edits) | partial | 5–9 h |
-| 7 | Portuguese (Brazil) | `pt-br` | 2,106 / 2,471 (85%) | as zh-hans | Latin | no (community edits) | partial | 6–10 h |
-| 8 | Indonesian | `id` | 0 (0%) | none | Latin (Inter covers it) | no | none (target: not shipped) | 10–16 h |
-| 9 | Japanese | `ja` | 2,097 / 2,471 (85%) | as zh-hans; vertical export watermarks | Jpan via craft-fonts (BIZ UDPGothic / UDMincho); IME through winit | no (community edits) | partial | 6–10 h |
-| 10 | German | `de` | 2,210 / 2,471 (89%) | as zh-hans; What's New translated line by line | Latin | no (community edits) | partial | 4–8 h |
+| 6 | French | `fr` | 2,315 / 2,398 (97%; 2026-10-12, the rest are words spelled the same) | as zh-hans | Latin | no (community edits) | partial | 2–4 h (native review, lower-layer errors) |
+| 7 | Portuguese (Brazil) | `pt-br` | 1,966 / 2,304 (85%) | as zh-hans | Latin | no (community edits) | partial | 6–10 h |
+| 8 | Indonesian | `id` | 2,555 / 2,555 (100%; 2026-10-19: every plain and formats message any catalog has, plus 69 command labels; What's New left in English) | as zh-hans | Latin (Inter covers it) | no (written with an agent; native-speaker pass pending) | partial (target: not shipped) | 2–4 h (native review, lower-layer errors) |
+| 9 | Japanese | `ja` | 2,383 / 2,398 (99%; 2026-10-12) | as zh-hans; vertical export watermarks | Jpan via craft-fonts (BIZ UDPGothic / UDMincho); IME through winit | no (community edits) | partial | 2–4 h (native review, lower-layer errors) |
+| 10 | German | `de` | 2,338 / 2,398 (97%; 2026-10-12, the rest are words spelled the same) | as zh-hans; What's New translated line by line | Latin | no (community edits) | partial | 2–4 h (native review, lower-layer errors) |
| 11 | Korean | `ko` | 0 (0%) | none | **no Korean (Hangul) face**: needs a non-Adobe OFL face in craft-fonts (Noto CJK is allowed only for Chinese) | no | none | 14–22 h |
- | 12 | Vietnamese | `vi` | 0 (0%) | none | Latin with stacked diacritics (Inter covers it; check combining marks) | no | none (target: not shipped) | 10–16 h |
+ | 12 | Vietnamese | `vi` | 2,471 / 2,471 (100% key coverage of current union; intentional English like `ISO`/`OK` kept) | menus, panels, dialogs, presets, profiles, dates, formats; lower-layer errors English | Latin with stacked diacritics (Inter) | no (community contribution) | partial (catalog complete; lower-layer errors English) | 1–3 h |
-## Other languages LightCraft ships (3)
+## Other languages LightCraft ships (4)
| Language | Code | UI strings translated | Script | Native review | Status | To `full` |
|---|---|---:|---|---|---|---:|
@@@ -94,11 -89,5 +94,12 @@@ Target languages LightCraft lacks: Kore
| Date | Change | Summary |
|---|---|---|
+| 2026-10-19 | minor | Indonesian interface catalog (`id`): every plain and formats message any catalog has, plus 69 command labels; What's New left in English |
+| 2026-10-17 | minor | Finnish interface catalog (`fi`): 2,610 of 3,308 messages (2,313 plain + 297 formats), What's New left in English |
+| 2026-10-15 | trivial | Italian (`it`): 339 interface messages and 60 format strings that were missing or still in English translated (2,628 of 3,278; only What's New left in English); native-speaker corrections: Exposure → *Esposizione*, Sharpening → *Nitidezza*, Preset → *Preset*, blurry → *sfocate* |
+ | 2026-10-13 | minor | Remeasured denominator (2,222 plain + 249 formats = 2,471); Vietnamese catalog complete at 2,471/2,471 (status partial: lower-layer errors still English) |
+| 2026-10-12 | minor | Italian interface catalog (`it`): 2,201 of 2,398 messages, What's New left in English |
+| 2026-10-11 | minor | Shared work: the interface decides on error kinds, not English error text (#1046) |
+| 2026-10-12 | minor | Georgian (`ka`) row: every catalog message |
| 2026-10-10 | major | Created: per-language counts measured from the catalogs, the twelve key languages, script support, estimates |
+| 2026-10-12 | minor | de, es, fr, ja and uk catalogs filled to every message another catalog knows (agent translations, native review welcome); those rows re-measured against the current 2,398 messages. Other rows keep their 2026-10-10 counts (open PRs for pt-BR, ru, zh) |
diff --cc docs/localization.md
index 10fc68fa2,7f40c32fa..94abfe236
--- a/docs/localization.md
+++ b/docs/localization.md
@@@ -2,11 -2,13 +2,11 @@@
The interface ships in the language it is written in (English) plus every language in the table in
`crates/ui-egui/src/i18n.rs`. Today that is English, Simplified Chinese (`zh-hans`), Traditional
- Chinese (`zh-hant`, Taiwan), Japanese (`ja`), Brazilian Portuguese (`pt-br`), Spanish (`es`), German (`de`), Russian (`ru`), French (`fr`), Ukrainian (`uk`), Czech (`cs`), Georgian (`ka`), Swedish (`sv`), Finnish (`fi`) and Indonesian (`id`). This file is the reference for **adding or maintaining a language**; the per-language notes
-Chinese (`zh-hant`, Taiwan), Japanese (`ja`), Brazilian Portuguese (`pt-br`), Spanish (`es`), German (`de`),
-Russian (`ru`), French (`fr`), Ukrainian (`uk`) and Vietnamese (`vi`). This file is the reference for
-**adding or maintaining a language**; the per-language notes are in
-[`localization-zh-hans.md`](localization-zh-hans.md), [`localization-zh-hant.md`](localization-zh-hant.md),
-[`localization-ja.md`](localization-ja.md), [`localization-pt-br.md`](localization-pt-br.md),
-[`localization-es.md`](localization-es.md), [`localization-de.md`](localization-de.md),
-[`localization-ru.md`](localization-ru.md) and [`localization-vi.md`](localization-vi.md).
++Chinese (`zh-hant`, Taiwan), Japanese (`ja`), Brazilian Portuguese (`pt-br`), Spanish (`es`), German (`de`), Russian (`ru`), French (`fr`), Ukrainian (`uk`), Czech (`cs`), Georgian (`ka`), Swedish (`sv`), Finnish (`fi`), Indonesian (`id`) and Vietnamese (`vi`). This file is the reference for **adding or maintaining a language**; the per-language notes
+are in [`localization-zh-hans.md`](localization-zh-hans.md), [`localization-zh-hant.md`](localization-zh-hant.md),
+[`localization-ja.md`](localization-ja.md), [`localization-pt-br.md`](localization-pt-br.md), [`localization-es.md`](localization-es.md),
+[`localization-de.md`](localization-de.md), [`localization-ru.md`](localization-ru.md),
- [`localization-cs.md`](localization-cs.md), [`localization-fi.md`](localization-fi.md), [`localization-ka.md`](localization-ka.md) and [`localization-id.md`](localization-id.md).
++[`localization-cs.md`](localization-cs.md), [`localization-fi.md`](localization-fi.md), [`localization-ka.md`](localization-ka.md), [`localization-id.md`](localization-id.md) and [`localization-vi.md`](localization-vi.md).
## Adding a language
@@@ -31,10 -33,7 +31,11 @@@
De, "de", "Deutsch", "Latn", include_str!("../locales/de.json");
Ru, "ru", "Русский", "Cyrl", include_str!("../locales/ru.json");
Uk, "uk", "Українська", "Cyrl", include_str!("../locales/uk.json");
+ Cs, "cs", "Čeština", "Latn", include_str!("../locales/cs.json");
+ It, "it", "Italiano", "Latn", include_str!("../locales/it.json");
+ Ka, "ka", "ქართული", "Geor", include_str!("../locales/ka.json");
+ Fi, "fi", "Suomi", "Latn", include_str!("../locales/fi.json");
+ Vi, "vi", "Tiếng Việt", "Latn", include_str!("../locales/vi.json");
}
```