Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Issue #989: the Export dialog height test expects the macOS row (Add to Apple Photos, 876 pt)

Alfons Hoogervorst0e53cfc2408d
diff --git a/crates/ui-egui/src/tests_dialog_fit.rs b/crates/ui-egui/src/tests_dialog_fit.rs
index 895a1d864..0014c6bdb 100644
--- a/crates/ui-egui/src/tests_dialog_fit.rs
+++ b/crates/ui-egui/src/tests_dialog_fit.rs
@@ -94,8 +94,10 @@ fn export_dialog_is_unchanged_in_a_tall_window() {
assert_fits(&h, "Export at 1600×1000");
let dialog = rect(&h, "dialog:window");
// (846 tall as before #781: the whole dialog, nothing scrolled away; 615 wide since the
- // format row gained JPEG XL, #780)
- assert!((dialog.height() - 846.0).abs() <= 1.0, "{dialog:?}");
+ // format row gained JPEG XL, #780. On macOS the dialog has one more row, "Add to Apple Photos"
+ // (#236), so it is 876 tall there)
+ let height = if cfg!(target_os = "macos") { 876.0 } else { 846.0 };
+ assert!((dialog.height() - height).abs() <= 1.0, "{dialog:?}");
assert!((dialog.width() - 615.2).abs() <= 1.0, "{dialog:?}");
}