Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Windows packaging: Start Menu/Add-Remove icon, no console window, correct description

Brandon Thomas11ebb3bdb6c4
diff --git a/.github/workflows/packaging-lint.yml b/.github/workflows/packaging-lint.yml
index 41b361cb5..2b53ae6cd 100644
--- a/.github/workflows/packaging-lint.yml
+++ b/.github/workflows/packaging-lint.yml
@@ -47,6 +47,10 @@ jobs:
- name: XML, desktop entry, AppStream, Flatpak manifest
run: |
xmllint --noout packaging/windows/lightcraft.wxs packaging/macos/*.plist* packaging/linux/*.xml*
+ # Windows Installer needs Icon ids ending in .ico or .exe, or shortcuts show a blank icon.
+ if grep -oE '<Icon Id="[^"]*"' packaging/windows/lightcraft.wxs | grep -vE '\.(ico|exe)"$'; then
+ echo "::error::Icon Id must end in .ico or .exe"; exit 1
+ fi
desktop-file-validate packaging/linux/ai.storyteller.lightcraft.desktop
sed -e 's/@VERSION@/0.0.0/' -e 's/@DATE@/2026-01-01/' packaging/linux/ai.storyteller.lightcraft.metainfo.xml.in >"$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
appstreamcli validate --no-net --explain "$RUNNER_TEMP/ai.storyteller.lightcraft.metainfo.xml"
diff --git a/packaging/windows/lightcraft.wxs b/packaging/windows/lightcraft.wxs
index 9d41899d4..375104552 100644
--- a/packaging/windows/lightcraft.wxs
+++ b/packaging/windows/lightcraft.wxs
@@ -17,15 +17,15 @@
Scope="perMachine"
Compressed="yes"
Language="1033">
- <SummaryInformation Description="LightCraft image editor" Manufacturer="Learning Machines LLC" />
+ <SummaryInformation Description="LightCraft photo library and raw developer" Manufacturer="Learning Machines LLC" />
<!-- Same-version upgrades let successive pre-releases of one X.Y.Z replace each other
(MSI versions are numeric, so 1.2.3-rc.1 and 1.2.3-rc.2 are both 1.2.3). -->
<MajorUpgrade AllowSameVersionUpgrades="yes"
DowngradeErrorMessage="A newer version of LightCraft is already installed." />
<MediaTemplate EmbedCab="yes" CompressionLevel="high" />
- <Icon Id="LightcraftIcon" SourceFile="$(var.IconPath)" />
- <Property Id="ARPPRODUCTICON" Value="LightcraftIcon" />
+ <Icon Id="LightcraftIcon.ico" SourceFile="$(var.IconPath)" />
+ <Property Id="ARPPRODUCTICON" Value="LightcraftIcon.ico" />
<Property Id="ARPURLINFOABOUT" Value="https://getartcraft.com/apps/lightcraft" />
<Property Id="ARPURLUPDATEINFO" Value="https://getartcraft.com/apps/lightcraft" />
<Property Id="ARPHELPLINK" Value="https://discord.gg/artcraft" />
@@ -45,8 +45,8 @@
<Component Id="LightcraftApp" Guid="8A1D3A39-F7C1-47B1-97AE-40C80BF82F4A">
<File Id="LightcraftExe" Source="$(var.BinDir)\lightcraft.exe" KeyPath="yes">
<Shortcut Id="StartMenuShortcut" Directory="ProgramMenuFolder" Name="LightCraft"
- Description="LightCraft image editor" WorkingDirectory="INSTALLFOLDER" Advertise="yes"
- Icon="LightcraftIcon" IconIndex="0" />
+ Description="LightCraft photo library and raw developer" WorkingDirectory="INSTALLFOLDER" Advertise="yes"
+ Icon="LightcraftIcon.ico" IconIndex="0" />
</File>
<RegistryValue Root="HKLM" Key="Software\Microsoft\Windows\CurrentVersion\App Paths\lightcraft.exe" Value="[#LightcraftExe]" Type="string" />