Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

M1: tint labelled thumbnails and colour label feedback

Hanmo4256865cf496
diff --git a/apps/lightcraft-web/src/web.rs b/apps/lightcraft-web/src/web.rs
index 6d0483a94..3201bf834 100644
--- a/apps/lightcraft-web/src/web.rs
+++ b/apps/lightcraft-web/src/web.rs
@@ -600,7 +600,7 @@ impl eframe::App for WebApp {
fn logic(&mut self, ctx: &egui::Context, _frame: &mut eframe::Frame) {
for text in safety::take_notices() {
let now = ctx.input(|i| i.time);
- self.app.ui.toast = Some((text, now + NOTICE_SECS));
+ self.app.ui.toast = Some((text, now + NOTICE_SECS, None));
}
self.run_inbox();
self.import_dropped(ctx);
diff --git a/crates/ui-egui/src/lib.rs b/crates/ui-egui/src/lib.rs
index e46e8663f..2b15b4185 100644
--- a/crates/ui-egui/src/lib.rs
+++ b/crates/ui-egui/src/lib.rs
@@ -30,6 +30,8 @@ mod tests_curve;
#[cfg(test)]
mod tests_grid;
#[cfg(test)]
+mod tests_labels;
+#[cfg(test)]
mod tests_library_problem;
#[cfg(test)]
mod tests_masking;
@@ -268,7 +270,8 @@ impl LightcraftApp {
}
let r = self.session.execute(id, &params).map_err(|e| e.to_string());
if r.is_ok() && id == "photo.label" {
- let text = match params.get("label").and_then(Value::as_str).and_then(lightcraft_catalog::ColorLabel::parse) {
+ let label = params.get("label").and_then(Value::as_str).and_then(lightcraft_catalog::ColorLabel::parse);
+ let text = match label {
Some(label) => {
let name =
self.session.catalog.custom_label_name(label).map(str::to_owned).unwrap_or_else(|| i18n::tr(&format!("{label:?}")).into());
@@ -278,7 +281,7 @@ impl LightcraftApp {
};
// Native menu clicks can arrive before logic() updates last_time after an idle gap.
let now = self.tasks.repaint.as_ref().map(|ctx| ctx.input(|i| i.time)).unwrap_or(self.last_time);
- self.ui.toast = Some((text, now + TOAST_SECONDS));
+ self.ui.toast = Some((text, now + TOAST_SECONDS, label));
}
if let Err(e) = &r {
log::warn!("{id}: {e}");
@@ -354,7 +357,7 @@ impl LightcraftApp {
self.ui.unsaved_seen = true;
let t = ctx.input(|i| i.time);
let what = if n == 1 { "1 change".to_string() } else { format!("{n} changes") };
- self.ui.toast = Some((format!("{what} saved in memory but not written to disk: {e} — LightCraft will retry"), t + 6.0));
+ self.ui.toast = Some((format!("{what} saved in memory but not written to disk: {e} — LightCraft will retry"), t + 6.0, None));
}
(None, true) => {
self.ui.unsaved_seen = false;
@@ -372,7 +375,7 @@ impl LightcraftApp {
/// A toast that stays `secs` seconds (messages that say where to look or what to do next).
pub fn toast_for(&mut self, ctx: &egui::Context, text: impl Into<String>, secs: f64) {
let t = ctx.input(|i| i.time);
- self.ui.toast = Some((text.into(), t + secs));
+ self.ui.toast = Some((text.into(), t + secs, None));
}
/// AI masks: apply finished background requests (clicks, descriptions, detail passes) and
@@ -450,7 +453,7 @@ impl LightcraftApp {
/// A toast for an error the user has to read and act on (stays 6 s).
pub fn toast_error(&mut self, ctx: &egui::Context, text: impl Into<String>) {
let t = ctx.input(|i| i.time);
- self.ui.toast = Some((text.into(), t + 6.0));
+ self.ui.toast = Some((text.into(), t + 6.0, None));
}
fn drain_control(&mut self, ctx: &egui::Context) {
diff --git a/crates/ui-egui/src/merge.rs b/crates/ui-egui/src/merge.rs
index bbb5252a6..cf9efd173 100644
--- a/crates/ui-egui/src/merge.rs
+++ b/crates/ui-egui/src/merge.rs
@@ -268,7 +268,7 @@ pub fn poll(app: &mut LightcraftApp, ctx: &egui::Context) {
Err(_) => {
let (f, stage) = t.progress.lock().map(|g| g.clone()).unwrap_or_default();
let now = ctx.input(|i| i.time);
- app.ui.toast = Some((crate::i18n::tr_format!("Merging… {stage} {:.0}%", f * 100.0, stage = stage), now + 0.5));
+ app.ui.toast = Some((crate::i18n::tr_format!("Merging… {stage} {:.0}%", f * 100.0, stage = stage), now + 0.5, None));
ctx.request_repaint_after(std::time::Duration::from_millis(100));
}
}
diff --git a/crates/ui-egui/src/panels/detail.rs b/crates/ui-egui/src/panels/detail.rs
index 3b3622bed..732dd019f 100644
--- a/crates/ui-egui/src/panels/detail.rs
+++ b/crates/ui-egui/src/panels/detail.rs
@@ -1528,11 +1528,15 @@ pub(crate) fn filmstrip(app: &mut LightcraftApp, ui: &mut egui::Ui, r: Rect) {
register(ui.ctx(), format!("film:{}", id.0), cr);
let sel = Some(*id) == active;
let p = ui.painter();
- if sel {
- p.rect_filled(cr, 0.0, t.cell_selected);
+ let label = app.session.catalog.photo(*id).and_then(|ph| ph.label);
+ let base = if sel {
+ t.cell_selected
} else if resp.hovered() {
- p.rect_filled(cr, 0.0, t.cell_selected.gamma_multiply(0.6));
- }
+ t.cell_selected.gamma_multiply(0.6)
+ } else {
+ t.canvas
+ };
+ p.rect_filled(cr, 0.0, crate::theme::label_background(base, label, sel));
let names = app.ui.settings.film_names;
if let Some(ph) = app.session.catalog.photo(*id).filter(|_| names) {
let name = ph.file_name.rsplit_once('.').map(|(n, _)| n).unwrap_or(&ph.file_name);
diff --git a/crates/ui-egui/src/panels/filterbar.rs b/crates/ui-egui/src/panels/filterbar.rs
index c8de2cff8..e12409674 100644
--- a/crates/ui-egui/src/panels/filterbar.rs
+++ b/crates/ui-egui/src/panels/filterbar.rs
@@ -16,15 +16,7 @@ pub const HEIGHT: f32 = 40.0;
const WIDE: f32 = 1240.0;
/// Colour-label swatches (UI colours, our own choice).
-pub fn label_color(l: ColorLabel) -> Color32 {
- match l {
- ColorLabel::Red => Color32::from_rgb(222, 72, 72),
- ColorLabel::Yellow => Color32::from_rgb(232, 196, 58),
- ColorLabel::Green => Color32::from_rgb(88, 176, 92),
- ColorLabel::Blue => Color32::from_rgb(72, 130, 222),
- ColorLabel::Purple => Color32::from_rgb(158, 100, 210),
- }
-}
+pub use crate::theme::label_color;
fn filter(app: &mut LightcraftApp, patch: Value) {
let _ = app.run("library.filter", patch);
diff --git a/crates/ui-egui/src/panels/grid.rs b/crates/ui-egui/src/panels/grid.rs
index e83fec8b4..0a38a6a4a 100644
--- a/crates/ui-egui/src/panels/grid.rs
+++ b/crates/ui-egui/src/panels/grid.rs
@@ -476,7 +476,8 @@ fn cell(app: &mut LightcraftApp, ui: &mut egui::Ui, id: PhotoId, r: Rect, square
let active = app.session.selection.active == Some(id);
let p = ui.painter();
let img_rect = if square {
- p.rect_filled(r, 0.0, if selected { t.cell_selected } else { t.cell });
+ let base = if selected { t.cell_selected } else { t.cell };
+ p.rect_filled(r, 0.0, crate::theme::label_background(base, photo.label, selected));
Rect::from_min_max(r.min + vec2(10.0, 24.0), r.max - vec2(10.0, 10.0))
} else {
r
@@ -539,9 +540,14 @@ fn cell(app: &mut LightcraftApp, ui: &mut egui::Ui, id: PhotoId, r: Rect, square
crate::state::GridBadges::Always => true,
crate::state::GridBadges::Never => false,
};
+ let badge_bar = Rect::from_min_max(pos2(img_rect.left(), img_rect.bottom() - 24.0), img_rect.right_bottom());
+ if !square && photo.label.is_some() {
+ // Justified photos fill the whole cell: reserve the badge footer as coloured chrome.
+ p.rect_filled(badge_bar, 0.0, crate::theme::label_background(t.cell, photo.label, selected));
+ }
if show_badges {
- let bar = Rect::from_min_max(pos2(img_rect.left(), img_rect.bottom() - 24.0), img_rect.right_bottom());
- if resp.hovered() || selected {
+ let bar = badge_bar;
+ if (resp.hovered() || selected) && (square || photo.label.is_none()) {
p.rect_filled(bar, 0.0, Color32::from_black_alpha(120));
}
let mut x = bar.left() + 6.0;
diff --git a/crates/ui-egui/src/panels/mod.rs b/crates/ui-egui/src/panels/mod.rs
index 8317dda78..7b8f1e2dd 100644
--- a/crates/ui-egui/src/panels/mod.rs
+++ b/crates/ui-egui/src/panels/mod.rs
@@ -63,7 +63,7 @@ pub fn resizable_side(
/// The HUD toast at the bottom centre of the canvas.
pub fn toast(app: &mut LightcraftApp, ctx: &egui::Context) {
let now = ctx.input(|i| i.time);
- let Some((text, until)) = app.ui.toast.clone() else { return };
+ let Some((text, until, label)) = app.ui.toast.clone() else { return };
if now > until {
app.ui.toast = None;
return;
@@ -74,11 +74,13 @@ pub fn toast(app: &mut LightcraftApp, ctx: &egui::Context) {
let painter = ctx.layer_painter(egui::LayerId::new(egui::Order::Foreground, egui::Id::new("toast")));
// long messages (a save warning, the web build's notices) wrap within the canvas
let wrap = (canvas.width() - 80.0).clamp(200.0, 720.0);
- let galley = painter.layout(text, t.font(14.0), t.text.gamma_multiply(fade), wrap);
+ let (background, foreground) = label.map(crate::theme::label_toast_colors).unwrap_or((egui::Color32::from_black_alpha(200), t.text));
+ let foreground = foreground.gamma_multiply(fade);
+ let galley = painter.layout(text, t.font(14.0), foreground, wrap);
let size = vec2(galley.size().x + 40.0, (galley.size().y + 22.0).max(40.0));
let r = Rect::from_center_size(pos2(canvas.center().x, canvas.bottom() - 60.0), size);
- painter.rect_filled(r, 6.0, egui::Color32::from_black_alpha((200.0 * fade) as u8));
- painter.galley(r.center() - galley.size() / 2.0, galley, t.text);
+ painter.rect_filled(r, 6.0, background.gamma_multiply(fade));
+ painter.galley(r.center() - galley.size() / 2.0, galley, foreground);
ctx.request_repaint_after(std::time::Duration::from_millis(30));
}
diff --git a/crates/ui-egui/src/shortcuts.rs b/crates/ui-egui/src/shortcuts.rs
index 8c47e1910..b91306cfe 100644
--- a/crates/ui-egui/src/shortcuts.rs
+++ b/crates/ui-egui/src/shortcuts.rs
@@ -434,6 +434,7 @@ mod tests {
h.app.ui.toast = None;
key(&mut h, k, shift);
assert_eq!(h.app.ui.toast.as_ref().map(|t| t.0.as_str()), Some(format!("{name} Label").as_str()));
+ assert_eq!(h.app.ui.toast.as_ref().and_then(|t| t.2), h.app.session.catalog.photo(PhotoId(1)).unwrap().label);
assert_eq!(h.app.session.active(), Some(PhotoId(if shift { 2 } else { 1 })));
}
}
@@ -442,6 +443,7 @@ mod tests {
assert_eq!(h.app.ui.toast.as_ref().map(|t| t.0.as_str()), Some("Purple Label"));
h.app.run("photo.label", json!({"label": "none"})).unwrap();
assert_eq!(h.app.ui.toast.as_ref().map(|t| t.0.as_str()), Some("Color label cleared"));
+ assert!(h.app.ui.toast.as_ref().is_some_and(|t| t.2.is_none()), "clear uses neutral feedback");
h.app.session.execute("label.setNames", &json!({"names": {"red": "Needs review"}})).unwrap();
key(&mut h, "6", false);
assert_eq!(h.app.ui.toast.as_ref().map(|t| t.0.as_str()), Some("Needs review Label"));
diff --git a/crates/ui-egui/src/state.rs b/crates/ui-egui/src/state.rs
index bdbbcf294..452885685 100644
--- a/crates/ui-egui/src/state.rs
+++ b/crates/ui-egui/src/state.rs
@@ -371,9 +371,9 @@ pub struct UiState {
/// Reference view: the reference photo.
#[serde(skip)]
pub reference: Option<u64>,
- /// Transient toast text and its expiry (seconds of app time).
+ /// Transient toast text, expiry (seconds of app time), and optional colour-label styling.
#[serde(skip)]
- pub toast: Option<(String, f64)>,
+ pub toast: Option<(String, f64, Option<lightcraft_catalog::ColorLabel>)>,
/// The result of the last Find Missing Photos (it searches in the background).
#[serde(skip)]
pub last_find_missing: Option<serde_json::Value>,
diff --git a/crates/ui-egui/src/tests_labels.rs b/crates/ui-egui/src/tests_labels.rs
new file mode 100644
index 000000000..8a24b9884
--- /dev/null
+++ b/crates/ui-egui/src/tests_labels.rs
@@ -0,0 +1,80 @@
+//! Rendered regressions: label colour belongs on thumbnail chrome and the label HUD, not pixels.
+
+use std::time::Duration;
+
+use egui::{Color32, ColorImage, Pos2};
+use lightcraft_catalog::{Op, Photo, PhotoId, Source};
+use serde_json::json;
+
+use crate::headless::Headless;
+use crate::state::ViewMode;
+use crate::{LightcraftApp, Services};
+
+fn app(view: ViewMode) -> Headless {
+ let mut s = lightcraft_engine::Session::new();
+ for id in 1..=6 {
+ let p = Photo::new(PhotoId(id), Source::Demo { scene: 1 }, &format!("{id}.jpg"), "JPEG", 640, 480, "2026-10-08");
+ s.catalog.apply(Op::AddPhoto { photo: Box::new(p) }).unwrap();
+ }
+ s.execute("library.sort", &json!({"key": "fileName", "ascending": true, "group": "none"})).unwrap();
+ s.execute("library.select", &json!({"ids": [1]})).unwrap();
+ let mut h = Headless::new(LightcraftApp::new(s, Services { png: None, ..Default::default() }), [1200.0, 800.0], 1.0);
+ h.app.ui.view = view;
+ h.app.ui.right = crate::state::RightPanel::None;
+ h.app.ui.thumb_size = 160.0;
+ assert!(h.settle(Duration::from_secs(30)));
+ h
+}
+
+fn rect(h: &Headless, id: &str) -> egui::Rect {
+ h.app.widgets.iter().find(|(w, _)| w == id).unwrap().1
+}
+
+fn pixel(image: &ColorImage, p: Pos2) -> Color32 {
+ image.pixels[p.y as usize * image.size[0] + p.x as usize]
+}
+
+#[test]
+fn label_tints_grid_and_filmstrip_chrome_without_changing_photo_pixels() {
+ for view in [ViewMode::SquareGrid, ViewMode::PhotoGrid, ViewMode::Detail] {
+ let mut h = app(view);
+ let widget = if view == ViewMode::Detail { "film:1" } else { "thumb:1" };
+ let cell = rect(&h, widget);
+ let sample = if view == ViewMode::PhotoGrid {
+ egui::pos2(cell.right() - 40.0, cell.bottom() - 8.0)
+ } else {
+ egui::pos2(cell.left() + 4.0, cell.center().y)
+ };
+ let neutral = h.paint();
+ let centre = pixel(&neutral, cell.center());
+ let mut colours = Vec::new();
+ for label in ["red", "yellow", "green", "blue", "purple"] {
+ h.app.run("photo.label", json!({"label": label})).unwrap();
+ h.app.ui.toast = None;
+ h.step();
+ let image = h.paint();
+ let c = pixel(&image, sample);
+ assert_ne!(c, pixel(&neutral, sample), "{view:?} {label} must tint the thumbnail surround/footer");
+ assert!(!colours.contains(&c), "each label has a distinct tint: {view:?} {label}");
+ colours.push(c);
+ assert_eq!(pixel(&image, cell.center()), centre, "{view:?} {label} must not tint image pixels");
+ }
+ h.app.run("photo.label", json!({"label": "none"})).unwrap();
+ h.app.ui.toast = None;
+ h.step();
+ assert_eq!(pixel(&h.paint(), sample), pixel(&neutral, sample), "clearing restores neutral chrome");
+ }
+}
+
+#[test]
+fn label_toast_has_pale_colour_and_rating_restores_neutral_style() {
+ let mut h = app(ViewMode::SquareGrid);
+ h.app.run("photo.label", json!({"label": "red"})).unwrap();
+ h.step();
+ let at = egui::pos2(h.app.canvas_rect.unwrap().center().x, h.app.canvas_rect.unwrap().bottom() - 45.0);
+ let red = pixel(&h.paint(), at);
+ assert!(red.r() > 180 && red.r() > red.g() && red.r() > red.b(), "pale red toast: {red:?}");
+ h.request("ui.key", json!({"key": "5"}), Duration::from_secs(20));
+ let rating = pixel(&h.paint(), at);
+ assert!(rating.r() < 80 && rating.r() == rating.g() && rating.g() == rating.b(), "neutral rating toast: {rating:?}");
+}
diff --git a/crates/ui-egui/src/theme.rs b/crates/ui-egui/src/theme.rs
index c77fb0a2f..9534ebb64 100644
--- a/crates/ui-egui/src/theme.rs
+++ b/crates/ui-egui/src/theme.rs
@@ -7,6 +7,28 @@ use egui::{Color32, CornerRadius, FontData, FontDefinitions, FontFamily, FontId,
pub const FONT_SEMIBOLD: &str = "semibold";
+/// Shared colour-label palette for badges, thumbnail surrounds and feedback.
+pub fn label_color(label: lightcraft_catalog::ColorLabel) -> Color32 {
+ use lightcraft_catalog::ColorLabel;
+ match label {
+ ColorLabel::Red => Color32::from_rgb(222, 72, 72),
+ ColorLabel::Yellow => Color32::from_rgb(232, 196, 58),
+ ColorLabel::Green => Color32::from_rgb(88, 176, 92),
+ ColorLabel::Blue => Color32::from_rgb(72, 130, 222),
+ ColorLabel::Purple => Color32::from_rgb(158, 100, 210),
+ }
+}
+
+/// A translucent label colour over thumbnail chrome; selection remains brighter.
+pub fn label_background(base: Color32, label: Option<lightcraft_catalog::ColorLabel>, selected: bool) -> Color32 {
+ label.map_or(base, |l| base.lerp_to_gamma(label_color(l), if selected { 0.32 } else { 0.22 }))
+}
+
+/// Label confirmations use a pale colour and dark text, distinct from neutral/error HUDs.
+pub fn label_toast_colors(label: lightcraft_catalog::ColorLabel) -> (Color32, Color32) {
+ (Color32::WHITE.lerp_to_gamma(label_color(label), 0.3), Color32::from_rgb(36, 24, 24))
+}
+
#[derive(Clone, Copy, Debug)]
pub struct Tokens {
/// Top bar, side panels, bottom bar, tool strip.
diff --git a/docs/library-shortcuts.md b/docs/library-shortcuts.md
index 4adddd514..5305fe57d 100644
--- a/docs/library-shortcuts.md
+++ b/docs/library-shortcuts.md
@@ -17,6 +17,10 @@ menu. Purple has no default number key, matching Lightroom Classic. Rejection ma
culling; it does not delete the original or remove it from the library.
Setting a colour label shows the same brief bottom toast as a rating, using the colour or your
custom label name. Clearing it shows a confirmation too, whether applied by a key, menu or swatch.
+Labelled thumbnails have a translucent matching colour on the square-grid surround, photo-grid
+footer and Detail filmstrip surround. The photo pixels and white active-photo outline remain clear.
+The label confirmation uses a pale matching background with dark text; ratings and errors retain
+their neutral HUD styling. Custom names use the underlying label's colour.
Grid actions apply to all selected photos and support Undo / Redo. In Compare and Survey, culling
actions apply to the active photo. Auto Advance moves forward after an action; holding Shift with
diff --git a/docs/parity.md b/docs/parity.md
index 4fbd41848..47f805c5a 100644
--- a/docs/parity.md
+++ b/docs/parity.md
@@ -60,7 +60,9 @@ that decide whether a photographer can switch (see the honest assessment in [ROA
Take the first one nobody is working on.
Library culling keys now cover ratings, labels and flags with Shift-to-advance (see
-[library shortcuts](library-shortcuts.md), issue #283 and PR #261). **KEYC-RATING** remains partial:
+[library shortcuts](library-shortcuts.md), issue #283 and PR #261). Colour labels also tint thumbnail
+surrounds/footers and use matching pale confirmations, with rendered regressions for all five colours.
+**KEYC-RATING** remains partial:
rating-step keys, flag cycling and filter-bar bindings are still open; Shift+P is contextual.
1. **LR-PROF-CAMERACOLOR** (P0): our own camera colour calibration. Sony ARW and Nikon NEF now get a guarded file-local fit to their own embedded JPEG (colour matrix + hue/saturation/value table + tone and chroma curves, relative WB; per-model profiles pooled from many photos via `lightcraft-cli calibrate`; ARW: 7 of 10 public samples accepted, mean ΔE vs the camera JPEG 17–26 → 3–10; NEF: 13 of 13 decodable samples from 6 bodies accepted, ΔE 13–46 → 3–8, one mixed-light scene 13 → 12); measured calibration and fidelity remain missing. Other non-DNG raws and rejected fits still use a neutral matrix. Expand validated preview fitting and use matrices the files carry themselves; never Adobe data.
@@ -151,7 +153,7 @@ under the UI command that wraps it (a no-op error); the UI command now wins.
| LR-LIB-TARGET | Target album | P2 | ✅ | `cmd:album.setTarget`, `cmd:album.toggleTarget` | see LRC-LIB-COLLECTIONS |
| LR-LIB-RATING | Star ratings | P0 | ✅ | `cmd:photo.rate` (`advance`), `crates/ui-egui/src/shortcuts.rs` | 0 clears; 1–5 set; Shift+0–5 applies and advances once, including with Auto Advance. Batch grid and undo/redo regressions; macOS native ownership corrected (PR #261) |
| LR-LIB-FLAG | Pick / reject flags | P0 | ✅ | `cmd:photo.pick`, `cmd:photo.reject`, `cmd:photo.unflag`, `cmd:photo.flag` | P pick, X reject, U clear; Shift+P picks and advances in both grids (Presets elsewhere); Shift+X/U and legacy Shift+Z advance; no flag cycle; rejection does not delete the file |
-| LR-LIB-LABEL | Colour labels | P1 | ✅ | `cmd:photo.label`, `cmd:label.setNames`, `cmd:label.names`, `cmd:dialog.labelNames`, keys 6–9 in `crates/ui-egui/src/shortcuts.rs` | Photo menu and grid context menu (coloured, named), Info-panel swatches, label dot in grid cells; setting/clearing through keys (including Shift), menus or Info swatches shows the same bottom toast as ratings, with the colour/custom name; editable label names (undoable, journaled); no purple key (as in Lightroom), no custom extra labels |
+| LR-LIB-LABEL | Colour labels | P1 | ✅ | `cmd:photo.label`, `cmd:label.setNames`, `cmd:label.names`, `cmd:dialog.labelNames`, keys 6–9 in `crates/ui-egui/src/shortcuts.rs` | Photo menu and grid context menu (coloured, named), Info-panel swatches, label dot plus translucent colour on square-grid/filmstrip surrounds and photo-grid footers (photo pixels unchanged); colour-label toasts have pale matching backgrounds; setting/clearing through keys (including Shift), menus or Info swatches shows the same bottom toast as ratings, with the colour/custom name; editable label names (undoable, journaled); no purple key (as in Lightroom), no custom extra labels |
| LR-LIB-KEYWORD | Keywords | P0 | ✅ | `cmd:panel.keywords`, `cmd:photo.setMeta` (`addKeywords`/`removeKeywords`), `cmd:keyword.list`, `cmd:keyword.rename`, `cmd:keyword.delete`, `cmd:keyword.merge`, `cmd:keyword.suggest`, `crates/catalog/src/keywords.rs`, `crates/ui-egui/src/panels/left.rs` | left-panel keyword tree with counts (click filters, children included; context menu rename / merge / delete / add / remove); library-wide ops are one undo step and replay from the op log; suggestions (co-occurring / most used / completions) in the Keywords panel; no keyword drag-and-drop |
| LR-LIB-PEOPLE | People / faces | P2 | 🟡 | `cmd:view.people`, `cmd:view.faceBoxes`, `cmd:photo.removeRegion`, `cmd:photo.setRegion`, `cmd:library.filter`, `crates/ui-egui/src/panels/people.rs`, `crates/catalog/src/query.rs` (`people`), `crates/engine/src/media.rs` (`face_job`), `crates/meta/src/xmp.rs` | MVP: named face regions read from XMP (MWG-RS, read-only, see `docs/xmp-interop.md`; clipped to the photo; Lightroom's `Rotation` of ±π/2 and π handled, mirrored orientations taken as written; boxes follow Rotate Left/Right and flips; a sidecar stating `mwg-rs:Regions`, even empty, replaces the photo's on re-read, one without leaves them) become cards in the People view (View ▸ People, or the People button in the toolbar): a close-up of the person's largest face, name and photo count; a click filters the grid (`person` in `library.filter`, `person:` search token, filter chip). Face boxes in the loupe can be switched off (View ▸ Face Boxes, toolbar) resized with eight drag handles and removed with the × shown on hover (catalog-only and undoable, one undo step per drag; the sidecar is never rewritten for either); no moving a box by dragging it yet. No face detection, no unnamed people / suggestions, no manual tagging, no writing regions back |
| LR-LIB-STACK | Stacks | P1 | ✅ | `cmd:stack.group`, `cmd:stack.ungroup`, `cmd:stack.toggle`, `cmd:stack.setTop`, `cmd:stack.remove`, `cmd:stack.auto`, `crates/catalog/src/stacks.rs` | grid/filmstrip count badges, expand/collapse, auto-stack by capture time; no visual-similarity auto-stack |
diff --git a/docs/whats-new.md b/docs/whats-new.md
index e01893cfc..be89ddbcb 100644
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@ -3,6 +3,7 @@
## October 2026
### Library keyboard culling
+- Colour labels tint thumbnail surrounds in Square Grid and the Detail filmstrip, and the footer in Photo Grid. Label confirmations use a matching pale colour; the photo pixels retain their original appearance.
- Setting or clearing a colour label shows a brief bottom confirmation, like rating a photo; custom label names appear in the message too.
- On macOS, ratings `0–5`, labels `6–9` and pick/unflag `P/U` now reach the app even when shown in the native menu (issue #283; adapted from PR #261).
- `Shift+6–9` labels and advances. `Shift+P` picks and advances in Photo Grid and Square Grid; it opens Presets in other views. With Auto Advance on, Shift still moves only once.