Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Merge PR #1666

Brandon Thomas4fe0466942a5
diff --cc crates/raw/src/dngwrite.rs
index 10e032c69,9db6ddf6c..379267c87
--- a/crates/raw/src/dngwrite.rs
+++ b/crates/raw/src/dngwrite.rs
@@@ -112,18 -108,27 +112,27 @@@ pub fn write_dng(raw: &RawImage, opts:
ifd.set(t::PHOTOMETRIC, Value::Short(vec![if raw.cfa.is_some() { photometric::CFA } else { photometric::LINEAR_RAW }]));
ifd.set(t::DNG_VERSION, Value::Byte(vec![1, 4, 0, 0]));
ifd.set(t::DNG_BACKWARD_VERSION, Value::Byte(vec![1, 3, 0, 0]));
- let make = raw.metadata.make.clone().unwrap_or_default();
- let model = raw.metadata.model.clone().unwrap_or_default();
+ let make = raw.metadata.make.as_deref().unwrap_or_default();
+ let model = raw.metadata.model.as_deref().unwrap_or_default();
if !make.is_empty() {
- ifd.set(t::MAKE, Value::Ascii(make.clone()));
+ ifd.set(t::MAKE, Value::Ascii(make.to_owned()));
}
if !model.is_empty() {
- ifd.set(t::MODEL, Value::Ascii(model.clone()));
+ ifd.set(t::MODEL, Value::Ascii(model.to_owned()));
}
- let unique = format!("{make} {model}").trim().to_string();
+ let model_includes_make = !make.is_empty()
+ && model.get(..make.len()).is_some_and(|prefix| prefix.eq_ignore_ascii_case(make))
+ && model.get(make.len()..).is_some_and(|suffix| suffix.chars().next().is_none_or(|c| !c.is_alphanumeric() && c != '_'));
+ let unique = if model_includes_make || make.is_empty() {
+ model.to_owned()
+ } else if model.is_empty() {
+ make.to_owned()
+ } else {
+ format!("{make} {model}")
+ };
ifd.set(t::UNIQUE_CAMERA_MODEL, Value::Ascii(if unique.is_empty() { "LightCraft".into() } else { unique }));
ifd.set(t::ORIENTATION, Value::Short(vec![raw.orientation.to_exif()]));
- ifd.set(t::SOFTWARE, Value::Ascii("LightCraft".into()));
+ ifd.set(t::SOFTWARE, Value::Ascii(SOFTWARE.into()));
let xmp = opts.xmp.clone().unwrap_or_else(|| lightcraft_meta::write_xmp(&raw.metadata, None));
ifd.set(t::XMP, Value::Byte(xmp.into_bytes()));
diff --cc docs/whats-new.md
index 3eace36e6,e9c5bf329..28b549559
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@@ -2,89 -2,11 +2,94 @@@
## 2026-10-13
+### HDR merges keep the lens correction
+- An HDR made with Photo ▸ Photo Merge ▸ HDR now keeps the lens correction the photos carry (Sony's, Panasonic's
+ and Leica's, and the one some DNGs carry, e.g. from drones): Optics ▸ Enable Lens Corrections straightens it as it
+ does the photos it was made from. HDRs merged before this don't have it; merge them again.
+
+### Portable mode
+- A file named `portable.txt` next to the LightCraft program makes it keep its settings, logs and downloaded
+ models in a `LightCraftData` folder beside it instead of the per-user settings folder (issue #1200), as
+ PhotoCraft does. If that folder can't be written, the usual folder is used and the log says why.
+
+### Reliability
+- A photo whose Defringe amount was stored far past the sliders' 20 (in a damaged catalog or sidecar) no longer
+ crashes LightCraft each time it renders: the amount acts as 20.
+
+### Reliability
+- Importing a preset zip that unpacks to far more than any preset (a "zip bomb") is refused with a message naming
+ the file, instead of asking for gigabytes of memory, which could end LightCraft.
+
+### Reliability
+- A crop of no size (from an agent or a sidecar) no longer gives the Detail view a photo of no size to lay out
+ (its width over its height was 0 / 0, which stopped debug builds); it shows as a single pixel's colour.
+
+### Reliability
+- A crop a hair wide (or of no size), set by an agent or read from a sidecar, no longer crashes or hangs the
+ render with Clarity, Dehaze, Texture or Highlights / Shadows on: their blurs are held to the picture's size.
+- A crop of no size with healing spots or masks no longer crashes the render: samples outside the picture read its
+ edge.
+
+### Reliability
+- A library whose catalog file was damaged (or edited by hand) in a way that still reads no longer crashes
+ LightCraft when it shows a stack, or hangs it when a folder is moved: on opening, records are put back under
+ their own ids, stacks keep only photos that exist (at least two), folders inside themselves move to the top,
+ and new photos never reuse an id in use. What was repaired is written to the log.
+
+### Nikon lens corrections
+- Raws from the Nikon Z 6II and Z f now open with the camera's own distortion correction, as Lightroom applies a
+ built-in profile: straight lines near the edges stay straight and the framing matches the camera's JPEG. It works
+ with Z lenses and with F-mount lenses on the FTZ adapter, follows the in-body stabilisation's shift of the optical
+ centre, and can be turned off under Lens Corrections. Vignetting correction from the file comes later.
+
+### Thumbnail cache stays in its folder
+- The thumbnail cache no longer follows a shard folder (`thumbs/ab/`) that is a symlink or junction to somewhere
+ else (issue #1504): trimming or clearing the cache can't delete files outside it, and thumbnails are never read
+ from or written through such a link.
+## 2026-10-13
+
+### Large libraries: Synchronize Folder, import and sidecars start sooner
+- Opening Synchronize Folder, an import review or an import no longer makes a table of every photo in the library
+ before it looks at the first file. In a library of 3.5 million photos that held the window for about 6 s before
+ a Synchronize scan began (now under 1 s), 2.6 s before an import review (now 0.05 s) and 1.7 s before an import
+ (now 0.05 s). The scan looks up only the files it finds and the contents it reads, on its own thread.
+- Writing one photo's XMP sidecar (Save Metadata to File, or automatically after an edit) no longer works out who
+ owns every shared sidecar name in the library: 2.4 s a write in that library, now under 1 s.
+- Nothing else changes: the same files are found new, already there, moved or missing, and sidecars get the same
+ names.
+
+### Faces load faster in the People view
+- Faces on unedited raws are cut from the camera's preview inside the file instead of developing the raw (issue
+ #1440): a Sony α1 face reads 8 MB instead of 70 MB, an A7S III face about 1 MB instead of 24 MB, several times
+ faster on an external hard disk. A face whose preview is too small, and any edited photo, is still developed from
+ the raw, so it keeps its look.
+- Raws whose preview is in Adobe RGB (Sony α1 among others) no longer read the whole file for their grid thumbnail:
+ only the header and the preview are read, as for other raws.
+- Faces are kept in the thumbnail cache at a few fixed sizes, so moving the thumbnail slider no longer renders them
+ all again.
+
+### Reliability
+- A raw file whose black level is stored as "not a number" (or infinity), or a floating-point DNG with such
+ samples, no longer crashes LightCraft at 1:1 or on export: the bad values read as black.
+
+### Reliability
+- Exporting a photo more than 65,535 times as long as it is wide (a one-pixel strip), or opening the Export dialog's
+ watermark preview for it, no longer crashes LightCraft; the export is capped at the encoders' 65,535 pixels.
+
+### Reliability
+- Dragging a Tone Curve point that sits very close to its neighbours (two clicks side by side, or a curve from a
+ sidecar, a preset or an agent) no longer crashes LightCraft; the point stays between them. Curve points sent to
+ `develop.curve` are kept in order, and a sidecar curve with a "NaN" or "inf" point is ignored.
+
+### Reliability
+- A demo photo whose stored size was damaged (a width of 4294967295) is rendered at its own size instead of
+ one that overflows.
+
+ ### DNG camera identity
+ - DNG export and Convert to DNG no longer duplicate the camera make when the model already
+ contains it: `Canon EOS R6` stays `Canon EOS R6`, rather than `Canon Canon EOS R6` (the camera
+ identity subissue in #840). The separate Make and Model tags keep their original values.
+ This does not change colour matrices, camera calibration or RAW noise rendering.
### Slider drags on large raws
- Dragging a slider no longer re-renders the edited photo's filmstrip thumbnail on every frame; it follows once you
let go. On a 64 MP raw the first of those renders decoded the whole file again, which held up the loupe's