LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
LR-PREF-PERFORMANCE: memory budget in Settings → Performance (app.memoryBudget)
Brandon Thomas6228e8f477e1
diff --git a/crates/ui-egui/src/headless.rs b/crates/ui-egui/src/headless.rsindex d5d71500b..72fd66bac 100644--- a/crates/ui-egui/src/headless.rs+++ b/crates/ui-egui/src/headless.rs@@ -404,6 +404,13 @@ mod tests {assert_eq!(h.app.session.cache_mb, 512);h.request("ui.clickWidget", json!({"id": "button:settingsPreview-2"}), t);assert_eq!(h.app.ui.settings.preview_edge, 3840);+ h.request("ui.clickWidget", json!({"id": "button:settingsMemory-2"}), t);+ assert_eq!(h.app.ui.settings.memory_mb, 1024);+ h.step();+ assert_eq!(lightcraft_engine::memory::budget(), 1024 << 20, "applied through app.memoryBudget");+ h.request("ui.clickWidget", json!({"id": "button:settingsMemory-0"}), t);+ h.step();+ assert_eq!(lightcraft_engine::memory::budget(), lightcraft_engine::memory::default_budget(), "back to automatic");// Import: per-camera defaultsh.request("ui.clickWidget", json!({"id": "button:settingsTab-import"}), t);h.request("ui.clickWidget", json!({"id": "check:settings.perCamera"}), t);diff --git a/crates/ui-egui/src/lib.rs b/crates/ui-egui/src/lib.rsindex 22e12e96d..ca0d7085d 100644--- a/crates/ui-egui/src/lib.rs+++ b/crates/ui-egui/src/lib.rs@@ -102,6 +102,8 @@ pub struct LightcraftApp {pub window_is_fullscreen: bool,/// The GPU preference last applied (`app.gpu`), to apply Settings changes once.gpu_applied: Option<bool>,+ /// The memory budget setting last applied (MB, 0 = automatic).+ memory_applied: Option<u32>,}impl LightcraftApp {@@ -134,6 +136,7 @@ impl LightcraftApp {merge: merge::MergeState::default(),window_is_fullscreen: false,gpu_applied: None,+ memory_applied: None,}}@@ -334,6 +337,13 @@ impl LightcraftApp {self.gpu_applied = Some(self.ui.settings.gpu);let _ = self.session.execute("app.gpu", &serde_json::json!({"enabled": self.ui.settings.gpu}));}+ let mb = self.ui.settings.memory_mb;+ // automatic at startup: leave the engine's default alone+ if self.memory_applied != Some(mb) && (mb > 0 || self.memory_applied.is_some()) {+ let mb = if mb == 0 { (lightcraft_engine::memory::default_budget() >> 20) as u32 } else { mb };+ let _ = self.session.execute("app.memoryBudget", &serde_json::json!({"mb": mb}));+ }+ self.memory_applied = Some(mb);if let Some(fs) = ctx.input(|i| i.viewport().fullscreen) {self.window_is_fullscreen = fs;}diff --git a/crates/ui-egui/src/panels/settings.rs b/crates/ui-egui/src/panels/settings.rsindex 2f05aa029..fad8ac511 100644--- a/crates/ui-egui/src/panels/settings.rs+++ b/crates/ui-egui/src/panels/settings.rs@@ -264,6 +264,11 @@ fn performance_tab(app: &mut LightcraftApp, ui: &mut egui::Ui, t: &Tokens) {choices(ui, "settingsPreview", &opts, &mut app.ui.settings.preview_edge);});hint(ui, t, "Largest long edge the Detail view renders at; larger is sharper on big displays but slower.");+ row(ui, t, "Memory for caches", |ui| {+ let auto = format!("Automatic ({} MB)", lightcraft_engine::memory::default_budget() >> 20);+ let opts = [(0u32, auto.as_str()), (512, "512 MB"), (1024, "1 GB"), (2048, "2 GB"), (4096, "4 GB")];+ choices(ui, "settingsMemory", &opts, &mut app.ui.settings.memory_mb);+ });heading(ui, t, "Thumbnail cache");let cur = (app.session.cache_bytes() >> 20) as u32;row(ui, t, "Size limit", |ui| {diff --git a/crates/ui-egui/src/state.rs b/crates/ui-egui/src/state.rsindex 2cd09b7b0..ce5924fac 100644--- a/crates/ui-egui/src/state.rs+++ b/crates/ui-egui/src/state.rs@@ -134,6 +134,8 @@ pub struct AppSettings {pub gpu: bool,/// Largest long edge (pixels) the loupe renders at.pub preview_edge: u32,+ /// Memory the caches may hold together, in MB (0 = automatic; `app.memoryBudget`).+ pub memory_mb: u32,/// Filmstrip: file names above the thumbnails.pub film_names: bool,/// Filmstrip: rating / flag / edited badges on the thumbnails.@@ -150,6 +152,7 @@ impl Default for AppSettings {confirm_delete: false,gpu: true,preview_edge: 2560,+ memory_mb: 0,film_names: true,film_badges: true,grid_badges: GridBadges::Auto,diff --git a/docs/parity.md b/docs/parity.mdindex bf992c44c..8bedebf98 100644--- a/docs/parity.md+++ b/docs/parity.md@@ -468,7 +468,7 @@ under the UI command that wraps it (a no-op error); the UI command now wins.| LR-PREF-LOCALSTORAGE | Storage & cache | P1 | ✅ | `cmd:library.preferences`, `cmd:library.clearPreviews`, `cmd:library.compact` | thumbnail cache size + clear in Settings → Performance; library location + Open Library… in General || LR-PREF-ACCOUNT | Account | OOS | 🚫 | | || LR-PREF-INTERFACE | Interface options | P1 | ✅ | `cmd:app.settings` | filmstrip names/badges, grid badges (auto/always/never), square-grid names, navigator, info overlay |-| LR-PREF-PERFORMANCE | GPU / performance | P1 | ✅ | `cmd:app.gpu`, `cmd:app.settings` | GPU on/off, preview size (1600–5120 px), cache size in Settings |+| LR-PREF-PERFORMANCE | GPU / performance | P1 | ✅ | `cmd:app.gpu`, `cmd:app.memoryBudget`, `cmd:app.settings` | GPU on/off, preview size (1600–5120 px), memory budget, thumbnail cache size in Settings || LR-PREF-PEOPLE | Face recognition | P2 | ⬜ | | || LR-PREF-WATERMARK | Watermark settings | P1 | 🟡 | `crates/ui-egui/src/panels/dialogs.rs` | per export in the dialog; not saved as a preference || LR-PREF-SHORTCUTS | Shortcut customisation | — | 🚫 | | not customisable in the reference app either; a keymap editor would be an extra |