Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

fix: document the deliberate buffer leak during thread teardown (SonarCloud)

Dylan M. Taylor6fb6815cd96b
diff --git a/crates/gpu/src/ctx.rs b/crates/gpu/src/ctx.rs
index 0c3ab8f05..33e02fbe4 100644
--- a/crates/gpu/src/ctx.rs
+++ b/crates/gpu/src/ctx.rs
@@ -118,7 +118,9 @@ impl Drop for Buf {
let mut b = Some(b);
let _ = RETIRED.try_with(|r| r.0.borrow_mut().extend(b.take()));
match b {
- Some(b) => std::mem::forget(b),
+ // Leaking is deliberate during thread teardown — dropping a wgpu buffer whose device
+ // thread-locals have already gone can abort the process. The device owns it.
+ Some(b) => std::mem::forget(b), // NOSONAR
None => {
RETIRED_BYTES.fetch_add(size, Ordering::Relaxed);
}