Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Merge PR #3385: Never crash: a mask id at the u32 limit doesn't overflow the next mask's id

aiongg866ed3846c1d
diff --cc docs/whats-new.md
index 7d43b2ec8,934c3c47f..b494eb8cf
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@@ -2,41 -2,11 +2,46 @@@
## 2026-10-30
+### A colour-range mask keeps at most 64 samples, however it arrives
+- A colour-range mask compares every pixel with every colour it has sampled, so a mask with thousands of samples
+ could stall a render or export, or lose the GPU for the rest of the session. `mask.add` and `mask.update` already
+ kept the first 64; a sidecar's `lc:settings`, a preset, `develop.merge`, `render --settings` and the catalog and
+ edit history now keep the first 64 too, in order, and the extra ones are skipped as they are read. Masks made in
+ the app (up to 5 samples) are unchanged.
+
+### A SAM 3 model in the wrong format says so
+- Object and Describe need `model.safetensors` from `facebook/sam3` in the Hugging Face format. The
+ `sam3.safetensors` on community mirrors is Meta's original checkpoint, with other tensor names; installed in its
+ place, AI masks failed with "unsupported dtype C64". LightCraft now says that the file is Meta's original
+ checkpoint and which file it needs instead.
+
+ ### Reliability
+ - A photo with a mask id at the 32-bit limit (from a damaged or hand-edited sidecar, a paste or an agent) no longer
+ breaks the masks added after it: new masks, duplicates and the masks of a preset each get an id no other mask has.
+ Before, the next id wrapped around to 0, so a second new mask shared the first one's id (debug builds crashed).
+
+## 2026-10-29
+
+### Object and Describe masks show their pins
+- With Show Pins on, an Object mask now has a pin where you first clicked the object, and a Describe mask has one in
+ the middle of what its description found. Before, these masks had no pin on the photo, so they couldn't be picked
+ there. Clicking a pin selects its mask; dragging it changes nothing, as these masks follow what they selected.
+ With the Object tool on, a click on another mask's pin selects that mask too, instead of adding a click to the
+ selected Object mask, and a click on the selected mask's own pin adds nothing. Subject, Sky, Background and the
+ range masks still have no pin.
+
+## 2026-10-27
+
+### The Edit menu groups Select Only Active Photo and Paste Settings from Previous with their kin
+- Select Only Active Photo now sits under Deselect All, and Paste Settings from Previous under Paste Selected Settings…, instead of both after Settings…, near the end of the Edit menu. On macOS, where Settings… lives in the application menu, the Edit menu no longer shows two separator lines in a row.
+
+## 2026-10-25
+
+### `>=` and `<=` work in the search box
+- Fielded search tokens now take inclusive comparisons: `rating:>=3`, `iso:<=400`, `f:>=2.8`, `focal:<=50`. Before,
+ the `=` was read as part of the number, so such a search quietly showed no photos at all.
+
+
## 2026-10-24
### Relative-date filters and smart albums follow the clock