LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Merge PR #1625
Brandon Thomasad2386145488
diff --cc apps/lightcraft/src/main.rsindex f113618ba,a882daa59..d6033f678--- a/apps/lightcraft/src/main.rs+++ b/apps/lightcraft/src/main.rs@@@ -878,15 -859,12 +920,15 @@@ fn main() -> eframe::Resultlet window_gpu::Chosen { renderer, wgpu_options, which: window_renderer, notice: window_notice } = window_gpu::choose(&win_files);win_files.arm(window_renderer);let win_files_app = win_files.clone();+ // the window came up: a failure after this is LightCraft stopping, not a start that failed+ let came_up = std::sync::Arc::new(std::sync::atomic::AtomicBool::new(false));+ let came_up_app = came_up.clone();+ // how the window was when the app was last used (checked: the settings file is a file)+ let opens_as = prefs.as_ref().and_then(|ui| ui.window).and_then(lightcraft_ui_egui::window_place::WindowPlace::checked);let options = eframe::NativeOptions {renderer,- viewport: egui::ViewportBuilder::default()- .with_title("LightCraft")- .with_inner_size([1600.0, 1000.0])- .with_min_inner_size([900.0, 560.0])+ viewport: as_remembered(egui::ViewportBuilder::default().with_title("LightCraft"), opens_as)+ .with_min_inner_size(lightcraft_ui_egui::window_place::MIN_SIZE).with_drag_and_drop(true).with_fullsize_content_view(true).with_titlebar_shown(false)diff --cc docs/parity-checklist.mdindex 0ce441574,9e08afd26..757a4ec4b--- a/docs/parity-checklist.md+++ b/docs/parity-checklist.md@@@ -51,13 -49,13 +51,13 @@@ cited here still exists. Formerly docs/| U. Map & location (MAP) | 0 | 1 | 1 | 0 | — | 0/1 (0%) || V. Preferences (PREF) | 6 | 2 | 2 | 2 | 1/1 (100%) | 4/5 (80%) || W. Cloud & AI infrastructure (CLOUD / AI) | 1 | 0 | 1 | 2 | — | — |- | X. Cross-cutting behaviours (BEHAV) | 23 | 6 | 1 | 1 | 8/8 (100%) | 7/10 (70%) |+ | X. Cross-cutting behaviours (BEHAV) | 23 | 7 | 1 | 1 | 8/8 (100%) | 7/10 (70%) || Y. Menus | 84 | 0 | 4 | 8 | 47/47 (100%) | 23/23 (100%) || Z. Keyboard shortcuts (desktop) | 76 | 4 | 3 | 1 | 49/52 (94%) | 23/25 (92%) |-| Lightroom Classic extras | 34 | 16 | 35 | 8 | — | 24/26 (92%) |-| **Total** | 409 | 54 | 72 | 35 | 193/201 (96%) | 146/159 (92%) |+| Lightroom Classic extras | 36 | 22 | 27 | 8 | — | 24/26 (92%) |+| **Total** | 411 | 59 | 64 | 35 | 193/201 (96%) | 146/159 (92%) |-Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **81.5%** of 535 in-scope rows — P0 98.0% of 201 · P1 95.0% of 159 · P2 50.0% of 174.+Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.5%** of 534 in-scope rows — P0 98.0% of 201 · P1 95.0% of 159 · P2 52.9% of 173.<!-- /parity:summary -->## Top gaps and shortcut notes@@@ -797,11 -791,7 +797,12 @@@ Latin stays upright. Advanced Japanese| Date | Change | Summary ||---|---|---|+| 2026-10-14 | minor | LR-IMP-CAMERA-COVERAGE: 17 uncompressed Olympus and Samsung Adobe models verified on one CC0 file each; status unchanged (🟡) |+| 2026-10-13 | minor | LR-EDIT-SECTION-SOLO: Solo Mode for Edit sections (Window ▸ Edit Sections, section-header menu, ⌥-click); KEYC-PANELS notes it |+| 2026-10-14 | minor | LR-MERGE-HDR ✅ → 🟡: tested on real 67 MP Sony brackets; moving clipped highlights (black-hole stars) and dark-sky ghosts fixed, merge memory cut ~25 %; AI Denoise on merged DNGs, JPEG response curves and per-frame memory remain (gap 29). LR-MERGE-HEADLESS, MENU-PHOTO-MERGE: HDR for Each Bracket Set (`merge.hdrBatch`) |+| 2026-10-15 | patch | LR-VIEW-BEFOREAFTER: side by side and stacked panes share click-zoom animation for whole-frame images, window tiles and input; render requests keep the final target (#1821); status unchanged |+| 2026-10-14 | patch | LR-META-XMP: automatic sidecar writes that fail (folder offline or read-only) wait and are written again once the files are reachable, with a notice (`cmd:library.retrySidecars`); status unchanged |+ | 2026-10-13 | minor | LR-BEHAV-WINDOW (new, 🟡): the desktop app's window opens at the size it was left at, zoomed / maximized if it was; full screen and the place on the desktop are not remembered || 2026-10-13 | patch | LR-VIEW-COMPARE, LRC-LIB-COMPARE: ⌘/Ctrl- and Shift-clicks on the filmstrip in Compare change the selection as in the grid; the two photos shown stay selected and the active photo is unchanged (#187); statuses unchanged || 2026-10-13 | minor | KEYC-SELECTONLYACTIVE: Edit → Select Only Active Photo (⌘⇧D) lands as a new row; status 🟡 (headless-tested, native macOS menu path unverified) || 2026-10-13 | patch | LRC-LIB-CATALOG-IMPORT: a catalog whose tables are all still in its `-wal` file (main file schema format 0) opens instead of failing as an unsupported schema format; status unchanged |diff --cc docs/whats-new.mdindex 19570b7dc,9fd9d0729..d42148617--- a/docs/whats-new.md+++ b/docs/whats-new.md@@@ -95,41 -6,22 +95,55 @@@- A spot with Feather at 0 no longer draws black pixels exactly on its radius. This also fixes spots at 0% Opacitychanging pixels along their edge. The hard edge now leaves pixels on the radius unchanged.+### HDR merges keep the white balance+- An HDR merged from raws that LightCraft colours from the camera's JPEG (CR2, NEF, ARW…) now opens at the same+ As Shot temperature and tint as its photos, and changing the white balance no longer turns it green. Sony ARW+ merges used to open at about 7000 K / +115 where the photos show 4000–5300 K / +8. HDRs merged before this keep+ their old white balance; merge them again.+## 2026-10-13+### Edits keep up in a large library+- A small edit (a keyword, a rating, a flag, a slider) no longer has the grid's list worked out again from every+ photo: only the photos the edit touched are asked about again and put at their place in the order. In a library of+ 67,000 photos that step went from 37 ms to under 1 ms. Still worked out whole: an edit to more than 256 photos, a+ change to an album, a stack or the keyword list, an album shown in its own order, Recently Added, Missing Photos,+ and a view that asks about "the last N days".+- With no filter set, the count of the source is taken from the list instead of from a second pass over the library.+- The side panels keep a tally an edit cannot have changed: a rating or a slider changes none of the folders,+ keywords, dates, people and counts; a keyword leaves the folders, the dates and the counts as they are. With both+ side panels open, the frame after a keyword went from about 156 ms to about 54 ms in that library (2 ms with the+ panels closed, from 71 ms).+- The count beside each smart album in the left panel follows an edit the same way: the album asks only the photos+ the edit touched, where it asked every photo of the library after each edit (about 25 ms an album in that library).+ With that, the frame after a keyword is at about 29 ms there. New rules, a change to an album or the keyword list,+ an edit to more than 256 photos, and each new minute for an album that asks about "the last N days" are still+ counted from every photo.+- Still tallied from every photo on each edit: the filter bar's lists of cameras, lenses and keywords.++### A view can hold its photos until you refresh it+- View ▸ Hold View Until Refreshed (off unless you turn it on; kept with the library). With it on, an edit that makes+ a photo stop matching the view keeps it in the view: a keyword given in a smart album of photos without keywords,+ a flag taken off in Picks, a rating that falls under the filter bar's. With it off, as before, the photo leaves the+ grid at once and every photo after it moves up. View ▸ Refresh View (also in the sort menu while the hold is on),+ Reshuffle, another source, filter or sort, or new rules for the smart album shows what matches now.+- Photos that start matching still appear at once, and deleting a photo or taking it out of the album or folder+ shown still takes it out of the view.++ ### The window opens at the size you left it+ - LightCraft's window opens at the size it had when you last used it, and zoomed (macOS) / maximized if it was: it+ used to open at 1600 × 1000 every time. Double-click the top bar to zoom the window, quit, and it is zoomed when+ you come back; un-zoom it and it goes back to the size it had before.+ - Full screen is not remembered (the app opens as a window), and neither is where on the desktop the window was:+ the system places it.+ - On macOS the system does not tell LightCraft when a window is zoomed from the Window menu or resized after a+ zoom, so it goes by the window's size, and when in doubt takes the window for a window of the size it has: it+ comes back as large as you left it, but not as a zoomed window. That is so after a zoom from the Window menu+ with the Dock at a side of the screen, or of a window already as wide as the screen. Zoomed by a double-click+ on the top bar it comes back zoomed. The other way round, a window you drag out until it is as wide as the+ screen and nearly as tall counts as zoomed.+ - For scripts: a size set with `ui.resize` is remembered like any other, so a script that needs a size sets it.+### HDR merges keep the lens correction- An HDR made with Photo ▸ Photo Merge ▸ HDR now keeps the lens correction the photos carry (Sony's, Panasonic'sand Leica's, and the one some DNGs carry, e.g. from drones): Optics ▸ Enable Lens Corrections straightens it as it