LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Reject mismatched XML closing tags
Max Mittelstädtb25808686dd2
diff --git a/crates/lensdb/src/tests.rs b/crates/lensdb/src/tests.rsindex 435882381..6411ffd66 100644--- a/crates/lensdb/src/tests.rs+++ b/crates/lensdb/src/tests.rs@@ -84,6 +84,11 @@ fn parses_cameras_lenses_and_skips_invalid_entries() {assert!(!db.lenses[2].rectilinear);}+#[test]+fn rejects_mismatched_xml_closing_tags() {+ assert!(LensDb::parse("<lensdatabase><lens><maker>X</lensdatabase><model>L</model></lens>").is_err());+}+#[test]fn malformed_documents_are_errors_not_panics() {assert!(LensDb::parse("").is_err());diff --git a/crates/lensdb/src/xml.rs b/crates/lensdb/src/xml.rsindex dc611a647..0ff0c742c 100644--- a/crates/lensdb/src/xml.rs+++ b/crates/lensdb/src/xml.rs@@ -74,7 +74,6 @@ fn unescape(s: &str) -> String {pub(crate) fn parse(s: &str) -> Result<Node, Error> {let mut reader = quick_xml::Reader::from_str(s);- reader.config_mut().check_end_names = false;let mut stack = vec![Node { name: "#root".into(), ..Default::default() }];let mut count = 0usize;loop {