LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Merge PR #286
Claudec03a67c59f2b
diff --cc apps/lightcraft/src/main.rsindex 4b42c2fa2,107594eee..f26725cf0--- a/apps/lightcraft/src/main.rs+++ b/apps/lightcraft/src/main.rs@@@ -511,7 -470,19 +511,19 @@@ fn main() -> eframe::Result_ => files.push(a),}}+ // The log file: opened after the arguments, so `--version`, `--help` and a usage error leave+ // no file behind. Records logged until now are written to it first.+ if let Some(logger) = logger {+ match log_dir() {+ Some(dir) => match logger.attach_dir(&dir) {+ Ok(path) => log::info!("LightCraft {}, log file {}", env!("CARGO_PKG_VERSION"), path.display()),+ // The file sink has given up by now, so this goes to standard error only.+ Err(e) => log::warn!("no log file: {e}"),+ },+ None => logger.no_file(),+ }+ }- let (prefs, prefs_warning, keep_prefs_file) = load_prefs();+ let (prefs, prefs_warning, keep_prefs_file) = load_prefs(in_memory);// --library, else the library last opened from Settings, else the default locationlet library_dir = library_dir.or_else(|| {prefsdiff --cc docs/whats-new.mdindex c15f29b33,e614d71d8..b3a0154bc--- a/docs/whats-new.md+++ b/docs/whats-new.md@@@ -20,29 -13,11 +20,33 @@@with a counterpart here come along, the rest is listed.- 23 new built-in presets: Portrait, Landscape, Urban, Food, Seasons, Vintage and B&W toners.+### Editing+- The Tint slider works the right way round (issues #188, #321): left adds green, right adds magenta, as its track+ shows and as in Lightroom, and Tint values in Lightroom XMP sidecars now render as they do there. A custom Tint+ saved in an earlier version now shifts the other way; set it again (or re-run Auto / the white-balance picker).+- Crop (issue #295): a Lock toggle keeps the aspect ratio on every handle, Custom takes your own ratio (Apply), and+ dragging a handle into the image edge stops there instead of pushing the crop out of shape.++### Library and views+- Trackpads: pinch to zoom around the pointer and scroll with two fingers to pan the photo; panning keeps the photo+ inside the view. A plain mouse wheel over a zoomed photo pans it too.+- A Folders section in the sidebar lists the folders your photos were imported from; choose one to see its photos.+- Select All and multi-selection show every selected photo in the grid and filmstrip, not only the active one+ (issues #187, #298). Importing files that are in Recently Deleted asks whether to leave them there, restore them+ (with their edits) or import them as new; the trash view's Photo menu has Empty Recently Deleted.+### Reliability+- On macOS, single-key shortcuts that appear in the menu bar now work: E, C, H, M, ⇧P, I, K, D, ratings 0–5,+ labels 6–9, P / U and the rest did nothing, because macOS only passes ⌘ / ⌃ combinations and function keys+ to the menu bar and the app ignored those keys, assuming the menu bar would handle them. Keys outside the menus+ (Space, G, X, ⌫) and ⌘ shortcuts were not affected.+- `--memory` sessions keep their promise to save nothing (issues #164, #169): UI changes made in one no longer+ land in `ui.json` (where they replaced the saved settings), and the GPU crash sentinel no longer creates the+ settings folder there. The same goes for the temporary session offered when the library can't be opened.+ - The desktop app keeps a log file: `logs/lightcraft.log` in its settings folder (Linux `~/.config/lightcraft/logs/`),+ with the logs of the two previous runs beside it, so warnings and crashes of a run started from a desktop menu or the+ Dock can be attached to a bug report. `LIGHTCRAFT_LOG` works as before; `RUST_LOG` takes env_logger-style+ directives. See README → Quick start → Logs.- LightCraft no longer crashes at launch on Windows PCs whose Vulkan driver is broken (issue #136, e.g. some Intel UHD630 drivers): on Windows the window and GPU rendering use DirectX 12 only and never load the Vulkan driver unlessasked to. `LIGHTCRAFT_GPU_BACKEND=dx12 | vulkan | metal | off` (or wgpu's `WGPU_BACKEND`, which GPU rendering