Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Merge slideshow-templates into slideshow-export (origin/main: sidebar and slideshow_export modules side by side; whats-new and tracker summary)

Jason Baldwinccfff38548b1
diff --cc crates/ui-egui/src/lib.rs
index 8fde2ac4e,16d0c421f..9c61c1ba1
--- a/crates/ui-egui/src/lib.rs
+++ b/crates/ui-egui/src/lib.rs
@@@ -28,7 -29,7 +29,8 @@@ pub mod pick
pub mod region;
pub mod render;
pub mod shortcuts;
+ pub mod sidebar;
+pub mod slideshow_export;
pub mod softpaint;
pub mod state;
pub mod sync;
diff --cc crates/ui-egui/src/menus.rs
index 7b3d3d127,6c3e9a3e1..e0ca029b1
--- a/crates/ui-egui/src/menus.rs
+++ b/crates/ui-egui/src/menus.rs
@@@ -140,10 -141,11 +141,13 @@@ pub const UI_COMMANDS: &[UiCommand] = &
("dialog.newFolder", "New Folder…", Some("Cmd+Shift+N"), "File"),
("dialog.smartAlbum", "New Smart Album…", None, "File"),
("view.photoCounts", "Show Photo Counts", None, "View"),
+ ("view.sidebarSection", "Show Sidebar Section", None, ""),
+ ("view.sidebarMoveSection", "Move Sidebar Section", None, ""),
+ ("view.sidebarReset", "Reset Sidebar Sections", None, ""),
("view.slideshow", "Slideshow", Some("Cmd+Alt+Enter"), "View"),
("view.slideshowOptions", "Slideshow Options…", None, "View"),
+ ("dialog.slideshowExport", "Export Slideshow…", None, "View"),
+ ("app.slideshowExport", "Export Slideshow", None, ""),
// the slideshow's playback controls (Space, ←/→ and Esc while it plays)
("slideshow.togglePause", "Pause / Resume Slideshow", None, ""),
("slideshow.next", "Next Slide", None, ""),
diff --cc docs/control-protocol.md
index 64e6b54db,cd4ea38a4..36da0057c
--- a/docs/control-protocol.md
+++ b/docs/control-protocol.md
@@@ -85,11 -85,16 +85,19 @@@ filmstrip is visible
| `engine.execute {command: "slideshow.templates.apply"}` | `{id}` or `{name}`; `{id: "previous"}` | Replaces the playback (prepare previews kept), layout, overlays and titles settings with the template's, saved with the library. No undo: the replaced settings become `previous` for the session → `{applied, name, warnings, previous, settings}` (`warnings`: a background photo not in this library, an unreadable plate or watermark image…) |
| `engine.execute {command: "slideshow.templates.save"}` / `update` / `rename` / `delete` | `{name, replace?}` / `{id}` / `{id, name}` / `{id}` | Save the current settings as a user template (`<name>.json`; path separators and reserved characters become `_`, a taken or built-in name is refused unless `replace`), update one with the current settings, rename (its file follows), delete. Built-ins can't change |
| `engine.execute {command: "slideshow.templates.import"}` / `export` | `{path}` / `{id, path}` | Import a template `.json` (at most 256 KB; format, version and every setting checked; a taken name gets " (2)") → `{id, name, renamed, warnings}`; export any template as `.json` |
+| `engine.execute {command: "slideshow.export"}` | `{format: "pdf"\|"jpeg"\|"video", path, size?, quality?, fps?, container?: "mp4"\|"webm", fullScreen?, speed?, name?, ids?, wait?}` | The slideshow (the photos in view, or `ids`, as composed slides between the intro and ending screens that are on) as a PDF (one page per slide; `size` = long side 64–8192 px, default 1920), a JPEG sequence (`path` = the folder, files `<name>-001.jpg`…) or AV1 video in MP4 / WebM (`size` = frame height 64–2160 or `"720p"` / `"1080p"`, `fps` 24 / 25 / 30 / 60; fades rendered as frames; no audio; at most 2 hours). Runs in the background → `{taskId, background, slides, seconds, total, width, height, warnings}`; its row is in `activity.list` (`kind: "export"`, label "Exporting slideshow"), `activity.cancel {id: taskId}` stops it and leaves no file (outputs are written as `.part` and renamed when complete). `wait: true` runs it in the call and replies with the result. One at a time |
+| `engine.execute {command: "slideshow.exportStatus"}` | — | The last slideshow export: `{taskId, format, path, running, done, total, cancelled, result?, error?}`; `result` has `pages` (PDF), `files` (JPEG) or `frames`, `samples`, `keyFrames`, `seconds`, `fps`, `container`, `codec: "av1"`, `audio: false` (video), and `skipped` / `warnings` for photos that could not be rendered |
+| `engine.execute {command: "dialog.slideshowExport"}` / `app.slideshowExport` | `{format?}` / `{format, size?, quality?, fps?, container?, fullScreen?, path?}` | View ▸ Export Slideshow…: opens the dialog; `app.slideshowExport` asks for the path with a save dialog when none is given, then starts `slideshow.export` |
| `app.quit` | — | Close the app |
+ White balance (`develop.set` with `wb.temp` / `wb.tint`, `develop.wb`, `develop.wbPick`) is in Kelvin and tint on
+ raws with colour matrices — in the file (DNG) or measured for the camera model (`lightcraft_raw::spectral`; issue
+ #730) — where As Shot reads the file's as-shot white; rendered files and raws without matrices use a relative scale
+ whose 6500 K / 0 is the as-shot look (the Edit panel shows it as −100..+100). The stored `wb` of such a Kelvin raw
+ says `"scale": "kelvin"`; a partial settings JSON given to `develop.merge` or a preset whose `wb` sets `temp` / `tint`
+ **without** `scale` keeps the relative meaning it always had (6500 = as shot) on every raw, so agents that mean
+ Kelvin on a Kelvin raw pass `"scale": "kelvin"` or use `develop.set` / `develop.wb`.
+
Image navigation is also available directly as the UI command `view.navigate`, with
`{zoom?: "fit" | "fill" | {"percent": number}, pan?: [x, y]}`. Percentage zoom accepts fractional
values greater than 0 and at most 800; pan is the normalized image centre, with coordinates from 0 to 1.
diff --cc docs/parity-checklist.md
index 78b92eb0c,bca6695ce..eaad5043d
--- a/docs/parity-checklist.md
+++ b/docs/parity-checklist.md
@@@ -49,13 -49,13 +49,13 @@@ cited here still exists. Formerly docs/
| U. Map & location (MAP) | 0 | 1 | 1 | 0 | — | 0/1 (0%) |
| V. Preferences (PREF) | 6 | 2 | 2 | 2 | 1/1 (100%) | 4/5 (80%) |
| W. Cloud & AI infrastructure (CLOUD / AI) | 1 | 0 | 1 | 2 | — | — |
- | X. Cross-cutting behaviours (BEHAV) | 18 | 6 | 1 | 1 | 8/8 (100%) | 6/9 (67%) |
- | Y. Menus | 82 | 0 | 4 | 8 | 47/47 (100%) | 23/23 (100%) |
- | Z. Keyboard shortcuts (desktop) | 75 | 3 | 3 | 1 | 49/52 (94%) | 23/24 (96%) |
- | Lightroom Classic extras | 35 | 21 | 27 | 9 | — | 23/25 (92%) |
- | **Total** | 399 | 55 | 65 | 36 | 192/200 (96%) | 143/155 (92%) |
+ | X. Cross-cutting behaviours (BEHAV) | 23 | 6 | 1 | 1 | 8/8 (100%) | 7/10 (70%) |
+ | Y. Menus | 84 | 0 | 4 | 8 | 47/47 (100%) | 23/23 (100%) |
+ | Z. Keyboard shortcuts (desktop) | 76 | 3 | 3 | 1 | 49/52 (94%) | 23/24 (96%) |
-| Lightroom Classic extras | 36 | 21 | 28 | 8 | — | 24/26 (92%) |
-| **Total** | 409 | 55 | 66 | 35 | 192/200 (96%) | 145/157 (92%) |
++| Lightroom Classic extras | 36 | 22 | 27 | 8 | — | 24/26 (92%) |
++| **Total** | 409 | 56 | 65 | 35 | 192/200 (96%) | 145/157 (92%) |
- Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.2%** of 519 in-scope rows — P0 98.0% of 200 · P1 95.2% of 155 · P2 50.3% of 163.
-Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.4%** of 530 in-scope rows — P0 98.0% of 200 · P1 95.2% of 157 · P2 52.3% of 172.
++Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.5%** of 530 in-scope rows — P0 98.0% of 200 · P1 95.2% of 157 · P2 52.6% of 172.
<!-- /parity:summary -->
## Top gaps and shortcut notes
diff --cc docs/whats-new.md
index a8a5bd98c,2d4bff106..3e2e8a0aa
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@@ -2,22 -2,36 +2,52 @@@
## 2026-10-11
+ ### Open Library knows a Lightroom catalog
+ - Choosing a Lightroom Classic catalog folder in File → Open Library… (or one of its `Previews.lrdata` /
+ `.lrcat-data` folders, or the `.lrcat`) no longer makes an empty LightCraft library inside it (issue #891). The
+ library open now stays, and LightCraft says "This is a Lightroom catalog, not a LightCraft library" and offers
+ **Import Lightroom Catalog…** with that catalog, or Cancel. `lightcraft-cli --library` refuses those folders too.
+
+ ### Canon EOS R5 Mark II
+ - Canon EOS R5 Mark II C-RAW files that opened as "preview only" (more than half of them, depending on the
+ scene) now develop from their sensor data with every editing tool, like the camera's other raws. Photos
+ imported earlier switch over with Photo ▸ Reload from Disk.
+
+ ### Switching libraries
+ - File ▸ New Library… asks for a name, then where to put it, and opens the new library (issue #902).
+ - File ▸ Open Recent Library lists the last 8 libraries; ones that are gone (moved, drive disconnected) are greyed
+ out. Clear Recent Libraries empties the list.
+ - The open library's name shows under My Photos at the top of the left panel and in the window title.
+ - `lightcraft-cli --library` given a library's own file (`catalog.snap`) opens its folder instead of failing with
+ "File exists".
+ - Agents use `app.newLibrary {path, name}`, `app.recentLibraries` and `app.clearRecentLibraries`.
+
+ ### Edit in PhotoCraft
+ - Right-click a photo ▸ Edit In ▸ Edit in PhotoCraft (or Photo ▸ Edit In, ⇧⌘E) renders a copy with your edits, stacks it
+ with the original and opens it in PhotoCraft. LightCraft finds PhotoCraft where its installer put it (Windows,
+ macOS, Linux packages, AppImage, Flatpak), and says so if it isn't installed, before making a copy.
+ - The copy is a 16-bit PSD by default, which PhotoCraft saves straight back to with File ▸ Save; when you come back to
+ LightCraft the copy shows what you saved.
+ - Settings ▸ General ▸ External Editing: the format (PSD or TIFF), colour space and bit depth for PhotoCraft and for
+ the other editor (Edit in Other Editor, now ⌥⌘E), and where PhotoCraft is if you use a portable copy.
+ - Export can write PSD too (flat, 8- or 16-bit).
+
+### Slideshow export: PDF, JPEG and video
+- View ▸ Export Slideshow… (or the Export buttons at the end of Settings ▸ Slideshow) writes the slideshow out, like
+ Lightroom Classic's Export PDF, Export JPEG and Export Video: the photos in view as their slides, with the layout,
+ overlays and the intro and ending screens, in view order.
+- **PDF:** one page per slide at 1024, 1920 or 3840 pixels on the long side, at a JPEG quality you choose. Each page
+ carries the slide duration and fade, so a PDF viewer's presentation mode plays it as a slideshow, and "Automatically
+ show full screen" asks the viewer to open it that way.
+- **JPEG:** numbered files (`Holiday-001.jpg`, `Holiday-002.jpg`…) in a new folder.
+- **Video:** AV1 video in an MP4 (or WebM) file at 720p or 1080p, 24 or 30 frames per second: each slide stays up for
+ its duration and the fades are rendered frame by frame (crossfades, or fades through the fade colour). The video has
+ no sound yet. It is AV1 rather than Lightroom's H.264, which has no open encoder we can ship; current browsers,
+ VLC and recent phones and TVs play it.
+- The export runs in the background with its row in the activity stack; ✕ stops it and leaves no half-written file
+ behind. A photo that can't be read is skipped and named in the message at the end. Agents use `slideshow.export`
+ (`slideshow.exportStatus` for the result).
+
### Slideshow templates
- Settings ▸ Slideshow now opens with a template browser, like Lightroom Classic's Template Browser. A template holds
everything about how a slideshow looks and plays: the playback timing and fades, the layout, options and backdrop,