Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Issue #3412: record the craft-fonts skip once per accessibility audit

Antonio Sokiccda73d235e36
diff --git a/crates/ui-egui/tests/it/accessibility.rs b/crates/ui-egui/tests/it/accessibility.rs
index 30196048b..39b707cd3 100644
--- a/crates/ui-egui/tests/it/accessibility.rs
+++ b/crates/ui-egui/tests/it/accessibility.rs
@@ -18,7 +18,6 @@ fn harness(view: ViewMode, right: RightPanel) -> Harness<'static, LightcraftApp>
// text such as "▸" in the Reference view's hint has its glyph only in the craft-fonts faces (releases
// always have them): without them it is drawn as a box, which this audit of names doesn't need
if lightcraft_engine::CRAFT_FONTS.is_empty() {
- lightcraft_testkit::skip!(Fonts, "built without CRAFT_FONTS_DIR: glyphs only craft-fonts has are drawn as boxes, not checked");
builder = builder.allow_missing_glyphs();
}
let mut h = builder.build_ui_state(
@@ -87,6 +86,10 @@ fn audit(h: &Harness<'_, LightcraftApp>, place: &str) -> Vec<String> {
#[test]
fn every_interactive_node_has_a_name_in_every_view_and_tool() {
+ // said once per audit, not once per harness
+ if lightcraft_engine::CRAFT_FONTS.is_empty() {
+ lightcraft_testkit::skip!(Fonts, "built without CRAFT_FONTS_DIR: glyphs only craft-fonts has are drawn as boxes, not checked");
+ }
let mut problems = Vec::new();
for view in [ViewMode::PhotoGrid, ViewMode::SquareGrid, ViewMode::Detail, ViewMode::Compare, ViewMode::Survey, ViewMode::Reference] {
let h = harness(view, RightPanel::None);