LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Merge PR #747
Claudedba63bc9d5f4
diff --cc crates/ui-egui/src/lib.rsindex 29f9712b2,31003a543..d425a96eb--- a/crates/ui-egui/src/lib.rs+++ b/crates/ui-egui/src/lib.rs@@@ -42,12 -41,10 +42,14 @@@ mod tests_activity#[cfg(test)]mod tests_album_picker;#[cfg(test)]+mod tests_copy_paste_dialogs;+#[cfg(test)]+ mod tests_compare;+ #[cfg(test)]mod tests_crop_rotate;#[cfg(test)]+mod tests_crop_tool;+#[cfg(test)]mod tests_curve;#[cfg(test)]mod tests_date_picker;diff --cc docs/parity-checklist.mdindex 3309447c7,2ffbe891a..af1b90f3e--- a/docs/parity-checklist.md+++ b/docs/parity-checklist.md@@@ -130,8 -130,8 +130,8 @@@ differences and missing bindings are i| LR-VIEW-FILMSTRIP | Filmstrip | P0 | β | `cmd:view.filmstrip`, `crates/ui-egui/src/panels/detail.rs` | the photo context menu on right-click; the mouse wheel scrolls it sideways; it follows the active photo only when that changes (centred if off screen), so a scrolled strip stays put; every selected photo is highlighted, the active one framed in white, as in the grid || LR-VIEW-ZOOM | Zoom & pan | P0 | π‘ | `cmd:view.zoomFit`, `cmd:view.zoom100`, `cmd:view.zoomIn`, `cmd:view.zoomOut`, `cmd:view.zoomToggle`, `cmd:view.clickZoom`, `cmd:view.navigate`, `crates/ui-egui/src/panels/detail.rs`, `crates/ui-egui/src/headless.rs` | continuous native pinch / modifier-wheel zoom (Fitβ800%, anchored under the pointer), two-finger scroll / touch pan with edge limits; Detail (including tools, Before/After and full-screen preview), Compare and Reference; fractional percentages preserve small gestures; image, picker and targeted-adjustment cursors stay steady between gesture events; keyboard steps 25β800 % (not 6β1600 %); Fill in the bottom bar; click / Z / Space eases to the chosen ratio (1:1 default, 2:1, 3:1, 4:1, 8:1). The loupe's cost follows the canvas, not the zoom (issue #323): the whole frame is rendered at about canvas size (at most the 2560 px preview source level unless a larger Preview size is chosen, and never above the GPU's texture side), and once the view is zoomed well past that (more than 25 %) the window on screen is rendered too, cut from a frame of at most the photo's own pixels, so beyond 100 % the GPU magnifies it (`region::plan`, `RenderRequest::window`, `Session::region_job`, `crates/ui-egui/src/region.rs`); 1:1 and 2:1β8:1 are sharp at any photo size. A slider tick takes 7β12 ms on a 1400 Γ 900 canvas and 11β25 ms on a 2800 Γ 1700 one at 100 % and 400 % of a 24 MP photo (M1 Max, GPU, `profile_slider_drag`); about 20β25 ms at 100 % on the big canvas is over a 16 ms frame. A continuous pinch holds the render sizes (and the windows there are) until it is quiet. A fit view on a canvas up to about 3200 px (a Retina Mac) never decodes the original; larger displays get a window at fit, which does. Modes that draw another picture over the loupe (mask overlays, soft proofing) and photos whose spots or Auto Mask strokes read too far for one window (only photos longer than 8192 px) render the whole frame at the size it is drawn, as before windows; while a preset or profile is hovered, or over a picture that is not the frame (an unsupported raw's embedded JPEG), the whole frame stays canvas-sized. Before/After (side by side, stacked, `\\` and both wipes) gets the same windows on both sides, clipped to their pane or side of the line. Windows render on the GPU like whole frames (equivalence-tested against the CPU), in the browser build too (windows no wider than its GPU's texture side, at most 3072 px), and are not made while hovering a look, soft-proofing or showing an overlay, nor over a picture that is not the frame (an unsupported raw's embedded JPEG with another crop). No texture is larger than the GPU allows. Spots and Auto Mask brushes work while what a window reads fits one render (8192 px along an axis, 4096 in the browser): the window grows to hold the spot and its source patch, or the dabs near it, and if that would take more (a clone from far away at 8:1) the loupe keeps the whole-frame render instead, and spots with an automatic source pick it from a fixed-size render of the whole frame (so a window's choice can differ from a whole-frame render's, which picks at its own resolution). The wide stages (dehaze, clarity, highlights/shadows base) and Refine Edges on masks read a window margin capped at 768 px; measured on hard-edged blocks that costs at most a few levels at 8:1. the histogram and Navigator come from the whole-frame render || LR-VIEW-NAVIGATOR | Navigator mini map | P1 | β | `cmd:view.navigator`, `crates/ui-egui/src/panels/detail.rs` | shown while zoomed (bottom right); click/drag pans |-| LR-VIEW-BEFOREAFTER | Before / after | P0 | β | `cmd:view.showOriginal`, `cmd:view.beforeAfter`, `cmd:view.beforeAfterSplit`, `cmd:view.beforeAfterTopBottom`, `cmd:view.beforeAfterSplitTopBottom`, `cmd:beforeAfter.setBefore`, `cmd:beforeAfter.copyAfterToBefore`, `cmd:beforeAfter.copyBeforeToAfter`, `cmd:beforeAfter.swap`, `cmd:beforeAfter.resetBefore` | all four layouts; before = the import state (defaults + import preset) or a chosen history step / version / the current settings; copy and swap (View β Before/After Settings, History row menu). The chosen before lasts for the session |+| LR-VIEW-BEFOREAFTER | Before / after | P0 | β | `cmd:view.showOriginal`, `cmd:view.beforeAfter`, `cmd:view.beforeAfterSplit`, `cmd:view.beforeAfterTopBottom`, `cmd:view.beforeAfterSplitTopBottom`, `cmd:beforeAfter.setBefore`, `cmd:beforeAfter.copyAfterToBefore`, `cmd:beforeAfter.copyBeforeToAfter`, `cmd:beforeAfter.swap`, `cmd:beforeAfter.resetBefore` | all four layouts; before = the import state (defaults + import preset) or a chosen history step / version / the current settings; copy and swap (View β Before/After Settings, History row menu). The chosen before lasts for the session. Zoomed in, the side by side and stacked views each stay in their pane, with their labels under it |- | LR-VIEW-COMPARE | Compare two photos | P1 | β | `cmd:view.compare`, `cmd:compare.swap`, `cmd:compare.makeSelect`, `crates/ui-egui/src/panels/compare.rs` | select / candidate, synced zoom + pan, arrows move the candidate; no zoom-link toggle |+ | LR-VIEW-COMPARE | Compare two photos | P1 | β | `cmd:view.compare`, `cmd:compare.swap`, `cmd:compare.makeSelect`, `cmd:compare.set`, `crates/ui-egui/src/panels/compare.rs`, `crates/ui-egui/src/tests_compare.rs` | select / candidate, synced zoom + pan, arrows move the candidate; a filmstrip click puts the photo into the active side (a photo on the other side swaps), so the active photo is always one of the two shown; no zoom-link toggle || LR-VIEW-SURVEY | Survey view [Classic] | P2 | β | `cmd:view.survey`, `crates/ui-egui/src/panels/compare.rs` | selection tiled (β€ 48), keys act on the active photo, hover Γ removes || LR-VIEW-INFOOVERLAY | Info overlay on the photo | P1 | β | `cmd:view.infoOverlay` | off / file + date + size / exposure + camera; βI cycles (I in full screen; elsewhere I stays the Info panel) || LR-VIEW-SLIDESHOW | Slideshow | P2 | β | `cmd:view.slideshow` | View βΈ Slideshow (β₯ββ©): the photos in view full screen, every 4 s (`interval`), wrapping; Space pauses, β/β step, Esc ends |