LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
docs: #1037 visible skips and the ci report
Chad Elliottdbf2dcbfbd3c
diff --git a/AGENTS.md b/AGENTS.mdindex 8cd199ff6..3d615d00c 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -125,11 +125,15 @@ of it. Full standard: `../craftrules/standards/never-crash.md`with `/usr/bin/time`. Record numbers in `plan/STATUS.md` → Metrics. Budgets: slider update ≤ 16 ms (draft) / loupe≤ 60 ms on ~2.5 MP; export ≤ 1 s per 24 MP JPEG.- Never commit media: test images are procedural (`lightcraft-scenes`) or CC0 downloads in the gitignored `corpus/`.+- A test that can't run here (no GPU, corpus file, craft-fonts face, model) calls `lightcraft_testkit::skip!(Gpu, "why")`+ before it returns, not a bare `eprintln!`. `cargo xtask ci` then lists the skips and the machine's GPU adapters and+ data, and writes `target/ci/report.json` and `target/ci/summary.md` (Markdown for a PR).## Map of the code`geom`, `color`, `raster`, `tiff` (L0) → `raw`, `codecs`, `meta`, `develop` (L1) → `pipeline` → `catalog` → `engine`→ `ui-egui`, `mcp` (L5) → apps `lightcraft` (desktop), `lightcraft-cli` (render/commands/MCP). `scenes` generates demo-photos. `xtask` = tooling (`ci`, `layers`, `assets`, `parity`, `wasm`, `corpus`, `stats`). `flake.nix` ++photos. `xtask` = tooling (`ci`, `layers`, `assets`, `parity`, `wasm`, `corpus`, `stats`); `testkit` = test helpers+(dev-dependency only). `flake.nix` +`nix/package.nix` = the Nix package (`nix build` builds both binaries with the craft-fonts input, installs thedesktop file/icons/AppStream metadata and runs `cargo test --workspace`; `nix develop` = dev shell). Community-maintained and notin CI: it may lag behind the workspace; see README → Quick start.diff --git a/CLAUDE.md b/CLAUDE.mdindex 4a736f12a..5596bb95f 100644--- a/CLAUDE.md+++ b/CLAUDE.md@@ -132,11 +132,15 @@ of it. Full standard: `../craftrules/standards/never-crash.md`with `/usr/bin/time`. Record numbers in `plan/STATUS.md` → Metrics. Budgets: slider update ≤ 16 ms (draft) / loupe≤ 60 ms on ~2.5 MP; export ≤ 1 s per 24 MP JPEG.- Never commit media: test images are procedural (`lightcraft-scenes`) or CC0 downloads in the gitignored `corpus/`.+- A test that can't run here (no GPU, corpus file, craft-fonts face, model) calls `lightcraft_testkit::skip!(Gpu, "why")`+ before it returns, not a bare `eprintln!`. `cargo xtask ci` then lists the skips and the machine's GPU adapters and+ data, and writes `target/ci/report.json` and `target/ci/summary.md` (Markdown for a PR).## Map of the code`geom`, `color`, `raster`, `tiff` (L0) → `raw`, `codecs`, `meta`, `develop` (L1) → `pipeline` → `catalog` → `engine`→ `ui-egui`, `mcp` (L5) → apps `lightcraft` (desktop), `lightcraft-cli` (render/commands/MCP). `scenes` generates demo-photos. `xtask` = tooling (`ci`, `layers`, `assets`, `parity`, `wasm`, `corpus`, `stats`). `flake.nix` ++photos. `xtask` = tooling (`ci`, `layers`, `assets`, `parity`, `wasm`, `corpus`, `stats`); `testkit` = test helpers+(dev-dependency only). `flake.nix` +`nix/package.nix` = the Nix package (`nix build` builds both binaries with the craft-fonts input, installs thedesktop file/icons/AppStream metadata and runs `cargo test --workspace`; `nix develop` = dev shell). Community-maintained and notin CI: it may lag behind the workspace; see README → Quick start.diff --git a/README.md b/README.mdindex 8884f2bd3..6f9ff1cba 100644--- a/README.md+++ b/README.md@@ -370,6 +370,13 @@ per CPU, otherwise exhaust RAM before any test runs. GPU coverage is unchanged.`CARGO_PROFILE_DEV_DEBUG`, `CARGO_BUILD_JOBS` and `RUST_TEST_THREADS` settingsoverride these defaults. Ordinary development commands keep their own settings.+Tests that need a GPU, the corpus, the craft-fonts faces or a model pass without checking anything when+those are missing (libtest has no "skipped" status), so `cargo xtask ci` lists them: tests record a skip+with `lightcraft_testkit::skip!`, and the run ends with what the machine offered (OS, CPUs, RAM, GPU+adapters per backend, corpus, fonts) and every skip by reason. It writes `target/ci/report.json` and+`target/ci/summary.md`, a block to paste into a PR (`--summary-md` prints it); `--hardware` also runs the+GPU tests on every backend that has a hardware adapter. Nothing is uploaded.+**Chinese and Japanese text** need the shared font repo, an optional build input (official releases always include it):```shdiff --git a/docs/architecture.md b/docs/architecture.mdindex c50066a10..7d1b7a3ae 100644--- a/docs/architecture.md+++ b/docs/architecture.md@@ -1,6 +1,6 @@# Architecture-> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-10 · **Change:** major (created from the code; the full design notes stay in the local `plan/architecture.md`) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6+> **Last reviewed:** 2026-10-10 · **Last updated:** 2026-10-11 · **Change:** minor (`cargo xtask ci` reports the machine and skipped tests; `testkit`) · **Target:** Adobe Lightroom Classic 15.5 / Lightroom 9.6How LightCraft is built today. The longer design document (`plan/architecture.md`) is local-only(`plan/` is gitignored); this page is the committed, current summary. Sizes are Rust lines counted@@ -19,7 +19,7 @@ L5 depends on egui, eframe, winit or rfd, and that each crate only uses lower la| L3 | `catalog` (11.0k), `gpu` (5.1k), `preview` (1.3k), `merge` (3.8k), `segment` (2.3k) | Library model and persistence; wgpu compute twin of the pipeline; thumbnail/preview cache and job pool; HDR and panorama merge; SAM 3 segmentation || L4 | `engine` (53.2k) | Session, command registry (everything is a command), history, render and export jobs, import, Lightroom catalog and preset import, faces index, view-models || L5 | `ui-egui` (46.9k), `mcp` (2.3k) | The Lightroom-style egui interface (swappable); the MCP server |-| L6 | `apps/lightcraft` (2.8k), `apps/lightcraft-cli` (1.5k), `apps/lightcraft-web` (3.4k), `xtask` (2.7k) | Desktop app (eframe + wgpu, native menus, control server), CLI (render, commands, calibrate, snapshot, MCP), WASM build, tooling |+| L6 | `apps/lightcraft` (2.8k), `apps/lightcraft-cli` (1.5k), `apps/lightcraft-web` (3.4k), `xtask` (3.4k), `testkit` (0.2k, dev-dependency only) | Desktop app (eframe + wgpu, native menus, control server), CLI (render, commands, calibrate, snapshot, MCP), WASM build, tooling; test helpers (skips the CI report lists) |## Data model@@ -63,8 +63,19 @@ dispatch by id, and headless snapshots render the UI without a window.`assets` (every asset attributed, no Adobe formats) and the WASM build. Other workflows build andtest FreeBSD and Windows ARM64, lint packaging, and build releases.+`ci` also probes the machine: OS, CPUs, RAM, the GPU adapters of each backend (from the ignored+`gpu_probe` test of `lightcraft-gpu`, run after the workspace tests so it reuses their build; xtask+has no wgpu), the corpus and `CRAFT_FONTS_DIR`. Tests+that need what is missing call `lightcraft_testkit::skip!(need, reason)`, which appends a JSON line to+the file `LIGHTCRAFT_SKIP_LOG` names. The run ends with the machine and the skips by need and reason,+and writes `target/ci/report.json` (commit, dirty flag, machine, capabilities, each step's result and+time, skips) and `target/ci/summary.md` (Markdown for a PR; `--summary-md` prints it). The report holds+no host name, user name or absolute path, and nothing is uploaded. `--hardware` adds a step that runs+the `lightcraft-gpu` tests once per backend with a hardware adapter (`LIGHTCRAFT_GPU_BACKEND`).+## Revision history| Date | Change | Summary ||---|---|---|+| 2026-10-11 | minor | Quality gates: the CI machine probe, visible skips (`testkit`) and `target/ci/report.json` || 2026-10-10 | major | Created from the code (crate sizes, layers, data model, rendering, control, gates) |