LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Merge PR #1489
Brandon Thomasde5ec99f611a
diff --cc docs/parity-checklist.mdindex 2ffef503f,a15e8cc92..ffa3ed37f--- a/docs/parity-checklist.md+++ b/docs/parity-checklist.md@@@ -797,20 -789,7 +797,21 @@@ Latin stays upright. Advanced Japanese| Date | Change | Summary ||---|---|---|+| 2026-10-14 | minor | LR-IMP-CAMERA-COVERAGE: 17 uncompressed Olympus and Samsung Adobe models verified on one CC0 file each; status unchanged (🟡) |+| 2026-10-13 | minor | LR-EDIT-SECTION-SOLO: Solo Mode for Edit sections (Window ▸ Edit Sections, section-header menu, ⌥-click); KEYC-PANELS notes it |+| 2026-10-14 | minor | LR-MERGE-HDR ✅ → 🟡: tested on real 67 MP Sony brackets; moving clipped highlights (black-hole stars) and dark-sky ghosts fixed, merge memory cut ~25 %; AI Denoise on merged DNGs, JPEG response curves and per-frame memory remain (gap 29). LR-MERGE-HEADLESS, MENU-PHOTO-MERGE: HDR for Each Bracket Set (`merge.hdrBatch`) |+| 2026-10-15 | patch | LR-VIEW-BEFOREAFTER: side by side and stacked panes share click-zoom animation for whole-frame images, window tiles and input; render requests keep the final target (#1821); status unchanged |+| 2026-10-14 | patch | LR-META-XMP: automatic sidecar writes that fail (folder offline or read-only) wait and are written again once the files are reachable, with a notice (`cmd:library.retrySidecars`); status unchanged |+| 2026-10-13 | patch | LR-VIEW-COMPARE, LRC-LIB-COMPARE: ⌘/Ctrl- and Shift-clicks on the filmstrip in Compare change the selection as in the grid; the two photos shown stay selected and the active photo is unchanged (#187); statuses unchanged |+| 2026-10-13 | minor | KEYC-SELECTONLYACTIVE: Edit → Select Only Active Photo (⌘⇧D) lands as a new row; status 🟡 (headless-tested, native macOS menu path unverified) |+| 2026-10-13 | patch | LRC-LIB-CATALOG-IMPORT: a catalog whose tables are all still in its `-wal` file (main file schema format 0) opens instead of failing as an unsupported schema format; status unchanged |+| 2026-10-14 | patch | LR-REM-HEAL, LR-REM-CLONE: zero-feather edges preserve exact-radius pixels; zero-opacity regression covers all spot modes and image corners. Statuses and feature counts unchanged. |+| 2026-10-13 | patch | LR-EXP-DIM: an enlarged export stops at 512 megapixels and is refused when it needs more memory than the computer has, instead of aborting the app; status unchanged |+| 2026-10-13 | minor | LR-PROF-CAMERACOLOR: bundled ILCA-99M2 profile with its held-out measurement |+| 2026-10-12 | minor | LR-MASK-EFFECTS (new, ✅): local adjustment (effect / brush) presets: Effect menu, New Effect Preset dialog, Manage window, groups and favorites; imports Lightroom Classic local `.lrtemplate`, Camera Raw local `.xmp`, `.lceffect` and `.zip`. LR-IMP-PROFILES and LR-MASK-SLIDERS notes updated |+| 2026-10-14 | minor | LR-IMP-CAMERA-COVERAGE: 21 Sony and Leica Adobe models verified on one CC0 file each; status unchanged (🟡) |+| 2026-10-13 | minor | KEY-HIDEPINS ⬜ → ✅: Tool Overlay (Auto / Always / Selected / Never, `view.toolOverlay`, ⇧H cycles; H stays Remove) for the Remove tool's spot pins and the mask pins (issue #224); LR-MASK-PINS loses its "no Auto mode" note, LR-REM-SPOT-EDIT notes the modes |+ | 2026-10-13 | minor | LR-EDIT-DETAIL-NR, LR-EDIT-DETAIL-CNR: noise-reduction radii in the original's pixels, so previews at any size and smaller exports look like the full-size render scaled down (issue #960); status unchanged || 2026-10-11 | minor | LR-MERGE-HDR: HDR and panorama merges of raws without colour matrices (CR2, NEF, ARW…) write the colour they open with as DNG tags (issue #965); status unchanged || 2026-10-12 | minor | LR-META-XMP: Read Metadata from File no longer auto-writes the sidecar it has just read, which added `lc:settings` and hid another app's later `crs:` edits (#934); status unchanged (✅) || 2026-10-12 | patch | LR-IMP-CAMERA-COVERAGE: CR2 white level from the active area, not the saturated masked rows above it (issue #1272); status unchanged (🟡) |diff --cc docs/whats-new.mdindex 3efe2c78b,35ac52f5f..1ae783089--- a/docs/whats-new.md+++ b/docs/whats-new.md@@@ -1,178 -1,14 +1,185 @@@# What's new in LightCraft+## 2026-10-15++### Lightroom radial masks on the right side+- Radial masks brought over from Lightroom Classic (catalog import, XMP sidecars, edits inside DNGs and presets) now+ apply their effect inside the circle, as Lightroom does, instead of outside it (issue #1815). A mask inverted in+ Lightroom stays inverted, and older Radial Filters keep their Effect Outside / Invert Mask setting. Photos imported+ before this keep the masks they got: Photo ▸ Read Metadata from File reads a sidecar's again.++## 2026-10-15++### Delete in an album removes from the album only+- In an album, the Delete key now takes the selected photos out of the album, as in Lightroom. It used to move them+ to Recently Deleted, so they also left their folder's view (issue #1805). They stay in the library and in their+ folder; Edit ▸ Undo puts them back in the album. Photo ▸ Remove from Album does the same and now shows the key.+ To delete photos from the library from an album, use Photo ▸ Delete Photo or right-click ▸ Delete Photo. In a smart+ album, Delete changes nothing: its rules decide what it shows.++## 2026-10-14++### HDR merges of moving lights, and many brackets at once+- A star, the moon or a light that moves between the photos of a bracket (a night bracket on a tripod) no longer+ leaves a black hole where the middle photo had it clipped. With Deghost, the brightest photo's copy of it in a+ dark sky is now removed too.+- Photo ▸ Photo Merge ▸ HDR for Each Bracket Set merges every bracket among the selected photos with the last HDR+ settings, one after the other: each stack, and photos taken less than a second apart at different exposures.+ From the command line: `lightcraft-cli merge hdr-batch FOLDER`.+- Merging uses about a quarter less memory: three 67 MP raws need 3.8 GB instead of 4.8 GB.++### XMP sidecars catch up after a network share comes back+- With automatic XMP writing on, an edit to a photo whose folder can't be written (a network share that dropped+ out, a folder that went read-only) used to be written only to the library, with a line in the log, so the sidecar+ stayed behind the edit. LightCraft now says once that the sidecars are waiting, tries again every few seconds once+ the files are reachable, and says when they're written. `library.retrySidecars` does it on request.++### Reliability+- A damaged or crafted raw can no longer make LightCraft set aside gigabytes of memory before finding out the file is+ bad (issue #1512): a compressed PEF whose data is too short for the size it declares, an uncompressed TIFF-based+ raw whose tile claims far more samples than it holds, and an ARW6 with a broken tile are refused first. All 74+ files in the test corpus still decode.++### Reliability+- Thumbnails and previews are written to the cache on disk by one background writer instead of a new thread for+ each image (issue #1522). When renders come in faster than the disk takes them, at most 128 MB of images wait;+ past that a write is skipped (the image stays in memory and is written by a later render), so a slow disk can't+ pile up threads and memory.++### Reliability+- Saving the catalog and resuming a model download no longer write through a link left at the temporary file's+ name (`catalog.snap.tmp`, `model.onnx.part`): the link is removed and a new file made in its place, so the file it+ pointed to is never changed (issue #1502).++### Reliability+- A photo whose file was replaced (Reload Changed Files after an outside edit) no longer keeps the faces recognition+ made from the old pixels: they are made again from the new file, and a scan still busy with the old file when it+ changed doesn't put its faces on the new one (issue #1524).++### Settings stays put when you change tabs+- The Settings window keeps its top edge and width when you switch tabs, so the tab row no longer jumps around+ under the pointer. It used to be centred, so every tab of a different height moved it.++### Layout image over the loupe+- View ▸ Loupe Overlay ▸ Choose Layout Image… draws a PNG with transparency over the photo in the loupe, such as+ a magazine cover's masthead and cover lines, so you can frame a shot for the page it is made for. It fits inside+ the photo, follows zoom and pan, and ⌥⌘O shows or hides it. The same menu sets its opacity and a matte that+ darkens the photo outside it. The layout stays chosen across launches.++### Hard-edged Heal and Clone spots+- A spot with Feather at 0 no longer draws black pixels exactly on its radius. This also fixes spots at 0% Opacity+ changing pixels along their edge. The hard edge now leaves pixels on the radius unchanged.+## 2026-10-13+### HDR merges keep the lens correction+- An HDR made with Photo ▸ Photo Merge ▸ HDR now keeps the lens correction the photos carry (Sony's, Panasonic's+ and Leica's, and the one some DNGs carry, e.g. from drones): Optics ▸ Enable Lens Corrections straightens it as it+ does the photos it was made from. HDRs merged before this don't have it; merge them again.++### Portable mode+- A file named `portable.txt` next to the LightCraft program makes it keep its settings, logs and downloaded+ models in a `LightCraftData` folder beside it instead of the per-user settings folder (issue #1200), as+ PhotoCraft does. If that folder can't be written, the usual folder is used and the log says why.++### Reliability+- A photo whose Defringe amount was stored far past the sliders' 20 (in a damaged catalog or sidecar) no longer+ crashes LightCraft each time it renders: the amount acts as 20.++### Reliability+- Importing a preset zip that unpacks to far more than any preset (a "zip bomb") is refused with a message naming+ the file, instead of asking for gigabytes of memory, which could end LightCraft.++### Reliability+- A crop of no size (from an agent or a sidecar) no longer gives the Detail view a photo of no size to lay out+ (its width over its height was 0 / 0, which stopped debug builds); it shows as a single pixel's colour.++### Reliability+- A crop a hair wide (or of no size), set by an agent or read from a sidecar, no longer crashes or hangs the+ render with Clarity, Dehaze, Texture or Highlights / Shadows on: their blurs are held to the picture's size.+- A crop of no size with healing spots or masks no longer crashes the render: samples outside the picture read its+ edge.++### Reliability+- A library whose catalog file was damaged (or edited by hand) in a way that still reads no longer crashes+ LightCraft when it shows a stack, or hangs it when a folder is moved: on opening, records are put back under+ their own ids, stacks keep only photos that exist (at least two), folders inside themselves move to the top,+ and new photos never reuse an id in use. What was repaired is written to the log.++### Nikon lens corrections+- Raws from the Nikon Z 6II, Z 8 and Z f now open with the camera's own distortion correction, as Lightroom applies a+ built-in profile: straight lines near the edges stay straight and the framing matches the camera's JPEG. It works+ with Z lenses and with F-mount lenses on the FTZ adapter, follows the in-body stabilisation's shift of the optical+ centre, and can be turned off under Lens Corrections. Vignetting correction from the file comes later.++### Thumbnail cache stays in its folder+- The thumbnail cache no longer follows a shard folder (`thumbs/ab/`) that is a symlink or junction to somewhere+ else (issue #1504): trimming or clearing the cache can't delete files outside it, and thumbnails are never read+ from or written through such a link.++### Large libraries: Synchronize Folder, import and sidecars start sooner+- Opening Synchronize Folder, an import review or an import no longer makes a table of every photo in the library+ before it looks at the first file. In a library of 3.5 million photos that held the window for about 6 s before+ a Synchronize scan began (now under 1 s), 2.6 s before an import review (now 0.05 s) and 1.7 s before an import+ (now 0.05 s). The scan looks up only the files it finds and the contents it reads, on its own thread.+- Writing one photo's XMP sidecar (Save Metadata to File, or automatically after an edit) no longer works out who+ owns every shared sidecar name in the library: 2.4 s a write in that library, now under 1 s.+- Nothing else changes: the same files are found new, already there, moved or missing, and sidecars get the same+ names.++### Faces load faster in the People view+- Faces on unedited raws are cut from the camera's preview inside the file instead of developing the raw (issue+ #1440): a Sony α1 face reads 8 MB instead of 70 MB, an A7S III face about 1 MB instead of 24 MB, several times+ faster on an external hard disk. A face whose preview is too small, and any edited photo, is still developed from+ the raw, so it keeps its look.+- Raws whose preview is in Adobe RGB (Sony α1 among others) no longer read the whole file for their grid thumbnail:+ only the header and the preview are read, as for other raws.+- Faces are kept in the thumbnail cache at a few fixed sizes, so moving the thumbnail slider no longer renders them+ all again.++### Reliability+- A raw file whose black level is stored as "not a number" (or infinity), or a floating-point DNG with such+ samples, no longer crashes LightCraft at 1:1 or on export: the bad values read as black.++### Reliability+- Exporting a photo more than 65,535 times as long as it is wide (a one-pixel strip), or opening the Export dialog's+ watermark preview for it, no longer crashes LightCraft; the export is capped at the encoders' 65,535 pixels.++### Reliability+- Dragging a Tone Curve point that sits very close to its neighbours (two clicks side by side, or a curve from a+ sidecar, a preset or an agent) no longer crashes LightCraft; the point stays between them. Curve points sent to+ `develop.curve` are kept in order, and a sidecar curve with a "NaN" or "inf" point is ignored.++### Reliability+- A demo photo whose stored size was damaged (a width of 4294967295) is rendered at its own size instead of+ one that overflows.++### DNG camera identity+- DNG export and Convert to DNG no longer duplicate the camera make when the model already+ contains it: `Canon EOS R6` stays `Canon EOS R6`, rather than `Canon Canon EOS R6` (the camera+ identity subissue in #840). The separate Make and Model tags keep their original values.+ This does not change colour matrices, camera calibration or RAW noise rendering.+### Building from source+- The English and Simplified Chinese build guides now describe command-local job and release+ profile overrides for memory-constrained builders (issue #1196), including why packaging+ recipes can override inherited settings. Default release profiles and application behavior+ are unchanged; the guidance does not guarantee a build will fit every 16 GB machine.+### Lightroom catalog import+- A Lightroom Classic catalog whose changes are all still in its `.lrcat-wal` file (a new catalog Lightroom has+ open and hasn't written back yet) imports instead of failing with "unsupported SQLite schema format".++### Reliability+- An export enlarged far past the photo's size (20000 typed for 2000 with Don't Enlarge off) no longer ends+ LightCraft: an enlargement stops at 512 megapixels, as in Lightroom, and one that needs more memory than the+ computer has is refused with the size it would take, before it starts.++ ### Noise reduction looks the same at every size+ - Luminance and colour noise reduction no longer look much stronger in grid thumbnails and the filmstrip than in+ the loupe (issue #960). Their radii are now set in the original photo's pixels, so a thumbnail, the fitted loupe+ and a smaller export look like the full-size result scaled down; 1:1 views and full-size exports are unchanged.+ Like in Lightroom, judge noise reduction at 1:1: at small sizes the noise it removes is mostly averaged away.+ Cached thumbnails are redrawn.+### Slider drags on large raws- Dragging a slider no longer re-renders the edited photo's filmstrip thumbnail on every frame; it follows once youlet go. On a 64 MP raw the first of those renders decoded the whole file again, which held up the loupe's