LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust
Merge PR #2952: LR-EDIT-COLOR-TEMP: a one-field white balance partial keeps the other field's look (#2910)
aiongge8566e839a37
diff --cc docs/parity-checklist.mdindex ea3f3fb0c,02c5caebd..69d8072c0--- a/docs/parity-checklist.md+++ b/docs/parity-checklist.md@@@ -190,8 -190,8 +190,10 @@@ differences and missing bindings are i| LR-EDIT-LIGHT-CURVE-REFINESAT | Curve saturation compensation | P1 | ✅ | `ctl:curve.refineSaturation` | || LR-EDIT-LIGHT-CURVE-TAT | Drag-on-image curve adjust | P1 | ✅ | `cmd:develop.targeted` (`target: curve`) | || LR-EDIT-COLOR-WB-PRESET | White-balance presets | P0 | ✅ | `cmd:develop.wb` | |+| LR-EDIT-COLOR-WB-PICKER | White-balance eyedropper | P0 | ✅ | `cmd:tool.wbPicker`, `cmd:develop.wbPick`, `crates/ui-egui/src/tests/wb_selector.rs` | the Edit panel's selector button does what W does (from Compare, Survey or the grid it opens the photo in Detail); no magnified loupe while picking |+| LR-EDIT-COLOR-TEMP | Temperature | P0 | ✅ | `ctl:wb.temp`, `crates/pipeline/src/local.rs` (`wb_matrix_for`, `legacy_white`), `crates/raw/src/color.rs` (`rebalance`), `crates/raw/src/spectral.rs` (`find_camera`), `crates/catalog/src/model.rs` (`relative_wb_camera`), `crates/develop/src/controls.rs` (`ControlSpec::position`), `crates/raw/src/kelvin_presets.rs` | Kelvin (2000–50000 K, As Shot read from the file) on raws with colour matrices: in the file (DNG: re-developed for the chosen white through the camera's own matrices, camera-space white balance as Lightroom; the eyedropper / Auto invert the same model) or measured for the camera model (`lightcraft_raw::spectral`, 52 bodies, issue #730: the matrices turn the as-shot multipliers into Kelvin and the slider back, the look stays the file's fit, and the picture is adapted from the as-shot white, Bradford), or read from the camera's own white-balance presets (Sony ARW `SR2SubIFD`, Sony ILCA-99M2, ILCA-77M2, SLT-A33, DSC-RX10, ILCE-3500, ILCE-7S: Sony's Kelvin dial reads back within 0.3 % on 5 settings of 4 bodies; Canon CR2 `ColorData` presets, PowerShot G1 X Mark III: the camera's own As Shot temperature reads back within 5 % on its 9 white-balance settings; or built-in presets from the camera's own stated temperatures, `crates/raw/src/kelvin_builtin.rs`: Nikon Z5II, whose Natural Auto shot reads back at 5036 K against the 5030 K the camera wrote). The Kelvin slider's track is Lightroom's: 7000 K in the middle, 2000–7000 K evenly on the left half, logarithmic up to 50000 K on the right (within 2 % of positions measured in Lightroom Classic), for drawing, clicks and drags; wheel / arrow-key nudges and Quick Develop still step a fixed 50 / 100 / 500 K; the relative slider stays linear. Settings written on the relative scale before a camera's matrices reached it keep their look (`WbScale`). Not verified against Lightroom's Kelvin: on the ILCE-7M3 the matrices read 7–10 % below Sony's dial (issue #730), and whether the matrices or the dial are off is open; raws without matrices or presets anywhere and rendered files use the relative −100..+100 scale (6500 K / 0 = as shot). |+ | LR-EDIT-COLOR-WB-PICKER | White-balance eyedropper | P0 | ✅ | `cmd:tool.wbPicker`, `cmd:develop.wbPick`, `crates/ui-egui/src/tests_wb_selector.rs` | the Edit panel's selector button does what W does (from Compare, Survey or the grid it opens the photo in Detail); no magnified loupe while picking |+ | LR-EDIT-COLOR-TEMP | Temperature | P0 | ✅ | `ctl:wb.temp`, `crates/pipeline/src/local.rs` (`wb_matrix_for`, `legacy_white`), `crates/raw/src/color.rs` (`rebalance`), `crates/raw/src/spectral.rs` (`find_camera`), `crates/catalog/src/model.rs` (`relative_wb_camera`), `crates/develop/src/controls.rs` (`ControlSpec::position`), `crates/raw/src/kelvin_presets.rs` | Kelvin (2000–50000 K, As Shot read from the file) on raws with colour matrices: in the file (DNG: re-developed for the chosen white through the camera's own matrices, camera-space white balance as Lightroom; the eyedropper / Auto invert the same model) or measured for the camera model (`lightcraft_raw::spectral`, 52 bodies, issue #730: the matrices turn the as-shot multipliers into Kelvin and the slider back, the look stays the file's fit, and the picture is adapted from the as-shot white, Bradford), or read from the camera's own white-balance presets (Sony ARW `SR2SubIFD`, Sony ILCA-99M2, ILCA-77M2, SLT-A33, DSC-RX10, ILCE-3500, ILCE-7S: Sony's Kelvin dial reads back within 0.3 % on 5 settings of 4 bodies; Canon CR2 `ColorData` presets, PowerShot G1 X Mark III: the camera's own As Shot temperature reads back within 5 % on its 9 white-balance settings; or built-in presets from the camera's own stated temperatures, `crates/raw/src/kelvin_builtin.rs`: Nikon Z5II, whose Natural Auto shot reads back at 5036 K against the 5030 K the camera wrote). The Kelvin slider's track is Lightroom's: 7000 K in the middle, 2000–7000 K evenly on the left half, logarithmic up to 50000 K on the right (within 2 % of positions measured in Lightroom Classic), for drawing, clicks and drags; wheel / arrow-key nudges and Quick Develop still step a fixed 50 / 100 / 500 K; the relative slider stays linear. Settings written on the relative scale before a camera's matrices reached it keep their look (`WbScale`). A partial white balance naming only `temp` or only `tint` (`develop.merge`, `render --settings`, MCP `set_develop`, or `preset.apply` of a hand-written preset naming one of them) is resolved against the photo, so the field it leaves out keeps the look it had, and a photo whose mode answers its own white (`As Shot`, or a named preset on a raw with a Kelvin scale) has the white it really renders written out as Custom values the partial can move: `prepare_photo_for_wb_partial` and `merge_settings_for_photo` in `crates/engine/src/cmd/develop.rs` and `kelvin_to_legacy` in `crates/pipeline/src/local.rs`, issue #2910, tests in `crates/engine/src/tests_color.rs`. Not verified against Lightroom's Kelvin: on the ILCE-7M3 the matrices read 7–10 % below Sony's dial (issue #730), and whether the matrices or the dial are off is open; raws without matrices or presets anywhere and rendered files use the relative −100..+100 scale (6500 K / 0 = as shot). || LR-EDIT-COLOR-TINT | Tint | P0 | ✅ | `ctl:wb.tint`, `docs/tint-direction.md` | DNG / Lightroom sign: negative (left) adds green, positive (right) magenta; XMP `crs:Tint` values render as in Lightroom (issue #188); CPU/GPU regression tests || LR-EDIT-COLOR-VIBRANCE | Vibrance | P0 | ✅ | `ctl:color.vibrance` | || LR-EDIT-COLOR-SATURATION | Saturation | P0 | ✅ | `ctl:color.saturation` | |diff --cc docs/whats-new.mdindex a8dcea327,db921cc55..75d8f8fbc--- a/docs/whats-new.md+++ b/docs/whats-new.md@@@ -1,79 -1,23 +1,97 @@@# What's new in LightCraft+## 2026-10-27++### The Edit menu groups Select Only Active Photo and Paste Settings from Previous with their kin+- Select Only Active Photo now sits under Deselect All, and Paste Settings from Previous under Paste Selected Settings…, instead of both after Settings…, near the end of the Edit menu. On macOS, where Settings… lives in the application menu, the Edit menu no longer shows two separator lines in a row.++### A refused name prompt stays open and says why+- A one-line prompt (Rename Folder, New Folder on Disk, the preset and version names, New Library for a name it can't+ use, Auto-Tag from Tracklog) that the app refuses, for example a folder name that is taken, now stays open with what+ you typed and shows the reason, so you can change the name. Before, it closed without a word. A New Folder on Disk+ that works now says so: “Created folder “Selects” in “2026/Shoot””. Cancel and Esc still close the prompt.++### The macOS menu bar shows every row+- File ▸ Export… no longer reads “Custom…”, File ▸ Export with Preset keeps its Custom… row, and Photo ▸ Add to Album keeps New Album…. When two menu rows ran the same command, the menu bar left the second one out and gave the first one its label; now each row is its own item and a click on either one runs the command. The View menu now also lists its second Layout Image row (without a key), as the in-window menu does.++### Shortcuts read the same way everywhere on macOS+- Wherever LightCraft shows a shortcut (the menu bar's labels, a button's tooltip, the empty-library hint, the+ line under "No photos" in an empty album, the Keyboard Shortcuts dialog and its search) it lists the modifiers in+ the order macOS menus use, Control, Option, Shift, Command: `⇧⌘I` where it used to say `⌘⇧I`. The line under+ "No photos" also shows the shortcut as it is bound now, and as Ctrl+Shift+I on Windows and Linux, where it+ always said Cmd+Shift+I. Windows and Linux otherwise keep the order a shortcut is written in.++### Screen readers name a slider's value field "value"+- The number beside a slider is now named "Exposure value" (the slider's name and "value"), and "Click to type a value,+ drag to change it" is its description. It was named "Exposure: Click to type a value, drag to change it", so+ VoiceOver read the whole sentence each time it reached the field, once for every slider in the Edit panel.+## 2026-10-25+ ### A one-field white balance edit no longer shifts the other one+ - Settings that name only a white balance temperature, or only a tint — `develop.merge`,+ `lightcraft-cli render --settings <partial JSON>`, an MCP `set_develop {settings: …}` call, or a hand-written+ preset naming one of the two — used to change the colour balance of photos they never mentioned. On a raw edited in+ Kelvin the field the partial left out was re-read on the other scale: `wb {temp: 5800}` on a photo at 5000 K /+ +12 tint came back at 5800 K with the +12 read as a relative shift, moving the green–magenta balance by a visible+ amount. The kept field now carries the look the photo had, and the result is stored on the scale that photo is+ edited on.+ - The same partial on a photo still on As Shot — or on a named white balance preset, on a raw with a Kelvin scale —+ stored the number without any render ever reading it: those modes answer their own white, so the panel showed+ 5800 K over a picture still at the file's white. That white is now written out as Custom values before the partial+ lands; a partial that names a mode itself still gets that mode.+ - Presets made from a photo and the crs / XMP and Luminar importers name mode, temperature, tint and scale together,+ and partials naming both fields (or neither) behave exactly as before; a partial that says `"scale": "kelvin"` is+ still read in Kelvin.+++## 2026-10-25+++### JPEG ICC chunks are validated before colour conversion+- JPEG ICC profiles are assembled only when every chunk is present exactly once, the sequence numbers and+ declared totals agree, and every APP2 segment is complete. Reordered valid chunks still work. An invalid+ sequence uses the existing unsupported-profile sRGB fallback, including when the JPEG is a raw preview.++## 2026-10-29++### A dialog no longer dims the macOS title bar+- On macOS the top bar is the window's title bar, and the window buttons drawn over it stayed bright while a dialog dimmed+ the bar under them. As under a macOS sheet, the dialog's backdrop now leaves the bar alone: its buttons are inactive, a+ click on it does not close the dialog, and dragging its empty space still moves the window. Windows, Linux and full+ screen are unchanged.++## 2026-10-28++### The window's parts are named for screen readers+- The top bar, the tool strip and the bottom bar are now announced as toolbars (Top bar, Tool strip, Bottom bar), and the+ sidebar (Library), the photos, the Tools panel (or Presets) and the filmstrip as landmarks, so a screen reader can list+ them and jump to one instead of walking every control. Nothing on screen changes. Not yet tried with a real VoiceOver session.++## 2026-10-28++### Dialogs are exposed to screen readers as dialogs+- Export, Settings and the other dialogs, the library chooser and the prompts that stop the window (the quit question, a+ library that could not be opened, a settings file problem) are now exposed to screen readers as dialogs: modal ones, so the+ rest of the window is marked as blocked while one is open, and an alert dialog for the prompts. The answer to Check for+ Updates is a dialog too, but not a modal one. Before, each was a plain group that only carried the dialog's title.+- An alert dialog also carries what it says as its description: a screen reader can read the library problem's path, error and+ explanation, or a prompt's text, together with the dialog.++## 2026-10-28++### Screen readers no longer read the shortcut with every button name+- Icon-only buttons (the tool strip, the view buttons and Before/After and Filmstrip in the bottom bar, the top bar's+ Import Photos…, the mask overlay and White Balance Selector buttons, the slideshow controls) are now announced by+ their label alone ("Edit", "Presets", "Photo Grid"), and the shortcut is the button's description ("E", "Shift+P",+ "G"), which VoiceOver reads after a pause or on request. Before, it read "Edit (E)" every time it landed on the+ button. This holds in every language, including Japanese and Traditional Chinese, which write the shortcut in+ full-width brackets. The tooltip you see on hover is unchanged.++## 2026-10-25++### `>=` and `<=` work in the search box+- Fielded search tokens now take inclusive comparisons: `rating:>=3`, `iso:<=400`, `f:>=2.8`, `focal:<=50`. Before,+ the `=` was read as part of the number, so such a search quietly showed no photos at all.+## 2026-10-24### Relative-date filters and smart albums follow the clock