Skip to content

LightCraft: An open-source non-destructive photo editor written by scratch in pure Rust

Merge slideshow-overlays into slideshow-titles (origin/main: batches 32–33)

Jason Baldwinf30e4af83828
diff --cc docs/parity-checklist.md
index 71f8590a7,279a3d4e2..29995530b
--- a/docs/parity-checklist.md
+++ b/docs/parity-checklist.md
@@@ -52,10 -52,10 +52,10 @@@ cited here still exists. Formerly docs/
| X. Cross-cutting behaviours (BEHAV) | 23 | 6 | 1 | 1 | 8/8 (100%) | 7/10 (70%) |
| Y. Menus | 84 | 0 | 4 | 8 | 47/47 (100%) | 23/23 (100%) |
| Z. Keyboard shortcuts (desktop) | 76 | 3 | 3 | 1 | 49/52 (94%) | 23/24 (96%) |
- | Lightroom Classic extras | 36 | 18 | 31 | 8 | — | 24/26 (92%) |
- | **Total** | 410 | 53 | 68 | 35 | 193/201 (96%) | 145/157 (92%) |
-| Lightroom Classic extras | 36 | 19 | 30 | 8 | — | 24/26 (92%) |
-| **Total** | 411 | 55 | 67 | 35 | 193/201 (96%) | 146/158 (92%) |
++| Lightroom Classic extras | 36 | 20 | 29 | 8 | — | 24/26 (92%) |
++| **Total** | 411 | 56 | 66 | 35 | 193/201 (96%) | 146/158 (92%) |
- Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.2%** of 531 in-scope rows — P0 98.0% of 201 · P1 95.2% of 157 · P2 51.7% of 172.
-Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.3%** of 533 in-scope rows — P0 98.0% of 201 · P1 95.3% of 158 · P2 52.0% of 173.
++Weighted completion (✅ = 1, 🟡 = ½, 🚫 left out): **82.4%** of 533 in-scope rows — P0 98.0% of 201 · P1 95.3% of 158 · P2 52.3% of 173.
<!-- /parity:summary -->
## Top gaps and shortcut notes
diff --cc docs/whats-new.md
index dd2feff2c,2362a562a..609b3eee7
--- a/docs/whats-new.md
+++ b/docs/whats-new.md
@@@ -45,19 -150,24 +150,36 @@@
- Upgrading from a Windows installer older than 0.6 (such as 0.5.0) keeps LightCraft in the folder it was installed
in, instead of moving it back to Program Files (issue #399). If that folder has been deleted since, the upgrade
installs to Program Files.
+ - A photo that runs into a bug in LightCraft while it renders (in a raw decoder or the editing pipeline) now fails
+ like a photo that can't be opened, with the reason, instead of rendering forever; its thumbnail stops waiting too.
+ Each such bug used to take one of the render threads with it, so after a few of them no photo rendered until
+ LightCraft was restarted. The bug is still written to the log (Help ▸ Open Log Folder) for a report.
+
+ ### Library sorting
+ - Photos that tie on the sort key (equal ratings, one import batch, a burst shot within the same second) now sort by
+ file name, then id, instead of import order. Recently Added keeps a batch in file name order, and Auto-Stack orders a
+ burst by file name, so the first file is the cover.
+
+ ### Large preset collections
+ - A library holding thousands of presets (a Lightroom collection imported whole: 11 000 presets, a 42 MB
+ presets.json) stays responsive. Every command used to re-serialize the whole list to see whether it had changed
+ (~0.6 s per slider tick); now the list is saved only after it changes, and a slider tick takes ~2 ms.
+ - The Presets panel builds only the rows in view (and their thumbnails) instead of every preset on every frame; the
+ preset pickers in Import and Settings ▸ Import scroll the same way.
+ - Importing a large collection and opening its library no longer compare every preset with every other.
+### Slideshow intro and ending screens
+- A slideshow can now open with an intro screen and close with an ending screen, like Lightroom Classic's Titles
+ panel. Each is switched on on its own and has a background colour and, centred on it, your identity plate (the one
+ set under Overlays: its text or image) or a line of text of its own, in the plate's colour or one you pick, at a
+ scale. Each stays up for its own duration (by default the slide duration) and fades in and out like a slide.
+- The intro plays once before the first photo; the ending after the last photo when Repeat is off (while repeating
+ the show runs until you stop it, so the ending doesn't come up). Random order never moves them, ←/→ step across them,
+ and the control bar says Intro or End while one is up (the photo count only counts photos).
+- Set them in Settings ▸ Slideshow ▸ Titles; the preview there switches between the photo's slide, the intro and the
+ ending. They are saved with the library. Agents use `slideshow.titles`, and `slideshow.preview {title: "intro"}`
+ renders a screen as a PNG.
+
### Slideshow overlays
- Slides can now carry Lightroom Classic's Slideshow overlays: an identity plate (a line of text in a colour, or an
image file such as a PNG logo with transparency, at a size and opacity, optionally drawn behind the photo), the