Skip to content

⚡️⚡️⚡️ Self-hosted collaborative bookmark manager to collect, read, annotate, and fully preserve what matters, all in one place.

security: fix SSRF via DNS rebinding

daniel31x13cad66cf3c832
diff --git a/apps/worker/lib/protectPageRequests.ts b/apps/worker/lib/protectPageRequests.ts
index 65199998..e78b97d8 100644
--- a/apps/worker/lib/protectPageRequests.ts
+++ b/apps/worker/lib/protectPageRequests.ts
@@ -1,8 +1,6 @@
import { BrowserContext, Route } from "playwright";
-import {
- assertUrlIsSafeForServerSideFetch,
- UnsafeUrlError,
-} from "@linkwarden/lib/ssrf";
+import { UnsafeUrlError } from "@linkwarden/lib/ssrf";
+import { safeFetch } from "@linkwarden/lib/safeFetch";
function isNonNetworkUrl(url: string) {
return (
@@ -14,23 +12,39 @@ function isNonNetworkUrl(url: string) {
export default async function protectPageRequests(context: BrowserContext) {
await context.route("**/*", async (route: Route) => {
- const requestUrl = route.request().url();
+ const request = route.request();
- if (isNonNetworkUrl(requestUrl)) {
+ if (isNonNetworkUrl(request.url())) {
await route.continue();
return;
}
try {
- await assertUrlIsSafeForServerSideFetch(requestUrl);
- await route.continue();
- } catch (error) {
- if (error instanceof UnsafeUrlError) {
- await route.abort("blockedbyclient");
- return;
- }
+ const headers = request.headers();
+ delete headers["accept-encoding"];
+ delete headers["content-length"];
+ delete headers["host"];
+
+ const response = await safeFetch(request.url(), {
+ method: request.method(),
+ headers,
+ body: request.postDataBuffer() ?? undefined,
+ });
- throw error;
+ const responseHeaders = Object.fromEntries(response.headers.entries());
+ delete responseHeaders["content-encoding"];
+ delete responseHeaders["content-length"];
+ delete responseHeaders["transfer-encoding"];
+
+ await route.fulfill({
+ status: response.status,
+ headers: responseHeaders,
+ body: await response.buffer(),
+ });
+ } catch (error) {
+ await route.abort(
+ error instanceof UnsafeUrlError ? "blockedbyclient" : "failed"
+ );
}
});
}