⚡️⚡️⚡️ Self-hosted collaborative bookmark manager to collect, read, annotate, and fully preserve what matters, all in one place.
TypeScript bookmarkbookmark-managercollaborationnextjsreact-nativeread-it-laterself-hostedtypescript
feat(e2e): add data-testids to components
QACometcd09843b9984
diff --git a/components/AccentSubmitButton.tsx b/components/AccentSubmitButton.tsxindex 1d877873..930c1a61 100644--- a/components/AccentSubmitButton.tsx+++ b/components/AccentSubmitButton.tsx@@ -4,6 +4,7 @@ type Props = {loading?: boolean;className?: string;type?: "button" | "submit" | "reset" | undefined;+ "data-testid"?: string;};export default function AccentSubmitButton({@@ -12,6 +13,7 @@ export default function AccentSubmitButton({loading,className,type,+ "data-testid": dataTestId,}: Props) {return (<button@@ -19,6 +21,7 @@ export default function AccentSubmitButton({className={`border primary-btn-gradient select-none duration-200 bg-black border-[oklch(var(--p))] hover:border-[#0070b5] rounded-lg text-center px-4 py-2 text-white active:scale-95 tracking-wider w-fit flex justify-center items-center gap-2 ${className || ""}`}+ data-testid={dataTestId}onClick={() => {if (loading !== undefined && !loading && onClick) onClick();}}diff --git a/components/Modal.tsx b/components/Modal.tsxindex 6d1bb9f0..1620b2cd 100644--- a/components/Modal.tsx+++ b/components/Modal.tsx@@ -32,8 +32,14 @@ export default function Modal({ toggleModal, className, children }: Props) {<Drawer.Overlay className="fixed inset-0 bg-black/40" /><ClickAwayHandler onClickOutside={() => setDrawerIsOpen(false)}><Drawer.Content className="flex flex-col rounded-t-2xl h-[90%] mt-24 fixed bottom-0 left-0 right-0 z-30">- <div className="p-4 pb-32 bg-base-100 rounded-t-2xl flex-1 border-neutral-content border-t overflow-y-auto">- <div className="mx-auto w-12 h-1.5 flex-shrink-0 rounded-full bg-neutral mb-5" />+ <div+ className="p-4 pb-32 bg-base-100 rounded-t-2xl flex-1 border-neutral-content border-t overflow-y-auto"+ data-testid="mobile-modal-container"+ >+ <div+ className="mx-auto w-12 h-1.5 flex-shrink-0 rounded-full bg-neutral mb-5"+ data-testid="mobile-modal-slider"+ />{children}</div>@@ -44,19 +50,28 @@ export default function Modal({ toggleModal, className, children }: Props) {);} else {return (- <div className="overflow-y-auto pt-2 sm:py-2 fixed top-0 bottom-0 right-0 left-0 bg-black bg-opacity-10 backdrop-blur-sm flex justify-center items-center fade-in z-40">+ <div+ className="overflow-y-auto pt-2 sm:py-2 fixed top-0 bottom-0 right-0 left-0 bg-black bg-opacity-10 backdrop-blur-sm flex justify-center items-center fade-in z-40"+ data-testid="modal-outer"+ ><ClickAwayHandleronClickOutside={toggleModal}className={`w-full mt-auto sm:m-auto sm:w-11/12 sm:max-w-2xl ${className || ""}`}>- <div className="slide-up mt-auto sm:m-auto relative border-neutral-content rounded-t-2xl sm:rounded-2xl border-t sm:border shadow-2xl p-5 bg-base-100 overflow-y-auto sm:overflow-y-visible">+ <div+ className="slide-up mt-auto sm:m-auto relative border-neutral-content rounded-t-2xl sm:rounded-2xl border-t sm:border shadow-2xl p-5 bg-base-100 overflow-y-auto sm:overflow-y-visible"+ data-testid="modal-container"+ ><divonClick={toggleModal as MouseEventHandler<HTMLDivElement>}className="absolute top-4 right-3 btn btn-sm outline-none btn-circle btn-ghost z-10">- <i className="bi-x text-neutral text-2xl"></i>+ <i+ className="bi-x text-neutral text-2xl"+ data-testid="close-modal-button"+ ></i></div>{children}</div>diff --git a/components/TextInput.tsx b/components/TextInput.tsxindex c8099d0e..2003823a 100644--- a/components/TextInput.tsx+++ b/components/TextInput.tsx@@ -9,6 +9,7 @@ type Props = {onKeyDown?: KeyboardEventHandler<HTMLInputElement> | undefined;className?: string;spellCheck?: boolean;+ "data-testid"?: string;};export default function TextInput({@@ -20,9 +21,11 @@ export default function TextInput({onKeyDown,className,spellCheck,+ "data-testid": dataTestId,}: Props) {return (<input+ data-testid={dataTestId}spellCheck={spellCheck}autoFocus={autoFocus}type={type ? type : "text"}diff --git a/layouts/CenteredForm.tsx b/layouts/CenteredForm.tsxindex 2ea8a8fa..5960ffbd 100644--- a/layouts/CenteredForm.tsx+++ b/layouts/CenteredForm.tsx@@ -6,13 +6,21 @@ import React, { ReactNode, useEffect } from "react";interface Props {text?: string;children: ReactNode;+ "data-testid"?: string;}-export default function CenteredForm({ text, children }: Props) {+export default function CenteredForm({+ text,+ children,+ "data-testid": dataTestId,+}: Props) {const { settings } = useLocalSettingsStore();return (- <div className="absolute top-0 bottom-0 left-0 right-0 flex justify-center items-center p-5">+ <div+ className="absolute top-0 bottom-0 left-0 right-0 flex justify-center items-center p-5"+ data-testid={dataTestId}+ ><div className="m-auto flex flex-col gap-2 w-full">{settings.theme ? (<Imagediff --git a/layouts/MainLayout.tsx b/layouts/MainLayout.tsxindex cc7fc8fa..a1178a50 100644--- a/layouts/MainLayout.tsx+++ b/layouts/MainLayout.tsx@@ -38,7 +38,7 @@ export default function MainLayout({ children }: Props) {<AnnouncementBar toggleAnnouncementBar={toggleAnnouncementBar} />) : undefined}- <div className="flex">+ <div className="flex" data-testid="dashboard-wrapper"><div className="hidden lg:block"><SidebarclassName={`fixed ${showAnnouncement ? "top-10" : "top-0"}`}diff --git a/pages/login.tsx b/pages/login.tsxindex 5b528b98..13941d1f 100644--- a/pages/login.tsx+++ b/pages/login.tsx@@ -69,7 +69,7 @@ export default function Login({function displayLoginCredential() {if (availableLogins.credentialsEnabled === "true") {return (- <>+ <div data-testid="login-form"><p className="text-3xl text-black dark:text-white text-center font-extralight">Enter your credentials</p>@@ -87,6 +87,7 @@ export default function Login({placeholder="johnny"value={form.username}className="bg-base-100"+ data-testid="username-input"onChange={(e) => setForm({ ...form, username: e.target.value })}/></div>@@ -100,6 +101,7 @@ export default function Login({placeholder="••••••••••••••"value={form.password}className="bg-base-100"+ data-testid="password-input"onChange={(e) => setForm({ ...form, password: e.target.value })}/>{availableLogins.emailEnabled === "true" && (@@ -107,6 +109,7 @@ export default function Login({<Linkhref={"/forgot"}className="text-gray-500 dark:text-gray-400 font-semibold"+ data-testid="forgot-password-link">Forgot Password?</Link>@@ -117,13 +120,14 @@ export default function Login({type="submit"label="Login"className=" w-full text-center"+ data-testid="submit-login-button"loading={submitLoader}/>{availableLogins.buttonAuths.length > 0 ? (<div className="divider my-1">OR</div>) : undefined}- </>+ </div>);}}@@ -155,6 +159,7 @@ export default function Login({<Linkhref={"/register"}className="block text-black dark:text-white font-semibold"+ data-testid="register-link">Sign Up</Link>diff --git a/pages/register.tsx b/pages/register.tsxindex 2f114888..eb5c6025 100644--- a/pages/register.tsx+++ b/pages/register.tsx@@ -102,6 +102,7 @@ export default function Register() {} days of Premium Service at no cost!`: "Create a new account"}+ data-testid="registration-form">{process.env.NEXT_PUBLIC_DISABLE_REGISTRATION === "true" ? (<div className="p-4 flex flex-col gap-3 justify-between max-w-[30rem] min-w-80 w-full bg-base-200 rounded-2xl shadow-md border border-neutral-content">@@ -127,6 +128,7 @@ export default function Register() {placeholder="Johnny"value={form.name}className="bg-base-100"+ data-testid="display-name-input"onChange={(e) => setForm({ ...form, name: e.target.value })}/></div>@@ -139,6 +141,7 @@ export default function Register() {placeholder="john"value={form.username}className="bg-base-100"+ data-testid="username-input"onChange={(e) =>setForm({ ...form, username: e.target.value })}@@ -155,6 +158,7 @@ export default function Register() {placeholder="[email protected]"value={form.email}className="bg-base-100"+ data-testid="email-input"onChange={(e) => setForm({ ...form, email: e.target.value })}/></div>@@ -168,6 +172,7 @@ export default function Register() {placeholder="••••••••••••••"value={form.password}className="bg-base-100"+ data-testid="password-input"onChange={(e) => setForm({ ...form, password: e.target.value })}/></div>@@ -182,6 +187,7 @@ export default function Register() {placeholder="••••••••••••••"value={form.passwordConfirmation}className="bg-base-100"+ data-testid="password-confirm-input"onChange={(e) =>setForm({ ...form, passwordConfirmation: e.target.value })}@@ -195,6 +201,7 @@ export default function Register() {<Linkhref="https://linkwarden.app/tos"className="font-semibold underline"+ data-testid="terms-of-service-link">Terms of Service</Link>{" "}@@ -202,6 +209,7 @@ export default function Register() {<Linkhref="https://linkwarden.app/privacy-policy"className="font-semibold underline"+ data-testid="privacy-policy-link">Privacy Policy</Link>@@ -212,6 +220,7 @@ export default function Register() {<Linkhref="mailto:[email protected]"className="font-semibold underline"+ data-testid="support-link">Get in touch</Link>@@ -225,10 +234,15 @@ export default function Register() {label="Sign Up"className="w-full"loading={submitLoader}+ data-testid="register-button"/><div className="flex items-baseline gap-1 justify-center"><p className="w-fit text-neutral">Already have an account?</p>- <Link href={"/login"} className="block font-bold">+ <Link+ href={"/login"}+ className="block font-bold"+ data-testid="login-link"+ >Login</Link></div>