Skip to content

⚡️⚡️⚡️ Self-hosted collaborative bookmark manager to collect, read, annotate, and fully preserve what matters, all in one place.

improve preview generation for webpages in case site does not provide an icon

Talkaboutd30fb4645e96
diff --git a/apps/worker/lib/preservationScheme/handleArchivePreview.ts b/apps/worker/lib/preservationScheme/handleArchivePreview.ts
index 0eea6386..e4c334d3 100644
--- a/apps/worker/lib/preservationScheme/handleArchivePreview.ts
+++ b/apps/worker/lib/preservationScheme/handleArchivePreview.ts
@@ -19,6 +19,8 @@ const handleArchivePreview = async (
return metaTag ? (metaTag as any).content : null;
});
+ let previewGenerated = false;
+
if (ogImageUrl) {
console.log("Found og:image URL:", ogImageUrl);
@@ -28,11 +30,13 @@ const handleArchivePreview = async (
// Check if imageResponse is not null
if (imageResponse && !link.preview?.startsWith("archive")) {
const buffer = await imageResponse.body();
- generatePreview(buffer, link.collectionId, link.id);
+ previewGenerated = generatePreview(buffer, link.collectionId, link.id);
}
await page.goBack();
- } else if (!link.preview?.startsWith("archive")) {
+ }
+
+ if (!previewGenerated && !link.preview?.startsWith("archive")) {
console.log("No og:image found");
await page
.screenshot({ type: "jpeg", quality: 20 })
diff --git a/packages/lib/generatePreview.ts b/packages/lib/generatePreview.ts
index 5ad3d822..2bf16ff8 100644
--- a/packages/lib/generatePreview.ts
+++ b/packages/lib/generatePreview.ts
@@ -6,14 +6,14 @@ export const generatePreview = async (
buffer: Buffer,
collectionId: number,
linkId: number
-) => {
+): Promise<boolean> => {
if (buffer && collectionId && linkId) {
try {
const image = await Jimp.read(buffer);
if (!image) {
console.log("Error generating preview: Image not found");
- return;
+ return false;
}
image.resize(1000, Jimp.AUTO).quality(20);
@@ -24,12 +24,13 @@ export const generatePreview = async (
1024 * 1024 * Number(process.env.PREVIEW_MAX_BUFFER || 10)
) {
console.log("Error generating preview: Buffer size exceeded");
- return prisma.link.update({
+ prisma.link.update({
where: { id: linkId },
data: {
preview: "unavailable",
},
});
+ return false;
}
await createFile({
@@ -43,8 +44,12 @@ export const generatePreview = async (
preview: `archives/preview/${collectionId}/${linkId}.jpeg`,
},
});
+
+ return true;
} catch (err) {
console.error("Error processing the image:", err);
}
}
+
+ return false;
};