Skip to content

A fast, helpful, and open-source document parser

fix: adjust maxPages behavior

Clelia (Astra) Bertelli2ca9d456b5d6
diff --git a/src/engines/pdf/pdfjs.test.ts b/src/engines/pdf/pdfjs.test.ts
index e230ffc..fc86a2d 100644
--- a/src/engines/pdf/pdfjs.test.ts
+++ b/src/engines/pdf/pdfjs.test.ts
@@ -219,30 +219,11 @@ describe("test PdfJS methods", () => {
it("test extractAllPages (with targetPages and maxPages)", async () => {
const doc = getTestData();
const expectedTextItems = getExpectedResults();
- const expectedPages = [1, 2, 3];
-
- const engine = new PdfJsEngine();
- const results = await engine.extractAllPages(doc, 4, "1,2,3,5,8");
- expect(results.length).toBe(3);
- for (let i = 0; i < results.length; i++) {
- expect(results[i].pageNum).toBe(expectedPages[i]);
- expect(results[i].width).toBe(612);
- expect(results[i].height).toBe(792);
- expect(results[i].images.length).toBe(0);
- expect(results[i].annotations?.length).toBe(0);
- expect(results[i].textItems).toStrictEqual(expectedTextItems);
- expect(results[i].garbledTextRegions).toBeUndefined();
- }
- });
-
- it("test extractAllPages (with targetPages and maxPages)", async () => {
- const doc = getTestData();
- const expectedTextItems = getExpectedResults();
- const expectedPages = [1, 2, 3];
+ const expectedPages = [1, 2, 3, 5];
const engine = new PdfJsEngine();
const results = await engine.extractAllPages(doc, 4, "1,2,3,5,8");
- expect(results.length).toBe(3);
+ expect(results.length).toBe(4);
for (let i = 0; i < results.length; i++) {
expect(results[i].pageNum).toBe(expectedPages[i]);
expect(results[i].width).toBe(612);
diff --git a/src/engines/pdf/pdfjs.ts b/src/engines/pdf/pdfjs.ts
index b07b9fc..3666efb 100644
--- a/src/engines/pdf/pdfjs.ts
+++ b/src/engines/pdf/pdfjs.ts
@@ -367,7 +367,7 @@ export class PdfJsEngine implements PdfEngine {
// Parse target pages if specified
let pageNumbers: number[];
if (targetPages) {
- pageNumbers = this.parseTargetPages(targetPages, numPages);
+ pageNumbers = this.parseTargetPages(targetPages, doc.numPages);
} else {
pageNumbers = Array.from({ length: numPages }, (_, i) => i + 1);
}