A fast, helpful, and open-source document parser
nits
Logan Markewichd34f96c7c809
diff --git a/crates/pdfium/src/library.rs b/crates/pdfium/src/library.rsindex a42dfde..b0dbf8f 100644--- a/crates/pdfium/src/library.rs+++ b/crates/pdfium/src/library.rs@@ -14,9 +14,12 @@ static INIT: Once = Once::new();/// PDFium's FFI is **not thread-safe**: concurrent calls (even across distinct/// documents) corrupt internal state and cause heap UB (double-free / heap/// corruption). Every [`Library`] handle holds this mutex for its entire-/// lifetime, and every PDFium resource ([`Document`], `Page`, `TextPage`,-/// `Bitmap`, `Font`) borrows from a [`Library`], so the borrow checker-/// statically prevents PDFium work outside the lock.+/// lifetime, and the owning PDFium resources ([`Document`], `Page`,+/// `TextPage`, `Bitmap`) borrow from a [`Library`] via their `'lib` lifetime,+/// so the borrow checker statically prevents PDFium work outside the lock.+/// (`Font` is a borrowed, non-owning handle constructed through an `unsafe`+/// fn; its lock discipline is the caller's responsibility, not statically+/// enforced.)#[cfg(not(target_arch = "wasm32"))]fn pdfium_lock() -> &'static Mutex<()> {static LOCK: OnceLock<Mutex<()>> = OnceLock::new();@@ -82,23 +85,6 @@ impl Library {}}- /// Try to acquire the PDFium lock without blocking.- ///- /// Returns `None` if another thread currently holds the lock. Useful- /// for callers that want to fail fast (or fall back to a worker queue)- /// rather than block on contention.- #[cfg(not(target_arch = "wasm32"))]- pub fn try_init() -> Option<Library> {- pdfium_sys::dynamic::load_default().expect("failed to load pdfium shared library");- let guard = match pdfium_lock().try_lock() {- Ok(g) => g,- Err(std::sync::TryLockError::WouldBlock) => return None,- Err(std::sync::TryLockError::Poisoned(p)) => p.into_inner(),- };- INIT.call_once(|| unsafe { ffi!(FPDF_InitLibrary()) });- Some(Library { _guard: guard })- }-pub fn load_document(&self,path: &str,diff --git a/crates/pdfium/src/page.rs b/crates/pdfium/src/page.rsindex 0f4ce55..6fcec1f 100644--- a/crates/pdfium/src/page.rs+++ b/crates/pdfium/src/page.rs@@ -129,7 +129,10 @@ impl<'doc, 'lib: 'doc> Page<'doc, 'lib> {let width = (self.width() * scale).round() as i32;let height = (self.height() * scale).round() as i32;- let bitmap = Bitmap::new(width, height)?;+ // SAFETY: this method is on `Page<'_, 'lib>`, whose existence proves+ // the PDFium lock is held for `'lib`; the returned `Bitmap<'lib>` is+ // tied to that same lock lifetime.+ let bitmap = unsafe { Bitmap::new(width, height) }?;// Fill with white (ARGB: 0xFFFFFFFF)bitmap.fill_rect(0, 0, width, height, 0xFFFFFFFF);