Skip to content

A fast, helpful, and open-source document parser

fix: don't flag gutter digits that abut a neighbour as margin line numbers

Logan Markewichf092d1d034a0
diff --git a/crates/liteparse/src/projection.rs b/crates/liteparse/src/projection.rs
index 98ce646..aae1472 100644
--- a/crates/liteparse/src/projection.rs
+++ b/crates/liteparse/src/projection.rs
@@ -480,16 +480,39 @@ fn form_lines(
(1..=2).contains(&digit_count)
}
- for item in items.iter_mut() {
- let center = item.item.x + item.item.width / 2.0;
+ // A real gutter line number is isolated on its baseline. An item that
+ // abuts a neighbour is a fragment of a larger token, e.g. the "7" of a
+ // table cell PDFium emits as "7" + ".7" (issue #465).
+ fn abuts_neighbour(items: &[ProjectedTextItem], idx: usize) -> bool {
+ let it = &items[idx].item;
+ let max_gap = it.height * 0.25;
+ items.iter().enumerate().any(|(j, other)| {
+ if j == idx {
+ return false;
+ }
+ let o = &other.item;
+ if (o.y - it.y).abs() > it.height * 0.5 {
+ return false;
+ }
+ let gap_right = o.x - (it.x + it.width);
+ let gap_left = it.x - (o.x + o.width);
+ (-0.5..=max_gap).contains(&gap_right) || (-0.5..=max_gap).contains(&gap_left)
+ })
+ }
- if center > margin_left
- && center < margin_right
- && is_margin_line_number_text(&item.item.text)
- && item.item.width < 15.0
- {
- item.is_margin_line_number = true;
- }
+ let margin_idxs: Vec<usize> = (0..items.len())
+ .filter(|&i| {
+ let item = &items[i];
+ let center = item.item.x + item.item.width / 2.0;
+ center > margin_left
+ && center < margin_right
+ && is_margin_line_number_text(&item.item.text)
+ && item.item.width < 15.0
+ && !abuts_neighbour(items, i)
+ })
+ .collect();
+ for i in margin_idxs {
+ items[i].is_margin_line_number = true;
}
}
@@ -5246,6 +5269,42 @@ mod tests {
}
}
+ #[test]
+ fn gutter_digit_abutting_neighbour_is_not_margin_line_number() {
+ // Issue #465: a table cell "7.7" emitted as runs "7" + ".7" with zero
+ // gap, sitting in the page-centre band. The "7" must stay on the row
+ // and merge with ".7" instead of being split off as a line number.
+ let mut items = vec![
+ item_at("58.5", 252.7, 149.76, 10.9, 8.42),
+ item_at("7", 313.37, 149.76, 3.108, 8.42),
+ item_at(".7", 316.478, 149.76, 4.66, 8.42),
+ item_at("2.3", 370.9, 149.76, 10.6, 8.42),
+ ];
+ let lines = form_lines(&mut items, 10.0, 8.42, 612.0);
+ assert_eq!(lines.len(), 1);
+ assert!(lines[0].iter().any(|i| i.item.text == "7.7"));
+ assert!(lines[0].iter().all(|i| !i.is_margin_line_number));
+ }
+
+ #[test]
+ fn isolated_gutter_digit_is_still_margin_line_number() {
+ // Two-column paper: "12" alone in the gutter, well clear of both
+ // columns' text, keeps its line-number flag.
+ let mut items = vec![
+ item_at("left column text", 60.0, 100.0, 230.0, 10.0),
+ item_at("12", 310.0, 100.0, 8.0, 10.0),
+ item_at("right column text", 330.0, 100.0, 230.0, 10.0),
+ ];
+ let lines = form_lines(&mut items, 10.0, 10.0, 612.0);
+ let flagged: Vec<_> = lines
+ .iter()
+ .flatten()
+ .filter(|i| i.is_margin_line_number)
+ .map(|i| i.item.text.as_str())
+ .collect();
+ assert_eq!(flagged, vec!["12"]);
+ }
+
#[test]
fn xy_cut_finds_column_gutter_on_two_column_layout() {
// Two columns, 50pt-wide gutter centered at x=300. Each column has