LLM inference in C/C++
C++ ggml
ci : fix dry-run reporting in make-release job [no ci] (#27167)
Daniel Bevenius4df29be4f4c3
diff --git a/.github/workflows/make-release.yml b/.github/workflows/make-release.ymlindex fed9c877c7..57229b5aeb 100644--- a/.github/workflows/make-release.yml+++ b/.github/workflows/make-release.yml@@ -42,5 +42,10 @@ jobs:- name: Dry run summaryif: ${{ github.event.inputs.dry_run == 'true' }}run: |- echo "Dry run complete - all checks passed."- echo "Would have created tag: ${{ steps.checks.outputs.version }}"+ if [[ "${{ steps.checks.outputs.checks_passed }}" == "true" ]]; then+ echo "Dry run complete - all checks passed."+ echo "Would have created tag: ${{ steps.checks.outputs.version }}"+ else+ echo "::error::Dry run found release check failures. A release tag would not be created."+ exit 1+ fidiff --git a/scripts/make-release-checks.sh b/scripts/make-release-checks.shindex c8c6322841..8d0e5490b3 100755--- a/scripts/make-release-checks.sh+++ b/scripts/make-release-checks.sh@@ -11,6 +11,7 @@ SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"REPO_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"DRY_RUN=false+CHECKS_PASSED=truefor arg in "$@"; docase "$arg" in--dry-run) DRY_RUN=true ;;@@ -44,6 +45,7 @@ elseif [[ "$RUNS" -eq 0 ]]; thenif [[ "$DRY_RUN" == "true" ]]; thenecho "Warning: no successful release.yml run found for HEAD (${SHA}) (dry run, continuing)."+ CHECKS_PASSED=falseelseecho "Error: no successful release.yml run found for HEAD (${SHA})"echo "The nightly build must complete successfully before making a release."@@ -73,6 +75,7 @@ elseecho "$DIFF"if [[ "$DRY_RUN" == "true" ]]; thenecho "Warning: would abort release due to ggml mismatch (dry run, continuing)."+ CHECKS_PASSED=falseelseecho "Error: ggml must match upstream before making a release."exit 1@@ -81,3 +84,7 @@ elseecho "local ggml/ matches upstream ${GGML_VERSION}"fifi++if [[ -n "${GITHUB_OUTPUT:-}" ]]; then+ echo "checks_passed=${CHECKS_PASSED}" >> "$GITHUB_OUTPUT"+fi