Skip to content

LLM inference in C/C++

C++ ggml

ui : fix llama-ui-embed crash when no asset dir is given (#24597)

Aldehir Rojas53bd47ea5b46
diff --git a/tools/ui/embed.cpp b/tools/ui/embed.cpp
index d4c222f642..cdbb642323 100644
--- a/tools/ui/embed.cpp
+++ b/tools/ui/embed.cpp
@@ -1,7 +1,7 @@
// llama-ui-embed: generate ui.cpp / ui.h that embed UI assets as C arrays.
//
// Usage:
-// llama-ui-embed <out_cpp> <out_h> <asset_dir>
+// llama-ui-embed <out_cpp> <out_h> [<asset_dir>]
//
// Recursively embeds every regular file under <asset_dir>.
// Asset names are relative paths from <asset_dir> (e.g. "_app/immutable/bundle.HASH.js").
@@ -147,9 +147,9 @@ int main(int argc, char ** argv) {
const std::string out_cpp = argv[1];
const std::string out_h = argv[2];
- const std::string asset_dir = argv[3];
+ const std::string asset_dir = (argc >= 4) ? argv[3] : std::string();
- const bool use_gzip = std::filesystem::exists(asset_dir + "/_gzip");
+ const bool use_gzip = !asset_dir.empty() && std::filesystem::exists(asset_dir + "/_gzip");
const std::string in_dir = use_gzip ? (asset_dir + "/_gzip") : asset_dir;
std::vector<asset_entry> assets;