Skip to content

LLM inference in C/C++

C++ ggml

Prefer npm ci over install for security (#26601)

Evan Huus6ea215d171fd
diff --git a/scripts/ui-assets.cmake b/scripts/ui-assets.cmake
index dc0417ea08..0c1c4de555 100644
--- a/scripts/ui-assets.cmake
+++ b/scripts/ui-assets.cmake
@@ -123,15 +123,15 @@ function(npm_build out_var)
endif()
if(need_install)
- message(STATUS "UI: running npm install")
+ message(STATUS "UI: running npm ci")
execute_process(
- COMMAND ${NPM_EXECUTABLE} install
+ COMMAND ${NPM_EXECUTABLE} ci
WORKING_DIRECTORY "${WORK_DIR}"
RESULT_VARIABLE rc
ERROR_VARIABLE err
)
if(NOT rc EQUAL 0)
- message(STATUS "UI: npm install failed (${rc})")
+ message(STATUS "UI: npm ci failed (${rc})")
message(STATUS " stderr: ${err}")
return()
endif()
diff --git a/tools/ui/README.md b/tools/ui/README.md
index 1b99ebbfe8..53b5925e2c 100644
--- a/tools/ui/README.md
+++ b/tools/ui/README.md
@@ -89,7 +89,7 @@ Llama UI supports two server operation modes:
```bash
cd tools/ui
-npm install
+npm ci
```
### 2. Start llama-server
diff --git a/tools/ui/scripts/dev.sh b/tools/ui/scripts/dev.sh
index 7e1d3c15e5..d14186630d 100644
--- a/tools/ui/scripts/dev.sh
+++ b/tools/ui/scripts/dev.sh
@@ -14,7 +14,7 @@ cd ../../
# Ensure node_modules are installed
if [ ! -d "tools/ui/node_modules" ]; then
echo "πŸ“¦ Installing npm dependencies..."
- cd tools/ui && npm install && cd ../../
+ cd tools/ui && npm ci && cd ../../
fi
# Check and install git hooks if missing
diff --git a/tools/ui/scripts/git-hooks/pre-commit.sh b/tools/ui/scripts/git-hooks/pre-commit.sh
index 208ef56fcd..31c23ed518 100755
--- a/tools/ui/scripts/git-hooks/pre-commit.sh
+++ b/tools/ui/scripts/git-hooks/pre-commit.sh
@@ -14,7 +14,7 @@ cd "$REPO_ROOT/tools/ui"
# Check that node_modules exists
if [ ! -d "node_modules" ]; then
- echo "❌ node_modules not found. Run 'npm install' first."
+ echo "❌ node_modules not found. Run 'npm ci' first."
exit 1
fi
diff --git a/tools/ui/scripts/git-hooks/pre-push.sh b/tools/ui/scripts/git-hooks/pre-push.sh
index 66d79b950a..d5598fb17a 100755
--- a/tools/ui/scripts/git-hooks/pre-push.sh
+++ b/tools/ui/scripts/git-hooks/pre-push.sh
@@ -30,7 +30,7 @@ cd "$REPO_ROOT/tools/ui"
# Check that node_modules exists
if [ ! -d "node_modules" ]; then
- echo "❌ node_modules not found. Run 'npm install' first."
+ echo "❌ node_modules not found. Run 'npm ci' first."
exit 1
fi