LLM inference in C/C++
C++ ggml
model : fix DFlash output head sharing (#30111)
Hrishith Thadicherlaa11f57ba9379
diff --git a/conversion/gemma.py b/conversion/gemma.pyindex 2a1f6931ff..924d8e784a 100644--- a/conversion/gemma.py+++ b/conversion/gemma.py@@ -849,8 +849,8 @@ class Gemma4DSparkModel(DFlashModel):raise ValueError("Gemma4 DSpark attention bias and MoE are not supported")if (self.hparams.get("draft_vocab_size") or self.hparams["vocab_size"]) != self.hparams["vocab_size"]:raise ValueError("Gemma4 DSpark currently requires a full draft vocabulary")- if "model.lm_head.weight" not in self.model_tensors and self.hparams.get("tie_word_embeddings") is not True:- raise ValueError("Gemma4 DSpark requires lm_head.weight unless tie_word_embeddings is true")+ if "model.lm_head.weight" not in self.model_tensors:+ raise ValueError("Gemma4 DSpark requires lm_head.weight")self.dflash_config = self.hparams.get("dflash_config", {})markov_type = self.dflash_config.get("markov_head_type", self.hparams.get("markov_head_type", "vanilla"))diff --git a/src/models/dflash.cpp b/src/models/dflash.cppindex c8c2895b6c..b6cb6bfb90 100644--- a/src/models/dflash.cpp+++ b/src/models/dflash.cpp@@ -167,9 +167,6 @@ void llama_model_dflash::load_arch_tensors(llama_model_loader &) {// optional: reduced-vocab drafts ship their own lm head, full-vocab drafts can share the target's via ctx_other// a draft with its own embeddings + head references no target tensors and can run on devices the target does not use (e.g. -devd with a tensor-split target)output = create_tensor(tn(LLM_TENSOR_OUTPUT, "weight"), { n_embd, n_vocab_draft }, TENSOR_NOT_REQUIRED);- if (output == nullptr && tok_embd != nullptr) {- output = create_tensor(tn(LLM_TENSOR_TOKEN_EMBD, "weight"), { n_embd, n_vocab_draft }, TENSOR_DUPLICATED);- }if (hparams.dsv4_hc_mult > 0) {const int64_t q_lora_rank = hparams.n_lora_q;